René's URL Explorer Experiment


Title: Fix closing socket resource before removing from loop by clue · Pull Request #141 · reactphp/socket · GitHub

Open Graph Title: Fix closing socket resource before removing from loop by clue · Pull Request #141 · reactphp/socket

X Title: Fix closing socket resource before removing from loop by clue · Pull Request #141 · reactphp/socket

Description: Async, streaming plaintext TCP/IP and secure TLS socket server and client connections for ReactPHP. - Fix closing socket resource before removing from loop by clue · Pull Request #141 · reactphp/socket

Open Graph Description: Currently, this component implicitly calls fclose() on the underlying socket resource before actually closing the stream (and removing it from the event loop). This code is in place ever since #99 ...

X Description: Currently, this component implicitly calls fclose() on the underlying socket resource before actually closing the stream (and removing it from the event loop). This code is in place ever since #99 ...

Opengraph URL: https://github.com/reactphp/socket/pull/141

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:63f593c1-7457-69b8-8e60-0601d1175a25
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB4CC:395091:67A2F:8CFAD:6B007EA3
html-safe-nonceb810e1d435564c79241af2a5c9833481e18d5338a9a6a9d880b40f00d7874239
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNENDOjM5NTA5MTo2N0EyRjo4Q0ZBRDo2QjAwN0VBMyIsInZpc2l0b3JfaWQiOiI1MjA1OTg3MTE3NDg1ODE3NTA3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacbf18f3dd7d0d86e722d903e9c9ff4bc80ef0803bbff15aab2858a736f983d228
hovercard-subject-tagpull_request:159977432
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/reactphp/socket/141/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/13c9baf627113ae0bc3db5b0ac89f147bf20704754d48351b0c5ded0baa1cc5f/reactphp/socket/pull/141
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/13c9baf627113ae0bc3db5b0ac89f147bf20704754d48351b0c5ded0baa1cc5f/reactphp/socket/pull/141
og:image:altCurrently, this component implicitly calls fclose() on the underlying socket resource before actually closing the stream (and removing it from the event loop). This code is in place ever since #99 ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameclue
hostnamegithub.com
expected-hostnamegithub.com
None82c186f13e104004ab7bdb779f3195e59dd38bfde531aaa74b76470fc2462b83
turbo-cache-controlno-cache
go-importgithub.com/reactphp/socket git https://github.com/reactphp/socket.git
octolytics-dimension-user_id1696866
octolytics-dimension-user_loginreactphp
octolytics-dimension-repository_id4287591
octolytics-dimension-repository_nworeactphp/socket
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id4287591
octolytics-dimension-repository_network_root_nworeactphp/socket
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released1bc2aa1939001689f5ce935982c10a6138f745c
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/reactphp/socket/pull/141#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Freactphp%2Fsocket%2Fpull%2F141
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Freactphp%2Fsocket%2Fpull%2F141
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=reactphp%2Fsocket
Reloadhttps://github.com/reactphp/socket/pull/141
Reloadhttps://github.com/reactphp/socket/pull/141
Reloadhttps://github.com/reactphp/socket/pull/141
reactphphttps://github.com/reactphp
sockethttps://github.com/reactphp/socket
Codehttps://github.com/reactphp/socket
Issues7 (7)https://github.com/reactphp/socket/issues
Pull requests9 (9)https://github.com/reactphp/socket/pulls
Actionshttps://github.com/reactphp/socket/actions
Security and qualityhttps://github.com/reactphp/socket/security
Insightshttps://github.com/reactphp/socket/insights
https://github.com/reactphp/socket
WyriHaximushttps://github.com/WyriHaximus
reactphp:masterhttps://github.com/reactphp/socket/tree/master
clue-labs:closehttps://github.com/clue-labs/socket/tree/close
Conversationhttps://github.com/reactphp/socket/pull/141
Commits2 (2)https://github.com/reactphp/socket/pull/141/commits
Checkshttps://github.com/reactphp/socket/pull/141/checks
Files changedhttps://github.com/reactphp/socket/pull/141/files
Fix closing socket resource before removing from loophttps://github.com/reactphp/socket/pull/141#top
WyriHaximushttps://github.com/WyriHaximus
reactphp:masterhttps://github.com/reactphp/socket/tree/master
clue-labs:closehttps://github.com/clue-labs/socket/tree/close
https://github.com/clue
cluehttps://github.com/clue
Dec 23, 2017https://github.com/reactphp/socket/pull/141#issue-284322182
Please reload this pagehttps://github.com/reactphp/socket/pull/141
#99https://github.com/reactphp/socket/pull/99
reactphp/stream#121https://github.com/reactphp/stream/pull/121
reactphp/event-loop#139https://github.com/reactphp/event-loop/pull/139
reactphp/event-loop#136https://github.com/reactphp/event-loop/issues/136
Please reload this pagehttps://github.com/reactphp/socket/pull/141
https://github.com/clue
Fix closing socket resource before removing from loophttps://github.com/reactphp/socket/pull/141/commits/006b41b858d3d2bc368b08094f9b19d19f2820b4
006b41bhttps://github.com/reactphp/socket/pull/141/commits/006b41b858d3d2bc368b08094f9b19d19f2820b4
https://github.com/clue
cluehttps://github.com/clue
bug https://github.com/reactphp/socket/issues?q=state%3Aopen%20label%3Abug
Dec 23, 2017https://github.com/reactphp/socket/pull/141#event-1400466019
https://github.com/clue
cluehttps://github.com/clue
v0.8.7https://github.com/reactphp/socket/milestone/23
Dec 23, 2017https://github.com/reactphp/socket/pull/141#event-1400466021
https://github.com/clue
Skip memory stream tests on unsupported HHVMhttps://github.com/reactphp/socket/pull/141/commits/3ce31854e2a94a50df3591a8cb685478955a0b12
3ce3185https://github.com/reactphp/socket/pull/141/commits/3ce31854e2a94a50df3591a8cb685478955a0b12
https://github.com/jsor
jsorhttps://github.com/jsor
Dec 23, 2017 https://github.com/reactphp/socket/pull/141#pullrequestreview-85429506
View reviewed changes https://github.com/reactphp/socket/pull/141/files/3ce31854e2a94a50df3591a8cb685478955a0b12
https://github.com/WyriHaximus
WyriHaximushttps://github.com/WyriHaximus
Dec 23, 2017 https://github.com/reactphp/socket/pull/141#pullrequestreview-85429864
View reviewed changes https://github.com/reactphp/socket/pull/141/files/3ce31854e2a94a50df3591a8cb685478955a0b12
https://github.com/WyriHaximus
WyriHaximushttps://github.com/WyriHaximus
70d44b9https://github.com/reactphp/socket/commit/70d44b9905b0a91175e9ad3c4a51672638807d07
Dec 23, 2017https://github.com/reactphp/socket/pull/141#event-1400486555
https://github.com/clue
cluehttps://github.com/clue
December 24, 2017 10:42https://github.com/reactphp/socket/pull/141#event-1400607239
Event::set(): supplied resource is not a valid reactphp/event-loop#136 https://github.com/reactphp/event-loop/issues/136
Fix separately removing readable and writable side of stream when closing reactphp/event-loop#139 https://github.com/reactphp/event-loop/pull/139
Update dependencies to latest supported component versions reactphp/reactphp#396 https://github.com/reactphp/reactphp/pull/396
https://github.co/hiddenchars
https://github.com/reactphp/socket/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Freactphp%2Fsocket%2Fpull%2F141
https://github.com/jsor
jsor https://github.com/jsor
https://github.com/reactphp/socket/pull/141/files/3ce31854e2a94a50df3591a8cb685478955a0b12
https://github.com/WyriHaximus
WyriHaximus https://github.com/WyriHaximus
https://github.com/reactphp/socket/pull/141/files/3ce31854e2a94a50df3591a8cb685478955a0b12
Please reload this pagehttps://github.com/reactphp/socket/pull/141
bug https://github.com/reactphp/socket/issues?q=state%3Aopen%20label%3Abug
v0.8.7 https://github.com/reactphp/socket/milestone/23
Event::set(): supplied resource is not a valid https://github.com/reactphp/event-loop/issues/136
Please reload this pagehttps://github.com/reactphp/socket/pull/141
https://github.com/clue
https://github.com/jsor
https://github.com/WyriHaximus
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.