| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0579d73c-19e2-c784-5542-07e73064edf8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ED7A:17415E:2F8713:4243A2:6B006B65 |
| html-safe-nonce | 9cce0b7b2e126b7c5a1ad10a6d716d9e31510a95fa0820aed74deff90af75762 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDdBOjE3NDE1RToyRjg3MTM6NDI0M0EyOjZCMDA2QjY1IiwidmlzaXRvcl9pZCI6Ijg1NTExNjEyNjU0Mjk0NDEzODEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b68514a465c0a9f9b370f76d7589c8f911f1929e5f9681a340d483b03b6d635e |
| hovercard-subject-tag | pull_request:83897861 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/reactphp/http/65/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/625af85b620fc464377881357d9e777a38441d1f862244958706cfd8e1aa20ef/reactphp/http/pull/65 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/625af85b620fc464377881357d9e777a38441d1f862244958706cfd8e1aa20ef/reactphp/http/pull/65 |
| og:image:alt | As discovered during @clue's talk at Typo3 days https://www.youtube.com/watch?v=q2pVVDZtuJs Guzzle's request parser can throw an exception but we don't catch it. This PR adds catching t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | WyriHaximus |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6527e91c60c0b29d16606ff32ac5df8ecdc37a2a62205ea057a14d7762c870fa |
| turbo-cache-control | no-cache |
| go-import | github.com/reactphp/http git https://github.com/reactphp/http.git |
| octolytics-dimension-user_id | 1696866 |
| octolytics-dimension-user_login | reactphp |
| octolytics-dimension-repository_id | 4287609 |
| octolytics-dimension-repository_nwo | reactphp/http |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 4287609 |
| octolytics-dimension-repository_network_root_nwo | reactphp/http |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 46f1cd2ae3cd8ae1a81019b5d619742e76f13bbd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/reactphp/http/pull/65#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Freactphp%2Fhttp%2Fpull%2F65 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Freactphp%2Fhttp%2Fpull%2F65 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=reactphp%2Fhttp |
| Reload | https://github.com/reactphp/http/pull/65 |
| Reload | https://github.com/reactphp/http/pull/65 |
| Reload | https://github.com/reactphp/http/pull/65 |
| reactphp | https://github.com/reactphp |
| http | https://github.com/reactphp/http |
| Code | https://github.com/reactphp/http |
| Issues13 (13) | https://github.com/reactphp/http/issues |
| Pull requests8 (8) | https://github.com/reactphp/http/pulls |
| Actions | https://github.com/reactphp/http/actions |
| Wiki | https://github.com/reactphp/http/wiki |
| Security and quality4 (4) | https://github.com/reactphp/http/security |
| Insights | https://github.com/reactphp/http/insights |
| https://github.com/reactphp/http |
| WyriHaximus | https://github.com/WyriHaximus |
| master | https://github.com/reactphp/http/tree/master |
| fix-guzzle-parse-request-exceptions | https://github.com/reactphp/http/tree/fix-guzzle-parse-request-exceptions |
| Conversation | https://github.com/reactphp/http/pull/65 |
| Commits6 (6) | https://github.com/reactphp/http/pull/65/commits |
| Checks | https://github.com/reactphp/http/pull/65/checks |
| Files changed | https://github.com/reactphp/http/pull/65/files |
| Catch Guzzle parse request errors | https://github.com/reactphp/http/pull/65#top |
| WyriHaximus | https://github.com/WyriHaximus |
| master | https://github.com/reactphp/http/tree/master |
| fix-guzzle-parse-request-exceptions | https://github.com/reactphp/http/tree/fix-guzzle-parse-request-exceptions |
|
| https://github.com/WyriHaximus |
| WyriHaximus | https://github.com/WyriHaximus |
| Sep 3, 2016 | https://github.com/reactphp/http/pull/65#issue-174901089 |
| Please reload this page | https://github.com/reactphp/http/pull/65 |
| @clue | https://github.com/clue |
| https://www.youtube.com/watch?v=q2pVVDZtuJs | https://www.youtube.com/watch?v=q2pVVDZtuJs |
| Please reload this page | https://github.com/reactphp/http/pull/65 |
| WyriHaximus | https://github.com/WyriHaximus |
| September 3, 2016 17:08 | https://github.com/reactphp/http/pull/65#commits-pushed-9d7896e |
|
| https://github.com/WyriHaximus |
| Catch Guzzle parse request errors and emit them as error | https://github.com/reactphp/http/pull/65/commits/9d7896e15254e59b1fe51d7edb17c3799d6c57db |
| 9d7896e | https://github.com/reactphp/http/pull/65/commits/9d7896e15254e59b1fe51d7edb17c3799d6c57db |
|
| https://github.com/WyriHaximus |
| Catching exception a level higher | https://github.com/reactphp/http/pull/65/commits/398ee26db99f11b741acb89b77cc4f79939b7455 |
| 398ee26 | https://github.com/reactphp/http/pull/65/commits/398ee26db99f11b741acb89b77cc4f79939b7455 |
|
| https://github.com/WyriHaximus |
| use Exception | https://github.com/reactphp/http/pull/65/commits/4f47d79da8bd3f89e939c4131ece69dee77da664 |
| 4f47d79 | https://github.com/reactphp/http/pull/65/commits/4f47d79da8bd3f89e939c4131ece69dee77da664 |
|
| https://github.com/WyriHaximus |
| Testing guzzle parse exception throwing | https://github.com/reactphp/http/pull/65/commits/dd966ba4f4c12a21bce4d151e00260df0458c758 |
| dd966ba | https://github.com/reactphp/http/pull/65/commits/dd966ba4f4c12a21bce4d151e00260df0458c758 |
| https://github.com/WyriHaximus |
| WyriHaximus | https://github.com/WyriHaximus |
| Sep 3, 2016 | https://github.com/reactphp/http/pull/65#event-777395797 |
| https://github.com/WyriHaximus |
| WyriHaximus | https://github.com/WyriHaximus |
| Sep 3, 2016 | https://github.com/reactphp/http/pull/65#issuecomment-244556398 |
| @clue | https://github.com/clue |
| Please reload this page | https://github.com/reactphp/http/pull/65 |
| https://github.com/clue |
| clue | https://github.com/clue |
|
Sep 5, 2016
| https://github.com/reactphp/http/pull/65#ref-pullrequest-174924361 |
|
Emit error event for invalid requests (instead of crashing)
#67
| https://github.com/reactphp/http/pull/67 |
| clue | https://github.com/clue |
|
Sep 8, 2016
| https://github.com/reactphp/http/pull/65#discussion-diff-78107100 |
| View reviewed changes
| https://github.com/reactphp/http/pull/65/files/dd966ba4f4c12a21bce4d151e00260df0458c758#diff-b005413e7f144745228c83be586645d3f0aae31a68e39840eae993960e0532a1 |
| src/RequestHeaderParser.php | https://github.com/reactphp/http/pull/65/files#diff-b005413e7f144745228c83be586645d3f0aae31a68e39840eae993960e0532a1 |
| clue | https://github.com/clue |
| Sep 8, 2016 | https://github.com/reactphp/http/pull/65#discussion_r78107100 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/reactphp/http/pull/65 |
| WyriHaximus | https://github.com/WyriHaximus |
| Sep 8, 2016 | https://github.com/reactphp/http/pull/65#discussion_r78110001 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/reactphp/http/pull/65 |
| WyriHaximus | https://github.com/WyriHaximus |
| September 9, 2016 10:40 | https://github.com/reactphp/http/pull/65#commits-pushed-dc0f3f3 |
|
| https://github.com/WyriHaximus |
| Moved parsing and emitting to function for clarity | https://github.com/reactphp/http/pull/65/commits/dc0f3f3a745fbab3089adeeaf63753fbdf3d813f |
| dc0f3f3 | https://github.com/reactphp/http/pull/65/commits/dc0f3f3a745fbab3089adeeaf63753fbdf3d813f |
|
| https://github.com/WyriHaximus |
| Assert removeAllListeners | https://github.com/reactphp/http/pull/65/commits/80a49ed8d4b8af6cf26080a206df423d226fff09 |
| 80a49ed | https://github.com/reactphp/http/pull/65/commits/80a49ed8d4b8af6cf26080a206df423d226fff09 |
| clue | https://github.com/clue |
|
Sep 9, 2016
| https://github.com/reactphp/http/pull/65#discussion-diff-78152932 |
| View reviewed changes
| https://github.com/reactphp/http/pull/65/files/80a49ed8d4b8af6cf26080a206df423d226fff09#diff-ca2add0fd3638c2f60e5892feeadc34e80c44b34c487079d72564eaff16a0b6c |
| tests/RequestHeaderParserTest.php | https://github.com/reactphp/http/pull/65/files#diff-ca2add0fd3638c2f60e5892feeadc34e80c44b34c487079d72564eaff16a0b6c |
| clue | https://github.com/clue |
| Sep 9, 2016 | https://github.com/reactphp/http/pull/65#discussion_r78152932 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/reactphp/http/pull/65 |
| WyriHaximus | https://github.com/WyriHaximus |
| Sep 9, 2016 | https://github.com/reactphp/http/pull/65#discussion_r78160572 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/reactphp/http/pull/65 |
| https://github.com/clue |
| clue | https://github.com/clue |
| Sep 9, 2016 | https://github.com/reactphp/http/pull/65#issuecomment-245866108 |
| Please reload this page | https://github.com/reactphp/http/pull/65 |
| https://github.com/WyriHaximus |
| WyriHaximus | https://github.com/WyriHaximus |
| Sep 9, 2016 | https://github.com/reactphp/http/pull/65#issuecomment-245879533 |
| Please reload this page | https://github.com/reactphp/http/pull/65 |
| https://github.com/WyriHaximus |
| WyriHaximus | https://github.com/WyriHaximus |
| 777cfef | https://github.com/reactphp/http/commit/777cfef6a2a54259da495ec6cb11e2bd04756a60 |
| Sep 9, 2016 | https://github.com/reactphp/http/pull/65#event-783750394 |
| https://github.com/WyriHaximus |
| WyriHaximus | https://github.com/WyriHaximus |
| September 9, 2016 10:41 | https://github.com/reactphp/http/pull/65#event-783750435 |
| https://github.com/WyriHaximus |
| WyriHaximus | https://github.com/WyriHaximus |
|
Sep 9, 2016
| https://github.com/reactphp/http/pull/65#ref-pullrequest-175987283 |
|
Remove all listeners after emitting error in RequestHeaderParser
#68
| https://github.com/reactphp/http/pull/68 |
| https://github.com/clue |
| clue | https://github.com/clue |
|
Oct 25, 2016
| https://github.com/reactphp/http/pull/65#ref-pullrequest-156540693 |
|
Emit error when guzzle throws an InvalidArgumentException on parse_request
#56
| https://github.com/reactphp/http/pull/56 |
|
Catch parse_response errors from guzzle parser
reactphp/http-client#81
| https://github.com/reactphp/http-client/issues/81 |
|
Catch Guzzle parser exception
reactphp/http-client#82
| https://github.com/reactphp/http-client/pull/82 |
| https://github.co/hiddenchars |
| https://github.com/reactphp/http/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Freactphp%2Fhttp%2Fpull%2F65 |
| Please reload this page | https://github.com/reactphp/http/pull/65 |
| Please reload this page | https://github.com/reactphp/http/pull/65 |
|
| https://github.com/WyriHaximus |
|
| https://github.com/clue |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |