René's URL Explorer Experiment


Title: Fix handling invalid or incomplete multipart parts by clue · Pull Request #267 · reactphp/http · GitHub

Open Graph Title: Fix handling invalid or incomplete multipart parts by clue · Pull Request #267 · reactphp/http

X Title: Fix handling invalid or incomplete multipart parts by clue · Pull Request #267 · reactphp/http

Description: Event-driven, streaming HTTP client and server implementation for ReactPHP. - Fix handling invalid or incomplete multipart parts by clue · Pull Request #267 · reactphp/http

Open Graph Description: While working on #257, I found a number of issues with parsing invalid multipart parts. This PR adds quite a few tests, removes some now unneeded code and improves code coverage to 100%. This now s...

X Description: While working on #257, I found a number of issues with parsing invalid multipart parts. This PR adds quite a few tests, removes some now unneeded code and improves code coverage to 100%. This now s...

Opengraph URL: https://github.com/reactphp/http/pull/267

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:82f8c4b4-a0e3-187d-1854-929affcddd8a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id84D8:185321:E8C56:14362D:6B006360
html-safe-nonce2afe4981e46cec055790041c46b0c32c6fecc14221e4a125fc980133f531e008
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEQ4OjE4NTMyMTpFOEM1NjoxNDM2MkQ6NkIwMDYzNjAiLCJ2aXNpdG9yX2lkIjoiMjAzNTk2MjA4ODA2MDM4MDAwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac97b8793f5001ebe464e0a77355e0f7ef915b761edca2a2d12d94663fec675657
hovercard-subject-tagpull_request:155135978
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/reactphp/http/267/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ca44eab369327f73aa6f03997f91127934a2f1e22918237a0e91b298453ec171/reactphp/http/pull/267
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ca44eab369327f73aa6f03997f91127934a2f1e22918237a0e91b298453ec171/reactphp/http/pull/267
og:image:altWhile working on #257, I found a number of issues with parsing invalid multipart parts. This PR adds quite a few tests, removes some now unneeded code and improves code coverage to 100%. This now s...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameclue
hostnamegithub.com
expected-hostnamegithub.com
None25854482a1773a7c1ebb8be3d2bc1c6e61d82d78126be63b5044474a86d44d9e
turbo-cache-controlno-cache
go-importgithub.com/reactphp/http git https://github.com/reactphp/http.git
octolytics-dimension-user_id1696866
octolytics-dimension-user_loginreactphp
octolytics-dimension-repository_id4287609
octolytics-dimension-repository_nworeactphp/http
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id4287609
octolytics-dimension-repository_network_root_nworeactphp/http
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee4f5c239e31f1f680e6bbc419ff92d774da616ec
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/reactphp/http/pull/267#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Freactphp%2Fhttp%2Fpull%2F267
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Freactphp%2Fhttp%2Fpull%2F267
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=reactphp%2Fhttp
Reloadhttps://github.com/reactphp/http/pull/267
Reloadhttps://github.com/reactphp/http/pull/267
Reloadhttps://github.com/reactphp/http/pull/267
reactphphttps://github.com/reactphp
httphttps://github.com/reactphp/http
Codehttps://github.com/reactphp/http
Issues13 (13)https://github.com/reactphp/http/issues
Pull requests8 (8)https://github.com/reactphp/http/pulls
Actionshttps://github.com/reactphp/http/actions
Wikihttps://github.com/reactphp/http/wiki
Security and quality4 (4)https://github.com/reactphp/http/security
Insightshttps://github.com/reactphp/http/insights
https://github.com/reactphp/http
jsorhttps://github.com/jsor
reactphp:masterhttps://github.com/reactphp/http/tree/master
clue-labs:multipart-gotchashttps://github.com/clue-labs/http/tree/multipart-gotchas
Conversationhttps://github.com/reactphp/http/pull/267
Commits6 (6)https://github.com/reactphp/http/pull/267/commits
Checkshttps://github.com/reactphp/http/pull/267/checks
Files changedhttps://github.com/reactphp/http/pull/267/files
Fix handling invalid or incomplete multipart partshttps://github.com/reactphp/http/pull/267#top
jsorhttps://github.com/jsor
reactphp:masterhttps://github.com/reactphp/http/tree/master
clue-labs:multipart-gotchashttps://github.com/clue-labs/http/tree/multipart-gotchas
https://github.com/clue
cluehttps://github.com/clue
Nov 28, 2017https://github.com/reactphp/http/pull/267#issue-277471070
#257https://github.com/reactphp/http/issues/257
#265https://github.com/reactphp/http/pull/265
#226https://github.com/reactphp/http/pull/226
Please reload this pagehttps://github.com/reactphp/http/pull/267
cluehttps://github.com/clue
November 28, 2017 15:06https://github.com/reactphp/http/pull/267#commits-pushed-7c790ef
https://github.com/clue
Handle file uploads with missing or duplicate Content-Type headerhttps://github.com/reactphp/http/pull/267/commits/7c790efac2d726b88bef8a9e9bd4b7d420c5ec7d
7c790efhttps://github.com/reactphp/http/pull/267/commits/7c790efac2d726b88bef8a9e9bd4b7d420c5ec7d
https://github.com/clue
Fix ignoring invalid/incomplete partshttps://github.com/reactphp/http/pull/267/commits/8c281d472ba687a248f2f04940bc95a273fc77ea
8c281d4https://github.com/reactphp/http/pull/267/commits/8c281d472ba687a248f2f04940bc95a273fc77ea
https://github.com/clue
Rely on required boundary=X parameter and do not try to guesshttps://github.com/reactphp/http/pull/267/commits/5da1a87a4c46a762895d56610497ca5d0beb0c44
5da1a87https://github.com/reactphp/http/pull/267/commits/5da1a87a4c46a762895d56610497ca5d0beb0c44
https://github.com/clue
Simplify parameter parsing by removing duplicate logichttps://github.com/reactphp/http/pull/267/commits/129df64e9e3194b742936611523f607f5942b3e3
129df64https://github.com/reactphp/http/pull/267/commits/129df64e9e3194b742936611523f607f5942b3e3
https://github.com/clue
Avoid excessive member variableshttps://github.com/reactphp/http/pull/267/commits/7ed5a80d8ff486f8b0f630cfe6ab46ea685c0ed5
7ed5a80https://github.com/reactphp/http/pull/267/commits/7ed5a80d8ff486f8b0f630cfe6ab46ea685c0ed5
https://github.com/clue
Strictly obey newline definitions as per RFC 7578 and RFC 2046https://github.com/reactphp/http/pull/267/commits/cd5d3c80b11ea48074b7dc75be034721805e3470
cd5d3c8https://github.com/reactphp/http/pull/267/commits/cd5d3c80b11ea48074b7dc75be034721805e3470
https://github.com/clue
cluehttps://github.com/clue
bug https://github.com/reactphp/http/issues?q=state%3Aopen%20label%3Abug
Nov 28, 2017https://github.com/reactphp/http/pull/267#event-1361879702
https://github.com/clue
cluehttps://github.com/clue
v0.8.0https://github.com/reactphp/http/milestone/14
Nov 28, 2017https://github.com/reactphp/http/pull/267#event-1361879708
https://github.com/WyriHaximus
WyriHaximushttps://github.com/WyriHaximus
WyriHaximushttps://github.com/WyriHaximus
jsorhttps://github.com/jsor
November 28, 2017 20:00https://github.com/reactphp/http/pull/267#event-1362162056
https://github.com/WyriHaximus
WyriHaximushttps://github.com/WyriHaximus
Nov 28, 2017 https://github.com/reactphp/http/pull/267#pullrequestreview-79641624
View reviewed changes https://github.com/reactphp/http/pull/267/files/cd5d3c80b11ea48074b7dc75be034721805e3470
WyriHaximushttps://github.com/WyriHaximus
https://github.com/reactphp/http/pull/267#pullrequestreview-79641624
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/reactphp/http/pull/267
https://github.com/jsor
jsorhttps://github.com/jsor
Nov 28, 2017 https://github.com/reactphp/http/pull/267#pullrequestreview-79646823
View reviewed changes https://github.com/reactphp/http/pull/267/files/cd5d3c80b11ea48074b7dc75be034721805e3470
https://github.com/jsor
jsorhttps://github.com/jsor
2db0c91https://github.com/reactphp/http/commit/2db0c91fabc08228eee208c33bed267f2db7651f
Nov 28, 2017https://github.com/reactphp/http/pull/267#event-1362215564
https://github.com/clue
cluehttps://github.com/clue
November 28, 2017 21:40https://github.com/reactphp/http/pull/267#event-1362334980
https://github.co/hiddenchars
https://github.com/reactphp/http/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Freactphp%2Fhttp%2Fpull%2F267
https://github.com/jsor
jsor https://github.com/jsor
https://github.com/reactphp/http/pull/267/files/cd5d3c80b11ea48074b7dc75be034721805e3470
https://github.com/WyriHaximus
WyriHaximus https://github.com/WyriHaximus
https://github.com/reactphp/http/pull/267/files/cd5d3c80b11ea48074b7dc75be034721805e3470
Please reload this pagehttps://github.com/reactphp/http/pull/267
bug https://github.com/reactphp/http/issues?q=state%3Aopen%20label%3Abug
v0.8.0 https://github.com/reactphp/http/milestone/14
Please reload this pagehttps://github.com/reactphp/http/pull/267
https://github.com/clue
https://github.com/jsor
https://github.com/WyriHaximus
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.