| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3e1cfab6-d474-dd7d-8222-dde211f3bd31 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AF90:2EC689:2C2D169:3C4D365:6B005A16 |
| html-safe-nonce | 34821546a5edf112a2d32875f042b8b25b8d85e45dee86a7899871a8fff4f92f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjkwOjJFQzY4OToyQzJEMTY5OjNDNEQzNjU6NkIwMDVBMTYiLCJ2aXNpdG9yX2lkIjoiNTkxMjUwOTEyMDY5MDQ4ODU0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 40c97795d5ca7549345fb633c7cb24bf6de9093703839ce3bd52a282d1347437 |
| hovercard-subject-tag | pull_request:1851433096 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/reactphp/async/86/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/dd1e58a0ae9aa87ef4bbbc0b318dbd4ede0fc4b5f13e1c864bcb2b093f575b4c/reactphp/async/pull/86 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/dd1e58a0ae9aa87ef4bbbc0b318dbd4ede0fc4b5f13e1c864bcb2b093f575b4c/reactphp/async/pull/86 |
| og:image:alt | This pull request adds some missing Promise v3 template types that have been reported by PHPStan. The same changes should also be applied to the 3.x branch, so once this is merged I will create a f... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | SimonFrings |
| hostname | github.com |
| expected-hostname | github.com |
| None | 29be975efff6507a5d135de9c7d634cf7ff8f0c55222a64386ab3202209aaf73 |
| turbo-cache-control | no-cache |
| go-import | github.com/reactphp/async git https://github.com/reactphp/async.git |
| octolytics-dimension-user_id | 1696866 |
| octolytics-dimension-user_login | reactphp |
| octolytics-dimension-repository_id | 4705850 |
| octolytics-dimension-repository_nwo | reactphp/async |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 4705850 |
| octolytics-dimension-repository_network_root_nwo | reactphp/async |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | eacd927ba6112e3b01ba99c762bd699a4a4f5df7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/reactphp/async/pull/86#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Freactphp%2Fasync%2Fpull%2F86 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Freactphp%2Fasync%2Fpull%2F86 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=reactphp%2Fasync |
| Reload | https://github.com/reactphp/async/pull/86 |
| Reload | https://github.com/reactphp/async/pull/86 |
| Reload | https://github.com/reactphp/async/pull/86 |
| reactphp | https://github.com/reactphp |
| async | https://github.com/reactphp/async |
| Code | https://github.com/reactphp/async |
| Issues2 (2) | https://github.com/reactphp/async/issues |
| Pull requests10 (10) | https://github.com/reactphp/async/pulls |
| Actions | https://github.com/reactphp/async/actions |
| Security and quality | https://github.com/reactphp/async/security |
| Insights | https://github.com/reactphp/async/insights |
| https://github.com/reactphp/async |
| WyriHaximus | https://github.com/WyriHaximus |
| reactphp:4.x | https://github.com/reactphp/async/tree/4.x |
| SimonFrings:tempalte_types | https://github.com/SimonFrings/async/tree/tempalte_types |
| Conversation | https://github.com/reactphp/async/pull/86 |
| Commits1 (1) | https://github.com/reactphp/async/pull/86/commits |
| Checks | https://github.com/reactphp/async/pull/86/checks |
| Files changed | https://github.com/reactphp/async/pull/86/files |
| [4.x] Improve type safety for test environment | https://github.com/reactphp/async/pull/86#top |
| WyriHaximus | https://github.com/WyriHaximus |
| reactphp:4.x | https://github.com/reactphp/async/tree/4.x |
| SimonFrings:tempalte_types | https://github.com/SimonFrings/async/tree/tempalte_types |
|
| https://github.com/SimonFrings |
| SimonFrings | https://github.com/SimonFrings |
| May 2, 2024 | https://github.com/reactphp/async/pull/86#issue-2275435179 |
| reactphp/promise#247 | https://github.com/reactphp/promise/pull/247 |
| clue/framework-x/pull/235 | https://github.com/clue/framework-x/pull/235 |
| #76 | https://github.com/reactphp/async/pull/76 |
| Please reload this page | https://github.com/reactphp/async/pull/86 |
| https://github.com/SimonFrings |
| SimonFrings | https://github.com/SimonFrings |
|
new feature
| https://github.com/reactphp/async/issues?q=state%3Aopen%20label%3A%22new%20feature%22 |
| May 2, 2024 | https://github.com/reactphp/async/pull/86#event-12682660715 |
| https://github.com/SimonFrings |
| SimonFrings | https://github.com/SimonFrings |
| v4.3.0 | https://github.com/reactphp/async/milestone/10 |
| May 2, 2024 | https://github.com/reactphp/async/pull/86#event-12682660734 |
| https://github.com/SimonFrings |
| SimonFrings | https://github.com/SimonFrings |
| WyriHaximus | https://github.com/WyriHaximus |
| clue | https://github.com/clue |
| May 2, 2024 12:36 | https://github.com/reactphp/async/pull/86#event-12682660763 |
| https://github.com/WyriHaximus |
| WyriHaximus | https://github.com/WyriHaximus |
| May 15, 2024 | https://github.com/reactphp/async/pull/86#issuecomment-2111629399 |
| @SimonFrings | https://github.com/SimonFrings |
| https://phpstan.org/blog/phpstan-1-11-errors-identifiers-phpstan-pro-reboot | https://phpstan.org/blog/phpstan-1-11-errors-identifiers-phpstan-pro-reboot |
| Please reload this page | https://github.com/reactphp/async/pull/86 |
| https://github.com/SimonFrings |
| SimonFrings | https://github.com/SimonFrings |
|
May 15, 2024
| https://github.com/reactphp/async/pull/86#ref-issue-2297569675 |
|
Unexpected >> reported by PHPStan when using template types
phpstan/phpstan#11032
| https://github.com/phpstan/phpstan/issues/11032 |
| https://github.com/SimonFrings |
| SimonFrings | https://github.com/SimonFrings |
| force-pushed | https://github.com/reactphp/async/compare/9102fe278e093d0aa110b5e2c3da7a6d792ee50d..1400c281bb062df34be5d1b53bb031319e338892 |
| 9102fe2 | https://github.com/reactphp/async/commit/9102fe278e093d0aa110b5e2c3da7a6d792ee50d |
| 1400c28 | https://github.com/reactphp/async/commit/1400c281bb062df34be5d1b53bb031319e338892 |
|
Compare
| https://github.com/reactphp/async/compare/9102fe278e093d0aa110b5e2c3da7a6d792ee50d..1400c281bb062df34be5d1b53bb031319e338892 |
| May 17, 2024 10:30 | https://github.com/reactphp/async/pull/86#event-12846126309 |
| https://github.com/SimonFrings |
| SimonFrings | https://github.com/SimonFrings |
|
May 17, 2024
| https://github.com/reactphp/async/pull/86#pullrequestreview-2062953677 |
|
View reviewed changes
| https://github.com/reactphp/async/pull/86/files |
| SimonFrings | https://github.com/SimonFrings |
| Please reload this page | https://github.com/reactphp/async/pull/86 |
| https://github.com/reactphp/async/pull/86#pullrequestreview-2062953677 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/reactphp/async/pull/86 |
| src/functions.php | https://github.com/reactphp/async/pull/86/files#diff-fe65dcdace9cc44252b537bee79dd574edd1bccf6cee646cc860006a6ec50e8b |
| Please reload this page | https://github.com/reactphp/async/pull/86 |
| src/functions.php | https://github.com/reactphp/async/pull/86/files#diff-fe65dcdace9cc44252b537bee79dd574edd1bccf6cee646cc860006a6ec50e8b |
| Please reload this page | https://github.com/reactphp/async/pull/86 |
|
| https://github.com/SimonFrings |
| Use Promise v3 template types | https://github.com/reactphp/async/pull/86/commits/6a15425dff13307037bf3aa4b1accad610a3c628 |
| 6a15425 | https://github.com/reactphp/async/pull/86/commits/6a15425dff13307037bf3aa4b1accad610a3c628 |
| https://github.com/SimonFrings |
| SimonFrings | https://github.com/SimonFrings |
| force-pushed | https://github.com/reactphp/async/compare/1400c281bb062df34be5d1b53bb031319e338892..6a15425dff13307037bf3aa4b1accad610a3c628 |
| 1400c28 | https://github.com/reactphp/async/commit/1400c281bb062df34be5d1b53bb031319e338892 |
| 6a15425 | https://github.com/reactphp/async/commit/6a15425dff13307037bf3aa4b1accad610a3c628 |
|
Compare
| https://github.com/reactphp/async/compare/1400c281bb062df34be5d1b53bb031319e338892..6a15425dff13307037bf3aa4b1accad610a3c628 |
| May 22, 2024 06:50 | https://github.com/reactphp/async/pull/86#event-12889298845 |
| https://github.com/clue |
| clue | https://github.com/clue |
|
May 22, 2024
| https://github.com/reactphp/async/pull/86#pullrequestreview-2070444722 |
|
View reviewed changes
| https://github.com/reactphp/async/pull/86/files/6a15425dff13307037bf3aa4b1accad610a3c628 |
| clue | https://github.com/clue |
| https://github.com/reactphp/async/pull/86#pullrequestreview-2070444722 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @SimonFrings | https://github.com/SimonFrings |
| phpstan/phpstan#11032 | https://github.com/phpstan/phpstan/issues/11032 |
| Please reload this page | https://github.com/reactphp/async/pull/86 |
| https://github.com/WyriHaximus |
| WyriHaximus | https://github.com/WyriHaximus |
|
May 22, 2024
| https://github.com/reactphp/async/pull/86#pullrequestreview-2071948509 |
|
View reviewed changes
| https://github.com/reactphp/async/pull/86/files/6a15425dff13307037bf3aa4b1accad610a3c628 |
| https://github.com/WyriHaximus |
| WyriHaximus | https://github.com/WyriHaximus |
| 16d653f | https://github.com/reactphp/async/commit/16d653f6958cba52f91ed401ce2e6dcd07db6bab |
| May 22, 2024 | https://github.com/reactphp/async/pull/86#event-12898618514 |
| https://github.com/clue |
| clue | https://github.com/clue |
|
May 22, 2024
| https://github.com/reactphp/async/pull/86#ref-pullrequest-2311447950 |
|
Improve PHP 8.4+ support by avoiding implicitly nullable types
#87
| https://github.com/reactphp/async/pull/87 |
| https://github.com/SimonFrings |
| SimonFrings | https://github.com/SimonFrings |
| Jun 3, 2024 | https://github.com/reactphp/async/pull/86#event-13024436985 |
| https://github.com/SimonFrings |
| SimonFrings | https://github.com/SimonFrings |
|
maintenance
| https://github.com/reactphp/async/issues?q=state%3Aopen%20label%3Amaintenance |
| Jun 3, 2024 | https://github.com/reactphp/async/pull/86#event-13024437876 |
| https://github.com/clue |
| clue | https://github.com/clue |
|
Aug 10, 2024
| https://github.com/reactphp/async/pull/86#ref-pullrequest-2459047681 |
|
[3.x] Improve type safety for test environment
#89
| https://github.com/reactphp/async/pull/89 |
| https://github.co/hiddenchars |
| https://github.com/reactphp/async/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Freactphp%2Fasync%2Fpull%2F86 |
|
| https://github.com/WyriHaximus |
|
WyriHaximus
| https://github.com/WyriHaximus |
|
| https://github.com/reactphp/async/pull/86/files/6a15425dff13307037bf3aa4b1accad610a3c628 |
|
| https://github.com/clue |
|
clue
| https://github.com/clue |
|
| https://github.com/reactphp/async/pull/86/files/6a15425dff13307037bf3aa4b1accad610a3c628 |
| Please reload this page | https://github.com/reactphp/async/pull/86 |
|
maintenance
| https://github.com/reactphp/async/issues?q=state%3Aopen%20label%3Amaintenance |
|
new feature
| https://github.com/reactphp/async/issues?q=state%3Aopen%20label%3A%22new%20feature%22 |
|
v4.3.0
| https://github.com/reactphp/async/milestone/10 |
| Please reload this page | https://github.com/reactphp/async/pull/86 |
|
| https://github.com/SimonFrings |
|
| https://github.com/WyriHaximus |
|
| https://github.com/clue |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |