Title: Split from PR 958: restoring the __import__ after shutdown. by benoithudson · Pull Request #993 · pythonnet/pythonnet · GitHub
Open Graph Title: Split from PR 958: restoring the __import__ after shutdown. by benoithudson · Pull Request #993 · pythonnet/pythonnet
X Title: Split from PR 958: restoring the __import__ after shutdown. by benoithudson · Pull Request #993 · pythonnet/pythonnet
Description: When C# shuts down we should restore Python to its original state. What does this implement/fix? Explain your changes. This is adapted from the large patch that amos put in PR #958. It restores the import hook. Does this close any currently open issues? Not yet. Any other comments? I would have used the ShutdownHandler but that's only in the PythonEngine, whereas __import__ is in the Runtime. Maybe we should move the ShutdownHandler mechanism to the runtime? Checklist Check all those that are applicable and complete. Make sure to include one or more tests for your change Can't really test this at the moment. After Py_Finalize (in Shutdown), we can't check the state of the __import__ function until we call Py_Initialize. But Py_Initialize will create a new __import__, so we can't see whether our code ran. This change only becomes relevant when we stop calling Py_Finalize in Shutdown. If an enhancement PR, please create docs and at best an example Add yourself to AUTHORS Updated the CHANGELOG
Open Graph Description: When C# shuts down we should restore Python to its original state. What does this implement/fix? Explain your changes. This is adapted from the large patch that amos put in PR #958. It restores the...
X Description: When C# shuts down we should restore Python to its original state. What does this implement/fix? Explain your changes. This is adapted from the large patch that amos put in PR #958. It restores the...
Opengraph URL: https://github.com/pythonnet/pythonnet/pull/993
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:b291e26e-5a05-b279-66b5-dc58861ec026 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | A830:3C5761:297D89B:3A597A8:697100BB |
| html-safe-nonce | 9cc17a76d494be0f427790c716e2a37407b8ca4a9b928bddd6dfd4a20e13d495 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODMwOjNDNTc2MToyOTdEODlCOjNBNTk3QTg6Njk3MTAwQkIiLCJ2aXNpdG9yX2lkIjoiOTEwNDU3Njg4OTY0MzY2MzU0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 67f91cdfd68e21416e6749c0f0f34652fba4b310dce8e5f199e12e8b17c3fada |
| hovercard-subject-tag | pull_request:343859455 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/993/checks |
| twitter:image | https://avatars.githubusercontent.com/u/15807877?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/15807877?s=400&v=4 |
| og:image:alt | When C# shuts down we should restore Python to its original state. What does this implement/fix? Explain your changes. This is adapted from the large patch that amos put in PR #958. It restores the... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2d17fd2bbd784dc91f3a78a2f1d2c41d9f4f8ce86136d09833e3cf21b2bde1b7 |
| turbo-cache-control | no-preview |
| go-import | github.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git |
| octolytics-dimension-user_id | 6050430 |
| octolytics-dimension-user_login | pythonnet |
| octolytics-dimension-repository_id | 14748123 |
| octolytics-dimension-repository_nwo | pythonnet/pythonnet |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 14748123 |
| octolytics-dimension-repository_network_root_nwo | pythonnet/pythonnet |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e053d923fb27a9d948f8cefae8ba3bf43f7b938f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width