Title: Enable pythonnet to survive in the Unity3d editor environment. by benoithudson · Pull Request #752 · pythonnet/pythonnet · GitHub
Open Graph Title: Enable pythonnet to survive in the Unity3d editor environment. by benoithudson · Pull Request #752 · pythonnet/pythonnet
X Title: Enable pythonnet to survive in the Unity3d editor environment. by benoithudson · Pull Request #752 · pythonnet/pythonnet
Description: The Unity editor unloads the C# domain and creates a new domain every time it recompiles C# sources. This caused two crashes. After a domain unload, python is now pointing to a bunch of objects whose C# side is now garbage. Solution: Shutdown() the engine on domain reload, which calls Py_Finalize. After a domain unload, Py_Finalize, and a new Py_Intialize, python still keeps pointers in gc for any python objects that were leaked. And pythonnet leaks. This means that python's gc will be calling tp_traverse, tp_clear, and tp_is_gc on types that are implemented in C#. This crashes because the implementation was freed. Solution: implement those calls in code that is not released on domain unload. Side effect: we leak a page on every domain unload. I suspect but didn't test that python gc performance will be slightly faster. Changes required to implement and test: 3. Use python's platform package to determine what we're running on, so we can use the right mmap/mprotect or VirtualAlloc/VirtualProtect routines, the right flags for mmap, and (theoretically) the right native code. Side effect: to port to a new platform requires updating some additional code now. New unit tests. (a) A new test for domain reload. It doesn't run under .NET Core because you can't create and unload a domain in .NET Core. (b) New unit tests to help us find where to add support for new platforms. Does this close any currently open issues? #714 ; see also #745 and #751.
Open Graph Description: The Unity editor unloads the C# domain and creates a new domain every time it recompiles C# sources. This caused two crashes. After a domain unload, python is now pointing to a bunch of objects w...
X Description: The Unity editor unloads the C# domain and creates a new domain every time it recompiles C# sources. This caused two crashes. After a domain unload, python is now pointing to a bunch of objects w...
Opengraph URL: https://github.com/pythonnet/pythonnet/pull/752
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:32fa485b-4dd1-bc0b-d056-e0c6cd2db0b5 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | D1AC:337F64:122E73E:18EC114:6971E0DB |
| html-safe-nonce | 157fc24a703c61bd42cd08e5d563ede0ff3344cf6438919f837ca1735285624b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMUFDOjMzN0Y2NDoxMjJFNzNFOjE4RUMxMTQ6Njk3MUUwREIiLCJ2aXNpdG9yX2lkIjoiMjAxMTgyOTEzMDY1NDUwNzIyNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c3300ea1f8a9c66c69f83288bb198208398c3f8038f04d84beb1a829ef648313 |
| hovercard-subject-tag | pull_request:222575536 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/752/checks |
| twitter:image | https://avatars.githubusercontent.com/u/15807877?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/15807877?s=400&v=4 |
| og:image:alt | The Unity editor unloads the C# domain and creates a new domain every time it recompiles C# sources. This caused two crashes. After a domain unload, python is now pointing to a bunch of objects w... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 683712716975b3393656edf09255a1d488d0e68ab7b9ac97e40ecf40036f696c |
| turbo-cache-control | no-preview |
| go-import | github.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git |
| octolytics-dimension-user_id | 6050430 |
| octolytics-dimension-user_login | pythonnet |
| octolytics-dimension-repository_id | 14748123 |
| octolytics-dimension-repository_nwo | pythonnet/pythonnet |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 14748123 |
| octolytics-dimension-repository_network_root_nwo | pythonnet/pythonnet |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ed99da4e2de688dd1056894c1eccd4c82c6bbbfe |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width