René's URL Explorer Experiment


Title: LookupType returns the first type found by Cronan · Pull Request #622 · pythonnet/pythonnet · GitHub

Open Graph Title: LookupType returns the first type found by Cronan · Pull Request #622 · pythonnet/pythonnet

X Title: LookupType returns the first type found by Cronan · Pull Request #622 · pythonnet/pythonnet

Description: What does this implement/fix? Explain your changes. In .Net Core 2.0, there are public and private versions of the same types in different assemblies. For example, there is a private version of System.Environment in mscorlib.dll, and a public version in System.Runtime.Extensions.dll. The existing code returns the first matching type found, even if it's private, and even if there are other matching types in other assemblies. The new version of this function returns the first public type, or the first type found. Does this close any currently open issues? This closes some parts of #613 Checklist Check all those that are applicable and complete. Make sure to include one or more tests for your change If an enhancement PR, please create docs and at best an example Add yourself to AUTHORS Updated the CHANGELOG

Open Graph Description: What does this implement/fix? Explain your changes. In .Net Core 2.0, there are public and private versions of the same types in different assemblies. For example, there is a private version of Sys...

X Description: What does this implement/fix? Explain your changes. In .Net Core 2.0, there are public and private versions of the same types in different assemblies. For example, there is a private version of Sys...

Opengraph URL: https://github.com/pythonnet/pythonnet/pull/622

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5a24cf44-c190-bd5b-bbf0-881b1729b7cd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCE5C:22C7B5:16681BD:1E5C372:6972AD23
html-safe-nonce057315b07b14e7d76767ab5aae8aff7953f8871e47d6dee7a05eb3042fa05c8a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRTVDOjIyQzdCNToxNjY4MUJEOjFFNUMzNzI6Njk3MkFEMjMiLCJ2aXNpdG9yX2lkIjoiNjAzMDU1NjgxMTk1NjUwMzM5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6fd2b24c1f40809da8a8be867d7f3a40039615b1bfa22bbe520c7e172ec8e1fe
hovercard-subject-tagpull_request:167680115
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/622/files
twitter:imagehttps://avatars.githubusercontent.com/u/777435?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/777435?s=400&v=4
og:image:altWhat does this implement/fix? Explain your changes. In .Net Core 2.0, there are public and private versions of the same types in different assemblies. For example, there is a private version of Sys...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneae357919e9cc5fb635a01c9a2cc530478d3ac85f55090215eb70e1beca3385ac
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git
octolytics-dimension-user_id6050430
octolytics-dimension-user_loginpythonnet
octolytics-dimension-repository_id14748123
octolytics-dimension-repository_nwopythonnet/pythonnet
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id14748123
octolytics-dimension-repository_network_root_nwopythonnet/pythonnet
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release625f1bd9f76a617a9c0729e2de91edb56b6ce42f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/pythonnet/pythonnet/pull/622/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F622%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F622%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=pythonnet%2Fpythonnet
Reloadhttps://github.com/pythonnet/pythonnet/pull/622/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/622/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/622/files
pythonnet https://github.com/pythonnet
pythonnethttps://github.com/pythonnet/pythonnet
Notifications https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Fork 770 https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Star 5.4k https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Code https://github.com/pythonnet/pythonnet
Issues 155 https://github.com/pythonnet/pythonnet/issues
Pull requests 18 https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects 0 https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security 0 https://github.com/pythonnet/pythonnet/security
Insights https://github.com/pythonnet/pythonnet/pulse
Code https://github.com/pythonnet/pythonnet
Issues https://github.com/pythonnet/pythonnet/issues
Pull requests https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security https://github.com/pythonnet/pythonnet/security
Insights https://github.com/pythonnet/pythonnet/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
Cronanhttps://github.com/Cronan
pythonnet:masterhttps://github.com/pythonnet/pythonnet/tree/master
Conversation 14 https://github.com/pythonnet/pythonnet/pull/622
Commits 2 https://github.com/pythonnet/pythonnet/pull/622/commits
Checks 0 https://github.com/pythonnet/pythonnet/pull/622/checks
Files changed https://github.com/pythonnet/pythonnet/pull/622/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/622/files
LookupType returns the first type found https://github.com/pythonnet/pythonnet/pull/622/files#top
Show all changes 2 commits https://github.com/pythonnet/pythonnet/pull/622/files
994d609 Fixes issue where private types are returned Cronan Feb 7, 2018 https://github.com/pythonnet/pythonnet/pull/622/commits/994d609f9448246cfc3e2790455944d155a73057
1cfc844 Merge branch 'master' into lookup_type Cronan Feb 7, 2018 https://github.com/pythonnet/pythonnet/pull/622/commits/1cfc844471af49df4f6698a82b80aff6df2036ef
Clear filters https://github.com/pythonnet/pythonnet/pull/622/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/622/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/622/files
CHANGELOG.md https://github.com/pythonnet/pythonnet/pull/622/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
assemblymanager.cs https://github.com/pythonnet/pythonnet/pull/622/files#diff-ec817a3080cb54b7ab7107226a35fe72560bead6faec81dd9e6a5620311d2a7b
test_import.py https://github.com/pythonnet/pythonnet/pull/622/files#diff-170ecfe0db72c6c2a0595b9df5ae11cc421e67a8afbfebca52f5d50bbea0003b
CHANGELOG.mdhttps://github.com/pythonnet/pythonnet/pull/622/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
View file https://github.com/pythonnet/pythonnet/blob/1cfc844471af49df4f6698a82b80aff6df2036ef/CHANGELOG.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/622/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/622/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
https://github.com/pythonnet/pythonnet/pull/622/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
src/runtime/assemblymanager.cshttps://github.com/pythonnet/pythonnet/pull/622/files#diff-ec817a3080cb54b7ab7107226a35fe72560bead6faec81dd9e6a5620311d2a7b
View file https://github.com/pythonnet/pythonnet/blob/1cfc844471af49df4f6698a82b80aff6df2036ef/src/runtime/assemblymanager.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/622/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/622/files#diff-ec817a3080cb54b7ab7107226a35fe72560bead6faec81dd9e6a5620311d2a7b
https://github.com/pythonnet/pythonnet/pull/622/files#diff-ec817a3080cb54b7ab7107226a35fe72560bead6faec81dd9e6a5620311d2a7b
https://github.com/pythonnet/pythonnet/pull/622/files#diff-ec817a3080cb54b7ab7107226a35fe72560bead6faec81dd9e6a5620311d2a7b
https://github.com/pythonnet/pythonnet/pull/622/files#diff-ec817a3080cb54b7ab7107226a35fe72560bead6faec81dd9e6a5620311d2a7b
src/tests/test_import.pyhttps://github.com/pythonnet/pythonnet/pull/622/files#diff-170ecfe0db72c6c2a0595b9df5ae11cc421e67a8afbfebca52f5d50bbea0003b
View file https://github.com/pythonnet/pythonnet/blob/1cfc844471af49df4f6698a82b80aff6df2036ef/src/tests/test_import.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/622/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/622/files#diff-170ecfe0db72c6c2a0595b9df5ae11cc421e67a8afbfebca52f5d50bbea0003b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.