Title: LookupType returns the first type found by Cronan · Pull Request #622 · pythonnet/pythonnet · GitHub
Open Graph Title: LookupType returns the first type found by Cronan · Pull Request #622 · pythonnet/pythonnet
X Title: LookupType returns the first type found by Cronan · Pull Request #622 · pythonnet/pythonnet
Description: What does this implement/fix? Explain your changes. In .Net Core 2.0, there are public and private versions of the same types in different assemblies. For example, there is a private version of System.Environment in mscorlib.dll, and a public version in System.Runtime.Extensions.dll. The existing code returns the first matching type found, even if it's private, and even if there are other matching types in other assemblies. The new version of this function returns the first public type, or the first type found. Does this close any currently open issues? This closes some parts of #613 Checklist Check all those that are applicable and complete. Make sure to include one or more tests for your change If an enhancement PR, please create docs and at best an example Add yourself to AUTHORS Updated the CHANGELOG
Open Graph Description: What does this implement/fix? Explain your changes. In .Net Core 2.0, there are public and private versions of the same types in different assemblies. For example, there is a private version of Sys...
X Description: What does this implement/fix? Explain your changes. In .Net Core 2.0, there are public and private versions of the same types in different assemblies. For example, there is a private version of Sys...
Opengraph URL: https://github.com/pythonnet/pythonnet/pull/622
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:202b149e-45a6-a2a5-fa0c-2c4b4b22eeac |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | B826:2D0736:49651E:65C679:6971E195 |
| html-safe-nonce | 59bb0d193c89190e4625cf079524e3bf1fa2def5a0a33ce06e2339514b68cf44 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODI2OjJEMDczNjo0OTY1MUU6NjVDNjc5OjY5NzFFMTk1IiwidmlzaXRvcl9pZCI6Ijg1NDM1NDU4ODAzNjU2MjE2NTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c9105acdfaee74ca6fee248d960f841cfac1dd1a0ca6b92b18854f7dcdf74cea |
| hovercard-subject-tag | pull_request:167680115 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/622/checks |
| twitter:image | https://avatars.githubusercontent.com/u/777435?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/777435?s=400&v=4 |
| og:image:alt | What does this implement/fix? Explain your changes. In .Net Core 2.0, there are public and private versions of the same types in different assemblies. For example, there is a private version of Sys... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 683712716975b3393656edf09255a1d488d0e68ab7b9ac97e40ecf40036f696c |
| turbo-cache-control | no-preview |
| go-import | github.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git |
| octolytics-dimension-user_id | 6050430 |
| octolytics-dimension-user_login | pythonnet |
| octolytics-dimension-repository_id | 14748123 |
| octolytics-dimension-repository_nwo | pythonnet/pythonnet |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 14748123 |
| octolytics-dimension-repository_network_root_nwo | pythonnet/pythonnet |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ed99da4e2de688dd1056894c1eccd4c82c6bbbfe |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width