René's URL Explorer Experiment


Title: Fix conversion of 'float' and 'double' values by Konstantin-Posudevskiy · Pull Request #487 · pythonnet/pythonnet · GitHub

Open Graph Title: Fix conversion of 'float' and 'double' values by Konstantin-Posudevskiy · Pull Request #487 · pythonnet/pythonnet

X Title: Fix conversion of 'float' and 'double' values by Konstantin-Posudevskiy · Pull Request #487 · pythonnet/pythonnet

Description: Fix problem of conversion 'float' and 'double' values in converter.cs. As there was a range check both for float and double values, which are less or greater than its MinValue and MaxValue accordingly, several values like float.NegativeInfinity, float.PositiveInfinity and the same 'double' values cannot be converted from Python to .NET values. Add error check after PyFloat_AsDouble call Due to Python C API documentation, method PyFloat_AsDouble can return -1.0 upon failure. So it requires error check. This rule forces to check for error and throw exception in case of error. Add tests, which cover problem of conversion float and double values. Resolves: #486

Open Graph Description: Fix problem of conversion 'float' and 'double' values in converter.cs. As there was a range check both for float and double values, which are less or greater than its MinValue and M...

X Description: Fix problem of conversion 'float' and 'double' values in converter.cs. As there was a range check both for float and double values, which are less or greater than it...

Opengraph URL: https://github.com/pythonnet/pythonnet/pull/487

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:776c2fee-7e2c-6a82-fb5a-e0ccac3b791e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAA80:DE334:3DF65:4E2BB:697565B6
html-safe-nonceea59fcb3c7b3f168a324ebbc98fc1185f43bb51687d1d9b13e15ef6b42377bf6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTgwOkRFMzM0OjNERjY1OjRFMkJCOjY5NzU2NUI2IiwidmlzaXRvcl9pZCI6IjQyMTI0MDE2NzUzOTk2ODU1NTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacaca5cf34f0fa31536cc8942727b9ac4dafa513a1bce2518b7392afb9d9630c6b
hovercard-subject-tagpull_request:125138337
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/487/files
twitter:imagehttps://avatars.githubusercontent.com/u/7294064?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7294064?s=400&v=4
og:image:altFix problem of conversion 'float' and 'double' values in converter.cs. As there was a range check both for float and double values, which are less or greater than its MinValue and M...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4a4bf5f4e28041a9d2e5c107d7d20b78b4294ba261cab243b28167c16a623a1f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git
octolytics-dimension-user_id6050430
octolytics-dimension-user_loginpythonnet
octolytics-dimension-repository_id14748123
octolytics-dimension-repository_nwopythonnet/pythonnet
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id14748123
octolytics-dimension-repository_network_root_nwopythonnet/pythonnet
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release488b30e96dfd057fbbe44c6665ccbc030b729dde
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/pythonnet/pythonnet/pull/487/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F487%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F487%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=pythonnet%2Fpythonnet
Reloadhttps://github.com/pythonnet/pythonnet/pull/487/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/487/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/487/files
pythonnet https://github.com/pythonnet
pythonnethttps://github.com/pythonnet/pythonnet
Notifications https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Fork 769 https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Star 5.4k https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Code https://github.com/pythonnet/pythonnet
Issues 155 https://github.com/pythonnet/pythonnet/issues
Pull requests 18 https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects 0 https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security 0 https://github.com/pythonnet/pythonnet/security
Insights https://github.com/pythonnet/pythonnet/pulse
Code https://github.com/pythonnet/pythonnet
Issues https://github.com/pythonnet/pythonnet/issues
Pull requests https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security https://github.com/pythonnet/pythonnet/security
Insights https://github.com/pythonnet/pythonnet/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
den-run-aihttps://github.com/den-run-ai
pythonnet:masterhttps://github.com/pythonnet/pythonnet/tree/master
Konstantin-Posudevskiy:masterhttps://github.com/Konstantin-Posudevskiy/pythonnet/tree/master
Conversation 5 https://github.com/pythonnet/pythonnet/pull/487
Commits 4 https://github.com/pythonnet/pythonnet/pull/487/commits
Checks 0 https://github.com/pythonnet/pythonnet/pull/487/checks
Files changed https://github.com/pythonnet/pythonnet/pull/487/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/487/files
Fix conversion of 'float' and 'double' values https://github.com/pythonnet/pythonnet/pull/487/files#top
Show all changes 4 commits https://github.com/pythonnet/pythonnet/pull/487/files
0952ebe Fix conversion of 'float' and 'double' values Konstantin-Posudevskiy Jun 12, 2017 https://github.com/pythonnet/pythonnet/pull/487/commits/0952ebe91c2d5a64b2d492253c60767f01e07171
71651fb Fix failing 'test_double_conversion' test Konstantin-Posudevskiy Jun 13, 2017 https://github.com/pythonnet/pythonnet/pull/487/commits/71651fb2e8673c495024146269adb5a4e074d278
c480756 Merge branch 'master' into master filmor Jun 14, 2017 https://github.com/pythonnet/pythonnet/pull/487/commits/c480756409329aec8b6ea90aa783f21ee1f7f16c
315d2d1 Merge branch 'master' into master filmor Jun 14, 2017 https://github.com/pythonnet/pythonnet/pull/487/commits/315d2d1d9e66e1a53d16fa85dd525c5904caa206
Clear filters https://github.com/pythonnet/pythonnet/pull/487/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/487/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/487/files
AUTHORS.md https://github.com/pythonnet/pythonnet/pull/487/files#diff-784f358cf224418379ac8bdb1eed7279ca2c499e0fadc292f8ab65dcafe3f7e8
CHANGELOG.md https://github.com/pythonnet/pythonnet/pull/487/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
Python.EmbeddingTest.csproj https://github.com/pythonnet/pythonnet/pull/487/files#diff-6bfe85b2afa32799eb0008c63c2ab5372012dba8bf12ffb8c3441fafc57d5ac7
TestConverter.cs https://github.com/pythonnet/pythonnet/pull/487/files#diff-d98abf2b9a1ec152804cfe9455ffb5402a716d814abda8bb1308cef2cb2a714e
converter.cs https://github.com/pythonnet/pythonnet/pull/487/files#diff-72dfd7f278c0d6de7e41256893ce639665e58b7d65a627b5d0c0dfa4173095e8
test_conversion.py https://github.com/pythonnet/pythonnet/pull/487/files#diff-31d837ef43a928d023727fea7e80edb11bcaa6191bed823e288a50afe479e0cc
AUTHORS.mdhttps://github.com/pythonnet/pythonnet/pull/487/files#diff-784f358cf224418379ac8bdb1eed7279ca2c499e0fadc292f8ab65dcafe3f7e8
View file https://github.com/Konstantin-Posudevskiy/pythonnet/blob/315d2d1d9e66e1a53d16fa85dd525c5904caa206/AUTHORS.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/487/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/487/files#diff-784f358cf224418379ac8bdb1eed7279ca2c499e0fadc292f8ab65dcafe3f7e8
https://github.com/pythonnet/pythonnet/pull/487/files#diff-784f358cf224418379ac8bdb1eed7279ca2c499e0fadc292f8ab65dcafe3f7e8
CHANGELOG.mdhttps://github.com/pythonnet/pythonnet/pull/487/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
View file https://github.com/Konstantin-Posudevskiy/pythonnet/blob/315d2d1d9e66e1a53d16fa85dd525c5904caa206/CHANGELOG.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/487/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/487/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
https://github.com/pythonnet/pythonnet/pull/487/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
src/embed_tests/Python.EmbeddingTest.csprojhttps://github.com/pythonnet/pythonnet/pull/487/files#diff-6bfe85b2afa32799eb0008c63c2ab5372012dba8bf12ffb8c3441fafc57d5ac7
View file https://github.com/Konstantin-Posudevskiy/pythonnet/blob/315d2d1d9e66e1a53d16fa85dd525c5904caa206/src/embed_tests/Python.EmbeddingTest.csproj
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/487/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/487/files#diff-6bfe85b2afa32799eb0008c63c2ab5372012dba8bf12ffb8c3441fafc57d5ac7
https://github.com/pythonnet/pythonnet/pull/487/files#diff-6bfe85b2afa32799eb0008c63c2ab5372012dba8bf12ffb8c3441fafc57d5ac7
src/embed_tests/TestConverter.cshttps://github.com/pythonnet/pythonnet/pull/487/files#diff-d98abf2b9a1ec152804cfe9455ffb5402a716d814abda8bb1308cef2cb2a714e
View file https://github.com/Konstantin-Posudevskiy/pythonnet/blob/315d2d1d9e66e1a53d16fa85dd525c5904caa206/src/embed_tests/TestConverter.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/487/{{ revealButtonHref }}
src/runtime/converter.cshttps://github.com/pythonnet/pythonnet/pull/487/files#diff-72dfd7f278c0d6de7e41256893ce639665e58b7d65a627b5d0c0dfa4173095e8
View file https://github.com/Konstantin-Posudevskiy/pythonnet/blob/315d2d1d9e66e1a53d16fa85dd525c5904caa206/src/runtime/converter.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/487/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/487/files#diff-72dfd7f278c0d6de7e41256893ce639665e58b7d65a627b5d0c0dfa4173095e8
https://github.com/pythonnet/pythonnet/pull/487/files#diff-72dfd7f278c0d6de7e41256893ce639665e58b7d65a627b5d0c0dfa4173095e8
https://github.com/pythonnet/pythonnet/pull/487/files#diff-72dfd7f278c0d6de7e41256893ce639665e58b7d65a627b5d0c0dfa4173095e8
src/tests/test_conversion.pyhttps://github.com/pythonnet/pythonnet/pull/487/files#diff-31d837ef43a928d023727fea7e80edb11bcaa6191bed823e288a50afe479e0cc
View file https://github.com/Konstantin-Posudevskiy/pythonnet/blob/315d2d1d9e66e1a53d16fa85dd525c5904caa206/src/tests/test_conversion.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/487/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/487/files#diff-31d837ef43a928d023727fea7e80edb11bcaa6191bed823e288a50afe479e0cc
https://github.com/pythonnet/pythonnet/pull/487/files#diff-31d837ef43a928d023727fea7e80edb11bcaa6191bed823e288a50afe479e0cc
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.