Title: Fix conversion of 'float' and 'double' values by Konstantin-Posudevskiy · Pull Request #487 · pythonnet/pythonnet · GitHub
Open Graph Title: Fix conversion of 'float' and 'double' values by Konstantin-Posudevskiy · Pull Request #487 · pythonnet/pythonnet
X Title: Fix conversion of 'float' and 'double' values by Konstantin-Posudevskiy · Pull Request #487 · pythonnet/pythonnet
Description: Fix problem of conversion 'float' and 'double' values in converter.cs. As there was a range check both for float and double values, which are less or greater than its MinValue and MaxValue accordingly, several values like float.NegativeInfinity, float.PositiveInfinity and the same 'double' values cannot be converted from Python to .NET values. Add error check after PyFloat_AsDouble call Due to Python C API documentation, method PyFloat_AsDouble can return -1.0 upon failure. So it requires error check. This rule forces to check for error and throw exception in case of error. Add tests, which cover problem of conversion float and double values. Resolves: #486
Open Graph Description: Fix problem of conversion 'float' and 'double' values in converter.cs. As there was a range check both for float and double values, which are less or greater than its MinValue and M...
X Description: Fix problem of conversion 'float' and 'double' values in converter.cs. As there was a range check both for float and double values, which are less or greater than it...
Opengraph URL: https://github.com/pythonnet/pythonnet/pull/487
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:5e7626b9-0c0f-2c78-3468-6b1ea9bd29e5 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | E72C:2586AA:E3AF0C:124D0BB:697547E9 |
| html-safe-nonce | def94a02fb63700a1ac3ba5b8f9ab75b8b91766c82555892a0f99c16a526c9b7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzJDOjI1ODZBQTpFM0FGMEM6MTI0RDBCQjo2OTc1NDdFOSIsInZpc2l0b3JfaWQiOiIyODUxMzQzMjUxMDE1MDI2NjY1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ecd2764b9761ae7629d5f1166ce4560ec5e5552803cd25726279298a702c87a8 |
| hovercard-subject-tag | pull_request:125138337 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/487/checks |
| twitter:image | https://avatars.githubusercontent.com/u/7294064?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/7294064?s=400&v=4 |
| og:image:alt | Fix problem of conversion 'float' and 'double' values in converter.cs. As there was a range check both for float and double values, which are less or greater than its MinValue and M... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4a4bf5f4e28041a9d2e5c107d7d20b78b4294ba261cab243b28167c16a623a1f |
| turbo-cache-control | no-preview |
| go-import | github.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git |
| octolytics-dimension-user_id | 6050430 |
| octolytics-dimension-user_login | pythonnet |
| octolytics-dimension-repository_id | 14748123 |
| octolytics-dimension-repository_nwo | pythonnet/pythonnet |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 14748123 |
| octolytics-dimension-repository_network_root_nwo | pythonnet/pythonnet |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 488b30e96dfd057fbbe44c6665ccbc030b729dde |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width