René's URL Explorer Experiment


Title: Fix exception pickling by filmor · Pull Request #286 · pythonnet/pythonnet · GitHub

Open Graph Title: Fix exception pickling by filmor · Pull Request #286 · pythonnet/pythonnet

X Title: Fix exception pickling by filmor · Pull Request #286 · pythonnet/pythonnet

Description: Fixes #284. This PR contains 3 componenents: Remove all of the Py<2.5 workarounds that wrap exceptions in old-style class instances Fix #284 by moving the exception args into the corresponding slot in the BaseException object instead of faking the functionality by overloading __getattr__ Remove the __getattr__ overload altogether since the only functionality it provides (lookup of .message) is deprecated in Python >= 2.6

Open Graph Description: Fixes #284. This PR contains 3 componenents: Remove all of the Py<2.5 workarounds that wrap exceptions in old-style class instances Fix #284 by moving the exception args into the corresponding ...

X Description: Fixes #284. This PR contains 3 componenents: Remove all of the Py&lt;2.5 workarounds that wrap exceptions in old-style class instances Fix #284 by moving the exception args into the correspond...

Opengraph URL: https://github.com/pythonnet/pythonnet/pull/286

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3a456583-b06c-9c81-6fc5-98464a17cf23
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD6E:126498:410F1B:5BBBC3:69724583
html-safe-nonce428db73c93981c093a2b00269e31883a075b1d2bf174a3735cdfc9cf8a9fa678
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDZFOjEyNjQ5ODo0MTBGMUI6NUJCQkMzOjY5NzI0NTgzIiwidmlzaXRvcl9pZCI6IjI3NzY5MjIxMjM1ODkwMTA4MTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac71b32a2447df3008ab2ebe1fcb8679f4721e9479f5bcb3325635abb27cd3fe2f
hovercard-subject-tagpull_request:92747783
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/286/files
twitter:imagehttps://avatars.githubusercontent.com/u/30848?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/30848?s=400&v=4
og:image:altFixes #284. This PR contains 3 componenents: Remove all of the Py<2.5 workarounds that wrap exceptions in old-style class instances Fix #284 by moving the exception args into the corresponding ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None2c16db4e575031f6e3be03e0437c1ab663e0b4643ba5cbbfba48c1e4fc056a11
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git
octolytics-dimension-user_id6050430
octolytics-dimension-user_loginpythonnet
octolytics-dimension-repository_id14748123
octolytics-dimension-repository_nwopythonnet/pythonnet
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id14748123
octolytics-dimension-repository_network_root_nwopythonnet/pythonnet
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release584fea6daacd0ba6f8dbec869937910ee0ae2e64
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/pythonnet/pythonnet/pull/286/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F286%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F286%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=pythonnet%2Fpythonnet
Reloadhttps://github.com/pythonnet/pythonnet/pull/286/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/286/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/286/files
pythonnet https://github.com/pythonnet
pythonnethttps://github.com/pythonnet/pythonnet
Notifications https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Fork 770 https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Star 5.4k https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Code https://github.com/pythonnet/pythonnet
Issues 155 https://github.com/pythonnet/pythonnet/issues
Pull requests 18 https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects 0 https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/pythonnet/pythonnet/security
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/286/files
Insights https://github.com/pythonnet/pythonnet/pulse
Code https://github.com/pythonnet/pythonnet
Issues https://github.com/pythonnet/pythonnet/issues
Pull requests https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security https://github.com/pythonnet/pythonnet/security
Insights https://github.com/pythonnet/pythonnet/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
den-run-aihttps://github.com/den-run-ai
pythonnet:masterhttps://github.com/pythonnet/pythonnet/tree/master
filmor:fix-exception-picklinghttps://github.com/filmor/pythonnet/tree/fix-exception-pickling
Conversation 7 https://github.com/pythonnet/pythonnet/pull/286
Commits 7 https://github.com/pythonnet/pythonnet/pull/286/commits
Checks 0 https://github.com/pythonnet/pythonnet/pull/286/checks
Files changed https://github.com/pythonnet/pythonnet/pull/286/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/286/files
Fix exception pickling https://github.com/pythonnet/pythonnet/pull/286/files#top
Show all changes 7 commits https://github.com/pythonnet/pythonnet/pull/286/files
2b167af Remove Python <2.5 exception wrapping. filmor Nov 8, 2016 https://github.com/pythonnet/pythonnet/pull/286/commits/2b167afc38e8bcad1eed6c56d2651d1479a26b3b
82fdc39 Fix crashes when trying to pickle CLR exceptions. filmor Nov 8, 2016 https://github.com/pythonnet/pythonnet/pull/286/commits/82fdc393fcfc1c20df297578f37f513e2448c2b8
d2bfa49 Fix Python 2 compatibility. filmor Nov 8, 2016 https://github.com/pythonnet/pythonnet/pull/286/commits/d2bfa49952583deb95564a7e032b1f0c8d26a544
1a46d0e Remove access to obsolete message attribute. filmor Nov 8, 2016 https://github.com/pythonnet/pythonnet/pull/286/commits/1a46d0e9397f5e890010ea807e48769edaf14625
54868ec Fix the tests. filmor Nov 8, 2016 https://github.com/pythonnet/pythonnet/pull/286/commits/54868eccc080d7b3c566266b5b0fa9659a09b557
47c0e14 Use cPickle for Python 2. filmor Nov 8, 2016 https://github.com/pythonnet/pythonnet/pull/286/commits/47c0e1439b46f70d0f073d42b6bebe0bf95a2de3
1af62ea Fix typo. filmor Nov 8, 2016 https://github.com/pythonnet/pythonnet/pull/286/commits/1af62ea8e417696dd58d3ebf7aae2bdb9d1505a0
Clear filters https://github.com/pythonnet/pythonnet/pull/286/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/286/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/286/files
clrobject.cs https://github.com/pythonnet/pythonnet/pull/286/files#diff-5d6160b3685501be659d3d53862856535c0548337eb77c5fc4bf2e0a3d552228
converter.cs https://github.com/pythonnet/pythonnet/pull/286/files#diff-72dfd7f278c0d6de7e41256893ce639665e58b7d65a627b5d0c0dfa4173095e8
exceptions.cs https://github.com/pythonnet/pythonnet/pull/286/files#diff-d8671ce7630fc9163c6732cfe4309cc3ccb1089b33d7e9809d516f809fc36eb2
interop.cs https://github.com/pythonnet/pythonnet/pull/286/files#diff-7eb886c1d364dfa7cc2cb64d82ab08f50a157e87c830cb375fd0214ef0ebe3e9
managedtype.cs https://github.com/pythonnet/pythonnet/pull/286/files#diff-9698e437a9f400bcc79315c7f340241208e63061364af646f25681fb19a966ef
moduleobject.cs https://github.com/pythonnet/pythonnet/pull/286/files#diff-95baca92be51a7722a976817722cd8effdbd462db8f6e189928f162762d75611
runtime.cs https://github.com/pythonnet/pythonnet/pull/286/files#diff-f1749bdd9f64fdac5c64d5cb0982ce1dac5e2d9a2cdd55b93d3f83b5047a855d
typemanager.cs https://github.com/pythonnet/pythonnet/pull/286/files#diff-64b3221887c395ea436fe9433800e73c0854e42d78cd7108c320e5d41d20ab64
test_exceptions.py https://github.com/pythonnet/pythonnet/pull/286/files#diff-cee40888cbbc215698a35f2513507f9540b47199b151dbcdc107d932e8de690c
src/runtime/clrobject.cshttps://github.com/pythonnet/pythonnet/pull/286/files#diff-5d6160b3685501be659d3d53862856535c0548337eb77c5fc4bf2e0a3d552228
View file https://github.com/filmor/pythonnet/blob/1af62ea8e417696dd58d3ebf7aae2bdb9d1505a0/src/runtime/clrobject.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/286/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/286/files#diff-5d6160b3685501be659d3d53862856535c0548337eb77c5fc4bf2e0a3d552228
https://github.com/pythonnet/pythonnet/pull/286/files#diff-5d6160b3685501be659d3d53862856535c0548337eb77c5fc4bf2e0a3d552228
src/runtime/converter.cshttps://github.com/pythonnet/pythonnet/pull/286/files#diff-72dfd7f278c0d6de7e41256893ce639665e58b7d65a627b5d0c0dfa4173095e8
View file https://github.com/filmor/pythonnet/blob/1af62ea8e417696dd58d3ebf7aae2bdb9d1505a0/src/runtime/converter.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/286/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/286/files#diff-72dfd7f278c0d6de7e41256893ce639665e58b7d65a627b5d0c0dfa4173095e8
https://github.com/pythonnet/pythonnet/pull/286/files#diff-72dfd7f278c0d6de7e41256893ce639665e58b7d65a627b5d0c0dfa4173095e8
https://github.com/pythonnet/pythonnet/pull/286/files#diff-72dfd7f278c0d6de7e41256893ce639665e58b7d65a627b5d0c0dfa4173095e8
https://github.com/pythonnet/pythonnet/pull/286/files#diff-72dfd7f278c0d6de7e41256893ce639665e58b7d65a627b5d0c0dfa4173095e8
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/286/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.