| route-pattern | /:user_id/:repository/pull/:id/commits(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:04851772-e3d8-0613-6a81-9aaa7d737ecb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A690:1FD077:390B938:4D35AA3:6971F740 |
| html-safe-nonce | b71658205a9717e80ebab7f61ae5a2de0d386cf7e9e55c9597080d3ae3dcc357 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjkwOjFGRDA3NzozOTBCOTM4OjREMzVBQTM6Njk3MUY3NDAiLCJ2aXNpdG9yX2lkIjoiMzAzNTc0ODQyNzc4MjgxMzUwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b57ec203db9bee9b4ffcc6dfe00bab7aef45ae9a04d75741ce9bf88a8ccf1ef9 |
| hovercard-subject-tag | pull_request:76100159 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/commits |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/239/commits |
| twitter:image | https://opengraph.githubassets.com/8ddba0ebc96b3f737f6e181dafff2cc740d9f73de3598edefac27b6a6af567fe/pythonnet/pythonnet/pull/239 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8ddba0ebc96b3f737f6e181dafff2cc740d9f73de3598edefac27b6a6af567fe/pythonnet/pythonnet/pull/239 |
| og:image:alt | Refer to Issue #238
This PR aim to improve constructor argument matching so that if you have a .NET constructor accepting a double, it will be selected if you pass it an int.
This corresponds to ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sigbjorn |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3d9da1aa47d387dfb2aca0f2e5c19150dc936b8128a6b2ecd6a02fc26a378fff |
| turbo-cache-control | no-cache |
| go-import | github.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git |
| octolytics-dimension-user_id | 6050430 |
| octolytics-dimension-user_login | pythonnet |
| octolytics-dimension-repository_id | 14748123 |
| octolytics-dimension-repository_nwo | pythonnet/pythonnet |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 14748123 |
| octolytics-dimension-repository_network_root_nwo | pythonnet/pythonnet |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4332d3e3368b9bce3dfd3c4a2643112933072734 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/pythonnet/pythonnet/pull/239/commits#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F239%2Fcommits |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F239%2Fcommits |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=pythonnet%2Fpythonnet |
| Reload | https://github.com/pythonnet/pythonnet/pull/239/commits |
| Reload | https://github.com/pythonnet/pythonnet/pull/239/commits |
| Reload | https://github.com/pythonnet/pythonnet/pull/239/commits |
|
pythonnet
| https://github.com/pythonnet |
| pythonnet | https://github.com/pythonnet/pythonnet |
|
Notifications
| https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet |
|
Fork
770
| https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet |
|
Star
5.4k
| https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet |
|
Code
| https://github.com/pythonnet/pythonnet |
|
Issues
156
| https://github.com/pythonnet/pythonnet/issues |
|
Pull requests
18
| https://github.com/pythonnet/pythonnet/pulls |
|
Discussions
| https://github.com/pythonnet/pythonnet/discussions |
|
Actions
| https://github.com/pythonnet/pythonnet/actions |
|
Projects
0
| https://github.com/pythonnet/pythonnet/projects |
|
Wiki
| https://github.com/pythonnet/pythonnet/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/pythonnet/pythonnet/security |
| Please reload this page | https://github.com/pythonnet/pythonnet/pull/239/commits |
|
Insights
| https://github.com/pythonnet/pythonnet/pulse |
|
Code
| https://github.com/pythonnet/pythonnet |
|
Issues
| https://github.com/pythonnet/pythonnet/issues |
|
Pull requests
| https://github.com/pythonnet/pythonnet/pulls |
|
Discussions
| https://github.com/pythonnet/pythonnet/discussions |
|
Actions
| https://github.com/pythonnet/pythonnet/actions |
|
Projects
| https://github.com/pythonnet/pythonnet/projects |
|
Wiki
| https://github.com/pythonnet/pythonnet/wiki |
|
Security
| https://github.com/pythonnet/pythonnet/security |
|
Insights
| https://github.com/pythonnet/pythonnet/pulse |
| sigbjorn | https://github.com/sigbjorn |
| pythonnet:master | https://github.com/pythonnet/pythonnet/tree/master |
| Conversation | https://github.com/pythonnet/pythonnet/pull/239 |
| Commits16 (16) | https://github.com/pythonnet/pythonnet/pull/239/commits |
| Checks | https://github.com/pythonnet/pythonnet/pull/239/checks |
| Files changed | https://github.com/pythonnet/pythonnet/pull/239/files |
| Constructor argument matching supports simple int to (float|double) types | https://github.com/pythonnet/pythonnet/pull/239/commits#top |
| sigbjorn | https://github.com/sigbjorn |
| pythonnet:master | https://github.com/pythonnet/pythonnet/tree/master |
| added intial test that illustrates how int->double conversion works in calling a constructor, prior to the change in the methodbinder.cs, this test failed, since the no-match in ct. was failing sil… | https://github.com/pythonnet/pythonnet/pull/239/commits/2a2c9c71ec0c6e54d95ca0a950dccbf07d323d1b |
| https://github.com/sigbjorn |
| sigbjorn | https://github.com/pythonnet/pythonnet/commits?author=sigbjorn |
| 2a2c9c7 | https://github.com/pythonnet/pythonnet/pull/239/commits/2a2c9c71ec0c6e54d95ca0a950dccbf07d323d1b |
| https://github.com/pythonnet/pythonnet/tree/2a2c9c71ec0c6e54d95ca0a950dccbf07d323d1b |
| ease windows development, - default settings after checkout reflecting most recent python, so that build and test works without fiddling with settings in vs 2015 | https://github.com/pythonnet/pythonnet/pull/239/commits/78dca296e7afc27c491544818dcf2610eebc64d9 |
| https://github.com/sigbjorn |
| sigbjorn | https://github.com/pythonnet/pythonnet/commits?author=sigbjorn |
| 78dca29 | https://github.com/pythonnet/pythonnet/pull/239/commits/78dca296e7afc27c491544818dcf2610eebc64d9 |
| https://github.com/pythonnet/pythonnet/tree/78dca296e7afc27c491544818dcf2610eebc64d9 |
| added method tests for simple promotions int->float, int->double | https://github.com/pythonnet/pythonnet/pull/239/commits/af1b937c6b342bfad304351329265dcf8959237b |
| https://github.com/sigbjorn |
| sigbjorn | https://github.com/pythonnet/pythonnet/commits?author=sigbjorn |
| af1b937 | https://github.com/pythonnet/pythonnet/pull/239/commits/af1b937c6b342bfad304351329265dcf8959237b |
| https://github.com/pythonnet/pythonnet/tree/af1b937c6b342bfad304351329265dcf8959237b |
| extending test to cover negative outcome of bool->double|float | https://github.com/pythonnet/pythonnet/pull/239/commits/24baadffeef457fb9b8c9f2cebc42aaae3ca95ba |
| https://github.com/sigbjorn |
| sigbjorn | https://github.com/pythonnet/pythonnet/commits?author=sigbjorn |
| 24baadf | https://github.com/pythonnet/pythonnet/pull/239/commits/24baadffeef457fb9b8c9f2cebc42aaae3ca95ba |
| https://github.com/pythonnet/pythonnet/tree/24baadffeef457fb9b8c9f2cebc42aaae3ca95ba |
| adding default ct to challenge the matching mechanism | https://github.com/pythonnet/pythonnet/pull/239/commits/bde42585a297cf57a8aca30d42f63cccfdd83df3 |
| https://github.com/sigbjorn |
| sigbjorn | https://github.com/pythonnet/pythonnet/commits?author=sigbjorn |
| bde4258 | https://github.com/pythonnet/pythonnet/pull/239/commits/bde42585a297cf57a8aca30d42f63cccfdd83df3 |
| https://github.com/pythonnet/pythonnet/tree/bde42585a297cf57a8aca30d42f63cccfdd83df3 |
| merged extra tests | https://github.com/pythonnet/pythonnet/pull/239/commits/c8c8d8cc8e40dcacaa0cb469c48ff9dbf8d432d3 |
| https://github.com/sigbjorn |
| sigbjorn | https://github.com/pythonnet/pythonnet/commits?author=sigbjorn |
| c8c8d8c | https://github.com/pythonnet/pythonnet/pull/239/commits/c8c8d8cc8e40dcacaa0cb469c48ff9dbf8d432d3 |
| https://github.com/pythonnet/pythonnet/tree/c8c8d8cc8e40dcacaa0cb469c48ff9dbf8d432d3 |
| adding test, and print-out warning for the not yet implemented feature | https://github.com/pythonnet/pythonnet/pull/239/commits/a65d7930936f9b8d9511e542974e371817d71261 |
| https://github.com/sigbjorn |
| sigbjorn | https://github.com/pythonnet/pythonnet/commits?author=sigbjorn |
| a65d793 | https://github.com/pythonnet/pythonnet/pull/239/commits/a65d7930936f9b8d9511e542974e371817d71261 |
| https://github.com/pythonnet/pythonnet/tree/a65d7930936f9b8d9511e542974e371817d71261 |
| added more test for illustrating super/sub-class and argument passing problems, tests runs, but with warning printed out | https://github.com/pythonnet/pythonnet/pull/239/commits/e698b57af58115568107f6a5275e2d3302b2b465 |
| https://github.com/sigbjorn |
| sigbjorn | https://github.com/pythonnet/pythonnet/commits?author=sigbjorn |
| e698b57 | https://github.com/pythonnet/pythonnet/pull/239/commits/e698b57af58115568107f6a5275e2d3302b2b465 |
| https://github.com/pythonnet/pythonnet/tree/e698b57af58115568107f6a5275e2d3302b2b465 |
| fixed py 2.7 syntax for super, plus fixed typo | https://github.com/pythonnet/pythonnet/pull/239/commits/1fd75b3b194c55b97ea757b7392e72be22a2895a |
| https://github.com/sigbjorn |
| sigbjorn | https://github.com/pythonnet/pythonnet/commits?author=sigbjorn |
| 1fd75b3 | https://github.com/pythonnet/pythonnet/pull/239/commits/1fd75b3b194c55b97ea757b7392e72be22a2895a |
| https://github.com/pythonnet/pythonnet/tree/1fd75b3b194c55b97ea757b7392e72be22a2895a |
| reverted the .sln to unmodified state | https://github.com/pythonnet/pythonnet/pull/239/commits/fb9b21e5cf5c8ab2fe4d08e178c9d571b9f1ba7c |
| https://github.com/sigbjorn |
| sigbjorn | https://github.com/pythonnet/pythonnet/commits?author=sigbjorn |
| fb9b21e | https://github.com/pythonnet/pythonnet/pull/239/commits/fb9b21e5cf5c8ab2fe4d08e178c9d571b9f1ba7c |
| https://github.com/pythonnet/pythonnet/tree/fb9b21e5cf5c8ab2fe4d08e178c9d571b9f1ba7c |
| reverting changes to runtime and clrmodule projects | https://github.com/pythonnet/pythonnet/pull/239/commits/9e1d72b213de710f525dcad3d59d6167fc2f6884 |
| https://github.com/sigbjorn |
| sigbjorn | https://github.com/pythonnet/pythonnet/commits?author=sigbjorn |
| 9e1d72b | https://github.com/pythonnet/pythonnet/pull/239/commits/9e1d72b213de710f525dcad3d59d6167fc2f6884 |
| https://github.com/pythonnet/pythonnet/tree/9e1d72b213de710f525dcad3d59d6167fc2f6884 |
| Reverting changes to Console, embed_tests and testing .csproj files | https://github.com/pythonnet/pythonnet/pull/239/commits/0e2cd12ccdd0dd0de7abfd2cfff990164965db5f |
| https://github.com/sigbjorn |
| sigbjorn | https://github.com/pythonnet/pythonnet/commits?author=sigbjorn |
| 0e2cd12 | https://github.com/pythonnet/pythonnet/pull/239/commits/0e2cd12ccdd0dd0de7abfd2cfff990164965db5f |
| https://github.com/pythonnet/pythonnet/tree/0e2cd12ccdd0dd0de7abfd2cfff990164965db5f |
| Hopefully fixed py 2.6 issues | https://github.com/pythonnet/pythonnet/pull/239/commits/e58d5b25cf35b9cc28b00425bfd6b24c39eab0d6 |
| https://github.com/sigbjorn |
| sigbjorn | https://github.com/pythonnet/pythonnet/commits?author=sigbjorn |
| e58d5b2 | https://github.com/pythonnet/pythonnet/pull/239/commits/e58d5b25cf35b9cc28b00425bfd6b24c39eab0d6 |
| https://github.com/pythonnet/pythonnet/tree/e58d5b25cf35b9cc28b00425bfd6b24c39eab0d6 |
| Merge branch 'ct_arg_match_fix' of https://github.com/sigbjorn/pythonnet into ct_arg_match_fix | https://github.com/pythonnet/pythonnet/pull/239/commits/8602823a4e6f5d4375f5499a1f4241f00367bb69 |
| https://github.com/sigbjorn |
| sigbjorn | https://github.com/pythonnet/pythonnet/commits?author=sigbjorn |
| 8602823 | https://github.com/pythonnet/pythonnet/pull/239/commits/8602823a4e6f5d4375f5499a1f4241f00367bb69 |
| https://github.com/pythonnet/pythonnet/tree/8602823a4e6f5d4375f5499a1f4241f00367bb69 |
| SimplePromotableType simplified, returns true if src is int-type and destination type is float or double, leaving overflow checking entirely to the conversion routine | https://github.com/pythonnet/pythonnet/pull/239/commits/bdbaa626a496354d1eaf2f5f2d6739f4dbe627b9 |
| https://github.com/sigbjorn |
| sigbjorn | https://github.com/pythonnet/pythonnet/commits?author=sigbjorn |
| bdbaa62 | https://github.com/pythonnet/pythonnet/pull/239/commits/bdbaa626a496354d1eaf2f5f2d6739f4dbe627b9 |
| https://github.com/pythonnet/pythonnet/tree/bdbaa626a496354d1eaf2f5f2d6739f4dbe627b9 |
| Merge branch 'master' into ct_arg_match_fix | https://github.com/pythonnet/pythonnet/pull/239/commits/478b632c1a7a4392e4f7e6688c326b8d0b546c4d |
| https://github.com/sigbjorn |
| sigbjorn | https://github.com/pythonnet/pythonnet/commits?author=sigbjorn |
| 478b632 | https://github.com/pythonnet/pythonnet/pull/239/commits/478b632c1a7a4392e4f7e6688c326b8d0b546c4d |
| https://github.com/pythonnet/pythonnet/tree/478b632c1a7a4392e4f7e6688c326b8d0b546c4d |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |