René's URL Explorer Experiment


Title: Constructor argument matching supports simple int to (float|double) types by sigbjorn · Pull Request #239 · pythonnet/pythonnet · GitHub

Open Graph Title: Constructor argument matching supports simple int to (float|double) types by sigbjorn · Pull Request #239 · pythonnet/pythonnet

X Title: Constructor argument matching supports simple int to (float|double) types by sigbjorn · Pull Request #239 · pythonnet/pythonnet

Description: Python for .NET is a package that gives Python programmers nearly seamless integration with the .NET Common Language Runtime (CLR) and provides a powerful application scripting tool for .NET developers. - Constructor argument matching supports simple int to (float|double) types by sigbjorn · Pull Request #239 · pythonnet/pythonnet

Open Graph Description: Refer to Issue #238 This PR aim to improve constructor argument matching so that if you have a .NET constructor accepting a double, it will be selected if you pass it an int. This corresponds to ...

X Description: Refer to Issue #238 This PR aim to improve constructor argument matching so that if you have a .NET constructor accepting a double, it will be selected if you pass it an int. This corresponds to ...

Opengraph URL: https://github.com/pythonnet/pythonnet/pull/239

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:04851772-e3d8-0613-6a81-9aaa7d737ecb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA690:1FD077:390B938:4D35AA3:6971F740
html-safe-nonceb71658205a9717e80ebab7f61ae5a2de0d386cf7e9e55c9597080d3ae3dcc357
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjkwOjFGRDA3NzozOTBCOTM4OjREMzVBQTM6Njk3MUY3NDAiLCJ2aXNpdG9yX2lkIjoiMzAzNTc0ODQyNzc4MjgxMzUwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb57ec203db9bee9b4ffcc6dfe00bab7aef45ae9a04d75741ce9bf88a8ccf1ef9
hovercard-subject-tagpull_request:76100159
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/239/commits
twitter:imagehttps://opengraph.githubassets.com/8ddba0ebc96b3f737f6e181dafff2cc740d9f73de3598edefac27b6a6af567fe/pythonnet/pythonnet/pull/239
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8ddba0ebc96b3f737f6e181dafff2cc740d9f73de3598edefac27b6a6af567fe/pythonnet/pythonnet/pull/239
og:image:altRefer to Issue #238 This PR aim to improve constructor argument matching so that if you have a .NET constructor accepting a double, it will be selected if you pass it an int. This corresponds to ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesigbjorn
hostnamegithub.com
expected-hostnamegithub.com
None3d9da1aa47d387dfb2aca0f2e5c19150dc936b8128a6b2ecd6a02fc26a378fff
turbo-cache-controlno-cache
go-importgithub.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git
octolytics-dimension-user_id6050430
octolytics-dimension-user_loginpythonnet
octolytics-dimension-repository_id14748123
octolytics-dimension-repository_nwopythonnet/pythonnet
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id14748123
octolytics-dimension-repository_network_root_nwopythonnet/pythonnet
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4332d3e3368b9bce3dfd3c4a2643112933072734
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/pythonnet/pythonnet/pull/239/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F239%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F239%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=pythonnet%2Fpythonnet
Reloadhttps://github.com/pythonnet/pythonnet/pull/239/commits
Reloadhttps://github.com/pythonnet/pythonnet/pull/239/commits
Reloadhttps://github.com/pythonnet/pythonnet/pull/239/commits
pythonnet https://github.com/pythonnet
pythonnethttps://github.com/pythonnet/pythonnet
Notifications https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Fork 770 https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Star 5.4k https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Code https://github.com/pythonnet/pythonnet
Issues 156 https://github.com/pythonnet/pythonnet/issues
Pull requests 18 https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects 0 https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/pythonnet/pythonnet/security
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/239/commits
Insights https://github.com/pythonnet/pythonnet/pulse
Code https://github.com/pythonnet/pythonnet
Issues https://github.com/pythonnet/pythonnet/issues
Pull requests https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security https://github.com/pythonnet/pythonnet/security
Insights https://github.com/pythonnet/pythonnet/pulse
sigbjornhttps://github.com/sigbjorn
pythonnet:masterhttps://github.com/pythonnet/pythonnet/tree/master
Conversationhttps://github.com/pythonnet/pythonnet/pull/239
Commits16 (16)https://github.com/pythonnet/pythonnet/pull/239/commits
Checkshttps://github.com/pythonnet/pythonnet/pull/239/checks
Files changedhttps://github.com/pythonnet/pythonnet/pull/239/files
Constructor argument matching supports simple int to (float|double) typeshttps://github.com/pythonnet/pythonnet/pull/239/commits#top
sigbjornhttps://github.com/sigbjorn
pythonnet:masterhttps://github.com/pythonnet/pythonnet/tree/master
added intial test that illustrates how int->double conversion works in calling a constructor, prior to the change in the methodbinder.cs, this test failed, since the no-match in ct. was failing sil…https://github.com/pythonnet/pythonnet/pull/239/commits/2a2c9c71ec0c6e54d95ca0a950dccbf07d323d1b
https://github.com/sigbjorn
sigbjornhttps://github.com/pythonnet/pythonnet/commits?author=sigbjorn
2a2c9c7https://github.com/pythonnet/pythonnet/pull/239/commits/2a2c9c71ec0c6e54d95ca0a950dccbf07d323d1b
https://github.com/pythonnet/pythonnet/tree/2a2c9c71ec0c6e54d95ca0a950dccbf07d323d1b
ease windows development, - default settings after checkout reflecting most recent python, so that build and test works without fiddling with settings in vs 2015https://github.com/pythonnet/pythonnet/pull/239/commits/78dca296e7afc27c491544818dcf2610eebc64d9
https://github.com/sigbjorn
sigbjornhttps://github.com/pythonnet/pythonnet/commits?author=sigbjorn
78dca29https://github.com/pythonnet/pythonnet/pull/239/commits/78dca296e7afc27c491544818dcf2610eebc64d9
https://github.com/pythonnet/pythonnet/tree/78dca296e7afc27c491544818dcf2610eebc64d9
added method tests for simple promotions int->float, int->doublehttps://github.com/pythonnet/pythonnet/pull/239/commits/af1b937c6b342bfad304351329265dcf8959237b
https://github.com/sigbjorn
sigbjornhttps://github.com/pythonnet/pythonnet/commits?author=sigbjorn
af1b937https://github.com/pythonnet/pythonnet/pull/239/commits/af1b937c6b342bfad304351329265dcf8959237b
https://github.com/pythonnet/pythonnet/tree/af1b937c6b342bfad304351329265dcf8959237b
extending test to cover negative outcome of bool->double|floathttps://github.com/pythonnet/pythonnet/pull/239/commits/24baadffeef457fb9b8c9f2cebc42aaae3ca95ba
https://github.com/sigbjorn
sigbjornhttps://github.com/pythonnet/pythonnet/commits?author=sigbjorn
24baadfhttps://github.com/pythonnet/pythonnet/pull/239/commits/24baadffeef457fb9b8c9f2cebc42aaae3ca95ba
https://github.com/pythonnet/pythonnet/tree/24baadffeef457fb9b8c9f2cebc42aaae3ca95ba
adding default ct to challenge the matching mechanismhttps://github.com/pythonnet/pythonnet/pull/239/commits/bde42585a297cf57a8aca30d42f63cccfdd83df3
https://github.com/sigbjorn
sigbjornhttps://github.com/pythonnet/pythonnet/commits?author=sigbjorn
bde4258https://github.com/pythonnet/pythonnet/pull/239/commits/bde42585a297cf57a8aca30d42f63cccfdd83df3
https://github.com/pythonnet/pythonnet/tree/bde42585a297cf57a8aca30d42f63cccfdd83df3
merged extra testshttps://github.com/pythonnet/pythonnet/pull/239/commits/c8c8d8cc8e40dcacaa0cb469c48ff9dbf8d432d3
https://github.com/sigbjorn
sigbjornhttps://github.com/pythonnet/pythonnet/commits?author=sigbjorn
c8c8d8chttps://github.com/pythonnet/pythonnet/pull/239/commits/c8c8d8cc8e40dcacaa0cb469c48ff9dbf8d432d3
https://github.com/pythonnet/pythonnet/tree/c8c8d8cc8e40dcacaa0cb469c48ff9dbf8d432d3
adding test, and print-out warning for the not yet implemented featurehttps://github.com/pythonnet/pythonnet/pull/239/commits/a65d7930936f9b8d9511e542974e371817d71261
https://github.com/sigbjorn
sigbjornhttps://github.com/pythonnet/pythonnet/commits?author=sigbjorn
a65d793https://github.com/pythonnet/pythonnet/pull/239/commits/a65d7930936f9b8d9511e542974e371817d71261
https://github.com/pythonnet/pythonnet/tree/a65d7930936f9b8d9511e542974e371817d71261
added more test for illustrating super/sub-class and argument passing problems, tests runs, but with warning printed outhttps://github.com/pythonnet/pythonnet/pull/239/commits/e698b57af58115568107f6a5275e2d3302b2b465
https://github.com/sigbjorn
sigbjornhttps://github.com/pythonnet/pythonnet/commits?author=sigbjorn
e698b57https://github.com/pythonnet/pythonnet/pull/239/commits/e698b57af58115568107f6a5275e2d3302b2b465
https://github.com/pythonnet/pythonnet/tree/e698b57af58115568107f6a5275e2d3302b2b465
fixed py 2.7 syntax for super, plus fixed typohttps://github.com/pythonnet/pythonnet/pull/239/commits/1fd75b3b194c55b97ea757b7392e72be22a2895a
https://github.com/sigbjorn
sigbjornhttps://github.com/pythonnet/pythonnet/commits?author=sigbjorn
1fd75b3https://github.com/pythonnet/pythonnet/pull/239/commits/1fd75b3b194c55b97ea757b7392e72be22a2895a
https://github.com/pythonnet/pythonnet/tree/1fd75b3b194c55b97ea757b7392e72be22a2895a
reverted the .sln to unmodified statehttps://github.com/pythonnet/pythonnet/pull/239/commits/fb9b21e5cf5c8ab2fe4d08e178c9d571b9f1ba7c
https://github.com/sigbjorn
sigbjornhttps://github.com/pythonnet/pythonnet/commits?author=sigbjorn
fb9b21ehttps://github.com/pythonnet/pythonnet/pull/239/commits/fb9b21e5cf5c8ab2fe4d08e178c9d571b9f1ba7c
https://github.com/pythonnet/pythonnet/tree/fb9b21e5cf5c8ab2fe4d08e178c9d571b9f1ba7c
reverting changes to runtime and clrmodule projectshttps://github.com/pythonnet/pythonnet/pull/239/commits/9e1d72b213de710f525dcad3d59d6167fc2f6884
https://github.com/sigbjorn
sigbjornhttps://github.com/pythonnet/pythonnet/commits?author=sigbjorn
9e1d72bhttps://github.com/pythonnet/pythonnet/pull/239/commits/9e1d72b213de710f525dcad3d59d6167fc2f6884
https://github.com/pythonnet/pythonnet/tree/9e1d72b213de710f525dcad3d59d6167fc2f6884
Reverting changes to Console, embed_tests and testing .csproj fileshttps://github.com/pythonnet/pythonnet/pull/239/commits/0e2cd12ccdd0dd0de7abfd2cfff990164965db5f
https://github.com/sigbjorn
sigbjornhttps://github.com/pythonnet/pythonnet/commits?author=sigbjorn
0e2cd12https://github.com/pythonnet/pythonnet/pull/239/commits/0e2cd12ccdd0dd0de7abfd2cfff990164965db5f
https://github.com/pythonnet/pythonnet/tree/0e2cd12ccdd0dd0de7abfd2cfff990164965db5f
Hopefully fixed py 2.6 issueshttps://github.com/pythonnet/pythonnet/pull/239/commits/e58d5b25cf35b9cc28b00425bfd6b24c39eab0d6
https://github.com/sigbjorn
sigbjornhttps://github.com/pythonnet/pythonnet/commits?author=sigbjorn
e58d5b2https://github.com/pythonnet/pythonnet/pull/239/commits/e58d5b25cf35b9cc28b00425bfd6b24c39eab0d6
https://github.com/pythonnet/pythonnet/tree/e58d5b25cf35b9cc28b00425bfd6b24c39eab0d6
Merge branch 'ct_arg_match_fix' of https://github.com/sigbjorn/pythonnet into ct_arg_match_fixhttps://github.com/pythonnet/pythonnet/pull/239/commits/8602823a4e6f5d4375f5499a1f4241f00367bb69
https://github.com/sigbjorn
sigbjornhttps://github.com/pythonnet/pythonnet/commits?author=sigbjorn
8602823https://github.com/pythonnet/pythonnet/pull/239/commits/8602823a4e6f5d4375f5499a1f4241f00367bb69
https://github.com/pythonnet/pythonnet/tree/8602823a4e6f5d4375f5499a1f4241f00367bb69
SimplePromotableType simplified, returns true if src is int-type and destination type is float or double, leaving overflow checking entirely to the conversion routinehttps://github.com/pythonnet/pythonnet/pull/239/commits/bdbaa626a496354d1eaf2f5f2d6739f4dbe627b9
https://github.com/sigbjorn
sigbjornhttps://github.com/pythonnet/pythonnet/commits?author=sigbjorn
bdbaa62https://github.com/pythonnet/pythonnet/pull/239/commits/bdbaa626a496354d1eaf2f5f2d6739f4dbe627b9
https://github.com/pythonnet/pythonnet/tree/bdbaa626a496354d1eaf2f5f2d6739f4dbe627b9
Merge branch 'master' into ct_arg_match_fixhttps://github.com/pythonnet/pythonnet/pull/239/commits/478b632c1a7a4392e4f7e6688c326b8d0b546c4d
https://github.com/sigbjorn
sigbjornhttps://github.com/pythonnet/pythonnet/commits?author=sigbjorn
478b632https://github.com/pythonnet/pythonnet/pull/239/commits/478b632c1a7a4392e4f7e6688c326b8d0b546c4d
https://github.com/pythonnet/pythonnet/tree/478b632c1a7a4392e4f7e6688c326b8d0b546c4d
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.