René's URL Explorer Experiment


Title: Delete target object from event handler collections when it has no more event handlers by lostmsu · Pull Request #1973 · pythonnet/pythonnet · GitHub

Open Graph Title: Delete target object from event handler collections when it has no more event handlers by lostmsu · Pull Request #1973 · pythonnet/pythonnet

X Title: Delete target object from event handler collections when it has no more event handlers by lostmsu · Pull Request #1973 · pythonnet/pythonnet

Description: What does this implement/fix? Explain your changes. The objects were leaking because they were kept as keys in a dictionary, that stored event handlers corresponding to object. This change ensures that when the last handler is removed from an object, the object is removed from that dictionary. Does this close any currently open issues? fixes #1972 Checklist Check all those that are applicable and complete. Make sure to include one or more tests for your change Updated the CHANGELOG

Open Graph Description: What does this implement/fix? Explain your changes. The objects were leaking because they were kept as keys in a dictionary, that stored event handlers corresponding to object. This change ensures ...

X Description: What does this implement/fix? Explain your changes. The objects were leaking because they were kept as keys in a dictionary, that stored event handlers corresponding to object. This change ensures ...

Opengraph URL: https://github.com/pythonnet/pythonnet/pull/1973

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:df80f430-510b-44cc-cdce-c9e2c02776df
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE3A8:140F48:2CD897B:3C755F9:69707FDC
html-safe-nonce3ae412d412ace8e31de8876cdd18d154af410afb2b22feb410a0208324458bac
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0E4OjE0MEY0ODoyQ0Q4OTdCOjNDNzU1Rjk6Njk3MDdGREMiLCJ2aXNpdG9yX2lkIjoiMjY1MDc0MDAxNzQwNjcwNTYyOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacceed9bab18edb8b74b95df91aeee3dcec8ee719af374e3b4625d99e2907f667c
hovercard-subject-tagpull_request:1086532473
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/1973/files
twitter:imagehttps://avatars.githubusercontent.com/u/239520?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/239520?s=400&v=4
og:image:altWhat does this implement/fix? Explain your changes. The objects were leaking because they were kept as keys in a dictionary, that stored event handlers corresponding to object. This change ensures ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git
octolytics-dimension-user_id6050430
octolytics-dimension-user_loginpythonnet
octolytics-dimension-repository_id14748123
octolytics-dimension-repository_nwopythonnet/pythonnet
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id14748123
octolytics-dimension-repository_network_root_nwopythonnet/pythonnet
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7d6181066430cc06553c8396ca201e194ae33cb9
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/pythonnet/pythonnet/pull/1973/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1973%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1973%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=pythonnet%2Fpythonnet
Reloadhttps://github.com/pythonnet/pythonnet/pull/1973/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1973/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1973/files
pythonnet https://github.com/pythonnet
pythonnethttps://github.com/pythonnet/pythonnet
Notifications https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Fork 770 https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Star 5.4k https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Code https://github.com/pythonnet/pythonnet
Issues 155 https://github.com/pythonnet/pythonnet/issues
Pull requests 18 https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects 0 https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/pythonnet/pythonnet/security
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1973/files
Insights https://github.com/pythonnet/pythonnet/pulse
Code https://github.com/pythonnet/pythonnet
Issues https://github.com/pythonnet/pythonnet/issues
Pull requests https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security https://github.com/pythonnet/pythonnet/security
Insights https://github.com/pythonnet/pythonnet/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
filmorhttps://github.com/filmor
pythonnet:masterhttps://github.com/pythonnet/pythonnet/tree/master
losttech:bugs/1972https://github.com/losttech/pythonnet/tree/bugs/1972
Conversation 0 https://github.com/pythonnet/pythonnet/pull/1973
Commits 3 https://github.com/pythonnet/pythonnet/pull/1973/commits
Checks 0 https://github.com/pythonnet/pythonnet/pull/1973/checks
Files changed https://github.com/pythonnet/pythonnet/pull/1973/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1973/files
Delete target object from event handler collections when it has no more event handlers https://github.com/pythonnet/pythonnet/pull/1973/files#top
Show all changes 3 commits https://github.com/pythonnet/pythonnet/pull/1973/files
b5c222c a few debug helper properties lostmsu Oct 13, 2022 https://github.com/pythonnet/pythonnet/pull/1973/commits/b5c222ca7bda1e9d37c788286356a71db1f6e124
6838ee1 fixed name collision for generated delegate dispatchers lostmsu Oct 13, 2022 https://github.com/pythonnet/pythonnet/pull/1973/commits/6838ee1ce2866d04d4a516801b1f2f7bc1aa2d55
5a28fd4 delete target object from event handler collections when it has no mo… lostmsu Oct 13, 2022 https://github.com/pythonnet/pythonnet/pull/1973/commits/5a28fd41db0bd1a78477717dbb91f1a10703a074
Clear filters https://github.com/pythonnet/pythonnet/pull/1973/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1973/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1973/files
CHANGELOG.md https://github.com/pythonnet/pythonnet/pull/1973/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
Events.cs https://github.com/pythonnet/pythonnet/pull/1973/files#diff-719c34e54f448e9409db09a060c0894827c050756b40289ba4a25d596380c62f
Finalizer.cs https://github.com/pythonnet/pythonnet/pull/1973/files#diff-8856f8173910a2ee97a6131d24e0a40796b61281875f1a447442ca600aac4629
PyObject.cs https://github.com/pythonnet/pythonnet/pull/1973/files#diff-0e47fd064cada6ce984f46f074f9f23c9b2d9dbef5a7abf1129b75f753bf2152
CodeGenerator.cs https://github.com/pythonnet/pythonnet/pull/1973/files#diff-8ece4c4e2fa924b586abccc87629dca0b1c737f0f14b79cdcacf196f20ead4ff
EventHandlerCollection.cs https://github.com/pythonnet/pythonnet/pull/1973/files#diff-7d0da93427cd1693261821f861ca9ab7d23d78a2f613ad556c26feaed1302d22
CHANGELOG.mdhttps://github.com/pythonnet/pythonnet/pull/1973/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
View file https://github.com/losttech/pythonnet/blob/5a28fd41db0bd1a78477717dbb91f1a10703a074/CHANGELOG.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1973/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1973/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
https://github.com/pythonnet/pythonnet/pull/1973/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
src/embed_tests/Events.cshttps://github.com/pythonnet/pythonnet/pull/1973/files#diff-719c34e54f448e9409db09a060c0894827c050756b40289ba4a25d596380c62f
View file https://github.com/losttech/pythonnet/blob/5a28fd41db0bd1a78477717dbb91f1a10703a074/src/embed_tests/Events.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1973/{{ revealButtonHref }}
src/runtime/Finalizer.cshttps://github.com/pythonnet/pythonnet/pull/1973/files#diff-8856f8173910a2ee97a6131d24e0a40796b61281875f1a447442ca600aac4629
View file https://github.com/losttech/pythonnet/blob/5a28fd41db0bd1a78477717dbb91f1a10703a074/src/runtime/Finalizer.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1973/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1973/files#diff-8856f8173910a2ee97a6131d24e0a40796b61281875f1a447442ca600aac4629
https://github.com/pythonnet/pythonnet/pull/1973/files#diff-8856f8173910a2ee97a6131d24e0a40796b61281875f1a447442ca600aac4629
src/runtime/PythonTypes/PyObject.cshttps://github.com/pythonnet/pythonnet/pull/1973/files#diff-0e47fd064cada6ce984f46f074f9f23c9b2d9dbef5a7abf1129b75f753bf2152
View file https://github.com/losttech/pythonnet/blob/5a28fd41db0bd1a78477717dbb91f1a10703a074/src/runtime/PythonTypes/PyObject.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1973/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1973/files#diff-0e47fd064cada6ce984f46f074f9f23c9b2d9dbef5a7abf1129b75f753bf2152
https://github.com/pythonnet/pythonnet/pull/1973/files#diff-0e47fd064cada6ce984f46f074f9f23c9b2d9dbef5a7abf1129b75f753bf2152
src/runtime/Util/CodeGenerator.cshttps://github.com/pythonnet/pythonnet/pull/1973/files#diff-8ece4c4e2fa924b586abccc87629dca0b1c737f0f14b79cdcacf196f20ead4ff
View file https://github.com/losttech/pythonnet/blob/5a28fd41db0bd1a78477717dbb91f1a10703a074/src/runtime/Util/CodeGenerator.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1973/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1973/files#diff-8ece4c4e2fa924b586abccc87629dca0b1c737f0f14b79cdcacf196f20ead4ff
https://github.com/pythonnet/pythonnet/pull/1973/files#diff-8ece4c4e2fa924b586abccc87629dca0b1c737f0f14b79cdcacf196f20ead4ff
https://github.com/pythonnet/pythonnet/pull/1973/files#diff-8ece4c4e2fa924b586abccc87629dca0b1c737f0f14b79cdcacf196f20ead4ff
src/runtime/Util/EventHandlerCollection.cshttps://github.com/pythonnet/pythonnet/pull/1973/files#diff-7d0da93427cd1693261821f861ca9ab7d23d78a2f613ad556c26feaed1302d22
View file https://github.com/losttech/pythonnet/blob/5a28fd41db0bd1a78477717dbb91f1a10703a074/src/runtime/Util/EventHandlerCollection.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1973/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1973/files#diff-7d0da93427cd1693261821f861ca9ab7d23d78a2f613ad556c26feaed1302d22
https://github.com/pythonnet/pythonnet/pull/1973/files#diff-7d0da93427cd1693261821f861ca9ab7d23d78a2f613ad556c26feaed1302d22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.