Title: Best effort serialization by BadSingleton · Pull Request #1892 · pythonnet/pythonnet · GitHub
Open Graph Title: Best effort serialization by BadSingleton · Pull Request #1892 · pythonnet/pythonnet
X Title: Best effort serialization by BadSingleton · Pull Request #1892 · pythonnet/pythonnet
Description: What does this implement/fix? Explain your changes. This PR adds a "last line of defense, best effort serialization" to serialize types not marked as Serializable. Such objects, when derivable, are deserialized as derived classes with all (overridable) methods and properties overriden to throw a "Not Serialized" Exception. Fields are not initialized and may be null. Instances of classes that are not derivable are null. Does this close any currently open issues? No, but it is an issue we've encountered with Unity. Any other comments? This is a "best effort" to ensure no SerializationExceptions are thrown on domain unloads/reloads. This should help users deal with serialization issues as sometimes unserializable classes may be in compiled libraries and therefore unmodifiable. Checklist Check all those that are applicable and complete. Make sure to include one or more tests for your change If an enhancement PR, please create docs and at best an example Ensure you have signed the .NET Foundation CLA Add yourself to AUTHORS Updated the CHANGELOG
Open Graph Description: What does this implement/fix? Explain your changes. This PR adds a "last line of defense, best effort serialization" to serialize types not marked as Serializable. Such objects, when deri...
X Description: What does this implement/fix? Explain your changes. This PR adds a "last line of defense, best effort serialization" to serialize types not marked as Serializable. Such objects, w...
Opengraph URL: https://github.com/pythonnet/pythonnet/pull/1892
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:bc69b7e9-c983-8140-3241-7e295192b290 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CF14:51C6B:216985A:2CC97AB:69706054 |
| html-safe-nonce | ed3134bb934240c6bc111e36a71d0f374184302ce420129aa39365a79bcde96f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjE0OjUxQzZCOjIxNjk4NUE6MkNDOTdBQjo2OTcwNjA1NCIsInZpc2l0b3JfaWQiOiI1NzIxODM3Njk5MzAzNzU5OTU2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | dbdc7058a3ec0b43f31263f630e5794bb19093eed058e41dbd4954505334c55c |
| hovercard-subject-tag | pull_request:1012059637 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/1892/files |
| twitter:image | https://avatars.githubusercontent.com/u/6788684?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/6788684?s=400&v=4 |
| og:image:alt | What does this implement/fix? Explain your changes. This PR adds a "last line of defense, best effort serialization" to serialize types not marked as Serializable. Such objects, when deri... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git |
| octolytics-dimension-user_id | 6050430 |
| octolytics-dimension-user_login | pythonnet |
| octolytics-dimension-repository_id | 14748123 |
| octolytics-dimension-repository_nwo | pythonnet/pythonnet |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 14748123 |
| octolytics-dimension-repository_network_root_nwo | pythonnet/pythonnet |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7d6181066430cc06553c8396ca201e194ae33cb9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width