René's URL Explorer Experiment


Title: Fixed a leak in `NewReference.Move` by lostmsu · Pull Request #1873 · pythonnet/pythonnet · GitHub

Open Graph Title: Fixed a leak in `NewReference.Move` by lostmsu · Pull Request #1873 · pythonnet/pythonnet

X Title: Fixed a leak in `NewReference.Move` by lostmsu · Pull Request #1873 · pythonnet/pythonnet

Description: What does this implement/fix? Explain your changes. NewReference.Move used to call NewReference constructor that increfs the handle. However, Move semantics must be of transferring the ownership: the reference count should stay, ownership transferred to the new instance. Does this close any currently open issues? #1872 Checklist Check all those that are applicable and complete. Make sure to include one or more tests for your change

Open Graph Description: What does this implement/fix? Explain your changes. NewReference.Move used to call NewReference constructor that increfs the handle. However, Move semantics must be of transferring the ownership: t...

X Description: What does this implement/fix? Explain your changes. NewReference.Move used to call NewReference constructor that increfs the handle. However, Move semantics must be of transferring the ownership: t...

Opengraph URL: https://github.com/pythonnet/pythonnet/pull/1873

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ec73701a-6393-91d7-1fbf-0afff021537d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCDCC:28F9BD:31E814D:432650F:697069FB
html-safe-nonce5f340f77a77b9672de6a9faa06c6a0d877a5c3b87f99dafea2c30e803b651764
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRENDOjI4RjlCRDozMUU4MTREOjQzMjY1MEY6Njk3MDY5RkIiLCJ2aXNpdG9yX2lkIjoiNzIxODc3Mjc1Mjc0MTcyMjYxOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1c1a028fef95af36cc31befa23700b9e8f741d9c53b865ace1dce9457b17c1d2
hovercard-subject-tagpull_request:996993299
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/1873/files
twitter:imagehttps://avatars.githubusercontent.com/u/239520?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/239520?s=400&v=4
og:image:altWhat does this implement/fix? Explain your changes. NewReference.Move used to call NewReference constructor that increfs the handle. However, Move semantics must be of transferring the ownership: t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git
octolytics-dimension-user_id6050430
octolytics-dimension-user_loginpythonnet
octolytics-dimension-repository_id14748123
octolytics-dimension-repository_nwopythonnet/pythonnet
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id14748123
octolytics-dimension-repository_network_root_nwopythonnet/pythonnet
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7d6181066430cc06553c8396ca201e194ae33cb9
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/pythonnet/pythonnet/pull/1873/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1873%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1873%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=pythonnet%2Fpythonnet
Reloadhttps://github.com/pythonnet/pythonnet/pull/1873/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1873/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1873/files
pythonnet https://github.com/pythonnet
pythonnethttps://github.com/pythonnet/pythonnet
Notifications https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Fork 770 https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Star 5.4k https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Code https://github.com/pythonnet/pythonnet
Issues 155 https://github.com/pythonnet/pythonnet/issues
Pull requests 18 https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects 0 https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/pythonnet/pythonnet/security
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1873/files
Insights https://github.com/pythonnet/pythonnet/pulse
Code https://github.com/pythonnet/pythonnet
Issues https://github.com/pythonnet/pythonnet/issues
Pull requests https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security https://github.com/pythonnet/pythonnet/security
Insights https://github.com/pythonnet/pythonnet/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
filmorhttps://github.com/filmor
pythonnet:releasehttps://github.com/pythonnet/pythonnet/tree/release
losttech:bugs/ctor-leakhttps://github.com/losttech/pythonnet/tree/bugs/ctor-leak
Conversation 1 https://github.com/pythonnet/pythonnet/pull/1873
Commits 2 https://github.com/pythonnet/pythonnet/pull/1873/commits
Checks 0 https://github.com/pythonnet/pythonnet/pull/1873/checks
Files changed https://github.com/pythonnet/pythonnet/pull/1873/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1873/files
Fixed a leak in NewReference.Move https://github.com/pythonnet/pythonnet/pull/1873/files#top
Show all changes 2 commits https://github.com/pythonnet/pythonnet/pull/1873/files
59b1c51 Finalizer.Instance.Collect() and Runtime.TryCollectingGarbage(...) ar… lostmsu Jul 14, 2022 https://github.com/pythonnet/pythonnet/pull/1873/commits/59b1c51daad161fc5f85452102188b75cc7284e3
469ec67 fixed leak in NewReference.Move lostmsu Jul 14, 2022 https://github.com/pythonnet/pythonnet/pull/1873/commits/469ec671fc9d7ee2f149a6687b5c7aeb5f861563
Clear filters https://github.com/pythonnet/pythonnet/pull/1873/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1873/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1873/files
Finalizer.cs https://github.com/pythonnet/pythonnet/pull/1873/files#diff-8856f8173910a2ee97a6131d24e0a40796b61281875f1a447442ca600aac4629
NewReference.cs https://github.com/pythonnet/pythonnet/pull/1873/files#diff-427199397b39137cfa1622bda5d7de63360423a7ee8ea77ee6bb647a54972917
Runtime.cs https://github.com/pythonnet/pythonnet/pull/1873/files#diff-010beffcb32e19ccddb5f2d7b87077b1606b7b4acc4c22d6803091b7a53ba8c2
test_constructors.py https://github.com/pythonnet/pythonnet/pull/1873/files#diff-4579d485b360f15202cfc8b962c910b8d662fa967d0194f0c11bf611fc14ba43
src/runtime/Finalizer.cshttps://github.com/pythonnet/pythonnet/pull/1873/files#diff-8856f8173910a2ee97a6131d24e0a40796b61281875f1a447442ca600aac4629
View file https://github.com/losttech/pythonnet/blob/469ec671fc9d7ee2f149a6687b5c7aeb5f861563/src/runtime/Finalizer.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1873/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1873/files#diff-8856f8173910a2ee97a6131d24e0a40796b61281875f1a447442ca600aac4629
https://github.com/pythonnet/pythonnet/pull/1873/files#diff-8856f8173910a2ee97a6131d24e0a40796b61281875f1a447442ca600aac4629
src/runtime/Native/NewReference.cshttps://github.com/pythonnet/pythonnet/pull/1873/files#diff-427199397b39137cfa1622bda5d7de63360423a7ee8ea77ee6bb647a54972917
View file https://github.com/losttech/pythonnet/blob/469ec671fc9d7ee2f149a6687b5c7aeb5f861563/src/runtime/Native/NewReference.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1873/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1873/files#diff-427199397b39137cfa1622bda5d7de63360423a7ee8ea77ee6bb647a54972917
https://github.com/pythonnet/pythonnet/pull/1873/files#diff-427199397b39137cfa1622bda5d7de63360423a7ee8ea77ee6bb647a54972917
src/runtime/Runtime.cshttps://github.com/pythonnet/pythonnet/pull/1873/files#diff-010beffcb32e19ccddb5f2d7b87077b1606b7b4acc4c22d6803091b7a53ba8c2
View file https://github.com/losttech/pythonnet/blob/469ec671fc9d7ee2f149a6687b5c7aeb5f861563/src/runtime/Runtime.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1873/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1873/files#diff-010beffcb32e19ccddb5f2d7b87077b1606b7b4acc4c22d6803091b7a53ba8c2
https://github.com/pythonnet/pythonnet/pull/1873/files#diff-010beffcb32e19ccddb5f2d7b87077b1606b7b4acc4c22d6803091b7a53ba8c2
tests/test_constructors.pyhttps://github.com/pythonnet/pythonnet/pull/1873/files#diff-4579d485b360f15202cfc8b962c910b8d662fa967d0194f0c11bf611fc14ba43
View file https://github.com/losttech/pythonnet/blob/469ec671fc9d7ee2f149a6687b5c7aeb5f861563/tests/test_constructors.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1873/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1873/files#diff-4579d485b360f15202cfc8b962c910b8d662fa967d0194f0c11bf611fc14ba43
https://github.com/pythonnet/pythonnet/pull/1873/files#diff-4579d485b360f15202cfc8b962c910b8d662fa967d0194f0c11bf611fc14ba43
https://github.com/pythonnet/pythonnet/pull/1873/files#diff-4579d485b360f15202cfc8b962c910b8d662fa967d0194f0c11bf611fc14ba43
https://github.com/pythonnet/pythonnet/pull/1873/files#diff-4579d485b360f15202cfc8b962c910b8d662fa967d0194f0c11bf611fc14ba43
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.