René's URL Explorer Experiment


Title: Grab the GIL on shutdown when checking for exceptions by BadSingleton · Pull Request #1832 · pythonnet/pythonnet · GitHub

Open Graph Title: Grab the GIL on shutdown when checking for exceptions by BadSingleton · Pull Request #1832 · pythonnet/pythonnet

X Title: Grab the GIL on shutdown when checking for exceptions by BadSingleton · Pull Request #1832 · pythonnet/pythonnet

Description: What does this implement/fix? Explain your changes. The GIL isn't taken when being called from the DomainUnload handler. Take it to avoid a crash when calling Exceptions.ErrorOccurred() Does this close any currently open issues? #1831 Checklist Check all those that are applicable and complete. Make sure to include one or more tests for your change Ensure you have signed the .NET Foundation CLA Add yourself to AUTHORS

Open Graph Description: What does this implement/fix? Explain your changes. The GIL isn't taken when being called from the DomainUnload handler. Take it to avoid a crash when calling Exceptions.ErrorOccurred() Does th...

X Description: What does this implement/fix? Explain your changes. The GIL isn't taken when being called from the DomainUnload handler. Take it to avoid a crash when calling Exceptions.ErrorOccurred() Doe...

Opengraph URL: https://github.com/pythonnet/pythonnet/pull/1832

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:de1ffc87-aff3-1b4e-8a47-988d1a773ebc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8BBC:4488E:32ED973:4760C45:69711B8D
html-safe-nonced806f1e211bd8e3e220f85831c8dcf9f650aaa9c482a0c3eb54bb82ab207cd0a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QkJDOjQ0ODhFOjMyRUQ5NzM6NDc2MEM0NTo2OTcxMUI4RCIsInZpc2l0b3JfaWQiOiIxMzYyNjM5MjA2MDQ2ODMzNTQ5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac612fa6dd6569cd982d6f1a300813788cecb1ab4c20e28bcde381c0bba9c82171
hovercard-subject-tagpull_request:977559177
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/1832/files
twitter:imagehttps://avatars.githubusercontent.com/u/6788684?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/6788684?s=400&v=4
og:image:altWhat does this implement/fix? Explain your changes. The GIL isn't taken when being called from the DomainUnload handler. Take it to avoid a crash when calling Exceptions.ErrorOccurred() Does th...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None73ca43ac10b0f114fadc2d2cf702bc0c6453174aa5f9dad3a1d131b428870c6d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git
octolytics-dimension-user_id6050430
octolytics-dimension-user_loginpythonnet
octolytics-dimension-repository_id14748123
octolytics-dimension-repository_nwopythonnet/pythonnet
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id14748123
octolytics-dimension-repository_network_root_nwopythonnet/pythonnet
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c16e50bde10edd19f5772e9b3804df6d7bf9bfe
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/pythonnet/pythonnet/pull/1832/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1832%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1832%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=pythonnet%2Fpythonnet
Reloadhttps://github.com/pythonnet/pythonnet/pull/1832/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1832/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1832/files
pythonnet https://github.com/pythonnet
pythonnethttps://github.com/pythonnet/pythonnet
Notifications https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Fork 770 https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Star 5.4k https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Code https://github.com/pythonnet/pythonnet
Issues 155 https://github.com/pythonnet/pythonnet/issues
Pull requests 18 https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects 0 https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/pythonnet/pythonnet/security
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1832/files
Insights https://github.com/pythonnet/pythonnet/pulse
Code https://github.com/pythonnet/pythonnet
Issues https://github.com/pythonnet/pythonnet/issues
Pull requests https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security https://github.com/pythonnet/pythonnet/security
Insights https://github.com/pythonnet/pythonnet/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
BadSingletonhttps://github.com/BadSingleton
pythonnet:masterhttps://github.com/pythonnet/pythonnet/tree/master
Unity-Technologies:grab-gil-shutdownhttps://github.com/Unity-Technologies/pythonnet/tree/grab-gil-shutdown
Conversation 3 https://github.com/pythonnet/pythonnet/pull/1832
Commits 1 https://github.com/pythonnet/pythonnet/pull/1832/commits
Checks 0 https://github.com/pythonnet/pythonnet/pull/1832/checks
Files changed https://github.com/pythonnet/pythonnet/pull/1832/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1832/files
Grab the GIL on shutdown when checking for exceptions https://github.com/pythonnet/pythonnet/pull/1832/files#top
Show all changes 1 commit https://github.com/pythonnet/pythonnet/pull/1832/files
0534d7f Grab the GIL on shutdown when checking for exceptions BadSingleton Jun 23, 2022 https://github.com/pythonnet/pythonnet/pull/1832/commits/0534d7f3c9864336e018ae366c6f3295c8402e9b
Clear filters https://github.com/pythonnet/pythonnet/pull/1832/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1832/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1832/files
src/runtime/PythonEngine.cshttps://github.com/pythonnet/pythonnet/pull/1832/files#diff-4da8ae86d58aa20cd6e439886d4c8ded46d02f69f2e557655094fac05a9bddb1
View file https://github.com/Unity-Technologies/pythonnet/blob/0534d7f3c9864336e018ae366c6f3295c8402e9b/src/runtime/PythonEngine.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1832/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1832/files#diff-4da8ae86d58aa20cd6e439886d4c8ded46d02f69f2e557655094fac05a9bddb1
lostmsuhttps://github.com/lostmsu
Jun 23, 2022https://github.com/pythonnet/pythonnet/pull/1832/files#r905498874
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1832/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1832/files
lostmsuhttps://github.com/lostmsu
Jun 24, 2022https://github.com/pythonnet/pythonnet/pull/1832/files#r906289097
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1832/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1832/files
filmorhttps://github.com/filmor
Jun 27, 2022https://github.com/pythonnet/pythonnet/pull/1832/files#r907168535
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1832/files
https://github.com/pythonnet/pythonnet/pull/1832/files#diff-4da8ae86d58aa20cd6e439886d4c8ded46d02f69f2e557655094fac05a9bddb1
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.