René's URL Explorer Experiment


Title: Grab the GIL on shutdown when checking for exceptions by BadSingleton · Pull Request #1832 · pythonnet/pythonnet · GitHub

Open Graph Title: Grab the GIL on shutdown when checking for exceptions by BadSingleton · Pull Request #1832 · pythonnet/pythonnet

X Title: Grab the GIL on shutdown when checking for exceptions by BadSingleton · Pull Request #1832 · pythonnet/pythonnet

Description: What does this implement/fix? Explain your changes. The GIL isn't taken when being called from the DomainUnload handler. Take it to avoid a crash when calling Exceptions.ErrorOccurred() Does this c...

Open Graph Description: What does this implement/fix? Explain your changes. The GIL isn't taken when being called from the DomainUnload handler. Take it to avoid a crash when calling Exceptions.ErrorOccurred() Does th...

X Description: What does this implement/fix? Explain your changes. The GIL isn't taken when being called from the DomainUnload handler. Take it to avoid a crash when calling Exceptions.ErrorOccurred() Doe...

Opengraph URL: https://github.com/pythonnet/pythonnet/pull/1832

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6d8c5100-20df-110d-e435-eb6f4062937c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC74:2A625F:28DDF50:398C737:69710164
html-safe-nonced146779e322750a2f6e1db4400e338b876c2382ee856414b59fdb4483d9451d0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzc0OjJBNjI1RjoyOERERjUwOjM5OEM3Mzc6Njk3MTAxNjQiLCJ2aXNpdG9yX2lkIjoiNzM0MTk4NDEzMzEyNDUyMjM0MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5f72924f2827ea07bc24906f9f1ec835e948d0ce4da058a0aac908d302cb6ec9
hovercard-subject-tagpull_request:977559177
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/pythonnet/pythonnet/1832/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d3171a82833724a2b94d9c2593fe446a1f5cca8ccfc3f52ddd31052f2f78fee9/pythonnet/pythonnet/pull/1832
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d3171a82833724a2b94d9c2593fe446a1f5cca8ccfc3f52ddd31052f2f78fee9/pythonnet/pythonnet/pull/1832
og:image:altWhat does this implement/fix? Explain your changes. The GIL isn't taken when being called from the DomainUnload handler. Take it to avoid a crash when calling Exceptions.ErrorOccurred() Does th...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBadSingleton
hostnamegithub.com
expected-hostnamegithub.com
None2d17fd2bbd784dc91f3a78a2f1d2c41d9f4f8ce86136d09833e3cf21b2bde1b7
turbo-cache-controlno-preview
go-importgithub.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git
octolytics-dimension-user_id6050430
octolytics-dimension-user_loginpythonnet
octolytics-dimension-repository_id14748123
octolytics-dimension-repository_nwopythonnet/pythonnet
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id14748123
octolytics-dimension-repository_network_root_nwopythonnet/pythonnet
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee053d923fb27a9d948f8cefae8ba3bf43f7b938f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/pythonnet/pythonnet/pull/1832#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1832
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1832
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=pythonnet%2Fpythonnet
Reloadhttps://github.com/pythonnet/pythonnet/pull/1832
Reloadhttps://github.com/pythonnet/pythonnet/pull/1832
Reloadhttps://github.com/pythonnet/pythonnet/pull/1832
pythonnet https://github.com/pythonnet
pythonnethttps://github.com/pythonnet/pythonnet
Notifications https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Fork 770 https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Star 5.4k https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Code https://github.com/pythonnet/pythonnet
Issues 155 https://github.com/pythonnet/pythonnet/issues
Pull requests 18 https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects 0 https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/pythonnet/pythonnet/security
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1832
Insights https://github.com/pythonnet/pythonnet/pulse
Code https://github.com/pythonnet/pythonnet
Issues https://github.com/pythonnet/pythonnet/issues
Pull requests https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security https://github.com/pythonnet/pythonnet/security
Insights https://github.com/pythonnet/pythonnet/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/pythonnet/pythonnet/pull/1832#issue-comment-box
BadSingletonhttps://github.com/BadSingleton
pythonnet:masterhttps://github.com/pythonnet/pythonnet/tree/master
Unity-Technologies:grab-gil-shutdownhttps://github.com/Unity-Technologies/pythonnet/tree/grab-gil-shutdown
Grab the GIL on shutdown when checking for exceptions https://github.com/pythonnet/pythonnet/pull/1832#top
BadSingletonhttps://github.com/BadSingleton
pythonnet:masterhttps://github.com/pythonnet/pythonnet/tree/master
Unity-Technologies:grab-gil-shutdownhttps://github.com/Unity-Technologies/pythonnet/tree/grab-gil-shutdown
Conversation 3 https://github.com/pythonnet/pythonnet/pull/1832
Commits 1 https://github.com/pythonnet/pythonnet/pull/1832/commits
Checks 0 https://github.com/pythonnet/pythonnet/pull/1832/checks
Files changed https://github.com/pythonnet/pythonnet/pull/1832/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1832
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/{{ revealButtonHref }}
https://github.com/BadSingleton
BadSingletonhttps://github.com/BadSingleton
Jun 23, 2022https://github.com/pythonnet/pythonnet/pull/1832#issue-1282853900
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1832
#1831https://github.com/pythonnet/pythonnet/issues/1831
.NET Foundation CLAhttps://cla.dotnetfoundation.org/pythonnet/pythonnet
AUTHORShttps://github.com/pythonnet/pythonnet/blob/master/AUTHORS.md
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1832
https://github.com/BadSingleton
Grab the GIL on shutdown when checking for exceptionshttps://github.com/pythonnet/pythonnet/pull/1832/commits/0534d7f3c9864336e018ae366c6f3295c8402e9b
0534d7fhttps://github.com/pythonnet/pythonnet/pull/1832/commits/0534d7f3c9864336e018ae366c6f3295c8402e9b
https://github.com/filmor
filmorhttps://github.com/filmor
lostmsuhttps://github.com/lostmsu
June 23, 2022 19:41https://github.com/pythonnet/pythonnet/pull/1832#event-6869087567
https://github.com/lostmsu
lostmsuhttps://github.com/lostmsu
Jun 23, 2022 https://github.com/pythonnet/pythonnet/pull/1832#pullrequestreview-1017696400
View reviewed changes https://github.com/pythonnet/pythonnet/pull/1832/files/0534d7f3c9864336e018ae366c6f3295c8402e9b
src/runtime/PythonEngine.cshttps://github.com/pythonnet/pythonnet/pull/1832/files/0534d7f3c9864336e018ae366c6f3295c8402e9b#diff-4da8ae86d58aa20cd6e439886d4c8ded46d02f69f2e557655094fac05a9bddb1
lostmsuhttps://github.com/lostmsu
Jun 23, 2022https://github.com/pythonnet/pythonnet/pull/1832#discussion_r905498874
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1832
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1832
lostmsuhttps://github.com/lostmsu
Jun 24, 2022https://github.com/pythonnet/pythonnet/pull/1832#discussion_r906289097
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1832
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1832
filmorhttps://github.com/filmor
Jun 27, 2022https://github.com/pythonnet/pythonnet/pull/1832#discussion_r907168535
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1832
https://github.com/filmor
filmorhttps://github.com/filmor
Jun 27, 2022 https://github.com/pythonnet/pythonnet/pull/1832#ref-pullrequest-1285518016
Take GIL when checking if error occurred on shutdown #1836 https://github.com/pythonnet/pythonnet/pull/1836
https://github.com/filmor
filmorhttps://github.com/filmor
Jun 27, 2022https://github.com/pythonnet/pythonnet/pull/1832#event-6883717977
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1832
https://github.com/filmor
filmor https://github.com/filmor
https://github.com/pythonnet/pythonnet/pull/1832/files/0534d7f3c9864336e018ae366c6f3295c8402e9b
https://github.com/lostmsu
lostmsu https://github.com/lostmsu
https://github.com/pythonnet/pythonnet/pull/1832/files/0534d7f3c9864336e018ae366c6f3295c8402e9b
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1832
https://github.com/BadSingleton
https://github.com/filmor
https://github.com/lostmsu
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.