René's URL Explorer Experiment


Title: Multiple fixes related to Dictionary.Keys bug by lostmsu · Pull Request #1786 · pythonnet/pythonnet · GitHub

Open Graph Title: Multiple fixes related to Dictionary.Keys bug by lostmsu · Pull Request #1786 · pythonnet/pythonnet

X Title: Multiple fixes related to Dictionary.Keys bug by lostmsu · Pull Request #1786 · pythonnet/pythonnet

Description: What does this implement/fix? Explain your changes. This has individual commits for: bad name generation for nested classes which caused the type of Dictionary.Keys to be confused with the Dictionary itself quality of life change, that allows cast Generic.IEnumerable(obj), which previously required the generic type argument to be specified. E.g. Generic.IEnumerable[String](obj) was required collection mixins now cast objects to corresponding interfaces when the interfaces are implemented privately Does this close any currently open issues? fixes #1785 Checklist Check all those that are applicable and complete. Make sure to include one or more tests for your change If an enhancement PR, please create docs and at best an example Updated the CHANGELOG @Martin-Molinero

Open Graph Description: What does this implement/fix? Explain your changes. This has individual commits for: bad name generation for nested classes which caused the type of Dictionary.Keys to be confused with the Diction...

X Description: What does this implement/fix? Explain your changes. This has individual commits for: bad name generation for nested classes which caused the type of Dictionary.Keys to be confused with the Diction...

Opengraph URL: https://github.com/pythonnet/pythonnet/pull/1786

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:bf67c0b6-f0bb-82eb-5480-53e523c80976
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC1E:2EBC14:3DF25B2:53E357B:69708580
html-safe-nonce954a1cde42c54a7062b1c90315733fc464eecb11b472aacc98fab9a81c882b9d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzFFOjJFQkMxNDozREYyNUIyOjUzRTM1N0I6Njk3MDg1ODAiLCJ2aXNpdG9yX2lkIjoiMzI5NDU4OTUxNTI1Mzk3NDQwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7df52690d417446ceea29a18b0936756314cb9791283f37885ded381e189567a
hovercard-subject-tagpull_request:930320785
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/1786/files
twitter:imagehttps://avatars.githubusercontent.com/u/239520?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/239520?s=400&v=4
og:image:altWhat does this implement/fix? Explain your changes. This has individual commits for: bad name generation for nested classes which caused the type of Dictionary.Keys to be confused with the Diction...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git
octolytics-dimension-user_id6050430
octolytics-dimension-user_loginpythonnet
octolytics-dimension-repository_id14748123
octolytics-dimension-repository_nwopythonnet/pythonnet
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id14748123
octolytics-dimension-repository_network_root_nwopythonnet/pythonnet
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7d6181066430cc06553c8396ca201e194ae33cb9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/pythonnet/pythonnet/pull/1786/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1786%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1786%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=pythonnet%2Fpythonnet
Reloadhttps://github.com/pythonnet/pythonnet/pull/1786/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1786/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1786/files
pythonnet https://github.com/pythonnet
pythonnethttps://github.com/pythonnet/pythonnet
Notifications https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Fork 770 https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Star 5.4k https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Code https://github.com/pythonnet/pythonnet
Issues 155 https://github.com/pythonnet/pythonnet/issues
Pull requests 18 https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects 0 https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/pythonnet/pythonnet/security
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1786/files
Insights https://github.com/pythonnet/pythonnet/pulse
Code https://github.com/pythonnet/pythonnet
Issues https://github.com/pythonnet/pythonnet/issues
Pull requests https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security https://github.com/pythonnet/pythonnet/security
Insights https://github.com/pythonnet/pythonnet/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
lostmsuhttps://github.com/lostmsu
pythonnet:masterhttps://github.com/pythonnet/pythonnet/tree/master
losttech:bugs/KeyCollectionhttps://github.com/losttech/pythonnet/tree/bugs/KeyCollection
Conversation 2 https://github.com/pythonnet/pythonnet/pull/1786
Commits 5 https://github.com/pythonnet/pythonnet/pull/1786/commits
Checks 0 https://github.com/pythonnet/pythonnet/pull/1786/checks
Files changed https://github.com/pythonnet/pythonnet/pull/1786/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1786/files
Multiple fixes related to Dictionary.Keys bug https://github.com/pythonnet/pythonnet/pull/1786/files#top
Show all changes 5 commits https://github.com/pythonnet/pythonnet/pull/1786/files
2910800 type name generator ignored names of nested classes lostmsu May 7, 2022 https://github.com/pythonnet/pythonnet/pull/1786/commits/2910800eb6f04fbe1fc70645b8c1820e6e192369
cf8823f added regression test for "in Dictionary.Keys" check lostmsu May 7, 2022 https://github.com/pythonnet/pythonnet/pull/1786/commits/cf8823fa941842cfd19ad808f04bc6aa6d0b7970
f48d7a9 ClassGeneric.GetClass now returns BorrowedReference to indicate that … lostmsu May 7, 2022 https://github.com/pythonnet/pythonnet/pull/1786/commits/f48d7a96f76cf1e44411c3d19ad036e96b9adaf0
537ddf4 allow casting objects to generic .NET interfaces without specifying g… lostmsu May 7, 2022 https://github.com/pythonnet/pythonnet/pull/1786/commits/537ddf4b7fc938bca461b1ffb532a136af7b7d67
d854332 a few collection mixins now properly handle private interface impleme… lostmsu May 7, 2022 https://github.com/pythonnet/pythonnet/pull/1786/commits/d8543321a32535b90789770219f0d7c1ff0265de
Clear filters https://github.com/pythonnet/pythonnet/pull/1786/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1786/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1786/files
CHANGELOG.md https://github.com/pythonnet/pythonnet/pull/1786/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
ClassManager.cs https://github.com/pythonnet/pythonnet/pull/1786/files#diff-52d09e532b78e00df47c2cac8247ee1fa57c17190a628ae4cce0d4c156df0f34
collections.py https://github.com/pythonnet/pythonnet/pull/1786/files#diff-2448063112e8ef5ab0bdc8f7b35953f830fd9c68aa49405f040137448563af0f
TypeManager.cs https://github.com/pythonnet/pythonnet/pull/1786/files#diff-a3d8f0a249eb8c6667815dca5cff30765b8a781031d91b0768fdf07af65d52d7
ClassObject.cs https://github.com/pythonnet/pythonnet/pull/1786/files#diff-6086caf4711f56eeb980ebd1411f1b89fbe5f56fffe67c19503d9303f116e7ef
ClrObject.cs https://github.com/pythonnet/pythonnet/pull/1786/files#diff-ca6091a740e6b55ddfe1a561219282c7f2ab60e4049a12f6f35917a4b6e9870b
GenericType.cs https://github.com/pythonnet/pythonnet/pull/1786/files#diff-ba8e5de3ff184f814c9e5539a5a499c9ae842cd81bd2fc429a974c764a951487
MethodObject.cs https://github.com/pythonnet/pythonnet/pull/1786/files#diff-7eebb026becf7ad3c3b8608fb5107b7bc643ff9eaa4630beef605492fe120caf
ReflectedClrType.cs https://github.com/pythonnet/pythonnet/pull/1786/files#diff-d0c776c5a2a85b17ab26c64f8012ebf5b6b3cda0b6146edf33d0e396284b92f3
test_collection_mixins.py https://github.com/pythonnet/pythonnet/pull/1786/files#diff-b99d9205f1b4b3ceba874f62ca0907665af92bde43fdb2ebbcd07a0ed3fa2757
CHANGELOG.mdhttps://github.com/pythonnet/pythonnet/pull/1786/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
View file https://github.com/losttech/pythonnet/blob/d8543321a32535b90789770219f0d7c1ff0265de/CHANGELOG.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1786/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1786/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
https://github.com/pythonnet/pythonnet/pull/1786/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
src/runtime/ClassManager.cshttps://github.com/pythonnet/pythonnet/pull/1786/files#diff-52d09e532b78e00df47c2cac8247ee1fa57c17190a628ae4cce0d4c156df0f34
View file https://github.com/losttech/pythonnet/blob/d8543321a32535b90789770219f0d7c1ff0265de/src/runtime/ClassManager.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1786/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1786/files#diff-52d09e532b78e00df47c2cac8247ee1fa57c17190a628ae4cce0d4c156df0f34
https://github.com/pythonnet/pythonnet/pull/1786/files#diff-52d09e532b78e00df47c2cac8247ee1fa57c17190a628ae4cce0d4c156df0f34
src/runtime/Mixins/collections.pyhttps://github.com/pythonnet/pythonnet/pull/1786/files#diff-2448063112e8ef5ab0bdc8f7b35953f830fd9c68aa49405f040137448563af0f
View file https://github.com/losttech/pythonnet/blob/d8543321a32535b90789770219f0d7c1ff0265de/src/runtime/Mixins/collections.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1786/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1786/files#diff-2448063112e8ef5ab0bdc8f7b35953f830fd9c68aa49405f040137448563af0f
https://github.com/pythonnet/pythonnet/pull/1786/files#diff-2448063112e8ef5ab0bdc8f7b35953f830fd9c68aa49405f040137448563af0f
https://github.com/pythonnet/pythonnet/pull/1786/files#diff-2448063112e8ef5ab0bdc8f7b35953f830fd9c68aa49405f040137448563af0f
src/runtime/TypeManager.cshttps://github.com/pythonnet/pythonnet/pull/1786/files#diff-a3d8f0a249eb8c6667815dca5cff30765b8a781031d91b0768fdf07af65d52d7
View file https://github.com/losttech/pythonnet/blob/d8543321a32535b90789770219f0d7c1ff0265de/src/runtime/TypeManager.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1786/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1786/files#diff-a3d8f0a249eb8c6667815dca5cff30765b8a781031d91b0768fdf07af65d52d7
https://github.com/pythonnet/pythonnet/pull/1786/files#diff-a3d8f0a249eb8c6667815dca5cff30765b8a781031d91b0768fdf07af65d52d7
src/runtime/Types/ClassObject.cshttps://github.com/pythonnet/pythonnet/pull/1786/files#diff-6086caf4711f56eeb980ebd1411f1b89fbe5f56fffe67c19503d9303f116e7ef
View file https://github.com/losttech/pythonnet/blob/d8543321a32535b90789770219f0d7c1ff0265de/src/runtime/Types/ClassObject.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1786/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1786/files#diff-6086caf4711f56eeb980ebd1411f1b89fbe5f56fffe67c19503d9303f116e7ef
https://github.com/pythonnet/pythonnet/pull/1786/files#diff-6086caf4711f56eeb980ebd1411f1b89fbe5f56fffe67c19503d9303f116e7ef
src/runtime/Types/ClrObject.cshttps://github.com/pythonnet/pythonnet/pull/1786/files#diff-ca6091a740e6b55ddfe1a561219282c7f2ab60e4049a12f6f35917a4b6e9870b
View file https://github.com/losttech/pythonnet/blob/d8543321a32535b90789770219f0d7c1ff0265de/src/runtime/Types/ClrObject.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1786/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1786/files#diff-ca6091a740e6b55ddfe1a561219282c7f2ab60e4049a12f6f35917a4b6e9870b
https://github.com/pythonnet/pythonnet/pull/1786/files#diff-ca6091a740e6b55ddfe1a561219282c7f2ab60e4049a12f6f35917a4b6e9870b
src/runtime/Types/GenericType.cshttps://github.com/pythonnet/pythonnet/pull/1786/files#diff-ba8e5de3ff184f814c9e5539a5a499c9ae842cd81bd2fc429a974c764a951487
View file https://github.com/losttech/pythonnet/blob/d8543321a32535b90789770219f0d7c1ff0265de/src/runtime/Types/GenericType.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1786/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1786/files#diff-ba8e5de3ff184f814c9e5539a5a499c9ae842cd81bd2fc429a974c764a951487
https://github.com/pythonnet/pythonnet/pull/1786/files#diff-ba8e5de3ff184f814c9e5539a5a499c9ae842cd81bd2fc429a974c764a951487
src/runtime/Types/MethodObject.cshttps://github.com/pythonnet/pythonnet/pull/1786/files#diff-7eebb026becf7ad3c3b8608fb5107b7bc643ff9eaa4630beef605492fe120caf
View file https://github.com/losttech/pythonnet/blob/d8543321a32535b90789770219f0d7c1ff0265de/src/runtime/Types/MethodObject.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1786/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1786/files#diff-7eebb026becf7ad3c3b8608fb5107b7bc643ff9eaa4630beef605492fe120caf
https://github.com/pythonnet/pythonnet/pull/1786/files#diff-7eebb026becf7ad3c3b8608fb5107b7bc643ff9eaa4630beef605492fe120caf
src/runtime/Types/ReflectedClrType.cshttps://github.com/pythonnet/pythonnet/pull/1786/files#diff-d0c776c5a2a85b17ab26c64f8012ebf5b6b3cda0b6146edf33d0e396284b92f3
View file https://github.com/losttech/pythonnet/blob/d8543321a32535b90789770219f0d7c1ff0265de/src/runtime/Types/ReflectedClrType.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1786/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1786/files#diff-d0c776c5a2a85b17ab26c64f8012ebf5b6b3cda0b6146edf33d0e396284b92f3
https://github.com/pythonnet/pythonnet/pull/1786/files#diff-d0c776c5a2a85b17ab26c64f8012ebf5b6b3cda0b6146edf33d0e396284b92f3
tests/test_collection_mixins.pyhttps://github.com/pythonnet/pythonnet/pull/1786/files#diff-b99d9205f1b4b3ceba874f62ca0907665af92bde43fdb2ebbcd07a0ed3fa2757
View file https://github.com/losttech/pythonnet/blob/d8543321a32535b90789770219f0d7c1ff0265de/tests/test_collection_mixins.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1786/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1786/files#diff-b99d9205f1b4b3ceba874f62ca0907665af92bde43fdb2ebbcd07a0ed3fa2757
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.