René's URL Explorer Experiment


Title: Fixed accessing partially overriden properties from Python by lostmsu · Pull Request #1650 · pythonnet/pythonnet · GitHub

Open Graph Title: Fixed accessing partially overriden properties from Python by lostmsu · Pull Request #1650 · pythonnet/pythonnet

X Title: Fixed accessing partially overriden properties from Python by lostmsu · Pull Request #1650 · pythonnet/pythonnet

Description: What does this implement/fix? Explain your changes. .NET PropertyInfo.GetMethod would not return base non-overridden accessor for a partially overridden property (e.g. only setter overridden) Because of that when constructing PropertyObject we scan base classes to find base accessor (if any). Does this close any currently open issues? fixes #1455 Any other comments? This might have performance implications due to replacement of PropertyInfo.GetValue with getter.Invoke (not tested) Also in the change No need to serialize accessors - they can be reconstructed from the PropertyInfo Checklist Check all those that are applicable and complete. Make sure to include one or more tests for your change

Open Graph Description: What does this implement/fix? Explain your changes. .NET PropertyInfo.GetMethod would not return base non-overridden accessor for a partially overridden property (e.g. only setter overridden) Becau...

X Description: What does this implement/fix? Explain your changes. .NET PropertyInfo.GetMethod would not return base non-overridden accessor for a partially overridden property (e.g. only setter overridden) Becau...

Opengraph URL: https://github.com/pythonnet/pythonnet/pull/1650

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:31a5d396-cef1-2b39-1af2-2ccd97df0bd9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE0A4:2CECE6:18CF384:22A8D64:6970DD3B
html-safe-nonce0bb981270035870964a75b6a703a7ddbdbcca57ef5352a46bf3c71a3a31e134d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMEE0OjJDRUNFNjoxOENGMzg0OjIyQThENjQ6Njk3MEREM0IiLCJ2aXNpdG9yX2lkIjoiNzk3NzAxODI0MDY2MTUxMTQ4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca28bf653a6212212a221071d2de95bfccb28e850ebaadd0c48c1b6971de48058
hovercard-subject-tagpull_request:811144639
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/1650/files
twitter:imagehttps://avatars.githubusercontent.com/u/239520?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/239520?s=400&v=4
og:image:altWhat does this implement/fix? Explain your changes. .NET PropertyInfo.GetMethod would not return base non-overridden accessor for a partially overridden property (e.g. only setter overridden) Becau...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9203e7efc62065329c3b7015a1e6d16fc14bce440abec7b0d3cbe9e4fb1e2e4
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git
octolytics-dimension-user_id6050430
octolytics-dimension-user_loginpythonnet
octolytics-dimension-repository_id14748123
octolytics-dimension-repository_nwopythonnet/pythonnet
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id14748123
octolytics-dimension-repository_network_root_nwopythonnet/pythonnet
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseeb3c92b74ae48a78cffd8700b8eb5f60bad61528
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/pythonnet/pythonnet/pull/1650/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1650%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1650%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=pythonnet%2Fpythonnet
Reloadhttps://github.com/pythonnet/pythonnet/pull/1650/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1650/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1650/files
pythonnet https://github.com/pythonnet
pythonnethttps://github.com/pythonnet/pythonnet
Notifications https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Fork 770 https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Star 5.4k https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Code https://github.com/pythonnet/pythonnet
Issues 155 https://github.com/pythonnet/pythonnet/issues
Pull requests 18 https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects 0 https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/pythonnet/pythonnet/security
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1650/files
Insights https://github.com/pythonnet/pythonnet/pulse
Code https://github.com/pythonnet/pythonnet
Issues https://github.com/pythonnet/pythonnet/issues
Pull requests https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security https://github.com/pythonnet/pythonnet/security
Insights https://github.com/pythonnet/pythonnet/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
lostmsuhttps://github.com/lostmsu
pythonnet:masterhttps://github.com/pythonnet/pythonnet/tree/master
losttech:bugs/OverridenPropertyhttps://github.com/losttech/pythonnet/tree/bugs/OverridenProperty
Conversation 0 https://github.com/pythonnet/pythonnet/pull/1650
Commits 1 https://github.com/pythonnet/pythonnet/pull/1650/commits
Checks 0 https://github.com/pythonnet/pythonnet/pull/1650/checks
Files changed https://github.com/pythonnet/pythonnet/pull/1650/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1650/files
Fixed accessing partially overriden properties from Python https://github.com/pythonnet/pythonnet/pull/1650/files#top
Show all changes 1 commit https://github.com/pythonnet/pythonnet/pull/1650/files
a07f00c base accessors were not exposed to Python because .NET PropertyInfo G… lostmsu Dec 28, 2021 https://github.com/pythonnet/pythonnet/pull/1650/commits/a07f00ced33881a929d82acb11a798eaded2cbf3
Clear filters https://github.com/pythonnet/pythonnet/pull/1650/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1650/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1650/files
Inheritance.cs https://github.com/pythonnet/pythonnet/pull/1650/files#diff-93af3c15c204262014339f0d3cbf591fbf6f5038dc0d8019169f80aa2ad737ea
ReflectionUtil.cs https://github.com/pythonnet/pythonnet/pull/1650/files#diff-af7678069708670564da60155a14ecb86faf6645c17011cb1bffa33124d1bc33
propertyobject.cs https://github.com/pythonnet/pythonnet/pull/1650/files#diff-2294b1ddaf374d8d12185e6edf7f4371b3f42ec807da9e7c63c95040732b5f68
src/embed_tests/Inheritance.cshttps://github.com/pythonnet/pythonnet/pull/1650/files#diff-93af3c15c204262014339f0d3cbf591fbf6f5038dc0d8019169f80aa2ad737ea
View file https://github.com/losttech/pythonnet/blob/a07f00ced33881a929d82acb11a798eaded2cbf3/src/embed_tests/Inheritance.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1650/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1650/files#diff-93af3c15c204262014339f0d3cbf591fbf6f5038dc0d8019169f80aa2ad737ea
https://github.com/pythonnet/pythonnet/pull/1650/files#diff-93af3c15c204262014339f0d3cbf591fbf6f5038dc0d8019169f80aa2ad737ea
https://github.com/pythonnet/pythonnet/pull/1650/files#diff-93af3c15c204262014339f0d3cbf591fbf6f5038dc0d8019169f80aa2ad737ea
https://github.com/pythonnet/pythonnet/pull/1650/files#diff-93af3c15c204262014339f0d3cbf591fbf6f5038dc0d8019169f80aa2ad737ea
src/runtime/ReflectionUtil.cshttps://github.com/pythonnet/pythonnet/pull/1650/files#diff-af7678069708670564da60155a14ecb86faf6645c17011cb1bffa33124d1bc33
View file https://github.com/losttech/pythonnet/blob/a07f00ced33881a929d82acb11a798eaded2cbf3/src/runtime/ReflectionUtil.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1650/{{ revealButtonHref }}
src/runtime/propertyobject.cshttps://github.com/pythonnet/pythonnet/pull/1650/files#diff-2294b1ddaf374d8d12185e6edf7f4371b3f42ec807da9e7c63c95040732b5f68
View file https://github.com/losttech/pythonnet/blob/a07f00ced33881a929d82acb11a798eaded2cbf3/src/runtime/propertyobject.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1650/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1650/files#diff-2294b1ddaf374d8d12185e6edf7f4371b3f42ec807da9e7c63c95040732b5f68
https://github.com/pythonnet/pythonnet/pull/1650/files#diff-2294b1ddaf374d8d12185e6edf7f4371b3f42ec807da9e7c63c95040732b5f68
https://github.com/pythonnet/pythonnet/pull/1650/files#diff-2294b1ddaf374d8d12185e6edf7f4371b3f42ec807da9e7c63c95040732b5f68
https://github.com/pythonnet/pythonnet/pull/1650/files#diff-2294b1ddaf374d8d12185e6edf7f4371b3f42ec807da9e7c63c95040732b5f68
https://github.com/pythonnet/pythonnet/pull/1650/files#diff-2294b1ddaf374d8d12185e6edf7f4371b3f42ec807da9e7c63c95040732b5f68
https://github.com/pythonnet/pythonnet/pull/1650/files#diff-2294b1ddaf374d8d12185e6edf7f4371b3f42ec807da9e7c63c95040732b5f68
https://github.com/pythonnet/pythonnet/pull/1650/files#diff-2294b1ddaf374d8d12185e6edf7f4371b3f42ec807da9e7c63c95040732b5f68
https://github.com/pythonnet/pythonnet/pull/1650/files#diff-2294b1ddaf374d8d12185e6edf7f4371b3f42ec807da9e7c63c95040732b5f68
https://github.com/pythonnet/pythonnet/pull/1650/files#diff-2294b1ddaf374d8d12185e6edf7f4371b3f42ec807da9e7c63c95040732b5f68
https://github.com/pythonnet/pythonnet/pull/1650/files#diff-2294b1ddaf374d8d12185e6edf7f4371b3f42ec807da9e7c63c95040732b5f68
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.