René's URL Explorer Experiment


Title: Match generic and private methods upon runtime reload by lostmsu · Pull Request #1637 · pythonnet/pythonnet · GitHub

Open Graph Title: Match generic and private methods upon runtime reload by lostmsu · Pull Request #1637 · pythonnet/pythonnet

X Title: Match generic and private methods upon runtime reload by lostmsu · Pull Request #1637 · pythonnet/pythonnet

Description: What does this implement/fix? Explain your changes. The old method matching code never worked for generic methods because their parameter types did not have assembly qualified names. The new method explicitly checks generic parameters. It also allows reloading of private methods, which can be exposed to Python via reflection or delegate binding. Any other comments? This is part of work to remove all shutdown modes (only Reload will remain), that ensures, that internal methods are always successfully reloaded. Checklist Check all those that are applicable and complete. Make sure to include one or more tests for your change If an enhancement PR, please create docs and at best an example Updated the CHANGELOG

Open Graph Description: What does this implement/fix? Explain your changes. The old method matching code never worked for generic methods because their parameter types did not have assembly qualified names. The new method...

X Description: What does this implement/fix? Explain your changes. The old method matching code never worked for generic methods because their parameter types did not have assembly qualified names. The new method...

Opengraph URL: https://github.com/pythonnet/pythonnet/pull/1637

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fa5de66a-7402-c74b-7ef6-4ba133543efc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAA80:287A4D:390EFB9:4D8145C:6970858D
html-safe-nonce82fd7d56aef46ddc5afb3ce9e7bfea5f2f2ca36cdb8ac6528bd9a1740b79b398
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTgwOjI4N0E0RDozOTBFRkI5OjREODE0NUM6Njk3MDg1OEQiLCJ2aXNpdG9yX2lkIjoiNjE4Nzg4MTg5MDQ2ODM2NTcwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac48f93541b4c30e1ced8583d254ec6cd97b63f440dfadb9f340ae32d7d5546b59
hovercard-subject-tagpull_request:805938119
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/1637/files
twitter:imagehttps://avatars.githubusercontent.com/u/239520?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/239520?s=400&v=4
og:image:altWhat does this implement/fix? Explain your changes. The old method matching code never worked for generic methods because their parameter types did not have assembly qualified names. The new method...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git
octolytics-dimension-user_id6050430
octolytics-dimension-user_loginpythonnet
octolytics-dimension-repository_id14748123
octolytics-dimension-repository_nwopythonnet/pythonnet
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id14748123
octolytics-dimension-repository_network_root_nwopythonnet/pythonnet
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7d6181066430cc06553c8396ca201e194ae33cb9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/pythonnet/pythonnet/pull/1637/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1637%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1637%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=pythonnet%2Fpythonnet
Reloadhttps://github.com/pythonnet/pythonnet/pull/1637/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1637/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1637/files
pythonnet https://github.com/pythonnet
pythonnethttps://github.com/pythonnet/pythonnet
Notifications https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Fork 770 https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Star 5.4k https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Code https://github.com/pythonnet/pythonnet
Issues 155 https://github.com/pythonnet/pythonnet/issues
Pull requests 18 https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects 0 https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/pythonnet/pythonnet/security
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1637/files
Insights https://github.com/pythonnet/pythonnet/pulse
Code https://github.com/pythonnet/pythonnet
Issues https://github.com/pythonnet/pythonnet/issues
Pull requests https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security https://github.com/pythonnet/pythonnet/security
Insights https://github.com/pythonnet/pythonnet/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
lostmsuhttps://github.com/lostmsu
pythonnet:masterhttps://github.com/pythonnet/pythonnet/tree/master
losttech:ReloadMethodMatchinghttps://github.com/losttech/pythonnet/tree/ReloadMethodMatching
Conversation 0 https://github.com/pythonnet/pythonnet/pull/1637
Commits 1 https://github.com/pythonnet/pythonnet/pull/1637/commits
Checks 0 https://github.com/pythonnet/pythonnet/pull/1637/checks
Files changed 5 https://github.com/pythonnet/pythonnet/pull/1637/files
Match generic and private methods upon runtime reload https://github.com/pythonnet/pythonnet/pull/1637/files#top
Show all changes 1 commit https://github.com/pythonnet/pythonnet/pull/1637/files
a66f4d6 Match generic and private methods upon runtime reload lostmsu Dec 18, 2021 https://github.com/pythonnet/pythonnet/pull/1637/commits/a66f4d6f0b1219db0d21d659bb1f9b2031632730
Clear filters https://github.com/pythonnet/pythonnet/pull/1637/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1637/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1637/files
CHANGELOG.md https://github.com/pythonnet/pythonnet/pull/1637/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
MethodSerialization.cs https://github.com/pythonnet/pythonnet/pull/1637/files#diff-cef5fd261645cb9362e90456712755f3e107a27069192ec62dfdf9431f55b1db
ParameterHelper.cs https://github.com/pythonnet/pythonnet/pull/1637/files#diff-1a3fd7a1d351a3510e04d51ac4d4c57b55c9abe823d6940374fbda9fa895262d
MaybeMethodBase.cs https://github.com/pythonnet/pythonnet/pull/1637/files#diff-11cc5a903ea86bb90b85ac9bbccaf8c41e6b297aac367a04961876f595a62845
runtime_data.cs https://github.com/pythonnet/pythonnet/pull/1637/files#diff-76d6056a54c57f9ebad0dfe5b6628d0c877e4e6c36fc622e9f6c7de47736526f
CHANGELOG.mdhttps://github.com/pythonnet/pythonnet/pull/1637/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
View file https://github.com/losttech/pythonnet/blob/a66f4d6f0b1219db0d21d659bb1f9b2031632730/CHANGELOG.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1637/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1637/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
https://github.com/pythonnet/pythonnet/pull/1637/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
src/embed_tests/StateSerialization/MethodSerialization.cshttps://github.com/pythonnet/pythonnet/pull/1637/files#diff-cef5fd261645cb9362e90456712755f3e107a27069192ec62dfdf9431f55b1db
View file https://github.com/losttech/pythonnet/blob/a66f4d6f0b1219db0d21d659bb1f9b2031632730/src/embed_tests/StateSerialization/MethodSerialization.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1637/{{ revealButtonHref }}
src/runtime/Reflection/ParameterHelper.cshttps://github.com/pythonnet/pythonnet/pull/1637/files#diff-1a3fd7a1d351a3510e04d51ac4d4c57b55c9abe823d6940374fbda9fa895262d
View file https://github.com/losttech/pythonnet/blob/a66f4d6f0b1219db0d21d659bb1f9b2031632730/src/runtime/Reflection/ParameterHelper.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1637/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1637/files#diff-1a3fd7a1d351a3510e04d51ac4d4c57b55c9abe823d6940374fbda9fa895262d
https://github.com/pythonnet/pythonnet/pull/1637/files#diff-1a3fd7a1d351a3510e04d51ac4d4c57b55c9abe823d6940374fbda9fa895262d
src/runtime/StateSerialization/MaybeMethodBase.cshttps://github.com/pythonnet/pythonnet/pull/1637/files#diff-11cc5a903ea86bb90b85ac9bbccaf8c41e6b297aac367a04961876f595a62845
View file https://github.com/losttech/pythonnet/blob/a66f4d6f0b1219db0d21d659bb1f9b2031632730/src/runtime/StateSerialization/MaybeMethodBase.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1637/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1637/files#diff-11cc5a903ea86bb90b85ac9bbccaf8c41e6b297aac367a04961876f595a62845
https://github.com/pythonnet/pythonnet/pull/1637/files#diff-11cc5a903ea86bb90b85ac9bbccaf8c41e6b297aac367a04961876f595a62845
https://github.com/pythonnet/pythonnet/pull/1637/files#diff-11cc5a903ea86bb90b85ac9bbccaf8c41e6b297aac367a04961876f595a62845
https://github.com/pythonnet/pythonnet/pull/1637/files#diff-11cc5a903ea86bb90b85ac9bbccaf8c41e6b297aac367a04961876f595a62845
https://github.com/pythonnet/pythonnet/pull/1637/files#diff-11cc5a903ea86bb90b85ac9bbccaf8c41e6b297aac367a04961876f595a62845
src/runtime/runtime_data.cshttps://github.com/pythonnet/pythonnet/pull/1637/files#diff-76d6056a54c57f9ebad0dfe5b6628d0c877e4e6c36fc622e9f6c7de47736526f
View file https://github.com/losttech/pythonnet/blob/a66f4d6f0b1219db0d21d659bb1f9b2031632730/src/runtime/runtime_data.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1637/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1637/files#diff-76d6056a54c57f9ebad0dfe5b6628d0c877e4e6c36fc622e9f6c7de47736526f
https://github.com/pythonnet/pythonnet/pull/1637/files#diff-76d6056a54c57f9ebad0dfe5b6628d0c877e4e6c36fc622e9f6c7de47736526f
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.