René's URL Explorer Experiment


Title: Fixed `FileLoadException` when trying `clr.AddReference('/full/path.dll')` by lostmsu · Pull Request #1573 · pythonnet/pythonnet · GitHub

Open Graph Title: Fixed `FileLoadException` when trying `clr.AddReference('/full/path.dll')` by lostmsu · Pull Request #1573 · pythonnet/pythonnet

X Title: Fixed `FileLoadException` when trying `clr.AddReference('/full/path.dll')` by lostmsu · Pull Request #1573 · pythonnet/pythonnet

Description: What does this implement/fix? Explain your changes. Before trying to load an assembly by its full path we were trying to call Assembly.Load on it. Assembly.Load interprets its argument as a valid AssemblyName. However full paths are not valid assembly names, so that call would throw FileLoadException, which we did not handle. The fix is to separately try to parse input string into an AssemblyName and only try Assembly.Load when it succeeds. Does this close any currently open issues? 9d5f579#commitcomment-57061082 Any other comments? Related: #1514

Open Graph Description: What does this implement/fix? Explain your changes. Before trying to load an assembly by its full path we were trying to call Assembly.Load on it. Assembly.Load interprets its argument as a valid A...

X Description: What does this implement/fix? Explain your changes. Before trying to load an assembly by its full path we were trying to call Assembly.Load on it. Assembly.Load interprets its argument as a valid A...

Opengraph URL: https://github.com/pythonnet/pythonnet/pull/1573

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f76aae30-9187-4d0a-40ef-4cc26dba130e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9C5E:EAD41:434C7EE:5D708EC:69714BB5
html-safe-nonce8edcd067143c2dc0227efb61ca38d9a8aa00efdaf426191cf853f496a1c8adb9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzVFOkVBRDQxOjQzNEM3RUU6NUQ3MDhFQzo2OTcxNEJCNSIsInZpc2l0b3JfaWQiOiIyODQzNTQ5MzAxNDUzMTU3NjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4ac60df0682b85e3baacc9c1f645e2ce08913478cc66131f9c1930738c19a786
hovercard-subject-tagpull_request:743878520
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/1573/files
twitter:imagehttps://avatars.githubusercontent.com/u/239520?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/239520?s=400&v=4
og:image:altWhat does this implement/fix? Explain your changes. Before trying to load an assembly by its full path we were trying to call Assembly.Load on it. Assembly.Load interprets its argument as a valid A...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneda7cbccf7f40bcd9540003423d9bef63b2fe7bb0b73fc59d91b5ae5b46000c90
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git
octolytics-dimension-user_id6050430
octolytics-dimension-user_loginpythonnet
octolytics-dimension-repository_id14748123
octolytics-dimension-repository_nwopythonnet/pythonnet
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id14748123
octolytics-dimension-repository_network_root_nwopythonnet/pythonnet
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec9e6c71b091ca750658a3b2e3c82b0b85555f788
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/pythonnet/pythonnet/pull/1573/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1573%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1573%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=pythonnet%2Fpythonnet
Reloadhttps://github.com/pythonnet/pythonnet/pull/1573/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1573/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1573/files
pythonnet https://github.com/pythonnet
pythonnethttps://github.com/pythonnet/pythonnet
Notifications https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Fork 770 https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Star 5.4k https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Code https://github.com/pythonnet/pythonnet
Issues 155 https://github.com/pythonnet/pythonnet/issues
Pull requests 18 https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects 0 https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/pythonnet/pythonnet/security
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1573/files
Insights https://github.com/pythonnet/pythonnet/pulse
Code https://github.com/pythonnet/pythonnet
Issues https://github.com/pythonnet/pythonnet/issues
Pull requests https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security https://github.com/pythonnet/pythonnet/security
Insights https://github.com/pythonnet/pythonnet/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
lostmsuhttps://github.com/lostmsu
pythonnet:masterhttps://github.com/pythonnet/pythonnet/tree/master
losttech:add-ref-fullpathhttps://github.com/losttech/pythonnet/tree/add-ref-fullpath
Conversation 0 https://github.com/pythonnet/pythonnet/pull/1573
Commits 1 https://github.com/pythonnet/pythonnet/pull/1573/commits
Checks 0 https://github.com/pythonnet/pythonnet/pull/1573/checks
Files changed https://github.com/pythonnet/pythonnet/pull/1573/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1573/files
Fixed FileLoadException when trying clr.AddReference('/full/path.dll') https://github.com/pythonnet/pythonnet/pull/1573/files#top
Show all changes 1 commit https://github.com/pythonnet/pythonnet/pull/1573/files
5e68b16 fixed FileLoadException when trying to do clr.AddReference('/full/lib… lostmsu Sep 27, 2021 https://github.com/pythonnet/pythonnet/pull/1573/commits/5e68b1611a96f4b208c6d7cd6b923582b6231a76
Clear filters https://github.com/pythonnet/pythonnet/pull/1573/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1573/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1573/files
pyimport.cs https://github.com/pythonnet/pythonnet/pull/1573/files#diff-54560ecd2f7920ff0812798703cf9b5138cc0fea38379ae21c4d54353ae5ac98
assemblymanager.cs https://github.com/pythonnet/pythonnet/pull/1573/files#diff-ec817a3080cb54b7ab7107226a35fe72560bead6faec81dd9e6a5620311d2a7b
moduleobject.cs https://github.com/pythonnet/pythonnet/pull/1573/files#diff-95baca92be51a7722a976817722cd8effdbd462db8f6e189928f162762d75611
src/embed_tests/pyimport.cshttps://github.com/pythonnet/pythonnet/pull/1573/files#diff-54560ecd2f7920ff0812798703cf9b5138cc0fea38379ae21c4d54353ae5ac98
View file https://github.com/losttech/pythonnet/blob/5e68b1611a96f4b208c6d7cd6b923582b6231a76/src/embed_tests/pyimport.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1573/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1573/files#diff-54560ecd2f7920ff0812798703cf9b5138cc0fea38379ae21c4d54353ae5ac98
https://github.com/pythonnet/pythonnet/pull/1573/files#diff-54560ecd2f7920ff0812798703cf9b5138cc0fea38379ae21c4d54353ae5ac98
https://github.com/pythonnet/pythonnet/pull/1573/files#diff-54560ecd2f7920ff0812798703cf9b5138cc0fea38379ae21c4d54353ae5ac98
src/runtime/assemblymanager.cshttps://github.com/pythonnet/pythonnet/pull/1573/files#diff-ec817a3080cb54b7ab7107226a35fe72560bead6faec81dd9e6a5620311d2a7b
View file https://github.com/losttech/pythonnet/blob/5e68b1611a96f4b208c6d7cd6b923582b6231a76/src/runtime/assemblymanager.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1573/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1573/files#diff-ec817a3080cb54b7ab7107226a35fe72560bead6faec81dd9e6a5620311d2a7b
https://github.com/pythonnet/pythonnet/pull/1573/files#diff-ec817a3080cb54b7ab7107226a35fe72560bead6faec81dd9e6a5620311d2a7b
https://github.com/pythonnet/pythonnet/pull/1573/files#diff-ec817a3080cb54b7ab7107226a35fe72560bead6faec81dd9e6a5620311d2a7b
https://github.com/pythonnet/pythonnet/pull/1573/files#diff-ec817a3080cb54b7ab7107226a35fe72560bead6faec81dd9e6a5620311d2a7b
src/runtime/moduleobject.cshttps://github.com/pythonnet/pythonnet/pull/1573/files#diff-95baca92be51a7722a976817722cd8effdbd462db8f6e189928f162762d75611
View file https://github.com/losttech/pythonnet/blob/5e68b1611a96f4b208c6d7cd6b923582b6231a76/src/runtime/moduleobject.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1573/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1573/files#diff-95baca92be51a7722a976817722cd8effdbd462db8f6e189928f162762d75611
https://github.com/pythonnet/pythonnet/pull/1573/files#diff-95baca92be51a7722a976817722cd8effdbd462db8f6e189928f162762d75611
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.