Title: Fixed `FileLoadException` when trying `clr.AddReference('/full/path.dll')` by lostmsu · Pull Request #1573 · pythonnet/pythonnet · GitHub
Open Graph Title: Fixed `FileLoadException` when trying `clr.AddReference('/full/path.dll')` by lostmsu · Pull Request #1573 · pythonnet/pythonnet
X Title: Fixed `FileLoadException` when trying `clr.AddReference('/full/path.dll')` by lostmsu · Pull Request #1573 · pythonnet/pythonnet
Description: What does this implement/fix? Explain your changes. Before trying to load an assembly by its full path we were trying to call Assembly.Load on it. Assembly.Load interprets its argument as a valid AssemblyName. However full paths are not valid assembly names, so that call would throw FileLoadException, which we did not handle. The fix is to separately try to parse input string into an AssemblyName and only try Assembly.Load when it succeeds. Does this close any currently open issues? 9d5f579#commitcomment-57061082 Any other comments? Related: #1514
Open Graph Description: What does this implement/fix? Explain your changes. Before trying to load an assembly by its full path we were trying to call Assembly.Load on it. Assembly.Load interprets its argument as a valid A...
X Description: What does this implement/fix? Explain your changes. Before trying to load an assembly by its full path we were trying to call Assembly.Load on it. Assembly.Load interprets its argument as a valid A...
Opengraph URL: https://github.com/pythonnet/pythonnet/pull/1573
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:fbccde17-07f5-61b6-5467-cb4b302daca8 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | E494:28EEF5:3D98534:535D7B0:69708597 |
| html-safe-nonce | 0bc7c44ac37a6ede6ada05211384ca54608068168fccdef6a1a69271065e303a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDk0OjI4RUVGNTozRDk4NTM0OjUzNUQ3QjA6Njk3MDg1OTciLCJ2aXNpdG9yX2lkIjoiOTEzMDg3NzMyODAzOTExODIzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b7eaeeeff15f38361c46dc602633c917026650ea03b972e7b8b097de2fa31a9c |
| hovercard-subject-tag | pull_request:743878520 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/1573/checks |
| twitter:image | https://avatars.githubusercontent.com/u/239520?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/239520?s=400&v=4 |
| og:image:alt | What does this implement/fix? Explain your changes. Before trying to load an assembly by its full path we were trying to call Assembly.Load on it. Assembly.Load interprets its argument as a valid A... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2 |
| turbo-cache-control | no-preview |
| go-import | github.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git |
| octolytics-dimension-user_id | 6050430 |
| octolytics-dimension-user_login | pythonnet |
| octolytics-dimension-repository_id | 14748123 |
| octolytics-dimension-repository_nwo | pythonnet/pythonnet |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 14748123 |
| octolytics-dimension-repository_network_root_nwo | pythonnet/pythonnet |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7d6181066430cc06553c8396ca201e194ae33cb9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width