Title: Fix exception refcnt by BadSingleton · Pull Request #1402 · pythonnet/pythonnet · GitHub
Open Graph Title: Fix exception refcnt by BadSingleton · Pull Request #1402 · pythonnet/pythonnet
X Title: Fix exception refcnt by BadSingleton · Pull Request #1402 · pythonnet/pythonnet
Description: What does this implement/fix? Explain your changes. Adds a tp_dealloc function to ExceptionClassObject, so we clean the BaseException members the same way as other the derived exceptions in the cpython code does. Does this close any currently open issues? Fixes issue #1371. Any other comments? Fixes a bug where C# Exceptions set as the Inner of another C# Exception, then converted into a Python exception object (and thus having __cause__ set to a valid object) would leak the Inner/__cause__ objects. Simplified diagram : AggregateException.Inner -> ArgumentException(...) ^ ^ | | PyAggregateException.__cause__ -> PyArgumentException In this case, where the AggregateException would be thrown from C# and caught in Python, the AggregateException and PyAggregateException would be freed, but not the ArgumentException set as the cause. Checklist Check all those that are applicable and complete. Make sure to include one or more tests for your change If an enhancement PR, please create docs and at best an example Add yourself to AUTHORS Updated the CHANGELOG
Open Graph Description: What does this implement/fix? Explain your changes. Adds a tp_dealloc function to ExceptionClassObject, so we clean the BaseException members the same way as other the derived exceptions in the cpy...
X Description: What does this implement/fix? Explain your changes. Adds a tp_dealloc function to ExceptionClassObject, so we clean the BaseException members the same way as other the derived exceptions in the cpy...
Opengraph URL: https://github.com/pythonnet/pythonnet/pull/1402
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:864e5c16-468d-abaf-38a3-8d0fc5e76ed6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8098:3AD658:17A2E:1E4CE:69736A8F |
| html-safe-nonce | 90cc308258f2f32d74256b4663c64f8296fac8a17c4aba16565955df83c18675 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDk4OjNBRDY1ODoxN0EyRToxRTRDRTo2OTczNkE4RiIsInZpc2l0b3JfaWQiOiIyMDU4MjQyODA2NDA3OTgxNzExIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 9edf53f6ab28edba4db5adb4ec45d8df3c4ecc79a4345d6fc2b5f198a8835580 |
| hovercard-subject-tag | pull_request:582112943 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/1402/files |
| twitter:image | https://avatars.githubusercontent.com/u/6788684?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/6788684?s=400&v=4 |
| og:image:alt | What does this implement/fix? Explain your changes. Adds a tp_dealloc function to ExceptionClassObject, so we clean the BaseException members the same way as other the derived exceptions in the cpy... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4cf879a11b0a28a85543899a36aaee9ec9ca2fb7bedad86c0da5731193c95f01 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git |
| octolytics-dimension-user_id | 6050430 |
| octolytics-dimension-user_login | pythonnet |
| octolytics-dimension-repository_id | 14748123 |
| octolytics-dimension-repository_nwo | pythonnet/pythonnet |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 14748123 |
| octolytics-dimension-repository_network_root_nwo | pythonnet/pythonnet |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | fe8be790582ef7a55477ce1918ac0ed16b106d31 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width