René's URL Explorer Experiment


Title: ImportHook cleanup + PyObject.Length exception by lostmsu · Pull Request #1400 · pythonnet/pythonnet · GitHub

Open Graph Title: ImportHook cleanup + PyObject.Length exception by lostmsu · Pull Request #1400 · pythonnet/pythonnet

X Title: ImportHook cleanup + PyObject.Length exception by lostmsu · Pull Request #1400 · pythonnet/pythonnet

Description: What does this implement/fix? Explain your changes. Import adds validation to PyImportTest before restoring original __import__, validates, that __import__ was not replaced by a third party (only in DEBUG build) drops unsupported _PyObject_GetDictPtr in favor of PyObject_GenericGetDict PyObject Length() method now raises an exception when object does not support concept of length (was returning 0).

Open Graph Description: What does this implement/fix? Explain your changes. Import adds validation to PyImportTest before restoring original __import__, validates, that __import__ was not replaced by a third party (only ...

X Description: What does this implement/fix? Explain your changes. Import adds validation to PyImportTest before restoring original __import__, validates, that __import__ was not replaced by a third party (only ...

Opengraph URL: https://github.com/pythonnet/pythonnet/pull/1400

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4cee733d-c715-4ca7-815b-bbf3e973b013
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA46E:C8498:1B02E1B:25DBE35:6970DD6E
html-safe-nonce2be7cf02a6fbdfb41eb0d513a62ccd3dc898214dbf325744fb6dba8e21f05c6a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDZFOkM4NDk4OjFCMDJFMUI6MjVEQkUzNTo2OTcwREQ2RSIsInZpc2l0b3JfaWQiOiIxNjU3MTI0OTU3MjUyMDE3NTE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3e59a2ed139c1e654d6409048cc1239fdd515fe021fb230abc3ae0a5e149b781
hovercard-subject-tagpull_request:580492039
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/1400/files
twitter:imagehttps://avatars.githubusercontent.com/u/239520?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/239520?s=400&v=4
og:image:altWhat does this implement/fix? Explain your changes. Import adds validation to PyImportTest before restoring original __import__, validates, that __import__ was not replaced by a third party (only ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9203e7efc62065329c3b7015a1e6d16fc14bce440abec7b0d3cbe9e4fb1e2e4
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git
octolytics-dimension-user_id6050430
octolytics-dimension-user_loginpythonnet
octolytics-dimension-repository_id14748123
octolytics-dimension-repository_nwopythonnet/pythonnet
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id14748123
octolytics-dimension-repository_network_root_nwopythonnet/pythonnet
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseeb3c92b74ae48a78cffd8700b8eb5f60bad61528
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/pythonnet/pythonnet/pull/1400/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1400%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1400%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=pythonnet%2Fpythonnet
Reloadhttps://github.com/pythonnet/pythonnet/pull/1400/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1400/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1400/files
pythonnet https://github.com/pythonnet
pythonnethttps://github.com/pythonnet/pythonnet
Notifications https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Fork 770 https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Star 5.4k https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Code https://github.com/pythonnet/pythonnet
Issues 155 https://github.com/pythonnet/pythonnet/issues
Pull requests 18 https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects 0 https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/pythonnet/pythonnet/security
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1400/files
Insights https://github.com/pythonnet/pythonnet/pulse
Code https://github.com/pythonnet/pythonnet
Issues https://github.com/pythonnet/pythonnet/issues
Pull requests https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security https://github.com/pythonnet/pythonnet/security
Insights https://github.com/pythonnet/pythonnet/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
lostmsuhttps://github.com/lostmsu
pythonnet:masterhttps://github.com/pythonnet/pythonnet/tree/master
losttech:cleanup/21-02-25https://github.com/losttech/pythonnet/tree/cleanup/21-02-25
Conversation 1 https://github.com/pythonnet/pythonnet/pull/1400
Commits 5 https://github.com/pythonnet/pythonnet/pull/1400/commits
Checks 0 https://github.com/pythonnet/pythonnet/pull/1400/checks
Files changed https://github.com/pythonnet/pythonnet/pull/1400/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1400/files
ImportHook cleanup + PyObject.Length exception https://github.com/pythonnet/pythonnet/pull/1400/files#top
Show all changes 5 commits https://github.com/pythonnet/pythonnet/pull/1400/files
6f10641 PyImport test validate no initialization failures lostmsu Feb 25, 2021 https://github.com/pythonnet/pythonnet/pull/1400/commits/6f1064185250ae4080b8d7f3fa491b78425380db
676fbb4 PyObject.Length raises an exception when object does not have a conce… lostmsu Feb 25, 2021 https://github.com/pythonnet/pythonnet/pull/1400/commits/676fbb42cd904f042ed1387c95c54baf090fbc98
b2c15a4 ImportHook: verify __import__ was not updated before overwriting it w… lostmsu Feb 25, 2021 https://github.com/pythonnet/pythonnet/pull/1400/commits/b2c15a4dafd6bdc02e79cf80cc48a91c2f0cb39b
fefa322 drop _PyObject_GetDictPtr and use PyObject_GenericGetDict instead lostmsu Feb 25, 2021 https://github.com/pythonnet/pythonnet/pull/1400/commits/fefa322cc49772bc5d85803a9d39fb78ce04a065
908316f ImportHook: drop dead code around clr_prefix lostmsu Feb 26, 2021 https://github.com/pythonnet/pythonnet/pull/1400/commits/908316fa766b1db33bda7a28a59c81684775ac89
Clear filters https://github.com/pythonnet/pythonnet/pull/1400/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1400/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1400/files
CHANGELOG.md https://github.com/pythonnet/pythonnet/pull/1400/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
pyimport.cs https://github.com/pythonnet/pythonnet/pull/1400/files#diff-54560ecd2f7920ff0812798703cf9b5138cc0fea38379ae21c4d54353ae5ac98
importhook.cs https://github.com/pythonnet/pythonnet/pull/1400/files#diff-a3519b110d7c58f117c82c3d4d5c1b4de9d1217504801b64a0476ddc50270ea1
pyobject.cs https://github.com/pythonnet/pythonnet/pull/1400/files#diff-c7afe47ee5bee58846cafad6ec4ecedb222d846124e7aec56bb7f62df0340392
runtime.cs https://github.com/pythonnet/pythonnet/pull/1400/files#diff-f1749bdd9f64fdac5c64d5cb0982ce1dac5e2d9a2cdd55b93d3f83b5047a855d
CHANGELOG.mdhttps://github.com/pythonnet/pythonnet/pull/1400/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
View file https://github.com/losttech/pythonnet/blob/908316fa766b1db33bda7a28a59c81684775ac89/CHANGELOG.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1400/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
src/embed_tests/pyimport.cshttps://github.com/pythonnet/pythonnet/pull/1400/files#diff-54560ecd2f7920ff0812798703cf9b5138cc0fea38379ae21c4d54353ae5ac98
View file https://github.com/losttech/pythonnet/blob/908316fa766b1db33bda7a28a59c81684775ac89/src/embed_tests/pyimport.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1400/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-54560ecd2f7920ff0812798703cf9b5138cc0fea38379ae21c4d54353ae5ac98
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-54560ecd2f7920ff0812798703cf9b5138cc0fea38379ae21c4d54353ae5ac98
src/runtime/importhook.cshttps://github.com/pythonnet/pythonnet/pull/1400/files#diff-a3519b110d7c58f117c82c3d4d5c1b4de9d1217504801b64a0476ddc50270ea1
View file https://github.com/losttech/pythonnet/blob/908316fa766b1db33bda7a28a59c81684775ac89/src/runtime/importhook.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1400/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-a3519b110d7c58f117c82c3d4d5c1b4de9d1217504801b64a0476ddc50270ea1
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-a3519b110d7c58f117c82c3d4d5c1b4de9d1217504801b64a0476ddc50270ea1
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-a3519b110d7c58f117c82c3d4d5c1b4de9d1217504801b64a0476ddc50270ea1
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-a3519b110d7c58f117c82c3d4d5c1b4de9d1217504801b64a0476ddc50270ea1
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-a3519b110d7c58f117c82c3d4d5c1b4de9d1217504801b64a0476ddc50270ea1
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-a3519b110d7c58f117c82c3d4d5c1b4de9d1217504801b64a0476ddc50270ea1
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-a3519b110d7c58f117c82c3d4d5c1b4de9d1217504801b64a0476ddc50270ea1
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-a3519b110d7c58f117c82c3d4d5c1b4de9d1217504801b64a0476ddc50270ea1
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-a3519b110d7c58f117c82c3d4d5c1b4de9d1217504801b64a0476ddc50270ea1
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-a3519b110d7c58f117c82c3d4d5c1b4de9d1217504801b64a0476ddc50270ea1
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-a3519b110d7c58f117c82c3d4d5c1b4de9d1217504801b64a0476ddc50270ea1
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-a3519b110d7c58f117c82c3d4d5c1b4de9d1217504801b64a0476ddc50270ea1
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-a3519b110d7c58f117c82c3d4d5c1b4de9d1217504801b64a0476ddc50270ea1
src/runtime/pyobject.cshttps://github.com/pythonnet/pythonnet/pull/1400/files#diff-c7afe47ee5bee58846cafad6ec4ecedb222d846124e7aec56bb7f62df0340392
View file https://github.com/losttech/pythonnet/blob/908316fa766b1db33bda7a28a59c81684775ac89/src/runtime/pyobject.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1400/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-c7afe47ee5bee58846cafad6ec4ecedb222d846124e7aec56bb7f62df0340392
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-c7afe47ee5bee58846cafad6ec4ecedb222d846124e7aec56bb7f62df0340392
src/runtime/runtime.cshttps://github.com/pythonnet/pythonnet/pull/1400/files#diff-f1749bdd9f64fdac5c64d5cb0982ce1dac5e2d9a2cdd55b93d3f83b5047a855d
View file https://github.com/losttech/pythonnet/blob/908316fa766b1db33bda7a28a59c81684775ac89/src/runtime/runtime.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1400/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-f1749bdd9f64fdac5c64d5cb0982ce1dac5e2d9a2cdd55b93d3f83b5047a855d
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-f1749bdd9f64fdac5c64d5cb0982ce1dac5e2d9a2cdd55b93d3f83b5047a855d
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-f1749bdd9f64fdac5c64d5cb0982ce1dac5e2d9a2cdd55b93d3f83b5047a855d
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-f1749bdd9f64fdac5c64d5cb0982ce1dac5e2d9a2cdd55b93d3f83b5047a855d
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-f1749bdd9f64fdac5c64d5cb0982ce1dac5e2d9a2cdd55b93d3f83b5047a855d
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-f1749bdd9f64fdac5c64d5cb0982ce1dac5e2d9a2cdd55b93d3f83b5047a855d
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-f1749bdd9f64fdac5c64d5cb0982ce1dac5e2d9a2cdd55b93d3f83b5047a855d
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-f1749bdd9f64fdac5c64d5cb0982ce1dac5e2d9a2cdd55b93d3f83b5047a855d
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-f1749bdd9f64fdac5c64d5cb0982ce1dac5e2d9a2cdd55b93d3f83b5047a855d
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-f1749bdd9f64fdac5c64d5cb0982ce1dac5e2d9a2cdd55b93d3f83b5047a855d
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-f1749bdd9f64fdac5c64d5cb0982ce1dac5e2d9a2cdd55b93d3f83b5047a855d
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-f1749bdd9f64fdac5c64d5cb0982ce1dac5e2d9a2cdd55b93d3f83b5047a855d
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-f1749bdd9f64fdac5c64d5cb0982ce1dac5e2d9a2cdd55b93d3f83b5047a855d
https://github.com/pythonnet/pythonnet/pull/1400/files#diff-f1749bdd9f64fdac5c64d5cb0982ce1dac5e2d9a2cdd55b93d3f83b5047a855d
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.