René's URL Explorer Experiment


Title: PyIter: do not force dispose previous object upon moving to the next one by lostmsu · Pull Request #1331 · pythonnet/pythonnet · GitHub

Open Graph Title: PyIter: do not force dispose previous object upon moving to the next one by lostmsu · Pull Request #1331 · pythonnet/pythonnet

X Title: PyIter: do not force dispose previous object upon moving to the next one by lostmsu · Pull Request #1331 · pythonnet/pythonnet

Description: What does this implement/fix? Explain your changes. Prior to this change trying to use object returned by iterating over PyObject would fail after iterator is closed, because iterator would dispose previously returned objects on close/moving to the next one. This also adds error handling for PyIter_Next calls, which can have other reasons to fail beyond reaching the end of collection. Checklist Check all those that are applicable and complete. Make sure to include one or more tests for your change If an enhancement PR, please create docs and at best an example Add yourself to AUTHORS Updated the CHANGELOG

Open Graph Description: What does this implement/fix? Explain your changes. Prior to this change trying to use object returned by iterating over PyObject would fail after iterator is closed, because iterator would dispose...

X Description: What does this implement/fix? Explain your changes. Prior to this change trying to use object returned by iterating over PyObject would fail after iterator is closed, because iterator would dispose...

Opengraph URL: https://github.com/pythonnet/pythonnet/pull/1331

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1d70d61c-daaf-5992-8dd3-6178ca4cf449
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD64:7B6E4:20F0455:2CB7DF2:697085A3
html-safe-nonce0041cac4c3afe7098a1eed6c6bc8fb0bdcdb70c4af54dd3a0859a9177b56e113
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDY0OjdCNkU0OjIwRjA0NTU6MkNCN0RGMjo2OTcwODVBMyIsInZpc2l0b3JfaWQiOiI0NTkyNDQ0NTkyNDgwMDkzNjAzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc67599ac7140cb83b0563abe043050c7495ca8ae401365824acf43231061d5ca
hovercard-subject-tagpull_request:542188245
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/1331/files
twitter:imagehttps://avatars.githubusercontent.com/u/239520?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/239520?s=400&v=4
og:image:altWhat does this implement/fix? Explain your changes. Prior to this change trying to use object returned by iterating over PyObject would fail after iterator is closed, because iterator would dispose...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git
octolytics-dimension-user_id6050430
octolytics-dimension-user_loginpythonnet
octolytics-dimension-repository_id14748123
octolytics-dimension-repository_nwopythonnet/pythonnet
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id14748123
octolytics-dimension-repository_network_root_nwopythonnet/pythonnet
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7d6181066430cc06553c8396ca201e194ae33cb9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/pythonnet/pythonnet/pull/1331/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1331%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1331%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=pythonnet%2Fpythonnet
Reloadhttps://github.com/pythonnet/pythonnet/pull/1331/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1331/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1331/files
pythonnet https://github.com/pythonnet
pythonnethttps://github.com/pythonnet/pythonnet
Notifications https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Fork 770 https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Star 5.4k https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Code https://github.com/pythonnet/pythonnet
Issues 155 https://github.com/pythonnet/pythonnet/issues
Pull requests 18 https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects 0 https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/pythonnet/pythonnet/security
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1331/files
Insights https://github.com/pythonnet/pythonnet/pulse
Code https://github.com/pythonnet/pythonnet
Issues https://github.com/pythonnet/pythonnet/issues
Pull requests https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security https://github.com/pythonnet/pythonnet/security
Insights https://github.com/pythonnet/pythonnet/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
filmorhttps://github.com/filmor
pythonnet:masterhttps://github.com/pythonnet/pythonnet/tree/master
losttech:PyIterFixeshttps://github.com/losttech/pythonnet/tree/PyIterFixes
Conversation 2 https://github.com/pythonnet/pythonnet/pull/1331
Commits 1 https://github.com/pythonnet/pythonnet/pull/1331/commits
Checks 0 https://github.com/pythonnet/pythonnet/pull/1331/checks
Files changed https://github.com/pythonnet/pythonnet/pull/1331/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1331/files
PyIter: do not force dispose previous object upon moving to the next one https://github.com/pythonnet/pythonnet/pull/1331/files#top
Show all changes 1 commit https://github.com/pythonnet/pythonnet/pull/1331/files
cebc515 PyIter: do not force dispose previous object upon moving to the next one lostmsu Dec 17, 2020 https://github.com/pythonnet/pythonnet/pull/1331/commits/cebc51536201bcb4173046d93b26e4f5f3047fd2
Clear filters https://github.com/pythonnet/pythonnet/pull/1331/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1331/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1331/files
CHANGELOG.md https://github.com/pythonnet/pythonnet/pull/1331/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
TestPyIter.cs https://github.com/pythonnet/pythonnet/pull/1331/files#diff-0cd4832c15b7881ebbc36db5a0930db1e1ead22f706c7444bd1e85522ef463fb
pyiter.cs https://github.com/pythonnet/pythonnet/pull/1331/files#diff-18a3e019a0fab5bdcce1d25f66b91985918fe0a488a81bacd2aa085b400d952f
pyobject.cs https://github.com/pythonnet/pythonnet/pull/1331/files#diff-c7afe47ee5bee58846cafad6ec4ecedb222d846124e7aec56bb7f62df0340392
runtime.cs https://github.com/pythonnet/pythonnet/pull/1331/files#diff-f1749bdd9f64fdac5c64d5cb0982ce1dac5e2d9a2cdd55b93d3f83b5047a855d
CHANGELOG.mdhttps://github.com/pythonnet/pythonnet/pull/1331/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
View file https://github.com/losttech/pythonnet/blob/cebc51536201bcb4173046d93b26e4f5f3047fd2/CHANGELOG.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1331/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1331/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
https://github.com/pythonnet/pythonnet/pull/1331/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
https://github.com/pythonnet/pythonnet/pull/1331/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
src/embed_tests/TestPyIter.cshttps://github.com/pythonnet/pythonnet/pull/1331/files#diff-0cd4832c15b7881ebbc36db5a0930db1e1ead22f706c7444bd1e85522ef463fb
View file https://github.com/losttech/pythonnet/blob/cebc51536201bcb4173046d93b26e4f5f3047fd2/src/embed_tests/TestPyIter.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1331/{{ revealButtonHref }}
src/runtime/pyiter.cshttps://github.com/pythonnet/pythonnet/pull/1331/files#diff-18a3e019a0fab5bdcce1d25f66b91985918fe0a488a81bacd2aa085b400d952f
View file https://github.com/losttech/pythonnet/blob/cebc51536201bcb4173046d93b26e4f5f3047fd2/src/runtime/pyiter.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1331/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1331/files#diff-18a3e019a0fab5bdcce1d25f66b91985918fe0a488a81bacd2aa085b400d952f
https://github.com/pythonnet/pythonnet/pull/1331/files#diff-18a3e019a0fab5bdcce1d25f66b91985918fe0a488a81bacd2aa085b400d952f
https://github.com/pythonnet/pythonnet/pull/1331/files#diff-18a3e019a0fab5bdcce1d25f66b91985918fe0a488a81bacd2aa085b400d952f
src/runtime/pyobject.cshttps://github.com/pythonnet/pythonnet/pull/1331/files#diff-c7afe47ee5bee58846cafad6ec4ecedb222d846124e7aec56bb7f62df0340392
View file https://github.com/losttech/pythonnet/blob/cebc51536201bcb4173046d93b26e4f5f3047fd2/src/runtime/pyobject.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1331/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1331/files#diff-c7afe47ee5bee58846cafad6ec4ecedb222d846124e7aec56bb7f62df0340392
https://github.com/pythonnet/pythonnet/pull/1331/files#diff-c7afe47ee5bee58846cafad6ec4ecedb222d846124e7aec56bb7f62df0340392
https://github.com/pythonnet/pythonnet/pull/1331/files#diff-c7afe47ee5bee58846cafad6ec4ecedb222d846124e7aec56bb7f62df0340392
https://github.com/pythonnet/pythonnet/pull/1331/files#diff-c7afe47ee5bee58846cafad6ec4ecedb222d846124e7aec56bb7f62df0340392
src/runtime/runtime.cshttps://github.com/pythonnet/pythonnet/pull/1331/files#diff-f1749bdd9f64fdac5c64d5cb0982ce1dac5e2d9a2cdd55b93d3f83b5047a855d
View file https://github.com/losttech/pythonnet/blob/cebc51536201bcb4173046d93b26e4f5f3047fd2/src/runtime/runtime.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1331/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1331/files#diff-f1749bdd9f64fdac5c64d5cb0982ce1dac5e2d9a2cdd55b93d3f83b5047a855d
filmorhttps://github.com/filmor
Dec 18, 2020https://github.com/pythonnet/pythonnet/pull/1331/files#r545802668
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1331/files
lostmsuhttps://github.com/lostmsu
Dec 18, 2020https://github.com/pythonnet/pythonnet/pull/1331/files#r546008572
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1331/files
https://github.com/pythonnet/pythonnet/pull/1331/files#diff-f1749bdd9f64fdac5c64d5cb0982ce1dac5e2d9a2cdd55b93d3f83b5047a855d
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.