Title: Fixed segfault in ClassDerived.tp_dealloc by lostmsu · Pull Request #1330 · pythonnet/pythonnet · GitHub
Open Graph Title: Fixed segfault in ClassDerived.tp_dealloc by lostmsu · Pull Request #1330 · pythonnet/pythonnet
X Title: Fixed segfault in ClassDerived.tp_dealloc by lostmsu · Pull Request #1330 · pythonnet/pythonnet
Description: What caused the problem + fixes All reflected .NET types stored GCHandle pointing to their implementations past the last byte of PyTypeObject. By adding IntPtr.Size to the size of PyTypeObject for CLR metatype we ensure, that the necessary space is allocated without relying on Python never writing immediately after type instances. In ClassDerivedObject tp_dealloc tried to use tpHandle which was previously NULLed in tp_clear. Fortunately, tpHandle in ClassDerivedObject is merely a duplicate of PyObject_TYPE(pyHandle), so could be read from there. Does this close any currently open issues? #1327
Open Graph Description: What caused the problem + fixes All reflected .NET types stored GCHandle pointing to their implementations past the last byte of PyTypeObject. By adding IntPtr.Size to the size of PyTypeObject fo...
X Description: What caused the problem + fixes All reflected .NET types stored GCHandle pointing to their implementations past the last byte of PyTypeObject. By adding IntPtr.Size to the size of PyTypeObject fo...
Opengraph URL: https://github.com/pythonnet/pythonnet/pull/1330
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:e5534748-78e0-3eaa-c312-b6ace8d863a1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C158:337755:1270105:1899B02:69702E09 |
| html-safe-nonce | 0b0acbbdad29aa5dd37ff61d372c709d7c1c0e651d7f2d3104461aa966907671 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTU4OjMzNzc1NToxMjcwMTA1OjE4OTlCMDI6Njk3MDJFMDkiLCJ2aXNpdG9yX2lkIjoiMjA3MTI5MTgxNDcwMTE4MjQ3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | bb4922b13a0bda665f4ab19de858b0d6178b99fce554f8837d0de9cd194fcb35 |
| hovercard-subject-tag | pull_request:542144056 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/1330/files |
| twitter:image | https://avatars.githubusercontent.com/u/239520?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/239520?s=400&v=4 |
| og:image:alt | What caused the problem + fixes All reflected .NET types stored GCHandle pointing to their implementations past the last byte of PyTypeObject. By adding IntPtr.Size to the size of PyTypeObject fo... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 01fa379f5de85ef8e791d09724e69709ce9eb9595278316e0a921312dc88e0bc |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git |
| octolytics-dimension-user_id | 6050430 |
| octolytics-dimension-user_login | pythonnet |
| octolytics-dimension-repository_id | 14748123 |
| octolytics-dimension-repository_nwo | pythonnet/pythonnet |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 14748123 |
| octolytics-dimension-repository_network_root_nwo | pythonnet/pythonnet |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | dda91974c069382b0dfa47b2da7e28bd061c8331 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width