René's URL Explorer Experiment


Title: Fix illegal delegate usage by BadSingleton · Pull Request #1328 · pythonnet/pythonnet · GitHub

Open Graph Title: Fix illegal delegate usage by BadSingleton · Pull Request #1328 · pythonnet/pythonnet

X Title: Fix illegal delegate usage by BadSingleton · Pull Request #1328 · pythonnet/pythonnet

Description: What does this implement/fix? Explain your changes. Cache the delegates to native code we've created so that when we need to call that delegate, we don't ask for a delegate from a native pointer (that is a delegate to managed code.) Does this close any currently open issues? This fixes issue #1323 . Any other comments? This is needed in order for #1287 to pass the domain reload tests on Mono. Checklist Check all those that are applicable and complete. Make sure to include one or more tests for your change If an enhancement PR, please create docs and at best an example Add yourself to AUTHORS Updated the CHANGELOG

Open Graph Description: What does this implement/fix? Explain your changes. Cache the delegates to native code we've created so that when we need to call that delegate, we don't ask for a delegate from a native po...

X Description: What does this implement/fix? Explain your changes. Cache the delegates to native code we've created so that when we need to call that delegate, we don't ask for a delegate from a n...

Opengraph URL: https://github.com/pythonnet/pythonnet/pull/1328

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9512897c-60b5-5903-54a7-79c5a79d44cf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC108:32E262:1258728:18A2B56:69702E32
html-safe-noncecda57206c4f6a8531e3009343fa1a7a1847fcf7c733a7bc7b8240f98d7bf9af0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTA4OjMyRTI2MjoxMjU4NzI4OjE4QTJCNTY6Njk3MDJFMzIiLCJ2aXNpdG9yX2lkIjoiNTM5OTMwMTkyNDcxMDI2NDM3MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac15fa680914f274dcb7f2166ee418b1d15741a8691292f3115ed60d78c2a42e60
hovercard-subject-tagpull_request:542044131
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/1328/files
twitter:imagehttps://avatars.githubusercontent.com/u/6788684?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/6788684?s=400&v=4
og:image:altWhat does this implement/fix? Explain your changes. Cache the delegates to native code we've created so that when we need to call that delegate, we don't ask for a delegate from a native po...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None01fa379f5de85ef8e791d09724e69709ce9eb9595278316e0a921312dc88e0bc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git
octolytics-dimension-user_id6050430
octolytics-dimension-user_loginpythonnet
octolytics-dimension-repository_id14748123
octolytics-dimension-repository_nwopythonnet/pythonnet
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id14748123
octolytics-dimension-repository_network_root_nwopythonnet/pythonnet
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedda91974c069382b0dfa47b2da7e28bd061c8331
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/pythonnet/pythonnet/pull/1328/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1328%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1328%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=pythonnet%2Fpythonnet
Reloadhttps://github.com/pythonnet/pythonnet/pull/1328/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1328/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1328/files
pythonnet https://github.com/pythonnet
pythonnethttps://github.com/pythonnet/pythonnet
Notifications https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Fork 770 https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Star 5.4k https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Code https://github.com/pythonnet/pythonnet
Issues 155 https://github.com/pythonnet/pythonnet/issues
Pull requests 18 https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects 0 https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/pythonnet/pythonnet/security
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1328/files
Insights https://github.com/pythonnet/pythonnet/pulse
Code https://github.com/pythonnet/pythonnet
Issues https://github.com/pythonnet/pythonnet/issues
Pull requests https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security https://github.com/pythonnet/pythonnet/security
Insights https://github.com/pythonnet/pythonnet/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
filmorhttps://github.com/filmor
pythonnet:masterhttps://github.com/pythonnet/pythonnet/tree/master
Unity-Technologies:fix_illegal_delegate_usagehttps://github.com/Unity-Technologies/pythonnet/tree/fix_illegal_delegate_usage
Conversation 6 https://github.com/pythonnet/pythonnet/pull/1328
Commits 2 https://github.com/pythonnet/pythonnet/pull/1328/commits
Checks 0 https://github.com/pythonnet/pythonnet/pull/1328/checks
Files changed https://github.com/pythonnet/pythonnet/pull/1328/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1328/files
Fix illegal delegate usage https://github.com/pythonnet/pythonnet/pull/1328/files#top
Show all changes 2 commits https://github.com/pythonnet/pythonnet/pull/1328/files
5d9f76f Fix illegal delegate usage BadSingleton Dec 17, 2020 https://github.com/pythonnet/pythonnet/pull/1328/commits/5d9f76f4815f8c2c178b76f1bc6644363d6df2d4
1325f59 Use the generic method BadSingleton Dec 18, 2020 https://github.com/pythonnet/pythonnet/pull/1328/commits/1325f5929bd84ca5da482cceeabdead351d39157
Clear filters https://github.com/pythonnet/pythonnet/pull/1328/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1328/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1328/files
interop.cs https://github.com/pythonnet/pythonnet/pull/1328/files#diff-7eb886c1d364dfa7cc2cb64d82ab08f50a157e87c830cb375fd0214ef0ebe3e9
managedtype.cs https://github.com/pythonnet/pythonnet/pull/1328/files#diff-9698e437a9f400bcc79315c7f340241208e63061364af646f25681fb19a966ef
nativecall.cs https://github.com/pythonnet/pythonnet/pull/1328/files#diff-c97ed69779ae3e5dadc953cab734b3c28a33f5adf80fec4c5b012faaf7b2b66f
src/runtime/interop.cshttps://github.com/pythonnet/pythonnet/pull/1328/files#diff-7eb886c1d364dfa7cc2cb64d82ab08f50a157e87c830cb375fd0214ef0ebe3e9
View file https://github.com/Unity-Technologies/pythonnet/blob/1325f5929bd84ca5da482cceeabdead351d39157/src/runtime/interop.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1328/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1328/files#diff-7eb886c1d364dfa7cc2cb64d82ab08f50a157e87c830cb375fd0214ef0ebe3e9
https://github.com/pythonnet/pythonnet/pull/1328/files#diff-7eb886c1d364dfa7cc2cb64d82ab08f50a157e87c830cb375fd0214ef0ebe3e9
https://github.com/pythonnet/pythonnet/pull/1328/files#diff-7eb886c1d364dfa7cc2cb64d82ab08f50a157e87c830cb375fd0214ef0ebe3e9
src/runtime/managedtype.cshttps://github.com/pythonnet/pythonnet/pull/1328/files#diff-9698e437a9f400bcc79315c7f340241208e63061364af646f25681fb19a966ef
View file https://github.com/Unity-Technologies/pythonnet/blob/1325f5929bd84ca5da482cceeabdead351d39157/src/runtime/managedtype.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1328/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1328/files#diff-9698e437a9f400bcc79315c7f340241208e63061364af646f25681fb19a966ef
https://github.com/pythonnet/pythonnet/pull/1328/files#diff-9698e437a9f400bcc79315c7f340241208e63061364af646f25681fb19a966ef
https://github.com/pythonnet/pythonnet/pull/1328/files#diff-9698e437a9f400bcc79315c7f340241208e63061364af646f25681fb19a966ef
https://github.com/pythonnet/pythonnet/pull/1328/files#diff-9698e437a9f400bcc79315c7f340241208e63061364af646f25681fb19a966ef
src/runtime/nativecall.cshttps://github.com/pythonnet/pythonnet/pull/1328/files#diff-c97ed69779ae3e5dadc953cab734b3c28a33f5adf80fec4c5b012faaf7b2b66f
View file https://github.com/Unity-Technologies/pythonnet/blob/1325f5929bd84ca5da482cceeabdead351d39157/src/runtime/nativecall.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1328/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1328/files#diff-c97ed69779ae3e5dadc953cab734b3c28a33f5adf80fec4c5b012faaf7b2b66f
lostmsuhttps://github.com/lostmsu
Dec 18, 2020https://github.com/pythonnet/pythonnet/pull/1328/files#r546009704
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1328/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1328/files
benoithudsonhttps://github.com/benoithudson
Dec 18, 2020https://github.com/pythonnet/pythonnet/pull/1328/files#r545959987
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1328/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.