René's URL Explorer Experiment


Title: Fixed CollectBasicObject test by lostmsu · Pull Request #1313 · pythonnet/pythonnet · GitHub

Open Graph Title: Fixed CollectBasicObject test by lostmsu · Pull Request #1313 · pythonnet/pythonnet

X Title: Fixed CollectBasicObject test by lostmsu · Pull Request #1313 · pythonnet/pythonnet

Description: This contains two fixes, that must go along for the tests to pass: Fixed the CollectBasicObject and CollectOnShutdown tests for Mono by fixing MakeAGarbage function to not keep the garbage on the stack during a conservative roots scan (looks like Mono scans some variables, that are already gone). Fixed the crash during runtime shutdown by further simplifying Finalizer to only store raw pointers to python objects instead of instances of IPyDisposable and thus replacing Dispose with reliable and simple DecRef. This removes some functions from Finalizer, which previously were public, but should not have been.

Open Graph Description: This contains two fixes, that must go along for the tests to pass: Fixed the CollectBasicObject and CollectOnShutdown tests for Mono by fixing MakeAGarbage function to not keep the garbage on the ...

X Description: This contains two fixes, that must go along for the tests to pass: Fixed the CollectBasicObject and CollectOnShutdown tests for Mono by fixing MakeAGarbage function to not keep the garbage on the ...

Opengraph URL: https://github.com/pythonnet/pythonnet/pull/1313

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:bc7e28b5-9e3b-a5a6-4ee0-45355a83552f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8946:AF22:1339CE7:1ADADDC:6972693D
html-safe-nonced890dca1b03808d90415870b51e08aa15d5c379259c3792e414bbafa588c82c4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTQ2OkFGMjI6MTMzOUNFNzoxQURBRERDOjY5NzI2OTNEIiwidmlzaXRvcl9pZCI6IjM3MzE1NjAwNjc3Njk3MjMxOTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace0d6f0e5adca5327c4a2eeba83fa83cb9727f81c67c19d7ceabdf89491f822d4
hovercard-subject-tagpull_request:536285165
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/1313/files
twitter:imagehttps://avatars.githubusercontent.com/u/239520?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/239520?s=400&v=4
og:image:altThis contains two fixes, that must go along for the tests to pass: Fixed the CollectBasicObject and CollectOnShutdown tests for Mono by fixing MakeAGarbage function to not keep the garbage on the ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneab2c8e6ec49d8737f6bf007a86b2c4a2bc434bba562c524e0c76465bc9ed358b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git
octolytics-dimension-user_id6050430
octolytics-dimension-user_loginpythonnet
octolytics-dimension-repository_id14748123
octolytics-dimension-repository_nwopythonnet/pythonnet
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id14748123
octolytics-dimension-repository_network_root_nwopythonnet/pythonnet
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release76f982acc7b406671507aee04f00d64414a22dbf
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/pythonnet/pythonnet/pull/1313/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1313%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1313%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=pythonnet%2Fpythonnet
Reloadhttps://github.com/pythonnet/pythonnet/pull/1313/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1313/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1313/files
pythonnet https://github.com/pythonnet
pythonnethttps://github.com/pythonnet/pythonnet
Notifications https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Fork 770 https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Star 5.4k https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Code https://github.com/pythonnet/pythonnet
Issues 155 https://github.com/pythonnet/pythonnet/issues
Pull requests 18 https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects 0 https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security 0 https://github.com/pythonnet/pythonnet/security
Insights https://github.com/pythonnet/pythonnet/pulse
Code https://github.com/pythonnet/pythonnet
Issues https://github.com/pythonnet/pythonnet/issues
Pull requests https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security https://github.com/pythonnet/pythonnet/security
Insights https://github.com/pythonnet/pythonnet/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
filmorhttps://github.com/filmor
pythonnet:masterhttps://github.com/pythonnet/pythonnet/tree/master
losttech:bugs/1309https://github.com/losttech/pythonnet/tree/bugs/1309
Conversation 4 https://github.com/pythonnet/pythonnet/pull/1313
Commits 3 https://github.com/pythonnet/pythonnet/pull/1313/commits
Checks 0 https://github.com/pythonnet/pythonnet/pull/1313/checks
Files changed https://github.com/pythonnet/pythonnet/pull/1313/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1313/files
Fixed CollectBasicObject test https://github.com/pythonnet/pythonnet/pull/1313/files#top
Show all changes 3 commits https://github.com/pythonnet/pythonnet/pull/1313/files
d888244 fixed CollectBasicObject by ensuring MakeAGarbage is not keeping temp… lostmsu Dec 10, 2020 https://github.com/pythonnet/pythonnet/pull/1313/commits/d88824415637842c8c46ca09355118bd2efd8de2
ff86507 reworked Finalizer to only store raw python object handles instead of… lostmsu Dec 11, 2020 https://github.com/pythonnet/pythonnet/pull/1313/commits/ff8650768b0eb9c0c05ec1790bfa22e4dc88de77
ca96444 fixed domain reload test, that tries to call static method from objec… lostmsu Dec 11, 2020 https://github.com/pythonnet/pythonnet/pull/1313/commits/ca96444017b46c3a638f6f18d07feb7fe48641f1
Clear filters https://github.com/pythonnet/pythonnet/pull/1313/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1313/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1313/files
TestDomainReload.cs https://github.com/pythonnet/pythonnet/pull/1313/files#diff-bcaca7eb88b9a4ae8e809aa8855c0d4e5b3890a304bf50c6499ac582833e86bf
TestFinalizer.cs https://github.com/pythonnet/pythonnet/pull/1313/files#diff-e9a94cc6a88676dbefe363a0819da5a6c2ab46beab1af5eb242966c5cbb35423
debughelper.cs https://github.com/pythonnet/pythonnet/pull/1313/files#diff-864d42dc105d8a29db9605ee1ec02f9d8cf2055107b40e126d0266d539a2a6d3
delegatemanager.cs https://github.com/pythonnet/pythonnet/pull/1313/files#diff-3b1b6e900caa2518c55500e3d4c4baf9c8a5705c4564e714bd090f4c5c46516f
finalizer.cs https://github.com/pythonnet/pythonnet/pull/1313/files#diff-1f4c2a463fbd7ab7933dafc01bb93aa3561f5afdcf54be6d22a3029433b82984
pybuffer.cs https://github.com/pythonnet/pythonnet/pull/1313/files#diff-175d81aaebd0115ffd789b3d6ed302b92dfc7fd1926242b74e2be1c1acdc1854
pylong.cs https://github.com/pythonnet/pythonnet/pull/1313/files#diff-5035265f1c2785f00e884323e85f5ee2bdcccf8f30162a05c9175d536747fc18
pyobject.cs https://github.com/pythonnet/pythonnet/pull/1313/files#diff-c7afe47ee5bee58846cafad6ec4ecedb222d846124e7aec56bb7f62df0340392
pyscope.cs https://github.com/pythonnet/pythonnet/pull/1313/files#diff-5a93f5d2b3df2777f89c8024e7880191f13b1ab50eac398d33f143ccc30ead64
pythonexception.cs https://github.com/pythonnet/pythonnet/pull/1313/files#diff-b068aae9f1f56cdc70d0931b63265b8a10510a62ae9a2814f22801a94eb46bae
src/embed_tests/TestDomainReload.cshttps://github.com/pythonnet/pythonnet/pull/1313/files#diff-bcaca7eb88b9a4ae8e809aa8855c0d4e5b3890a304bf50c6499ac582833e86bf
View file https://github.com/losttech/pythonnet/blob/ca96444017b46c3a638f6f18d07feb7fe48641f1/src/embed_tests/TestDomainReload.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1313/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1313/files#diff-bcaca7eb88b9a4ae8e809aa8855c0d4e5b3890a304bf50c6499ac582833e86bf
https://github.com/pythonnet/pythonnet/pull/1313/files#diff-bcaca7eb88b9a4ae8e809aa8855c0d4e5b3890a304bf50c6499ac582833e86bf
https://github.com/pythonnet/pythonnet/pull/1313/files#diff-bcaca7eb88b9a4ae8e809aa8855c0d4e5b3890a304bf50c6499ac582833e86bf
https://github.com/pythonnet/pythonnet/pull/1313/files#diff-bcaca7eb88b9a4ae8e809aa8855c0d4e5b3890a304bf50c6499ac582833e86bf
https://github.com/pythonnet/pythonnet/pull/1313/files#diff-bcaca7eb88b9a4ae8e809aa8855c0d4e5b3890a304bf50c6499ac582833e86bf
https://github.com/pythonnet/pythonnet/pull/1313/files#diff-bcaca7eb88b9a4ae8e809aa8855c0d4e5b3890a304bf50c6499ac582833e86bf
src/embed_tests/TestFinalizer.cshttps://github.com/pythonnet/pythonnet/pull/1313/files#diff-e9a94cc6a88676dbefe363a0819da5a6c2ab46beab1af5eb242966c5cbb35423
View file https://github.com/losttech/pythonnet/blob/ca96444017b46c3a638f6f18d07feb7fe48641f1/src/embed_tests/TestFinalizer.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1313/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1313/files#diff-e9a94cc6a88676dbefe363a0819da5a6c2ab46beab1af5eb242966c5cbb35423
https://github.com/pythonnet/pythonnet/pull/1313/files#diff-e9a94cc6a88676dbefe363a0819da5a6c2ab46beab1af5eb242966c5cbb35423
https://github.com/pythonnet/pythonnet/pull/1313/files#diff-e9a94cc6a88676dbefe363a0819da5a6c2ab46beab1af5eb242966c5cbb35423
https://github.com/pythonnet/pythonnet/pull/1313/files#diff-e9a94cc6a88676dbefe363a0819da5a6c2ab46beab1af5eb242966c5cbb35423
https://github.com/pythonnet/pythonnet/pull/1313/files#diff-e9a94cc6a88676dbefe363a0819da5a6c2ab46beab1af5eb242966c5cbb35423
filmorhttps://github.com/filmor
Dec 11, 2020https://github.com/pythonnet/pythonnet/pull/1313/files#r540716615
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://docs.nunit.org/articles/nunit/writing-tests/attributes/retry.htmlhttps://docs.nunit.org/articles/nunit/writing-tests/attributes/retry.html
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1313/files
lostmsuhttps://github.com/lostmsu
Dec 11, 2020https://github.com/pythonnet/pythonnet/pull/1313/files#r541232682
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1313/files
https://github.com/pythonnet/pythonnet/pull/1313/files#diff-e9a94cc6a88676dbefe363a0819da5a6c2ab46beab1af5eb242966c5cbb35423
https://github.com/pythonnet/pythonnet/pull/1313/files#diff-e9a94cc6a88676dbefe363a0819da5a6c2ab46beab1af5eb242966c5cbb35423
https://github.com/pythonnet/pythonnet/pull/1313/files#diff-e9a94cc6a88676dbefe363a0819da5a6c2ab46beab1af5eb242966c5cbb35423
https://github.com/pythonnet/pythonnet/pull/1313/files#diff-e9a94cc6a88676dbefe363a0819da5a6c2ab46beab1af5eb242966c5cbb35423
src/runtime/debughelper.cshttps://github.com/pythonnet/pythonnet/pull/1313/files#diff-864d42dc105d8a29db9605ee1ec02f9d8cf2055107b40e126d0266d539a2a6d3
View file https://github.com/losttech/pythonnet/blob/ca96444017b46c3a638f6f18d07feb7fe48641f1/src/runtime/debughelper.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1313/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1313/files#diff-864d42dc105d8a29db9605ee1ec02f9d8cf2055107b40e126d0266d539a2a6d3
src/runtime/delegatemanager.cshttps://github.com/pythonnet/pythonnet/pull/1313/files#diff-3b1b6e900caa2518c55500e3d4c4baf9c8a5705c4564e714bd090f4c5c46516f
View file https://github.com/losttech/pythonnet/blob/ca96444017b46c3a638f6f18d07feb7fe48641f1/src/runtime/delegatemanager.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1313/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1313/files#diff-3b1b6e900caa2518c55500e3d4c4baf9c8a5705c4564e714bd090f4c5c46516f
https://github.com/pythonnet/pythonnet/pull/1313/files#diff-3b1b6e900caa2518c55500e3d4c4baf9c8a5705c4564e714bd090f4c5c46516f
https://github.com/pythonnet/pythonnet/pull/1313/files#diff-3b1b6e900caa2518c55500e3d4c4baf9c8a5705c4564e714bd090f4c5c46516f
https://github.com/pythonnet/pythonnet/pull/1313/files#diff-3b1b6e900caa2518c55500e3d4c4baf9c8a5705c4564e714bd090f4c5c46516f
https://github.com/pythonnet/pythonnet/pull/1313/files#diff-3b1b6e900caa2518c55500e3d4c4baf9c8a5705c4564e714bd090f4c5c46516f
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1313/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.