Title: Fixed CollectBasicObject test by lostmsu · Pull Request #1313 · pythonnet/pythonnet · GitHub
Open Graph Title: Fixed CollectBasicObject test by lostmsu · Pull Request #1313 · pythonnet/pythonnet
X Title: Fixed CollectBasicObject test by lostmsu · Pull Request #1313 · pythonnet/pythonnet
Description: This contains two fixes, that must go along for the tests to pass: Fixed the CollectBasicObject and CollectOnShutdown tests for Mono by fixing MakeAGarbage function to not keep the garbage on the stack during a conservative roots scan (looks like Mono scans some variables, that are already gone). Fixed the crash during runtime shutdown by further simplifying Finalizer to only store raw pointers to python objects instead of instances of IPyDisposable and thus replacing Dispose with reliable and simple DecRef. This removes some functions from Finalizer, which previously were public, but should not have been.
Open Graph Description: This contains two fixes, that must go along for the tests to pass: Fixed the CollectBasicObject and CollectOnShutdown tests for Mono by fixing MakeAGarbage function to not keep the garbage on the ...
X Description: This contains two fixes, that must go along for the tests to pass: Fixed the CollectBasicObject and CollectOnShutdown tests for Mono by fixing MakeAGarbage function to not keep the garbage on the ...
Opengraph URL: https://github.com/pythonnet/pythonnet/pull/1313
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:84fa14e6-004e-1556-6364-69260ca90df9 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | B11E:EAF27:9EE957:CFDA0F:69716DA8 |
| html-safe-nonce | 5fb38211ffced9ecf119b284dad06f228d5c33ffdbf028edd3489d10faabfac3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTFFOkVBRjI3OjlFRTk1NzpDRkRBMEY6Njk3MTZEQTgiLCJ2aXNpdG9yX2lkIjoiNDI0MjY3ODQyODg3NzI4NjgyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e96ae0d406cee57cc59b16993f24fcc0cb36c3b01f3bac868bb2141b2eb9daf0 |
| hovercard-subject-tag | pull_request:536285165 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/1313/checks |
| twitter:image | https://avatars.githubusercontent.com/u/239520?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/239520?s=400&v=4 |
| og:image:alt | This contains two fixes, that must go along for the tests to pass: Fixed the CollectBasicObject and CollectOnShutdown tests for Mono by fixing MakeAGarbage function to not keep the garbage on the ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 353479110ec1e87d687013548f216c852055ec907d09d2fb6a180cb5ed9d28e1 |
| turbo-cache-control | no-preview |
| go-import | github.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git |
| octolytics-dimension-user_id | 6050430 |
| octolytics-dimension-user_login | pythonnet |
| octolytics-dimension-repository_id | 14748123 |
| octolytics-dimension-repository_nwo | pythonnet/pythonnet |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 14748123 |
| octolytics-dimension-repository_network_root_nwo | pythonnet/pythonnet |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a4c7e274c03a115b82dcef6c47ce3f7f903e88e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width