Title: Domain reload test cases fixes by BadSingleton · Pull Request #1287 · pythonnet/pythonnet · GitHub
Open Graph Title: Domain reload test cases fixes by BadSingleton · Pull Request #1287 · pythonnet/pythonnet
X Title: Domain reload test cases fixes by BadSingleton · Pull Request #1287 · pythonnet/pythonnet
Description: What does this implement/fix? Explain your changes. This PR adds the fixes for the xfail tests in #1275 . Serialization of System.Type, MemberInfo and MethodBase is now string based. At de-serialization, use reflection to attempt to recreate the object, which now fails safely instead of throwing a SerializationException during the de-serialization of the whole data stream. Appropriate Exceptions will now be raised when the Maybe*'s Value property is accessed. Does this close any currently open issues? This addresses #957 and #1250 and offers an answer to #1268 . Any other comments? TODO: add changelog entries once the fixes are approved. Also, add docs on best practices with domain reloads. Checklist Check all those that are applicable and complete. Make sure to include one or more tests for your change If an enhancement PR, please create docs and at best an example Add yourself to AUTHORS Updated the CHANGELOG
Open Graph Description: What does this implement/fix? Explain your changes. This PR adds the fixes for the xfail tests in #1275 . Serialization of System.Type, MemberInfo and MethodBase is now string based. At de-serializ...
X Description: What does this implement/fix? Explain your changes. This PR adds the fixes for the xfail tests in #1275 . Serialization of System.Type, MemberInfo and MethodBase is now string based. At de-serializ...
Opengraph URL: https://github.com/pythonnet/pythonnet/pull/1287
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:fcfd7591-df8b-ce98-b492-950aa8624da1 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | 9EC8:3E5B37:3DA3DDF:5617276:69713151 |
| html-safe-nonce | 6858f56d370dfc19c13e84152eddae9737267975cf59130cb4539804d0a12277 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUM4OjNFNUIzNzozREEzRERGOjU2MTcyNzY6Njk3MTMxNTEiLCJ2aXNpdG9yX2lkIjoiMjM2MDMxNTI3MjQ4NTM5OTg1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | df1bb65b9e80721f8eca7b6b3f9d816dfd6f68ab1543fb2cc6c9008b9b0102a8 |
| hovercard-subject-tag | pull_request:524096527 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/1287/checks |
| twitter:image | https://avatars.githubusercontent.com/u/6788684?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/6788684?s=400&v=4 |
| og:image:alt | What does this implement/fix? Explain your changes. This PR adds the fixes for the xfail tests in #1275 . Serialization of System.Type, MemberInfo and MethodBase is now string based. At de-serializ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 235f189cb7458700436eaa6676a45f9abab16ecdfb4be6cc339f24abaa820b19 |
| turbo-cache-control | no-preview |
| go-import | github.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git |
| octolytics-dimension-user_id | 6050430 |
| octolytics-dimension-user_login | pythonnet |
| octolytics-dimension-repository_id | 14748123 |
| octolytics-dimension-repository_nwo | pythonnet/pythonnet |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 14748123 |
| octolytics-dimension-repository_network_root_nwo | pythonnet/pythonnet |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e26123de62cafb036ecaec64b7f90a01b4a7f823 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width