| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:e6b4e06c-3e96-8ed5-2d09-14c75b19a3a1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 91BE:AD4AF:B8F4FE:1020C9B:6970BB0D |
| html-safe-nonce | 39feb15f4252e1e008c98b7574afa89f21b113c432bbff17e070c19b8db76b68 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MUJFOkFENEFGOkI4RjRGRToxMDIwQzlCOjY5NzBCQjBEIiwidmlzaXRvcl9pZCI6IjI2MjEwODk4MDUxNjgwNjUyOTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 746776bad18782217cc6c62a695f12521312c75f4ba0210b1a124637a1ba71a9 |
| hovercard-subject-tag | pull_request:504421517 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/1265/files |
| twitter:image | https://avatars.githubusercontent.com/u/55871?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/55871?s=400&v=4 |
| og:image:alt | See https://docs.python.org/3/c-api/exceptions.html#c.PyErr_NormalizeException
What does this implement/fix? Explain your changes.
This fixes cases where some exceptions are "unnormalized"... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 8e0be80373b724b033cdf8a7b1f78bf5fb6a5d7a2182a9a403aa30894606e390 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git |
| octolytics-dimension-user_id | 6050430 |
| octolytics-dimension-user_login | pythonnet |
| octolytics-dimension-repository_id | 14748123 |
| octolytics-dimension-repository_nwo | pythonnet/pythonnet |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 14748123 |
| octolytics-dimension-repository_network_root_nwo | pythonnet/pythonnet |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 84d9d5bf3b01412ea10f7c2429cbfc735ccce9ce |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/pythonnet/pythonnet/pull/1265/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1265%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1265%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=pythonnet%2Fpythonnet |
| Reload | https://github.com/pythonnet/pythonnet/pull/1265/files |
| Reload | https://github.com/pythonnet/pythonnet/pull/1265/files |
| Reload | https://github.com/pythonnet/pythonnet/pull/1265/files |
|
pythonnet
| https://github.com/pythonnet |
| pythonnet | https://github.com/pythonnet/pythonnet |
|
Notifications
| https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet |
|
Fork
770
| https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet |
|
Star
5.4k
| https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet |
|
Code
| https://github.com/pythonnet/pythonnet |
|
Issues
155
| https://github.com/pythonnet/pythonnet/issues |
|
Pull requests
18
| https://github.com/pythonnet/pythonnet/pulls |
|
Discussions
| https://github.com/pythonnet/pythonnet/discussions |
|
Actions
| https://github.com/pythonnet/pythonnet/actions |
|
Projects
0
| https://github.com/pythonnet/pythonnet/projects |
|
Wiki
| https://github.com/pythonnet/pythonnet/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/pythonnet/pythonnet/security |
| Please reload this page | https://github.com/pythonnet/pythonnet/pull/1265/files |
|
Insights
| https://github.com/pythonnet/pythonnet/pulse |
|
Code
| https://github.com/pythonnet/pythonnet |
|
Issues
| https://github.com/pythonnet/pythonnet/issues |
|
Pull requests
| https://github.com/pythonnet/pythonnet/pulls |
|
Discussions
| https://github.com/pythonnet/pythonnet/discussions |
|
Actions
| https://github.com/pythonnet/pythonnet/actions |
|
Projects
| https://github.com/pythonnet/pythonnet/projects |
|
Wiki
| https://github.com/pythonnet/pythonnet/wiki |
|
Security
| https://github.com/pythonnet/pythonnet/security |
|
Insights
| https://github.com/pythonnet/pythonnet/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose |
| lostmsu | https://github.com/lostmsu |
| pythonnet:master | https://github.com/pythonnet/pythonnet/tree/master |
|
Conversation
14
| https://github.com/pythonnet/pythonnet/pull/1265 |
|
Commits
17
| https://github.com/pythonnet/pythonnet/pull/1265/commits |
|
Checks
0
| https://github.com/pythonnet/pythonnet/pull/1265/checks |
|
Files changed
4
| https://github.com/pythonnet/pythonnet/pull/1265/files |
|
Call PyErr_NormalizeException for exceptions
| https://github.com/pythonnet/pythonnet/pull/1265/files#top |
|
Show all changes
17 commits
| https://github.com/pythonnet/pythonnet/pull/1265/files |
|
84197d4
Call PyErr_NormalizeException for exceptions
slide Oct 15, 2020
| https://github.com/pythonnet/pythonnet/pull/1265/commits/84197d487839781c83139ed4b5347e5d317ae8fe |
|
eddd657
Add CHANGELOG entry
slide Oct 15, 2020
| https://github.com/pythonnet/pythonnet/pull/1265/commits/eddd65788ae624ead5b40204bd4e722f76c14d6f |
|
a923e99
Add test
slide Oct 15, 2020
| https://github.com/pythonnet/pythonnet/pull/1265/commits/a923e998b5626607217a0ba67d6a73c13512289c |
|
9b3d14b
Localize call to PyErr_NormalizeException to the Format method.
slide Oct 15, 2020
| https://github.com/pythonnet/pythonnet/pull/1265/commits/9b3d14b9996d72717e11db1d960c4fc3b51a5445 |
|
cc584dd
Merge branch 'master' into normalize_exceptions
slide Nov 12, 2020
| https://github.com/pythonnet/pythonnet/pull/1265/commits/cc584ddd91227b297877e097da00fd47d2247777 |
|
d1fe930
Merge branch 'master' into normalize_exceptions
slide Nov 17, 2020
| https://github.com/pythonnet/pythonnet/pull/1265/commits/d1fe930e96a1b0ccc41c6b7156a8be49ea793831 |
|
4229a38
Merge branch 'master' into normalize_exceptions
filmor Nov 18, 2020
| https://github.com/pythonnet/pythonnet/pull/1265/commits/4229a3832d1e6878361a680af67d71090ef8d151 |
|
04c8b66
Merge branch 'master' into normalize_exceptions
slide Nov 20, 2020
| https://github.com/pythonnet/pythonnet/pull/1265/commits/04c8b66a6fa669029e006b264cffec40d645794d |
|
95940aa
Merge branch 'master' into normalize_exceptions
filmor Dec 10, 2020
| https://github.com/pythonnet/pythonnet/pull/1265/commits/95940aa6be128842b1c6edc51ac4f2b695ec371c |
|
7a5ded5
Merge branch 'master' into normalize_exceptions
slide Dec 10, 2020
| https://github.com/pythonnet/pythonnet/pull/1265/commits/7a5ded5708644ee986e150478081e6500e783588 |
|
092e961
incref before the call to PyErr_NormalizeException
slide Nov 12, 2020
| https://github.com/pythonnet/pythonnet/pull/1265/commits/092e961bc49fd0ce7a1f5f4394fca70374d9beef |
|
caa0922
Add test for __init__ that causes exception
slide Dec 11, 2020
| https://github.com/pythonnet/pythonnet/pull/1265/commits/caa09225c1bf029db2d66922ced2b23a0576bbbb |
|
c28951f
Fix test for exception during normalization
slide Dec 14, 2020
| https://github.com/pythonnet/pythonnet/pull/1265/commits/c28951f086dbc845a4b1b498b4bae52aa2ceef90 |
|
4654330
Merge branch 'master' into normalize_exceptions
slide Dec 14, 2020
| https://github.com/pythonnet/pythonnet/pull/1265/commits/4654330cfb5a7a5bc6e813b0efcc71b64b5b3fa4 |
|
62a0b00
Merge branch 'master' into normalize_exceptions
slide Dec 18, 2020
| https://github.com/pythonnet/pythonnet/pull/1265/commits/62a0b00bde19e05b47bcc8cae67f007e12c01c99 |
|
4ac9c48
Fixup test
slide Dec 19, 2020
| https://github.com/pythonnet/pythonnet/pull/1265/commits/4ac9c48d3442b8fe63ed885340c79c2d05811e9e |
|
946aa1f
Merge branch 'normalize_exceptions' of github.com:slide/pythonnet int…
slide Dec 19, 2020
| https://github.com/pythonnet/pythonnet/pull/1265/commits/946aa1f8d4bc77af3bc97398b99b8994c42fc4b4 |
|
Clear filters
| https://github.com/pythonnet/pythonnet/pull/1265/files |
| Please reload this page | https://github.com/pythonnet/pythonnet/pull/1265/files |
| Please reload this page | https://github.com/pythonnet/pythonnet/pull/1265/files |
|
CHANGELOG.md
| https://github.com/pythonnet/pythonnet/pull/1265/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed |
|
TestPythonException.cs
| https://github.com/pythonnet/pythonnet/pull/1265/files#diff-c9e555a1a6d8032db5fa7b9ea5c17cdd44d1563f68ea8f1b2a8d4ac6d0a92172 |
|
pythonexception.cs
| https://github.com/pythonnet/pythonnet/pull/1265/files#diff-b068aae9f1f56cdc70d0931b63265b8a10510a62ae9a2814f22801a94eb46bae |
|
runtime.cs
| https://github.com/pythonnet/pythonnet/pull/1265/files#diff-f1749bdd9f64fdac5c64d5cb0982ce1dac5e2d9a2cdd55b93d3f83b5047a855d |
| CHANGELOG.md | https://github.com/pythonnet/pythonnet/pull/1265/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed |
|
View file
| https://github.com/pythonnet/pythonnet/blob/946aa1f8d4bc77af3bc97398b99b8994c42fc4b4/CHANGELOG.md |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/pythonnet/pythonnet/pull/1265/{{ revealButtonHref }} |
|
| https://github.com/pythonnet/pythonnet/pull/1265/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed |
|
| https://github.com/pythonnet/pythonnet/pull/1265/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed |
| src/embed_tests/TestPythonException.cs | https://github.com/pythonnet/pythonnet/pull/1265/files#diff-c9e555a1a6d8032db5fa7b9ea5c17cdd44d1563f68ea8f1b2a8d4ac6d0a92172 |
|
View file
| https://github.com/pythonnet/pythonnet/blob/946aa1f8d4bc77af3bc97398b99b8994c42fc4b4/src/embed_tests/TestPythonException.cs |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/pythonnet/pythonnet/pull/1265/{{ revealButtonHref }} |
|
| https://github.com/pythonnet/pythonnet/pull/1265/files#diff-c9e555a1a6d8032db5fa7b9ea5c17cdd44d1563f68ea8f1b2a8d4ac6d0a92172 |
| src/runtime/pythonexception.cs | https://github.com/pythonnet/pythonnet/pull/1265/files#diff-b068aae9f1f56cdc70d0931b63265b8a10510a62ae9a2814f22801a94eb46bae |
|
View file
| https://github.com/pythonnet/pythonnet/blob/946aa1f8d4bc77af3bc97398b99b8994c42fc4b4/src/runtime/pythonexception.cs |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/pythonnet/pythonnet/pull/1265/{{ revealButtonHref }} |
|
| https://github.com/pythonnet/pythonnet/pull/1265/files#diff-b068aae9f1f56cdc70d0931b63265b8a10510a62ae9a2814f22801a94eb46bae |
|
| https://github.com/pythonnet/pythonnet/pull/1265/files#diff-b068aae9f1f56cdc70d0931b63265b8a10510a62ae9a2814f22801a94eb46bae |
| src/runtime/runtime.cs | https://github.com/pythonnet/pythonnet/pull/1265/files#diff-f1749bdd9f64fdac5c64d5cb0982ce1dac5e2d9a2cdd55b93d3f83b5047a855d |
|
View file
| https://github.com/pythonnet/pythonnet/blob/946aa1f8d4bc77af3bc97398b99b8994c42fc4b4/src/runtime/runtime.cs |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/pythonnet/pythonnet/pull/1265/{{ revealButtonHref }} |
|
| https://github.com/pythonnet/pythonnet/pull/1265/files#diff-f1749bdd9f64fdac5c64d5cb0982ce1dac5e2d9a2cdd55b93d3f83b5047a855d |
|
| https://github.com/pythonnet/pythonnet/pull/1265/files#diff-f1749bdd9f64fdac5c64d5cb0982ce1dac5e2d9a2cdd55b93d3f83b5047a855d |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |