| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:20a47c30-a0f7-8dee-bb7c-8069aa0966c6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E0A4:28F9BD:30E8730:41C9CFB:697066F0 |
| html-safe-nonce | fbe32ecb8252608cc210be07d2382dd3868911a4ebcd768df1e999c363371317 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMEE0OjI4RjlCRDozMEU4NzMwOjQxQzlDRkI6Njk3MDY2RjAiLCJ2aXNpdG9yX2lkIjoiNTE4MjM2NTEwNjU2OTI0MjM1MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8b179bd98f1a14b07c21f9ce35d327e0b136f504dbf8411bdfad48eea28b2745 |
| hovercard-subject-tag | pull_request:500398866 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/pythonnet/pythonnet/1254/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a55a52877e0db60cecb65896e6ba567f2906b98138bc708ed7dc8df676fe9fe2/pythonnet/pythonnet/pull/1254 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a55a52877e0db60cecb65896e6ba567f2906b98138bc708ed7dc8df676fe9fe2/pythonnet/pythonnet/pull/1254 |
| og:image:alt | What does this implement/fix? Explain your changes.
Use the intern strings map to const strings instead of creating temporary strings everytimes.
Checklist
Check all those that are applicable and c... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | amos402 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2 |
| turbo-cache-control | no-preview |
| go-import | github.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git |
| octolytics-dimension-user_id | 6050430 |
| octolytics-dimension-user_login | pythonnet |
| octolytics-dimension-repository_id | 14748123 |
| octolytics-dimension-repository_nwo | pythonnet/pythonnet |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 14748123 |
| octolytics-dimension-repository_network_root_nwo | pythonnet/pythonnet |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7d6181066430cc06553c8396ca201e194ae33cb9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/pythonnet/pythonnet/pull/1254#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1254 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1254 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=pythonnet%2Fpythonnet |
| Reload | https://github.com/pythonnet/pythonnet/pull/1254 |
| Reload | https://github.com/pythonnet/pythonnet/pull/1254 |
| Reload | https://github.com/pythonnet/pythonnet/pull/1254 |
|
pythonnet
| https://github.com/pythonnet |
| pythonnet | https://github.com/pythonnet/pythonnet |
|
Notifications
| https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet |
|
Fork
770
| https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet |
|
Star
5.4k
| https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet |
|
Code
| https://github.com/pythonnet/pythonnet |
|
Issues
155
| https://github.com/pythonnet/pythonnet/issues |
|
Pull requests
18
| https://github.com/pythonnet/pythonnet/pulls |
|
Discussions
| https://github.com/pythonnet/pythonnet/discussions |
|
Actions
| https://github.com/pythonnet/pythonnet/actions |
|
Projects
0
| https://github.com/pythonnet/pythonnet/projects |
|
Wiki
| https://github.com/pythonnet/pythonnet/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/pythonnet/pythonnet/security |
| Please reload this page | https://github.com/pythonnet/pythonnet/pull/1254 |
|
Insights
| https://github.com/pythonnet/pythonnet/pulse |
|
Code
| https://github.com/pythonnet/pythonnet |
|
Issues
| https://github.com/pythonnet/pythonnet/issues |
|
Pull requests
| https://github.com/pythonnet/pythonnet/pulls |
|
Discussions
| https://github.com/pythonnet/pythonnet/discussions |
|
Actions
| https://github.com/pythonnet/pythonnet/actions |
|
Projects
| https://github.com/pythonnet/pythonnet/projects |
|
Wiki
| https://github.com/pythonnet/pythonnet/wiki |
|
Security
| https://github.com/pythonnet/pythonnet/security |
|
Insights
| https://github.com/pythonnet/pythonnet/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/pythonnet/pythonnet/pull/1254#issue-comment-box |
| lostmsu | https://github.com/lostmsu |
| pythonnet:master | https://github.com/pythonnet/pythonnet/tree/master |
| amos402:intern-string | https://github.com/amos402/pythonnet/tree/intern-string |
|
Intern string
| https://github.com/pythonnet/pythonnet/pull/1254#top |
| lostmsu | https://github.com/lostmsu |
| pythonnet:master | https://github.com/pythonnet/pythonnet/tree/master |
| amos402:intern-string | https://github.com/amos402/pythonnet/tree/intern-string |
|
Conversation
15
| https://github.com/pythonnet/pythonnet/pull/1254 |
|
Commits
2
| https://github.com/pythonnet/pythonnet/pull/1254/commits |
|
Checks
0
| https://github.com/pythonnet/pythonnet/pull/1254/checks |
|
Files changed
| https://github.com/pythonnet/pythonnet/pull/1254/files |
| Please reload this page | https://github.com/pythonnet/pythonnet/pull/1254 |
| https://github.co/hiddenchars |
| https://github.com/pythonnet/pythonnet/pull/{{ revealButtonHref }} |
|
| https://github.com/amos402 |
| amos402 | https://github.com/amos402 |
| Oct 9, 2020 | https://github.com/pythonnet/pythonnet/pull/1254#issue-717917001 |
| AUTHORS | https://github.com/pythonnet/pythonnet/blob/master/AUTHORS.md |
| CHANGELOG | https://github.com/pythonnet/pythonnet/blob/master/CHANGELOG.md |
| Please reload this page | https://github.com/pythonnet/pythonnet/pull/1254 |
| https://github.com/lostmsu |
| lostmsu | https://github.com/lostmsu |
|
Oct 9, 2020
| https://github.com/pythonnet/pythonnet/pull/1254#pullrequestreview-505980985 |
|
View reviewed changes
| https://github.com/pythonnet/pythonnet/pull/1254/files |
| src/runtime/intern.cs | https://github.com/pythonnet/pythonnet/pull/1254/files#diff-f0683094e9d5199e04311d44d276fa5e332dce87f16d206de9eb18569ba77779 |
| Please reload this page | https://github.com/pythonnet/pythonnet/pull/1254 |
| src/runtime/intern_.tt | https://github.com/pythonnet/pythonnet/pull/1254/files#diff-6a45b9264ae7d0ba42571fa179a96e5461db804b84bfdf95b2dab808ca3abf79 |
| lostmsu | https://github.com/lostmsu |
| Oct 9, 2020 | https://github.com/pythonnet/pythonnet/pull/1254#discussion_r502666370 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/pythonnet/pythonnet/pull/1254 |
| amos402 | https://github.com/amos402 |
| Oct 22, 2020 | https://github.com/pythonnet/pythonnet/pull/1254#discussion_r509830937 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/pythonnet/pythonnet/pull/1254 |
| src/runtime/intern.cs | https://github.com/pythonnet/pythonnet/pull/1254/files#diff-f0683094e9d5199e04311d44d276fa5e332dce87f16d206de9eb18569ba77779 |
| Please reload this page | https://github.com/pythonnet/pythonnet/pull/1254 |
| https://github.com/amos402 |
| amos402 | https://github.com/amos402 |
| force-pushed | https://github.com/pythonnet/pythonnet/compare/49e3340777582dd25b4dee82797022b5167ef042..021bf9f7d72770428eb08c61bd7f7a190cf780cf |
| 49e3340 | https://github.com/pythonnet/pythonnet/commit/49e3340777582dd25b4dee82797022b5167ef042 |
| 021bf9f | https://github.com/pythonnet/pythonnet/commit/021bf9f7d72770428eb08c61bd7f7a190cf780cf |
|
Compare
| https://github.com/pythonnet/pythonnet/compare/49e3340777582dd25b4dee82797022b5167ef042..021bf9f7d72770428eb08c61bd7f7a190cf780cf |
| October 22, 2020 08:19 | https://github.com/pythonnet/pythonnet/pull/1254#event-3907720727 |
|
| https://github.com/amos402 |
| Add intern string | https://github.com/pythonnet/pythonnet/pull/1254/commits/955ef8dcae1e9e956d3b1c2cb5974c914e7c85d3 |
| 955ef8d | https://github.com/pythonnet/pythonnet/pull/1254/commits/955ef8dcae1e9e956d3b1c2cb5974c914e7c85d3 |
| https://github.com/amos402 |
| amos402 | https://github.com/amos402 |
| force-pushed | https://github.com/pythonnet/pythonnet/compare/021bf9f7d72770428eb08c61bd7f7a190cf780cf..955ef8dcae1e9e956d3b1c2cb5974c914e7c85d3 |
| 021bf9f | https://github.com/pythonnet/pythonnet/commit/021bf9f7d72770428eb08c61bd7f7a190cf780cf |
| 955ef8d | https://github.com/pythonnet/pythonnet/commit/955ef8dcae1e9e956d3b1c2cb5974c914e7c85d3 |
|
Compare
| https://github.com/pythonnet/pythonnet/compare/021bf9f7d72770428eb08c61bd7f7a190cf780cf..955ef8dcae1e9e956d3b1c2cb5974c914e7c85d3 |
| October 22, 2020 08:23 | https://github.com/pythonnet/pythonnet/pull/1254#event-3907739917 |
| https://github.com/codecov-io |
| codecov-io | https://github.com/codecov-io |
| Oct 22, 2020 | https://github.com/pythonnet/pythonnet/pull/1254#issuecomment-714350974 |
| Please reload this page | https://github.com/pythonnet/pythonnet/pull/1254 |
| Codecov | https://codecov.io/gh/pythonnet/pythonnet/pull/1254?src=pr&el=h1 |
| #1254 | https://codecov.io/gh/pythonnet/pythonnet/pull/1254?src=pr&el=desc |
| master | https://codecov.io/gh/pythonnet/pythonnet/commit/84e2735ffd00cc1d596b11d6b70a913150438619?el=desc |
| https://codecov.io/gh/pythonnet/pythonnet/pull/1254?src=pr&el=tree |
| Click here | https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment |
| Continue to review full report at Codecov | https://codecov.io/gh/pythonnet/pythonnet/pull/1254?src=pr&el=continue |
| Click here to learn more | https://docs.codecov.io/docs/codecov-delta |
| Codecov | https://codecov.io/gh/pythonnet/pythonnet/pull/1254?src=pr&el=footer |
| 84e2735...f2a6621 | https://codecov.io/gh/pythonnet/pythonnet/pull/1254?src=pr&el=lastupdated |
| comment docs | https://docs.codecov.io/docs/pull-request-comments |
| Please reload this page | https://github.com/pythonnet/pythonnet/pull/1254 |
| https://github.com/lostmsu |
| lostmsu | https://github.com/lostmsu |
|
Oct 23, 2020
| https://github.com/pythonnet/pythonnet/pull/1254#pullrequestreview-515238359 |
|
View reviewed changes
| https://github.com/pythonnet/pythonnet/pull/1254/files/955ef8dcae1e9e956d3b1c2cb5974c914e7c85d3 |
| src/runtime/intern.cs | https://github.com/pythonnet/pythonnet/pull/1254/files#diff-f0683094e9d5199e04311d44d276fa5e332dce87f16d206de9eb18569ba77779 |
| Please reload this page | https://github.com/pythonnet/pythonnet/pull/1254 |
|
| https://github.com/amos402 |
| Merge branch 'master' into intern-string | https://github.com/pythonnet/pythonnet/pull/1254/commits/f2a662127cf103e865227602ebe564474ccc14b1 |
| f2a6621 | https://github.com/pythonnet/pythonnet/pull/1254/commits/f2a662127cf103e865227602ebe564474ccc14b1 |
| https://github.com/lostmsu |
| lostmsu | https://github.com/lostmsu |
| Nov 5, 2020 | https://github.com/pythonnet/pythonnet/pull/1254#issuecomment-722607937 |
| @amos402 | https://github.com/amos402 |
| Please reload this page | https://github.com/pythonnet/pythonnet/pull/1254 |
| https://github.com/amos402 |
| amos402 | https://github.com/amos402 |
| Nov 6, 2020 | https://github.com/pythonnet/pythonnet/pull/1254#issuecomment-723194917 |
| Please reload this page | https://github.com/pythonnet/pythonnet/pull/1254 |
| https://gist.github.com/amos402/8decd54dee57fe654e098bc0b15c061a | https://gist.github.com/amos402/8decd54dee57fe654e098bc0b15c061a |
| Please reload this page | https://github.com/pythonnet/pythonnet/pull/1254 |
| https://github.com/lostmsu |
| lostmsu | https://github.com/lostmsu |
|
Nov 6, 2020
| https://github.com/pythonnet/pythonnet/pull/1254#pullrequestreview-525533542 |
|
View reviewed changes
| https://github.com/pythonnet/pythonnet/pull/1254/files/f2a662127cf103e865227602ebe564474ccc14b1 |
| https://github.com/lostmsu |
| lostmsu | https://github.com/lostmsu |
| d0c588b | https://github.com/pythonnet/pythonnet/commit/d0c588b27113ca36a8b03111565fbcdf041e1967 |
| Nov 6, 2020 | https://github.com/pythonnet/pythonnet/pull/1254#event-3969145155 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1254 |
|
| https://github.com/lostmsu |
|
lostmsu
| https://github.com/lostmsu |
|
| https://github.com/pythonnet/pythonnet/pull/1254/files/f2a662127cf103e865227602ebe564474ccc14b1 |
| Please reload this page | https://github.com/pythonnet/pythonnet/pull/1254 |
|
| https://github.com/amos402 |
|
| https://github.com/codecov-io |
|
| https://github.com/lostmsu |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |