René's URL Explorer Experiment


Title: Make indexers work for interface objects by danabr · Pull Request #1246 · pythonnet/pythonnet · GitHub

Open Graph Title: Make indexers work for interface objects by danabr · Pull Request #1246 · pythonnet/pythonnet

X Title: Make indexers work for interface objects by danabr · Pull Request #1246 · pythonnet/pythonnet

Description: What does this implement/fix? Explain your changes. Makes the following work instead of throwing an exception: from System.Collections.Generic import Dictionary, IDictionary d = IDictionary[str, str](Dictionary[str, str]()) d["one"] = "1" assert d["one"] == "1" Does this close any currently open issues? No Checklist Check all those that are applicable and complete. Make sure to include one or more tests for your change If an enhancement PR, please create docs and at best an example Add yourself to AUTHORS Updated the CHANGELOG

Open Graph Description: What does this implement/fix? Explain your changes. Makes the following work instead of throwing an exception: from System.Collections.Generic import Dictionary, IDictionary d = IDictionary[str, st...

X Description: What does this implement/fix? Explain your changes. Makes the following work instead of throwing an exception: from System.Collections.Generic import Dictionary, IDictionary d = IDictionary[str, st...

Opengraph URL: https://github.com/pythonnet/pythonnet/pull/1246

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:383da725-31b5-45e4-6343-953bf81e189d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8092:25EF8D:117949E:1743F1C:69702E25
html-safe-nonce52adcdd60e855baa04e920ddab5b80457d9e3e3779a8f3b7c7cf4273169b1d9e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDkyOjI1RUY4RDoxMTc5NDlFOjE3NDNGMUM6Njk3MDJFMjUiLCJ2aXNpdG9yX2lkIjoiOTE4OTc1MDU4Nzk1NDA0ODU0OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8fcce8a799bd42732e2aef239aca23aacb888ac0b59529269b0df759c308a569
hovercard-subject-tagpull_request:497861691
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/1246/files
twitter:imagehttps://avatars.githubusercontent.com/u/207266?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/207266?s=400&v=4
og:image:altWhat does this implement/fix? Explain your changes. Makes the following work instead of throwing an exception: from System.Collections.Generic import Dictionary, IDictionary d = IDictionary[str, st...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None01fa379f5de85ef8e791d09724e69709ce9eb9595278316e0a921312dc88e0bc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git
octolytics-dimension-user_id6050430
octolytics-dimension-user_loginpythonnet
octolytics-dimension-repository_id14748123
octolytics-dimension-repository_nwopythonnet/pythonnet
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id14748123
octolytics-dimension-repository_network_root_nwopythonnet/pythonnet
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedda91974c069382b0dfa47b2da7e28bd061c8331
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/pythonnet/pythonnet/pull/1246/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1246%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1246%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=pythonnet%2Fpythonnet
Reloadhttps://github.com/pythonnet/pythonnet/pull/1246/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1246/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1246/files
pythonnet https://github.com/pythonnet
pythonnethttps://github.com/pythonnet/pythonnet
Notifications https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Fork 770 https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Star 5.4k https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Code https://github.com/pythonnet/pythonnet
Issues 155 https://github.com/pythonnet/pythonnet/issues
Pull requests 18 https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects 0 https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/pythonnet/pythonnet/security
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1246/files
Insights https://github.com/pythonnet/pythonnet/pulse
Code https://github.com/pythonnet/pythonnet
Issues https://github.com/pythonnet/pythonnet/issues
Pull requests https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security https://github.com/pythonnet/pythonnet/security
Insights https://github.com/pythonnet/pythonnet/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
lostmsuhttps://github.com/lostmsu
pythonnet:masterhttps://github.com/pythonnet/pythonnet/tree/master
danabr:interface-indexershttps://github.com/danabr/pythonnet/tree/interface-indexers
Conversation 4 https://github.com/pythonnet/pythonnet/pull/1246
Commits 2 https://github.com/pythonnet/pythonnet/pull/1246/commits
Checks 0 https://github.com/pythonnet/pythonnet/pull/1246/checks
Files changed https://github.com/pythonnet/pythonnet/pull/1246/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1246/files
Make indexers work for interface objects https://github.com/pythonnet/pythonnet/pull/1246/files#top
Show all changes 2 commits https://github.com/pythonnet/pythonnet/pull/1246/files
9c870c1 Make indexers work for interface objects danabr Oct 5, 2020 https://github.com/pythonnet/pythonnet/pull/1246/commits/9c870c120718ce8c7cb7729cf20189587a32c402
12fdaab Only set mp_subscript and mp_ass_subscript for indexable types danabr Oct 6, 2020 https://github.com/pythonnet/pythonnet/pull/1246/commits/12fdaab6a8f62123a253acd4ca2e173a9b2e096e
Clear filters https://github.com/pythonnet/pythonnet/pull/1246/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1246/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1246/files
CHANGELOG.md https://github.com/pythonnet/pythonnet/pull/1246/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
arrayobject.cs https://github.com/pythonnet/pythonnet/pull/1246/files#diff-8e5665a987d0fbd3f45d41f704db0a2a5dad19503acc3382b04bd8c489dfdb56
classbase.cs https://github.com/pythonnet/pythonnet/pull/1246/files#diff-32bee523619b42a59c7c60132a7d605f738b74bf85b7288552d57b6dd03c96d0
classobject.cs https://github.com/pythonnet/pythonnet/pull/1246/files#diff-17760fb24802cfcc24f8b9bb6f16bb28fa4c4a95b1f827c6e0de3c0df677b2f5
typemanager.cs https://github.com/pythonnet/pythonnet/pull/1246/files#diff-64b3221887c395ea436fe9433800e73c0854e42d78cd7108c320e5d41d20ab64
test_array.py https://github.com/pythonnet/pythonnet/pull/1246/files#diff-cb231c7e9ddeb97e5d71094f563180683eb75fce91c0d8c7f235b6d06196ea7a
test_indexer.py https://github.com/pythonnet/pythonnet/pull/1246/files#diff-f8ff6d3a7238901aa645cc277bd095659a7416c5801caf9e7c8d1242969a9ec8
CHANGELOG.mdhttps://github.com/pythonnet/pythonnet/pull/1246/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
View file https://github.com/danabr/pythonnet/blob/12fdaab6a8f62123a253acd4ca2e173a9b2e096e/CHANGELOG.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1246/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1246/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
https://github.com/pythonnet/pythonnet/pull/1246/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
src/runtime/arrayobject.cshttps://github.com/pythonnet/pythonnet/pull/1246/files#diff-8e5665a987d0fbd3f45d41f704db0a2a5dad19503acc3382b04bd8c489dfdb56
View file https://github.com/danabr/pythonnet/blob/12fdaab6a8f62123a253acd4ca2e173a9b2e096e/src/runtime/arrayobject.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1246/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1246/files#diff-8e5665a987d0fbd3f45d41f704db0a2a5dad19503acc3382b04bd8c489dfdb56
https://github.com/pythonnet/pythonnet/pull/1246/files#diff-8e5665a987d0fbd3f45d41f704db0a2a5dad19503acc3382b04bd8c489dfdb56
https://github.com/pythonnet/pythonnet/pull/1246/files#diff-8e5665a987d0fbd3f45d41f704db0a2a5dad19503acc3382b04bd8c489dfdb56
https://github.com/pythonnet/pythonnet/pull/1246/files#diff-8e5665a987d0fbd3f45d41f704db0a2a5dad19503acc3382b04bd8c489dfdb56
src/runtime/classbase.cshttps://github.com/pythonnet/pythonnet/pull/1246/files#diff-32bee523619b42a59c7c60132a7d605f738b74bf85b7288552d57b6dd03c96d0
View file https://github.com/danabr/pythonnet/blob/12fdaab6a8f62123a253acd4ca2e173a9b2e096e/src/runtime/classbase.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1246/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1246/files#diff-32bee523619b42a59c7c60132a7d605f738b74bf85b7288552d57b6dd03c96d0
src/runtime/classobject.cshttps://github.com/pythonnet/pythonnet/pull/1246/files#diff-17760fb24802cfcc24f8b9bb6f16bb28fa4c4a95b1f827c6e0de3c0df677b2f5
View file https://github.com/danabr/pythonnet/blob/12fdaab6a8f62123a253acd4ca2e173a9b2e096e/src/runtime/classobject.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1246/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1246/files#diff-17760fb24802cfcc24f8b9bb6f16bb28fa4c4a95b1f827c6e0de3c0df677b2f5
src/runtime/typemanager.cshttps://github.com/pythonnet/pythonnet/pull/1246/files#diff-64b3221887c395ea436fe9433800e73c0854e42d78cd7108c320e5d41d20ab64
View file https://github.com/danabr/pythonnet/blob/12fdaab6a8f62123a253acd4ca2e173a9b2e096e/src/runtime/typemanager.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1246/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1246/files#diff-64b3221887c395ea436fe9433800e73c0854e42d78cd7108c320e5d41d20ab64
https://github.com/pythonnet/pythonnet/pull/1246/files#diff-64b3221887c395ea436fe9433800e73c0854e42d78cd7108c320e5d41d20ab64
src/tests/test_array.pyhttps://github.com/pythonnet/pythonnet/pull/1246/files#diff-cb231c7e9ddeb97e5d71094f563180683eb75fce91c0d8c7f235b6d06196ea7a
View file https://github.com/danabr/pythonnet/blob/12fdaab6a8f62123a253acd4ca2e173a9b2e096e/src/tests/test_array.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1246/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1246/files#diff-cb231c7e9ddeb97e5d71094f563180683eb75fce91c0d8c7f235b6d06196ea7a
https://github.com/pythonnet/pythonnet/pull/1246/files#diff-cb231c7e9ddeb97e5d71094f563180683eb75fce91c0d8c7f235b6d06196ea7a
src/tests/test_indexer.pyhttps://github.com/pythonnet/pythonnet/pull/1246/files#diff-f8ff6d3a7238901aa645cc277bd095659a7416c5801caf9e7c8d1242969a9ec8
View file https://github.com/danabr/pythonnet/blob/12fdaab6a8f62123a253acd4ca2e173a9b2e096e/src/tests/test_indexer.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1246/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1246/files#diff-f8ff6d3a7238901aa645cc277bd095659a7416c5801caf9e7c8d1242969a9ec8
https://github.com/pythonnet/pythonnet/pull/1246/files#diff-f8ff6d3a7238901aa645cc277bd095659a7416c5801caf9e7c8d1242969a9ec8
https://github.com/pythonnet/pythonnet/pull/1246/files#diff-f8ff6d3a7238901aa645cc277bd095659a7416c5801caf9e7c8d1242969a9ec8
https://github.com/pythonnet/pythonnet/pull/1246/files#diff-f8ff6d3a7238901aa645cc277bd095659a7416c5801caf9e7c8d1242969a9ec8
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.