Title: Wrap returned objects in interface if method return type is interface by danabr · Pull Request #1240 · pythonnet/pythonnet · GitHub
Open Graph Title: Wrap returned objects in interface if method return type is interface by danabr · Pull Request #1240 · pythonnet/pythonnet
X Title: Wrap returned objects in interface if method return type is interface by danabr · Pull Request #1240 · pythonnet/pythonnet
Description: What does this implement/fix? Explain your changes. This allows callers to call all methods of an interface, regardless of whether the method was implemented implicitly or explicitly. Before this change, you had to make an explicit cast to the interface to be able to call the explicitly implemented method. Consider the following code: namespace Python.Test { public interface ITestInterface { void Foo(); void Bar(); } public class TestImpl : ITestInterface { public void Foo() { }; public void ITestInterface.Bar() { }; public void Baz() { }; public static ITestInterface GetInterface() { return new TestImpl(); } } } And the following Python code, demonstrating the behavior before this change: from Python.Test import TestImpl, ITestInterface test = TestImpl.GetInterface() test.Foo() # works test.Bar() # AttributeError: 'TestImpl' object has no attribute 'Bar' test.Baz() # works! - baz After this change, the behavior is as follows: test = TestImpl.GetInterface() test.Foo() # works test.Bar() # works test.Baz() # AttributeError: 'ITestInterface' object has no attribute 'Baz' This is a breaking change due to that Baz is no longer visible in Python. Does this close any currently open issues? No. Any other comments? See #1233 for an alternative approach, that exposes methods of explictly implemented interfaces without need to cast the object first. Checklist Check all those that are applicable and complete. Make sure to include one or more tests for your change If an enhancement PR, please create docs and at best an example Add yourself to AUTHORS Updated the CHANGELOG
Open Graph Description: What does this implement/fix? Explain your changes. This allows callers to call all methods of an interface, regardless of whether the method was implemented implicitly or explicitly. Before this c...
X Description: What does this implement/fix? Explain your changes. This allows callers to call all methods of an interface, regardless of whether the method was implemented implicitly or explicitly. Before this c...
Opengraph URL: https://github.com/pythonnet/pythonnet/pull/1240
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:a596d1d1-b95b-eb20-9c09-091fd395e60e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C3D8:EAF27:1B3645F:23F530D:6971A2BD |
| html-safe-nonce | 8e2e1473c95d5dcf705c5711ea7a1028f2a25abf674971b13d8dcf6b87eb853e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDM0Q4OkVBRjI3OjFCMzY0NUY6MjNGNTMwRDo2OTcxQTJCRCIsInZpc2l0b3JfaWQiOiI0NDU5MTMyOTQzNjY1ODMyNjM3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a9401bd3a3af2fea8e6ebb12a4170cceda594bc11ba872332315b5b23a383c50 |
| hovercard-subject-tag | pull_request:493386321 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/1240/files |
| twitter:image | https://avatars.githubusercontent.com/u/207266?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/207266?s=400&v=4 |
| og:image:alt | What does this implement/fix? Explain your changes. This allows callers to call all methods of an interface, regardless of whether the method was implemented implicitly or explicitly. Before this c... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | fdfdce9cd4f6ab85dca2b0d11264270829297c962dd5a79df449062d7822258f |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git |
| octolytics-dimension-user_id | 6050430 |
| octolytics-dimension-user_login | pythonnet |
| octolytics-dimension-repository_id | 14748123 |
| octolytics-dimension-repository_nwo | pythonnet/pythonnet |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 14748123 |
| octolytics-dimension-repository_network_root_nwo | pythonnet/pythonnet |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 51c736e60b302bd039c9d5164573d176ceb24bb2 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width