| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:7fde1b30-4daa-f1dd-b309-31a13cdaed1c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ADE4:2B2A66:3F4C9CD:588A765:69713988 |
| html-safe-nonce | e368aa65cfa5fc2a5640fa82712b92d2e32b5d37c20fed52ee3b66aaf410d57a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBREU0OjJCMkE2NjozRjRDOUNEOjU4OEE3NjU6Njk3MTM5ODgiLCJ2aXNpdG9yX2lkIjoiNTA0OTQ4OTM2MjU3NTc2Nzk0NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | cfa3b34207b6c5a0077a8d4d4ba5493ea1fb18f782d73c428581bc925261651f |
| hovercard-subject-tag | pull_request:443411456 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/1175/files |
| twitter:image | https://avatars.githubusercontent.com/u/3406561?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3406561?s=400&v=4 |
| og:image:alt | What does this implement/fix? Explain your changes.
Fro saving unnecessary costs.
Does this close any currently open issues?
...
Any other comments?
...
Checklist
Check all those that are applicabl... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7899979feb505886f0f29e8086a739254f3a850fd3dbc9fb63ce4ec27831b1fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git |
| octolytics-dimension-user_id | 6050430 |
| octolytics-dimension-user_login | pythonnet |
| octolytics-dimension-repository_id | 14748123 |
| octolytics-dimension-repository_nwo | pythonnet/pythonnet |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 14748123 |
| octolytics-dimension-repository_network_root_nwo | pythonnet/pythonnet |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 998d3ef09faa982f8d83ad111166244ae4625572 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/pythonnet/pythonnet/pull/1175/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1175%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1175%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=pythonnet%2Fpythonnet |
| Reload | https://github.com/pythonnet/pythonnet/pull/1175/files |
| Reload | https://github.com/pythonnet/pythonnet/pull/1175/files |
| Reload | https://github.com/pythonnet/pythonnet/pull/1175/files |
|
pythonnet
| https://github.com/pythonnet |
| pythonnet | https://github.com/pythonnet/pythonnet |
|
Notifications
| https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet |
|
Fork
770
| https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet |
|
Star
5.4k
| https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet |
|
Code
| https://github.com/pythonnet/pythonnet |
|
Issues
155
| https://github.com/pythonnet/pythonnet/issues |
|
Pull requests
18
| https://github.com/pythonnet/pythonnet/pulls |
|
Discussions
| https://github.com/pythonnet/pythonnet/discussions |
|
Actions
| https://github.com/pythonnet/pythonnet/actions |
|
Projects
0
| https://github.com/pythonnet/pythonnet/projects |
|
Wiki
| https://github.com/pythonnet/pythonnet/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/pythonnet/pythonnet/security |
| Please reload this page | https://github.com/pythonnet/pythonnet/pull/1175/files |
|
Insights
| https://github.com/pythonnet/pythonnet/pulse |
|
Code
| https://github.com/pythonnet/pythonnet |
|
Issues
| https://github.com/pythonnet/pythonnet/issues |
|
Pull requests
| https://github.com/pythonnet/pythonnet/pulls |
|
Discussions
| https://github.com/pythonnet/pythonnet/discussions |
|
Actions
| https://github.com/pythonnet/pythonnet/actions |
|
Projects
| https://github.com/pythonnet/pythonnet/projects |
|
Wiki
| https://github.com/pythonnet/pythonnet/wiki |
|
Security
| https://github.com/pythonnet/pythonnet/security |
|
Insights
| https://github.com/pythonnet/pythonnet/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose |
| filmor | https://github.com/filmor |
| pythonnet:master | https://github.com/pythonnet/pythonnet/tree/master |
| amos402:remove-redundant-calls | https://github.com/amos402/pythonnet/tree/remove-redundant-calls |
|
Conversation
9
| https://github.com/pythonnet/pythonnet/pull/1175 |
|
Commits
11
| https://github.com/pythonnet/pythonnet/pull/1175/commits |
|
Checks
0
| https://github.com/pythonnet/pythonnet/pull/1175/checks |
|
Files changed
| https://github.com/pythonnet/pythonnet/pull/1175/files |
| Please reload this page | https://github.com/pythonnet/pythonnet/pull/1175/files |
|
Remove unnecessary CheckExceptionOccurred calls
| https://github.com/pythonnet/pythonnet/pull/1175/files#top |
|
Show all changes
11 commits
| https://github.com/pythonnet/pythonnet/pull/1175/files |
|
03a401e
Remove unnecessary `CheckExceptionOccurred` calls
amos402 Jul 2, 2020
| https://github.com/pythonnet/pythonnet/pull/1175/commits/03a401ef22f2110eac9b66929cc5d53042f51f82 |
|
950676f
Dispose safety
amos402 Jul 29, 2020
| https://github.com/pythonnet/pythonnet/pull/1175/commits/950676f3eef28cfe34c4b955e6d1975895f59896 |
|
88f2cfa
Refactor Converter.ToPrimitive
amos402 Jul 29, 2020
| https://github.com/pythonnet/pythonnet/pull/1175/commits/88f2cfa9659a0f7a1de8e5046bcf1ce67dbd87ff |
|
0e4668c
str to int raises `ValueError`
amos402 Jul 29, 2020
| https://github.com/pythonnet/pythonnet/pull/1175/commits/0e4668cfcf0de1f040b627fdc0fc456315233c87 |
|
9845e98
Test convert error for float types
amos402 Jul 29, 2020
| https://github.com/pythonnet/pythonnet/pull/1175/commits/9845e98129dcdb83bc7ed44fee769a2d126733e2 |
|
97f0009
Convert error for UInt32
amos402 Jul 29, 2020
| https://github.com/pythonnet/pythonnet/pull/1175/commits/97f00095362b006f61a20ffc019f005a87b12935 |
|
838dfc2
* Ignore package index
amos402 Jul 30, 2020
| https://github.com/pythonnet/pythonnet/pull/1175/commits/838dfc2f3d6767293c9196be7e9817426fd502ce |
|
d9628f7
BorrowedReference instead of `in NewReference`
amos402 Jul 30, 2020
| https://github.com/pythonnet/pythonnet/pull/1175/commits/d9628f7d89d982499731aa608437852642ed9be2 |
|
aced268
Remove useless pip argument
amos402 Jul 30, 2020
| https://github.com/pythonnet/pythonnet/pull/1175/commits/aced2689030082e620eb59f3e19511562a8f30c3 |
|
e379520
Merge branch 'master' into remove-redundant-calls
amos402 Aug 10, 2020
| https://github.com/pythonnet/pythonnet/pull/1175/commits/e379520b764ec55d1358c3e227e95548e91d3784 |
|
8ca0a62
Merge branch 'master' into remove-redundant-calls
amos402 Aug 11, 2020
| https://github.com/pythonnet/pythonnet/pull/1175/commits/8ca0a626c708f3bb93f1b00fd5ef5e0f06a271f9 |
|
Clear filters
| https://github.com/pythonnet/pythonnet/pull/1175/files |
| Please reload this page | https://github.com/pythonnet/pythonnet/pull/1175/files |
| Please reload this page | https://github.com/pythonnet/pythonnet/pull/1175/files |
|
TestConverter.cs
| https://github.com/pythonnet/pythonnet/pull/1175/files#diff-d98abf2b9a1ec152804cfe9455ffb5402a716d814abda8bb1308cef2cb2a714e |
|
NewReference.cs
| https://github.com/pythonnet/pythonnet/pull/1175/files#diff-068e7e2921c451819f9e8312de3669ee44d933385eba2e8a0bc51469aefbfcbc |
|
converter.cs
| https://github.com/pythonnet/pythonnet/pull/1175/files#diff-72dfd7f278c0d6de7e41256893ce639665e58b7d65a627b5d0c0dfa4173095e8 |
|
pyansistring.cs
| https://github.com/pythonnet/pythonnet/pull/1175/files#diff-7ec984f30123e498d270a3046eb4ce4a44dd90bc0fd4e7cd2cc645c0290b99cf |
|
pyfloat.cs
| https://github.com/pythonnet/pythonnet/pull/1175/files#diff-8be67f20238d9176fdeb679d58c61be8d1753507a26bc8c292c1f1cb1aa2e796 |
|
pyint.cs
| https://github.com/pythonnet/pythonnet/pull/1175/files#diff-c5080b06d924521b684e8e1c08b74eec5b169a1bc0d172eb44b4cd4f79de5895 |
|
pylong.cs
| https://github.com/pythonnet/pythonnet/pull/1175/files#diff-5035265f1c2785f00e884323e85f5ee2bdcccf8f30162a05c9175d536747fc18 |
|
pyscope.cs
| https://github.com/pythonnet/pythonnet/pull/1175/files#diff-5a93f5d2b3df2777f89c8024e7880191f13b1ab50eac398d33f143ccc30ead64 |
|
pystring.cs
| https://github.com/pythonnet/pythonnet/pull/1175/files#diff-1aa5051809cf54f2e0b1b52e8b7ecc7ce677a8f2019ea4dbae3909653c04de77 |
|
pythonengine.cs
| https://github.com/pythonnet/pythonnet/pull/1175/files#diff-59c1255540fe4fce6bd6d1f2b5b31ced7b9baacc387b3d07cb08e9444bcd82aa |
|
pythonexception.cs
| https://github.com/pythonnet/pythonnet/pull/1175/files#diff-b068aae9f1f56cdc70d0931b63265b8a10510a62ae9a2814f22801a94eb46bae |
|
pytuple.cs
| https://github.com/pythonnet/pythonnet/pull/1175/files#diff-fbdcc9261e772f7058ec708adbc3f32ae7a9d29a0e4635c66ae39e095c31f25a |
|
test_conversion.py
| https://github.com/pythonnet/pythonnet/pull/1175/files#diff-31d837ef43a928d023727fea7e80edb11bcaa6191bed823e288a50afe479e0cc |
| src/embed_tests/TestConverter.cs | https://github.com/pythonnet/pythonnet/pull/1175/files#diff-d98abf2b9a1ec152804cfe9455ffb5402a716d814abda8bb1308cef2cb2a714e |
|
View file
| https://github.com/amos402/pythonnet/blob/8ca0a626c708f3bb93f1b00fd5ef5e0f06a271f9/src/embed_tests/TestConverter.cs |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/pythonnet/pythonnet/pull/1175/{{ revealButtonHref }} |
|
| https://github.com/pythonnet/pythonnet/pull/1175/files#diff-d98abf2b9a1ec152804cfe9455ffb5402a716d814abda8bb1308cef2cb2a714e |
|
| https://github.com/pythonnet/pythonnet/pull/1175/files#diff-d98abf2b9a1ec152804cfe9455ffb5402a716d814abda8bb1308cef2cb2a714e |
|
| https://github.com/pythonnet/pythonnet/pull/1175/files#diff-d98abf2b9a1ec152804cfe9455ffb5402a716d814abda8bb1308cef2cb2a714e |
| src/runtime/NewReference.cs | https://github.com/pythonnet/pythonnet/pull/1175/files#diff-068e7e2921c451819f9e8312de3669ee44d933385eba2e8a0bc51469aefbfcbc |
|
View file
| https://github.com/amos402/pythonnet/blob/8ca0a626c708f3bb93f1b00fd5ef5e0f06a271f9/src/runtime/NewReference.cs |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/pythonnet/pythonnet/pull/1175/{{ revealButtonHref }} |
|
| https://github.com/pythonnet/pythonnet/pull/1175/files#diff-068e7e2921c451819f9e8312de3669ee44d933385eba2e8a0bc51469aefbfcbc |
|
| https://github.com/pythonnet/pythonnet/pull/1175/files#diff-068e7e2921c451819f9e8312de3669ee44d933385eba2e8a0bc51469aefbfcbc |
| Please reload this page | https://github.com/pythonnet/pythonnet/pull/1175/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |