René's URL Explorer Experiment


Title: Fix kwarg func resolution by jmlidbetter · Pull Request #1136 · pythonnet/pythonnet · GitHub

Open Graph Title: Fix kwarg func resolution by jmlidbetter · Pull Request #1136 · pythonnet/pythonnet

X Title: Fix kwarg func resolution by jmlidbetter · Pull Request #1136 · pythonnet/pythonnet

Description: What does this implement/fix? Explain your changes. A first run at fixing issue #1097. Currently, the method for selecting which method to use is quite simple and just takes the first function it finds to match. The problem is that the current picking algorithm has no knowledge of kwargs and how many have been supplied or used, i.e. MatchesArgumentCount will return true even if we've supplied some kwargs but the current overload does not require them. Ultimately, this means the first matched method might not be the best. This small patch aims to rectify this issue by collecting together all the methods for which MatchesArgumentCount returns true and then from these selecting the best match based on the following criteria Maximizing the number of supplied kwargs that have been used Minimizing the number of default arguments needed It also has some logic to abort in the case where The above criteria are met by more than one overload We need at least one default argument to make the call This stops users in python making ambiguous function calls - see the tests for an example. Does this close any currently open issues? #1097 Any other comments? Feedback please! Checklist Check all those that are applicable and complete. Make sure to include one or more tests for your change If an enhancement PR, please create docs and at best an example Add yourself to AUTHORS Updated the CHANGELOG

Open Graph Description: What does this implement/fix? Explain your changes. A first run at fixing issue #1097. Currently, the method for selecting which method to use is quite simple and just takes the first function it f...

X Description: What does this implement/fix? Explain your changes. A first run at fixing issue #1097. Currently, the method for selecting which method to use is quite simple and just takes the first function it f...

Opengraph URL: https://github.com/pythonnet/pythonnet/pull/1136

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:164d8cd1-3099-2954-c976-0e1057b5b57f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA9F8:8E649:8CE9D2:B9B9F3:69716903
html-safe-nonce8fd25775bd154369070d8baf6ebabb0b34e03bad3cb16b837c7818ad44c67aa7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOUY4OjhFNjQ5OjhDRTlEMjpCOUI5RjM6Njk3MTY5MDMiLCJ2aXNpdG9yX2lkIjoiMzAzNDcxOTgwMDI5NTI1NDI3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb8cce793bc59981584f571cc5268f504e42ba6f83f8cdf4f220ad0f1963f2646
hovercard-subject-tagpull_request:414560789
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/1136/files
twitter:imagehttps://avatars.githubusercontent.com/u/53430310?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/53430310?s=400&v=4
og:image:altWhat does this implement/fix? Explain your changes. A first run at fixing issue #1097. Currently, the method for selecting which method to use is quite simple and just takes the first function it f...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None353479110ec1e87d687013548f216c852055ec907d09d2fb6a180cb5ed9d28e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git
octolytics-dimension-user_id6050430
octolytics-dimension-user_loginpythonnet
octolytics-dimension-repository_id14748123
octolytics-dimension-repository_nwopythonnet/pythonnet
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id14748123
octolytics-dimension-repository_network_root_nwopythonnet/pythonnet
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea4c7e274c03a115b82dcef6c47ce3f7f903e88e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/pythonnet/pythonnet/pull/1136/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1136%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1136%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=pythonnet%2Fpythonnet
Reloadhttps://github.com/pythonnet/pythonnet/pull/1136/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1136/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1136/files
pythonnet https://github.com/pythonnet
pythonnethttps://github.com/pythonnet/pythonnet
Notifications https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Fork 770 https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Star 5.4k https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Code https://github.com/pythonnet/pythonnet
Issues 156 https://github.com/pythonnet/pythonnet/issues
Pull requests 18 https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects 0 https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/pythonnet/pythonnet/security
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1136/files
Insights https://github.com/pythonnet/pythonnet/pulse
Code https://github.com/pythonnet/pythonnet
Issues https://github.com/pythonnet/pythonnet/issues
Pull requests https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security https://github.com/pythonnet/pythonnet/security
Insights https://github.com/pythonnet/pythonnet/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
lostmsuhttps://github.com/lostmsu
pythonnet:masterhttps://github.com/pythonnet/pythonnet/tree/master
jmlidbetter:fix_kwarg_func_resolutionhttps://github.com/jmlidbetter/pythonnet/tree/fix_kwarg_func_resolution
Conversation 30 https://github.com/pythonnet/pythonnet/pull/1136
Commits 9 https://github.com/pythonnet/pythonnet/pull/1136/commits
Checks 0 https://github.com/pythonnet/pythonnet/pull/1136/checks
Files changed https://github.com/pythonnet/pythonnet/pull/1136/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1136/files
Fix kwarg func resolution https://github.com/pythonnet/pythonnet/pull/1136/files#top
Show all changes 9 commits https://github.com/pythonnet/pythonnet/pull/1136/files
9fb753a Fix function resolution when calling overloads with keyword arguments jmlidbetter Apr 28, 2020 https://github.com/pythonnet/pythonnet/pull/1136/commits/9fb753a789e52188061dc5a3194ba92d8e45ca18
fee4373 Updates CHANGELOG.md jmlidbetter May 7, 2020 https://github.com/pythonnet/pythonnet/pull/1136/commits/fee4373419f640500dcf3210cc018f1ef6bb3abc
8581715 Switches Tuple for struct jmlidbetter May 11, 2020 https://github.com/pythonnet/pythonnet/pull/1136/commits/8581715173766f3f1d9a5396665c430d45f8eef9
86d21f1 Use LINQ Min and Max methods; don't create second list for methods be… jmlidbetter May 12, 2020 https://github.com/pythonnet/pythonnet/pull/1136/commits/86d21f1696f79cf1f6b8eedd0a287ad1d7fdccbb
d453159 Removes all secondary lists jmlidbetter May 12, 2020 https://github.com/pythonnet/pythonnet/pull/1136/commits/d45315969d1a5d65481ae34fa17fda3c155ac984
a1b6c76 Updates CHANGELOG jmlidbetter Jun 22, 2020 https://github.com/pythonnet/pythonnet/pull/1136/commits/a1b6c76bfb45b445add2d9942b651057b5852610
1d01c45 Merge branch 'master' into fix_kwarg_func_resolution filmor Oct 13, 2020 https://github.com/pythonnet/pythonnet/pull/1136/commits/1d01c457a5f573d9454dffc3da3ac93aee479be9
980c231 Merge branch 'master' into fix_kwarg_func_resolution jmlidbetter Oct 21, 2020 https://github.com/pythonnet/pythonnet/pull/1136/commits/980c231d08008c80685d83b673de5ad117e8c776
8d0fc2c Merge branch 'master' into fix_kwarg_func_resolution filmor Nov 18, 2020 https://github.com/pythonnet/pythonnet/pull/1136/commits/8d0fc2cc6779960054f3945a1ec8f3db90e08865
Clear filters https://github.com/pythonnet/pythonnet/pull/1136/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1136/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1136/files
CHANGELOG.md https://github.com/pythonnet/pythonnet/pull/1136/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
methodbinder.cs https://github.com/pythonnet/pythonnet/pull/1136/files#diff-237dc718ad5424f5476d2ebbbc4e5164c95901bd2a4c2daaf8ca6fc9f9d3a5fb
methodtest.cs https://github.com/pythonnet/pythonnet/pull/1136/files#diff-1d0f6055444d3a45c61ebb7e0e5b13a3df067c3b7bd870bb20e32e66f73b3ee9
test_method.py https://github.com/pythonnet/pythonnet/pull/1136/files#diff-466ca471fe877d2ed8ea2c63abefa78808471ab8c26e858228178387a440a8f3
CHANGELOG.mdhttps://github.com/pythonnet/pythonnet/pull/1136/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
View file https://github.com/jmlidbetter/pythonnet/blob/8d0fc2cc6779960054f3945a1ec8f3db90e08865/CHANGELOG.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1136/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1136/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
https://github.com/pythonnet/pythonnet/pull/1136/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
src/runtime/methodbinder.cshttps://github.com/pythonnet/pythonnet/pull/1136/files#diff-237dc718ad5424f5476d2ebbbc4e5164c95901bd2a4c2daaf8ca6fc9f9d3a5fb
View file https://github.com/jmlidbetter/pythonnet/blob/8d0fc2cc6779960054f3945a1ec8f3db90e08865/src/runtime/methodbinder.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1136/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1136/files#diff-237dc718ad5424f5476d2ebbbc4e5164c95901bd2a4c2daaf8ca6fc9f9d3a5fb
https://github.com/pythonnet/pythonnet/pull/1136/files#diff-237dc718ad5424f5476d2ebbbc4e5164c95901bd2a4c2daaf8ca6fc9f9d3a5fb
https://github.com/pythonnet/pythonnet/pull/1136/files#diff-237dc718ad5424f5476d2ebbbc4e5164c95901bd2a4c2daaf8ca6fc9f9d3a5fb
https://github.com/pythonnet/pythonnet/pull/1136/files#diff-237dc718ad5424f5476d2ebbbc4e5164c95901bd2a4c2daaf8ca6fc9f9d3a5fb
https://github.com/pythonnet/pythonnet/pull/1136/files#diff-237dc718ad5424f5476d2ebbbc4e5164c95901bd2a4c2daaf8ca6fc9f9d3a5fb
jmlidbetterhttps://github.com/jmlidbetter
May 12, 2020https://github.com/pythonnet/pythonnet/pull/1136/files#r423552509
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1136/files
lostmsuhttps://github.com/lostmsu
May 12, 2020https://github.com/pythonnet/pythonnet/pull/1136/files#r423943182
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1136/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1136/files
https://github.com/pythonnet/pythonnet/pull/1136/files#diff-237dc718ad5424f5476d2ebbbc4e5164c95901bd2a4c2daaf8ca6fc9f9d3a5fb
https://github.com/pythonnet/pythonnet/pull/1136/files#diff-237dc718ad5424f5476d2ebbbc4e5164c95901bd2a4c2daaf8ca6fc9f9d3a5fb
https://github.com/pythonnet/pythonnet/pull/1136/files#diff-237dc718ad5424f5476d2ebbbc4e5164c95901bd2a4c2daaf8ca6fc9f9d3a5fb
https://github.com/pythonnet/pythonnet/pull/1136/files#diff-237dc718ad5424f5476d2ebbbc4e5164c95901bd2a4c2daaf8ca6fc9f9d3a5fb
https://github.com/pythonnet/pythonnet/pull/1136/files#diff-237dc718ad5424f5476d2ebbbc4e5164c95901bd2a4c2daaf8ca6fc9f9d3a5fb
src/testing/methodtest.cshttps://github.com/pythonnet/pythonnet/pull/1136/files#diff-1d0f6055444d3a45c61ebb7e0e5b13a3df067c3b7bd870bb20e32e66f73b3ee9
View file https://github.com/jmlidbetter/pythonnet/blob/8d0fc2cc6779960054f3945a1ec8f3db90e08865/src/testing/methodtest.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1136/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1136/files#diff-1d0f6055444d3a45c61ebb7e0e5b13a3df067c3b7bd870bb20e32e66f73b3ee9
https://github.com/pythonnet/pythonnet/pull/1136/files#diff-1d0f6055444d3a45c61ebb7e0e5b13a3df067c3b7bd870bb20e32e66f73b3ee9
src/tests/test_method.pyhttps://github.com/pythonnet/pythonnet/pull/1136/files#diff-466ca471fe877d2ed8ea2c63abefa78808471ab8c26e858228178387a440a8f3
View file https://github.com/jmlidbetter/pythonnet/blob/8d0fc2cc6779960054f3945a1ec8f3db90e08865/src/tests/test_method.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1136/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1136/files#diff-466ca471fe877d2ed8ea2c63abefa78808471ab8c26e858228178387a440a8f3
https://github.com/pythonnet/pythonnet/pull/1136/files#diff-466ca471fe877d2ed8ea2c63abefa78808471ab8c26e858228178387a440a8f3
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.