René's URL Explorer Experiment


Title: Allow borrowing from NewReference by lostmsu · Pull Request #1088 · pythonnet/pythonnet · GitHub

Open Graph Title: Allow borrowing from NewReference by lostmsu · Pull Request #1088 · pythonnet/pythonnet

X Title: Allow borrowing from NewReference by lostmsu · Pull Request #1088 · pythonnet/pythonnet

Description: implemented as an implicit conversion To be honest, I would prefer an explicit NewReference.Borrow() method due to "explicit is better than implicit" motto. The only problem with implicit conversion that I see is new PyObject(newRef) will call an extra incref implicitly as opposed to newRef.MoveToPyObject(), and will go unnoticed. Another thing to consider is having a null-check in the conversion. E.g. should we throw NullReferenceException if NewReference is null? Does this close any currently open issues? Related to #1087 Checklist Check all those that are applicable and complete. Make sure to include one or more tests for your change If an enhancement PR, please create docs and at best an example

Open Graph Description: implemented as an implicit conversion To be honest, I would prefer an explicit NewReference.Borrow() method due to "explicit is better than implicit" motto. The only problem with implicit...

X Description: implemented as an implicit conversion To be honest, I would prefer an explicit NewReference.Borrow() method due to "explicit is better than implicit" motto. The only problem with ...

Opengraph URL: https://github.com/pythonnet/pythonnet/pull/1088

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3b5a8b41-85d4-99f6-98e6-842897f6a324
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id977E:1A86E7:880169:B7B8A6:6973C626
html-safe-nonced9fb5eebe1c35f962bc779df04a599bbcb7e29beaaf6328d37abfcfa9f3523f7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzdFOjFBODZFNzo4ODAxNjk6QjdCOEE2OjY5NzNDNjI2IiwidmlzaXRvcl9pZCI6IjY1MTQxMDI0NDIwNTkzNTE1OTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4c3ef57ac849cde97f7781c67b58b40ca9dac56a185f8a0f7c38395898143541
hovercard-subject-tagpull_request:386508475
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/1088/files
twitter:imagehttps://avatars.githubusercontent.com/u/239520?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/239520?s=400&v=4
og:image:altimplemented as an implicit conversion To be honest, I would prefer an explicit NewReference.Borrow() method due to "explicit is better than implicit" motto. The only problem with implicit...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacb8c988baca9616cb18bcb596629b823688faa1ef21a000061fe3616b4e3605
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git
octolytics-dimension-user_id6050430
octolytics-dimension-user_loginpythonnet
octolytics-dimension-repository_id14748123
octolytics-dimension-repository_nwopythonnet/pythonnet
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id14748123
octolytics-dimension-repository_network_root_nwopythonnet/pythonnet
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseaf4eb23c75c70abd61c0b216b767faf4c9a30817
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/pythonnet/pythonnet/pull/1088/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1088%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F1088%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=pythonnet%2Fpythonnet
Reloadhttps://github.com/pythonnet/pythonnet/pull/1088/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1088/files
Reloadhttps://github.com/pythonnet/pythonnet/pull/1088/files
pythonnet https://github.com/pythonnet
pythonnethttps://github.com/pythonnet/pythonnet
Notifications https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Fork 769 https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Star 5.4k https://github.com/login?return_to=%2Fpythonnet%2Fpythonnet
Code https://github.com/pythonnet/pythonnet
Issues 155 https://github.com/pythonnet/pythonnet/issues
Pull requests 18 https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects 0 https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security 0 https://github.com/pythonnet/pythonnet/security
Insights https://github.com/pythonnet/pythonnet/pulse
Code https://github.com/pythonnet/pythonnet
Issues https://github.com/pythonnet/pythonnet/issues
Pull requests https://github.com/pythonnet/pythonnet/pulls
Discussions https://github.com/pythonnet/pythonnet/discussions
Actions https://github.com/pythonnet/pythonnet/actions
Projects https://github.com/pythonnet/pythonnet/projects
Wiki https://github.com/pythonnet/pythonnet/wiki
Security https://github.com/pythonnet/pythonnet/security
Insights https://github.com/pythonnet/pythonnet/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
lostmsuhttps://github.com/lostmsu
pythonnet:masterhttps://github.com/pythonnet/pythonnet/tree/master
losttech:features/BorrowFromNewReferencehttps://github.com/losttech/pythonnet/tree/features/BorrowFromNewReference
Conversation 3 https://github.com/pythonnet/pythonnet/pull/1088
Commits 1 https://github.com/pythonnet/pythonnet/pull/1088/commits
Checks 0 https://github.com/pythonnet/pythonnet/pull/1088/checks
Files changed https://github.com/pythonnet/pythonnet/pull/1088/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1088/files
Allow borrowing from NewReference https://github.com/pythonnet/pythonnet/pull/1088/files#top
Show all changes 1 commit https://github.com/pythonnet/pythonnet/pull/1088/files
0f03624 allow borrowing from NewReference lostmsu Mar 11, 2020 https://github.com/pythonnet/pythonnet/pull/1088/commits/0f0362458ad2f6e7069af79b377e4308a00e111b
Clear filters https://github.com/pythonnet/pythonnet/pull/1088/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1088/files
Please reload this pagehttps://github.com/pythonnet/pythonnet/pull/1088/files
References.cs https://github.com/pythonnet/pythonnet/pull/1088/files#diff-b6bdcd132babd3b45e80d9e7cd65b9566c391391b2cb2ba47dbf9a141427d50c
NewReference.cs https://github.com/pythonnet/pythonnet/pull/1088/files#diff-068e7e2921c451819f9e8312de3669ee44d933385eba2e8a0bc51469aefbfcbc
src/embed_tests/References.cshttps://github.com/pythonnet/pythonnet/pull/1088/files#diff-b6bdcd132babd3b45e80d9e7cd65b9566c391391b2cb2ba47dbf9a141427d50c
View file https://github.com/losttech/pythonnet/blob/0f0362458ad2f6e7069af79b377e4308a00e111b/src/embed_tests/References.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1088/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1088/files#diff-b6bdcd132babd3b45e80d9e7cd65b9566c391391b2cb2ba47dbf9a141427d50c
src/runtime/NewReference.cshttps://github.com/pythonnet/pythonnet/pull/1088/files#diff-068e7e2921c451819f9e8312de3669ee44d933385eba2e8a0bc51469aefbfcbc
View file https://github.com/losttech/pythonnet/blob/0f0362458ad2f6e7069af79b377e4308a00e111b/src/runtime/NewReference.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pythonnet/pythonnet/pull/1088/{{ revealButtonHref }}
https://github.com/pythonnet/pythonnet/pull/1088/files#diff-068e7e2921c451819f9e8312de3669ee44d933385eba2e8a0bc51469aefbfcbc
https://github.com/pythonnet/pythonnet/pull/1088/files#diff-068e7e2921c451819f9e8312de3669ee44d933385eba2e8a0bc51469aefbfcbc
https://github.com/pythonnet/pythonnet/pull/1088/files#diff-068e7e2921c451819f9e8312de3669ee44d933385eba2e8a0bc51469aefbfcbc
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.