René's URL Explorer Experiment

Title: Add PyHandle by amos402 · Pull Request #1087 · pythonnet/pythonnet · GitHub

Open Graph Title: Add PyHandle by amos402 · Pull Request #1087 · pythonnet/pythonnet

X Title: Add PyHandle by amos402 · Pull Request #1087 · pythonnet/pythonnet

Description: What does this implement/fix? Explain your changes. Add a wrapper named PyHandle to replace IntPtr of C API. Refactor Rutime.XDecref and Runtime.XIncref. Add implcit operator for BorrowedReference and NewReference NewReference and BorrowedReference seem be good for helping user comprehend the type of return value quickly. But it should not interfere the general usage. When I tried to merge the code, I found that the DangerousGetAddress just keep annoying me. In many cases we have to use the raw IntPtr(e.g. put the Python object to a clr collection). Keep typing the long method name DangerousGetAddress just verbose since I must know that C API does return borrowed reference or new reference before using the C API. Also I can't the NewReference or BorrowedReference to the collection, because they're non-copyable. This may good cause no matter which put to the collection wouldn't make sense(e.g. List`, I still have to iterate it and Decref the objects when I clear the List). So, here by I introduce the PyHandle. Be more readable compare with the raw IntPtr, it contains some basic functions for the Python object for easy usage, can be implicit convert from NewReference or BorrowedReference. And it doesn't conflict with current code. Use the PyHandle instead of BorrowedReference as the parameter type should be more rantional. For example, such as int PyList_Append(BorrowedReference pointer, IntPtr value);, why the pointer should be a BorrowedReference? What about the value what's type it should be? Either New nor Borrowed both doesn't match. I may just created a PyList from PyList_New and it will return a NewReference, but I can't even use the return value through to the other functions, seems that doesn't match the general usage cases. Does this close any currently open issues? #1068 #1043 Any other comments? ... Checklist Check all those that are applicable and complete. Make sure to include one or more tests for your change If an enhancement PR, please create docs and at best an example Add yourself to AUTHORS Updated the CHANGELOG

Open Graph Description: What does this implement/fix? Explain your changes. Add a wrapper named PyHandle to replace IntPtr of C API. Refactor Rutime.XDecref and Runtime.XIncref. Add implcit operator for BorrowedReference...

X Description: What does this implement/fix? Explain your changes. Add a wrapper named PyHandle to replace IntPtr of C API. Refactor Rutime.XDecref and Runtime.XIncref. Add implcit operator for BorrowedReference...

Opengraph URL: https://github.com/pythonnet/pythonnet/pull/1087

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width