Title: Provide more info about failuers to load CLR assemblies by lostmsu · Pull Request #1076 · pythonnet/pythonnet · GitHub
Open Graph Title: Provide more info about failuers to load CLR assemblies by lostmsu · Pull Request #1076 · pythonnet/pythonnet
X Title: Provide more info about failuers to load CLR assemblies by lostmsu · Pull Request #1076 · pythonnet/pythonnet
Description: What does this implement/fix? Explain your changes. When trying to implicitly load assemblies, and that fails not because an assembly is missing, but because loading failed for some reason, emit Python warning. When trying to import a module in our import hook, if the module name is an assembly name, and CLR fails to load it, and Python also fails to find a module with the same name, add the exceptions we got from both during the attempt into __cause__ attribute of the final ImportError. BREAKING: clr.AddReference will now throw exceptions besides FileNotFoundException. Additional: a few uses of BorrowedReference Does this close any currently open issues? This addresses #261 It is an alternative to #298 Checklist Check all those that are applicable and complete. Make sure to include one or more tests for your change If an enhancement PR, please create docs and at best an example
Open Graph Description: What does this implement/fix? Explain your changes. When trying to implicitly load assemblies, and that fails not because an assembly is missing, but because loading failed for some reason, emit P...
X Description: What does this implement/fix? Explain your changes. When trying to implicitly load assemblies, and that fails not because an assembly is missing, but because loading failed for some reason, emit P...
Opengraph URL: https://github.com/pythonnet/pythonnet/pull/1076
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:bb430b05-3ccb-f153-9f91-be6d03110fe6 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | B4B2:6834D:243D142:306E878:69706614 |
| html-safe-nonce | 7de7f5e9e44178abbaa93224684d86f4c80d64bca03a93772f9c11e1919bb66a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEIyOjY4MzREOjI0M0QxNDI6MzA2RTg3ODo2OTcwNjYxNCIsInZpc2l0b3JfaWQiOiI2ODcxNDAzNjQwNDUxNTI0MTE2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 4ae3fb33fa05e66a205df18898572657ff40f0f2f6f9ec634c3ed7ead22b4196 |
| hovercard-subject-tag | pull_request:383283247 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/1076/checks |
| twitter:image | https://avatars.githubusercontent.com/u/239520?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/239520?s=400&v=4 |
| og:image:alt | What does this implement/fix? Explain your changes. When trying to implicitly load assemblies, and that fails not because an assembly is missing, but because loading failed for some reason, emit P... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2 |
| turbo-cache-control | no-preview |
| go-import | github.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git |
| octolytics-dimension-user_id | 6050430 |
| octolytics-dimension-user_login | pythonnet |
| octolytics-dimension-repository_id | 14748123 |
| octolytics-dimension-repository_nwo | pythonnet/pythonnet |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 14748123 |
| octolytics-dimension-repository_network_root_nwo | pythonnet/pythonnet |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7d6181066430cc06553c8396ca201e194ae33cb9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width