Title: Seeking Feedback for Potential PR: Method Binder IsAssignable From · Issue #529 · pythonnet/pythonnet · GitHub
Open Graph Title: Seeking Feedback for Potential PR: Method Binder IsAssignable From · Issue #529 · pythonnet/pythonnet
X Title: Seeking Feedback for Potential PR: Method Binder IsAssignable From · Issue #529 · pythonnet/pythonnet
Description: One of our team (@mchandschuh) suggested this line could be substituted for a "IsAssignableFrom" check. https://github.com/pythonnet/pythonnet/blob/master/src/runtime/methodbinder.cs#L60 The plan would be to make the generic-locator code...
Open Graph Description: One of our team (@mchandschuh) suggested this line could be substituted for a "IsAssignableFrom" check. https://github.com/pythonnet/pythonnet/blob/master/src/runtime/methodbinder.cs#L60 The plan w...
X Description: One of our team (@mchandschuh) suggested this line could be substituted for a "IsAssignableFrom" check. https://github.com/pythonnet/pythonnet/blob/master/src/runtime/methodbinder.cs#L60 ...
Opengraph URL: https://github.com/pythonnet/pythonnet/issues/529
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Seeking Feedback for Potential PR: Method Binder IsAssignable From","articleBody":"One of our team (@mchandschuh) suggested this line could be substituted for a \"IsAssignableFrom\" check. https://github.com/pythonnet/pythonnet/blob/master/src/runtime/methodbinder.cs#L60\r\n\r\nThe plan would be to make the generic-locator code more effective.\r\n\r\nmhandschuh [4:11 PM] \r\nI would recommend looking at the MethodBinder -- it appears to be matching directly on type and not using `Type.IsAssignableFrom` which should properly handle super types (going from SimpleMovingAverage to IndicatorBase\u003cIndicatorDataPoint\u003e)\r\n\r\nWe're not really sure the flow on impacts for the whole library -- is this feasible; or are other parts of the code dependent on this = statement?","author":{"url":"https://github.com/jaredbroad","@type":"Person","name":"jaredbroad"},"datePublished":"2017-08-25T20:25:29.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/529/pythonnet/issues/529"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:467e4a90-adad-e0e2-272a-dca58a1f789e |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E2A6:31CF89:12C7B04:199B385:6971DD55 |
| html-safe-nonce | 66bd1ef520483cb2d66dd3b29f6eb58cf0e7f823f82bdd57a9a0a739d5109ecf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMkE2OjMxQ0Y4OToxMkM3QjA0OjE5OUIzODU6Njk3MURENTUiLCJ2aXNpdG9yX2lkIjoiMzYyODIwODE2NTE5MjA2NDM0MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 20706760f2f12c778437c5d0c2559f39403589d17264a4e24c6ec20b6c47ce18 |
| hovercard-subject-tag | issue:253009100 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/pythonnet/pythonnet/529/issue_layout |
| twitter:image | https://opengraph.githubassets.com/783a541019b839bd6ae2f9e9a9e7fc19931c37e297f0d82b49190b79b380ebdb/pythonnet/pythonnet/issues/529 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/783a541019b839bd6ae2f9e9a9e7fc19931c37e297f0d82b49190b79b380ebdb/pythonnet/pythonnet/issues/529 |
| og:image:alt | One of our team (@mchandschuh) suggested this line could be substituted for a "IsAssignableFrom" check. https://github.com/pythonnet/pythonnet/blob/master/src/runtime/methodbinder.cs#L60 The plan w... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jaredbroad |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7476eb4140129667a7530d10cfb7688f701883e35a4dcaa4673e3ec599af5199 |
| turbo-cache-control | no-preview |
| go-import | github.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git |
| octolytics-dimension-user_id | 6050430 |
| octolytics-dimension-user_login | pythonnet |
| octolytics-dimension-repository_id | 14748123 |
| octolytics-dimension-repository_nwo | pythonnet/pythonnet |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 14748123 |
| octolytics-dimension-repository_network_root_nwo | pythonnet/pythonnet |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2cc0827c872b538cd08371730242ae4951d2d61a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width