René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"AssemblyManager.FindAssemblyCandidates runs without GIL and crashes with \"Attempted to read or write protected memory\" unpredictably","articleBody":"### Environment\r\n\r\n-   Pythonnet version: 3.0.4\r\n-   Python version: 3.11.9\r\n-   Operating System: Windows 11 Pro\r\n-   .NET Runtime: .NET Core 8\r\n\r\n### Details\r\n\r\nWhen assemblies are dynamically loaded in .NET, PythonNet assembly loading hook can crash with \"Attempted to read or write protected memory.\" I'm still trying to make a repro, but maybe you'll immediately see what's wrong.\r\n\r\nhttps://github.com/pythonnet/pythonnet/blob/de7a1d2d2aa505a4be5e4dee9368e514b6963bef/src/runtime/AssemblyManager.cs#L206\r\n\r\nI think that the issue may be that during assembly loading, the AssemblyManager hook runs without a GIL, so it _may_ crash with the error above. I've seen multiple stack traces happening at different times, often in code completely unrelated to PythonNet (there is multithreading, I use PythonEngine.BeginAllowThreads())\r\n\r\nThis did not happen in version 3.0.3.\r\n\r\n-   Describe what you were trying to get done.\r\n\r\n    Run an application normally that has more than one assembly being loaded (e.g. resources)\r\n\r\n-   What commands did you run to trigger this issue? If you can provide a\r\n    [Minimal, Complete, and Verifiable example](http://stackoverflow.com/help/mcve)\r\n    this will help us understand the issue.\r\n\r\nI will try to provide one, although it's difficult to reproduce reliably\r\n\r\n-   If there was a crash, please include the traceback here.\r\n\r\n```\r\nFatal error. System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.\r\n   at Python.Runtime.Runtime.PyObject_GetAttrString(Python.Runtime.BorrowedReference, System.String)\r\n   at Python.Runtime.AssemblyManager+\u003cFindAssemblyCandidates\u003ed__15.MoveNext()\r\n   at System.Linq.Enumerable.TryGetFirst[[System.__Canon, System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]](System.Collections.Generic.IEnumerable`1\u003cSystem.__Canon\u003e, Boolean ByRef)\r\n   at System.Linq.Enumerable.FirstOrDefault[[System.__Canon, System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]](System.Collections.Generic.IEnumerable`1\u003cSystem.__Canon\u003e)\r\n   at Python.Runtime.AssemblyManager.FindAssembly(System.String)\r\n   at Python.Runtime.AssemblyManager.LoadAssemblyPath(System.String)\r\n   at Python.Runtime.AssemblyManager.ResolveHandler(System.Object, System.ResolveEventArgs)\r\n   at System.Runtime.Loader.AssemblyLoadContext.InvokeResolveEvent(System.ResolveEventHandler, System.Reflection.RuntimeAssembly, System.String)\r\n   at System.Reflection.RuntimeAssembly.InternalLoad(System.Reflection.AssemblyName, System.Threading.StackCrawlMark ByRef, System.Runtime.Loader.AssemblyLoadContext, System.Reflection.RuntimeAssembly, Boolean)\r\n  at ...\r\n```\r\n","author":{"url":"https://github.com/acidbubbles","@type":"Person","name":"acidbubbles"},"datePublished":"2024-10-11T05:12:41.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/2481/pythonnet/issues/2481"}