René's URL Explorer Experiment


Title: Sprite scale: Preserve performance by einarf · Pull Request #2389 · pythonarcade/arcade · GitHub

Open Graph Title: Sprite scale: Preserve performance by einarf · Pull Request #2389 · pythonarcade/arcade

X Title: Sprite scale: Preserve performance by einarf · Pull Request #2389 · pythonarcade/arcade

Description: The Sprite.scale changes made the property 4-5 times slower. Instead we introduce methods to handle uniform scaling.

Open Graph Description: The Sprite.scale changes made the property 4-5 times slower. Instead we introduce methods to handle uniform scaling.

X Description: The Sprite.scale changes made the property 4-5 times slower. Instead we introduce methods to handle uniform scaling.

Opengraph URL: https://github.com/pythonarcade/arcade/pull/2389

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6c18e34d-324d-2b25-37c3-474c92821b15
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE7C6:2E1DE1:134C76E:19D7C97:69699E36
html-safe-nonce359465eb53ebb8cab8a8a993081546f9b666af00cb63c604d988823caa03a220
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0M2OjJFMURFMToxMzRDNzZFOjE5RDdDOTc6Njk2OTlFMzYiLCJ2aXNpdG9yX2lkIjoiMTM0NzY1NDU4MzU3ODUzNzUwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacaa6980ad3aa3e22fafa3747e5cd9fa45b900adbb73a2c7449f0376b63aa5b7fa
hovercard-subject-tagpull_request:2109243348
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/pythonarcade/arcade/2389/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c67d48045580ccd664e2767d116b5a7f957ed3c845eda116524af74f08e081cf/pythonarcade/arcade/pull/2389
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c67d48045580ccd664e2767d116b5a7f957ed3c845eda116524af74f08e081cf/pythonarcade/arcade/pull/2389
og:image:altThe Sprite.scale changes made the property 4-5 times slower. Instead we introduce methods to handle uniform scaling.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameeinarf
hostnamegithub.com
expected-hostnamegithub.com
None24c4c97a2d520cb286b35e1a4c22d7a4df3c26a2fa28dd7cdf0e65db327b4de7
turbo-cache-controlno-preview
go-importgithub.com/pythonarcade/arcade git https://github.com/pythonarcade/arcade.git
octolytics-dimension-user_id39569439
octolytics-dimension-user_loginpythonarcade
octolytics-dimension-repository_id49003082
octolytics-dimension-repository_nwopythonarcade/arcade
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49003082
octolytics-dimension-repository_network_root_nwopythonarcade/arcade
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release124667f43168afb6c9c03b7c02eb5b1d2e1be3d9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/pythonarcade/arcade/pull/2389#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonarcade%2Farcade%2Fpull%2F2389
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonarcade%2Farcade%2Fpull%2F2389
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=pythonarcade%2Farcade
Reloadhttps://github.com/pythonarcade/arcade/pull/2389
Reloadhttps://github.com/pythonarcade/arcade/pull/2389
Reloadhttps://github.com/pythonarcade/arcade/pull/2389
pythonarcade https://github.com/pythonarcade
arcadehttps://github.com/pythonarcade/arcade
Notifications https://github.com/login?return_to=%2Fpythonarcade%2Farcade
Fork 363 https://github.com/login?return_to=%2Fpythonarcade%2Farcade
Star 2k https://github.com/login?return_to=%2Fpythonarcade%2Farcade
Code https://github.com/pythonarcade/arcade
Issues 99 https://github.com/pythonarcade/arcade/issues
Pull requests 16 https://github.com/pythonarcade/arcade/pulls
Actions https://github.com/pythonarcade/arcade/actions
Projects 2 https://github.com/pythonarcade/arcade/projects
Wiki https://github.com/pythonarcade/arcade/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/pythonarcade/arcade/security
Please reload this pagehttps://github.com/pythonarcade/arcade/pull/2389
Insights https://github.com/pythonarcade/arcade/pulse
Code https://github.com/pythonarcade/arcade
Issues https://github.com/pythonarcade/arcade/issues
Pull requests https://github.com/pythonarcade/arcade/pulls
Actions https://github.com/pythonarcade/arcade/actions
Projects https://github.com/pythonarcade/arcade/projects
Wiki https://github.com/pythonarcade/arcade/wiki
Security https://github.com/pythonarcade/arcade/security
Insights https://github.com/pythonarcade/arcade/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpythonarcade%2Farcade%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpythonarcade%2Farcade%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/pythonarcade/arcade/pull/2389#issue-comment-box
DragonMoffonhttps://github.com/DragonMoffon
developmenthttps://github.com/pythonarcade/arcade/tree/development
scale-tweakshttps://github.com/pythonarcade/arcade/tree/scale-tweaks
Sprite scale: Preserve performance https://github.com/pythonarcade/arcade/pull/2389#top
DragonMoffonhttps://github.com/DragonMoffon
developmenthttps://github.com/pythonarcade/arcade/tree/development
scale-tweakshttps://github.com/pythonarcade/arcade/tree/scale-tweaks
Conversation 5 https://github.com/pythonarcade/arcade/pull/2389
Commits 12 https://github.com/pythonarcade/arcade/pull/2389/commits
Checks 0 https://github.com/pythonarcade/arcade/pull/2389/checks
Files changed https://github.com/pythonarcade/arcade/pull/2389/files
Please reload this pagehttps://github.com/pythonarcade/arcade/pull/2389
https://github.co/hiddenchars
https://github.com/pythonarcade/arcade/pull/{{ revealButtonHref }}
https://github.com/einarf
einarfhttps://github.com/einarf
Oct 6, 2024https://github.com/pythonarcade/arcade/pull/2389#issue-2568421072
Please reload this pagehttps://github.com/pythonarcade/arcade/pull/2389
einarfhttps://github.com/einarf
October 6, 2024 04:18https://github.com/pythonarcade/arcade/pull/2389#commits-pushed-8a2b1de
https://github.com/einarf
Initial workhttps://github.com/pythonarcade/arcade/pull/2389/commits/8a2b1de370cf93f601c4bc2183a1423bd8518eea
8a2b1dehttps://github.com/pythonarcade/arcade/pull/2389/commits/8a2b1de370cf93f601c4bc2183a1423bd8518eea
https://github.com/einarf
More fixes + testshttps://github.com/pythonarcade/arcade/pull/2389/commits/ca6aa9b1073c3b0b38f2abe52b051c0dc7fce74b
ca6aa9bhttps://github.com/pythonarcade/arcade/pull/2389/commits/ca6aa9b1073c3b0b38f2abe52b051c0dc7fce74b
https://github.com/einarf
Example fixeshttps://github.com/pythonarcade/arcade/pull/2389/commits/d369c451e2bf5db21b6e98e6244f5c302be75ea2
d369c45https://github.com/pythonarcade/arcade/pull/2389/commits/d369c451e2bf5db21b6e98e6244f5c302be75ea2
https://github.com/einarf
einarfhttps://github.com/einarf
Oct 7, 2024 https://github.com/pythonarcade/arcade/pull/2389#ref-issue-2433949237
Review performance impact of Sprite.scale changes #2324 https://github.com/pythonarcade/arcade/issues/2324
https://github.com/einarf
einarfhttps://github.com/einarf
DigiDuncanhttps://github.com/DigiDuncan
DragonMoffonhttps://github.com/DragonMoffon
October 8, 2024 21:34https://github.com/pythonarcade/arcade/pull/2389#event-14563132978
https://github.com/DragonMoffon
DragonMoffonhttps://github.com/DragonMoffon
Oct 8, 2024https://github.com/pythonarcade/arcade/pull/2389#issuecomment-2400969975
Please reload this pagehttps://github.com/pythonarcade/arcade/pull/2389
https://github.com/DigiDuncan
DigiDuncanhttps://github.com/DigiDuncan
Oct 8, 2024https://github.com/pythonarcade/arcade/pull/2389#issuecomment-2400979658
Please reload this pagehttps://github.com/pythonarcade/arcade/pull/2389
https://github.com/einarf
einarfhttps://github.com/einarf
Oct 8, 2024https://github.com/pythonarcade/arcade/pull/2389#issuecomment-2401002590
Please reload this pagehttps://github.com/pythonarcade/arcade/pull/2389
#2399https://github.com/pythonarcade/arcade/issues/2399
Please reload this pagehttps://github.com/pythonarcade/arcade/pull/2389
DragonMoffonhttps://github.com/DragonMoffon
October 10, 2024 22:27https://github.com/pythonarcade/arcade/pull/2389#commits-pushed-d0a68db
https://github.com/DragonMoffon
Updated scale method names, and reimplimented scalar setting of scalehttps://github.com/pythonarcade/arcade/pull/2389/commits/d0a68db0ea1b120425b6d5c9d043205ee4156f7e
d0a68dbhttps://github.com/pythonarcade/arcade/pull/2389/commits/d0a68db0ea1b120425b6d5c9d043205ee4156f7e
https://github.com/DragonMoffon
Fix examples and tutorialshttps://github.com/pythonarcade/arcade/pull/2389/commits/492ce7ae54e152664175e55aeac0201d3536944b
492ce7ahttps://github.com/pythonarcade/arcade/pull/2389/commits/492ce7ae54e152664175e55aeac0201d3536944b
https://github.com/DragonMoffon
fixing typing errorhttps://github.com/pythonarcade/arcade/pull/2389/commits/b39cf5d7bba7a80268038acaa25007a37aac15b9
b39cf5dhttps://github.com/pythonarcade/arcade/pull/2389/commits/b39cf5d7bba7a80268038acaa25007a37aac15b9
https://github.com/DragonMoffon
linting and type passhttps://github.com/pythonarcade/arcade/pull/2389/commits/3c50ddf6f6167f7bc6a43e1210ba618cd42710c1
3c50ddfhttps://github.com/pythonarcade/arcade/pull/2389/commits/3c50ddf6f6167f7bc6a43e1210ba618cd42710c1
https://github.com/DragonMoffon
DragonMoffonhttps://github.com/DragonMoffon
Oct 10, 2024 https://github.com/pythonarcade/arcade/pull/2389#pullrequestreview-2361334619
View reviewed changes https://github.com/pythonarcade/arcade/pull/2389/files/3c50ddf6f6167f7bc6a43e1210ba618cd42710c1
arcade/examples/sprite_explosion_particles.pyhttps://github.com/pythonarcade/arcade/pull/2389/files/3c50ddf6f6167f7bc6a43e1210ba618cd42710c1#diff-d7c11cd30c6c31a67b69b473993a0a7e3dd9cac128a0c27fc290064f59d9bf5f
Please reload this pagehttps://github.com/pythonarcade/arcade/pull/2389
https://github.com/DragonMoffon
last place the old method was hidinghttps://github.com/pythonarcade/arcade/pull/2389/commits/6744f6922818a33a1c2a6d4e370fa9b710fbf41d
6744f69https://github.com/pythonarcade/arcade/pull/2389/commits/6744f6922818a33a1c2a6d4e370fa9b710fbf41d
https://github.com/DigiDuncan
DigiDuncanhttps://github.com/DigiDuncan
October 11, 2024 10:36https://github.com/pythonarcade/arcade/pull/2389#event-14606664596
https://github.com/DragonMoffon
DragonMoffonhttps://github.com/DragonMoffon
Oct 11, 2024 https://github.com/pythonarcade/arcade/pull/2389#pullrequestreview-2362497665
View reviewed changes https://github.com/pythonarcade/arcade/pull/2389/files/6744f6922818a33a1c2a6d4e370fa9b710fbf41d
https://github.com/DigiDuncan
DigiDuncanhttps://github.com/DigiDuncan
Oct 11, 2024 https://github.com/pythonarcade/arcade/pull/2389#pullrequestreview-2362499171
View reviewed changes https://github.com/pythonarcade/arcade/pull/2389/files/6744f6922818a33a1c2a6d4e370fa9b710fbf41d
DigiDuncanhttps://github.com/DigiDuncan
https://github.com/pythonarcade/arcade/pull/2389#pullrequestreview-2362499171
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/pythonarcade/arcade/pull/2389
DragonMoffonhttps://github.com/DragonMoffon
October 12, 2024 14:07https://github.com/pythonarcade/arcade/pull/2389#commits-pushed-01ca6df
https://github.com/DragonMoffon
perf tests and improved scale setterhttps://github.com/pythonarcade/arcade/pull/2389/commits/01ca6df9a0fdc53e59e39d557633f6e1c4082445
01ca6dfhttps://github.com/pythonarcade/arcade/pull/2389/commits/01ca6df9a0fdc53e59e39d557633f6e1c4082445
https://github.com/DragonMoffon
comparing func vs unpacking and random numbers in perf testhttps://github.com/pythonarcade/arcade/pull/2389/commits/1981ad5a26d1585fbb394104089f72389a614bd4
1981ad5https://github.com/pythonarcade/arcade/pull/2389/commits/1981ad5a26d1585fbb394104089f72389a614bd4
https://github.com/DragonMoffon
arcade scale incorect type unit testhttps://github.com/pythonarcade/arcade/pull/2389/commits/c46defd83390052f892072332d86963f9f94bf4a
c46defdhttps://github.com/pythonarcade/arcade/pull/2389/commits/c46defd83390052f892072332d86963f9f94bf4a
Review performance impact of Sprite.scale changes #2324 https://github.com/pythonarcade/arcade/issues/2324
Allow tuple scale in arcade.Sprite init, same as the setter #2399 https://github.com/pythonarcade/arcade/issues/2399
https://github.com/DragonMoffon
Merge branch 'development' into scale-tweakshttps://github.com/pythonarcade/arcade/pull/2389/commits/889d906035ffa780aa786438054add474e5ee556
889d906https://github.com/pythonarcade/arcade/pull/2389/commits/889d906035ffa780aa786438054add474e5ee556
https://github.com/DragonMoffon
DragonMoffonhttps://github.com/DragonMoffon
0444db5https://github.com/pythonarcade/arcade/commit/0444db547fd409ca259cfac0306efc05e55cada0
Oct 14, 2024https://github.com/pythonarcade/arcade/pull/2389#event-14634542361
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonarcade%2Farcade%2Fpull%2F2389
https://github.com/DigiDuncan
DigiDuncan https://github.com/DigiDuncan
https://github.com/pythonarcade/arcade/pull/2389/files/6744f6922818a33a1c2a6d4e370fa9b710fbf41d
https://github.com/DragonMoffon
DragonMoffon https://github.com/DragonMoffon
https://github.com/pythonarcade/arcade/pull/2389/files/6744f6922818a33a1c2a6d4e370fa9b710fbf41d
Allow tuple scale in arcade.Sprite init, same as the setter https://github.com/pythonarcade/arcade/issues/2399
Review performance impact of Sprite.scale changes https://github.com/pythonarcade/arcade/issues/2324
Please reload this pagehttps://github.com/pythonarcade/arcade/pull/2389
https://github.com/einarf
https://github.com/DragonMoffon
https://github.com/DigiDuncan
https://github.com/apps/copilot-swe-agent
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.