René's URL Explorer Experiment


Title: Simplify the can_send_to check by bdraco · Pull Request #990 · python-zeroconf/python-zeroconf · GitHub

Open Graph Title: Simplify the can_send_to check by bdraco · Pull Request #990 · python-zeroconf/python-zeroconf

X Title: Simplify the can_send_to check by bdraco · Pull Request #990 · python-zeroconf/python-zeroconf

Description: There is no need to call can_send_to when we derive the target since we already know we can send to it. can_send_to was converting the addr string into an ipaddress object to check if it was IPv4 or IPv6. Since this all happens internally there was no need for the additional validation and check. We can use a must more simple test.

Open Graph Description: There is no need to call can_send_to when we derive the target since we already know we can send to it. can_send_to was converting the addr string into an ipaddress object to check if it was IPv4...

X Description: There is no need to call can_send_to when we derive the target since we already know we can send to it. can_send_to was converting the addr string into an ipaddress object to check if it was IPv4...

Opengraph URL: https://github.com/python-zeroconf/python-zeroconf/pull/990

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1471cd33-df71-57aa-c004-7c7c6442f8d0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9E56:2E2180:8F1F63:C52932:6B00A1CB
html-safe-nonce33ff1ae6fde9da1ce4e1b843c50397a87615011387aaf89a1f62a2f6b12e75a3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTU2OjJFMjE4MDo4RjFGNjM6QzUyOTMyOjZCMDBBMUNCIiwidmlzaXRvcl9pZCI6IjI0ODk5NjYwMjEzMTA0NTYyNjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac806a15b114e609461d39ecba0ed2ce3518651436c1bd045d8bd0e841d16f620b
hovercard-subject-tagpull_request:737041049
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-zeroconf/python-zeroconf/pull/990/files
twitter:imagehttps://avatars.githubusercontent.com/u/663432?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/663432?s=400&v=4
og:image:altThere is no need to call can_send_to when we derive the target since we already know we can send to it. can_send_to was converting the addr string into an ipaddress object to check if it was IPv4...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None52c95ce7e48016ae14399656b4ee812462b6f1fa28c5008c8394da64794c00b8
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git
octolytics-dimension-user_id120192235
octolytics-dimension-user_loginpython-zeroconf
octolytics-dimension-repository_id21548731
octolytics-dimension-repository_nwopython-zeroconf/python-zeroconf
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21548731
octolytics-dimension-repository_network_root_nwopython-zeroconf/python-zeroconf
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1c9ddec8215f9a94e295c8310c3579b9c54ba31a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-zeroconf/python-zeroconf/pull/990/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F990%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F990%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/990/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/990/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/990/files
python-zeroconfhttps://github.com/python-zeroconf
python-zeroconfhttps://github.com/python-zeroconf/python-zeroconf
Codehttps://github.com/python-zeroconf/python-zeroconf
Issues50 (50)https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests16 (16)https://github.com/python-zeroconf/python-zeroconf/pulls
Discussionshttps://github.com/python-zeroconf/python-zeroconf/discussions
Actionshttps://github.com/python-zeroconf/python-zeroconf/actions
Projectshttps://github.com/python-zeroconf/python-zeroconf/projects
Wikihttps://github.com/python-zeroconf/python-zeroconf/wiki
Security and quality5 (5)https://github.com/python-zeroconf/python-zeroconf/security
Insightshttps://github.com/python-zeroconf/python-zeroconf/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
bdracohttps://github.com/bdraco
python-zeroconf:masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
bdraco:simplify_can_send_tohttps://github.com/bdraco/python-zeroconf/tree/simplify_can_send_to
Conversation 3 https://github.com/python-zeroconf/python-zeroconf/pull/990
Commits 1 https://github.com/python-zeroconf/python-zeroconf/pull/990/commits
Checks 0 https://github.com/python-zeroconf/python-zeroconf/pull/990/checks
Files changed https://github.com/python-zeroconf/python-zeroconf/pull/990/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/990/files
Simplify the can_send_to check https://github.com/python-zeroconf/python-zeroconf/pull/990/files#top
Show all changes 1 commit https://github.com/python-zeroconf/python-zeroconf/pull/990/files
9df5203 Simplify the can_send_to check bdraco Sep 19, 2021 https://github.com/python-zeroconf/python-zeroconf/pull/990/commits/9df5203d3d2787033c99a5054121ccfcd7c1c9c5
Clear filters https://github.com/python-zeroconf/python-zeroconf/pull/990/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/990/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/990/files
__init__.py https://github.com/python-zeroconf/python-zeroconf/pull/990/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
_core.py https://github.com/python-zeroconf/python-zeroconf/pull/990/files#diff-750ed0c2ea67041705a919870d16a3bd6d463ac0ab68371f92ab75d4a5257a8d
net.py https://github.com/python-zeroconf/python-zeroconf/pull/990/files#diff-70cd068d887d4b68ba9cc1708ad06cde61794f04fa27151760fb88ab15afa1a1
zeroconf/__init__.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/990/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
View file https://github.com/bdraco/python-zeroconf/blob/9df5203d3d2787033c99a5054121ccfcd7c1c9c5/zeroconf/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/990/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/990/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
https://github.com/python-zeroconf/python-zeroconf/pull/990/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
zeroconf/_core.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/990/files#diff-750ed0c2ea67041705a919870d16a3bd6d463ac0ab68371f92ab75d4a5257a8d
View file https://github.com/bdraco/python-zeroconf/blob/9df5203d3d2787033c99a5054121ccfcd7c1c9c5/zeroconf/_core.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/990/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/990/files#diff-750ed0c2ea67041705a919870d16a3bd6d463ac0ab68371f92ab75d4a5257a8d
https://github.com/python-zeroconf/python-zeroconf/pull/990/files#diff-750ed0c2ea67041705a919870d16a3bd6d463ac0ab68371f92ab75d4a5257a8d
https://github.com/python-zeroconf/python-zeroconf/pull/990/files#diff-750ed0c2ea67041705a919870d16a3bd6d463ac0ab68371f92ab75d4a5257a8d
zeroconf/_utils/net.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/990/files#diff-70cd068d887d4b68ba9cc1708ad06cde61794f04fa27151760fb88ab15afa1a1
View file https://github.com/bdraco/python-zeroconf/blob/9df5203d3d2787033c99a5054121ccfcd7c1c9c5/zeroconf/_utils/net.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/990/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/990/files#diff-70cd068d887d4b68ba9cc1708ad06cde61794f04fa27151760fb88ab15afa1a1
https://github.com/python-zeroconf/python-zeroconf/pull/990/files#diff-70cd068d887d4b68ba9cc1708ad06cde61794f04fa27151760fb88ab15afa1a1
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.