René's URL Explorer Experiment


Title: Let connection_lost close the underlying socket by bdraco · Pull Request #918 · python-zeroconf/python-zeroconf · GitHub

Open Graph Title: Let connection_lost close the underlying socket by bdraco · Pull Request #918 · python-zeroconf/python-zeroconf

X Title: Let connection_lost close the underlying socket by bdraco · Pull Request #918 · python-zeroconf/python-zeroconf

Description: A pure python implementation of multicast DNS service discovery - Let connection_lost close the underlying socket by bdraco · Pull Request #918 · python-zeroconf/python-zeroconf

Open Graph Description: Fixes #917 The socket was closed during shutdown before asyncio's connection_lost handler had a chance to close it which resulted in a traceback on win32.

X Description: Fixes #917 The socket was closed during shutdown before asyncio's connection_lost handler had a chance to close it which resulted in a traceback on win32.

Opengraph URL: https://github.com/python-zeroconf/python-zeroconf/pull/918

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f9d14677-76d5-8fc7-93cb-29cc5848dafe
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAD3E:39D56:36D06CE:46CAAE1:6990F7B2
html-safe-nonceef68a963fedcbc476eb2099a45e4aa0b91e5b8f7eb8f8795b056d5a2db9e5d3f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDNFOjM5RDU2OjM2RDA2Q0U6NDZDQUFFMTo2OTkwRjdCMiIsInZpc2l0b3JfaWQiOiI3MTUwMzkzMTExMDAwMTg0NzU0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac15b34da095dcff15955760f631f75656f81acbd56a97519d39b8556293a22831
hovercard-subject-tagpull_request:692198854
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-zeroconf/python-zeroconf/918/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/53eb0442984bf40cca8948552a88b4573010fd196c7c4b9b466996442586a733/python-zeroconf/python-zeroconf/pull/918
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/53eb0442984bf40cca8948552a88b4573010fd196c7c4b9b466996442586a733/python-zeroconf/python-zeroconf/pull/918
og:image:altFixes #917 The socket was closed during shutdown before asyncio's connection_lost handler had a chance to close it which resulted in a traceback on win32.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebdraco
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git
octolytics-dimension-user_id120192235
octolytics-dimension-user_loginpython-zeroconf
octolytics-dimension-repository_id21548731
octolytics-dimension-repository_nwopython-zeroconf/python-zeroconf
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21548731
octolytics-dimension-repository_network_root_nwopython-zeroconf/python-zeroconf
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-zeroconf/python-zeroconf/pull/918#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F918
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F918
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/918
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/918
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/918
python-zeroconf https://github.com/python-zeroconf
python-zeroconfhttps://github.com/python-zeroconf/python-zeroconf
Notifications https://github.com/login?return_to=%2Fpython-zeroconf%2Fpython-zeroconf
Fork 231 https://github.com/login?return_to=%2Fpython-zeroconf%2Fpython-zeroconf
Star 711 https://github.com/login?return_to=%2Fpython-zeroconf%2Fpython-zeroconf
Code https://github.com/python-zeroconf/python-zeroconf
Issues 51 https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests 7 https://github.com/python-zeroconf/python-zeroconf/pulls
Discussions https://github.com/python-zeroconf/python-zeroconf/discussions
Actions https://github.com/python-zeroconf/python-zeroconf/actions
Projects 0 https://github.com/python-zeroconf/python-zeroconf/projects
Wiki https://github.com/python-zeroconf/python-zeroconf/wiki
Security 0 https://github.com/python-zeroconf/python-zeroconf/security
Insights https://github.com/python-zeroconf/python-zeroconf/pulse
Code https://github.com/python-zeroconf/python-zeroconf
Issues https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests https://github.com/python-zeroconf/python-zeroconf/pulls
Discussions https://github.com/python-zeroconf/python-zeroconf/discussions
Actions https://github.com/python-zeroconf/python-zeroconf/actions
Projects https://github.com/python-zeroconf/python-zeroconf/projects
Wiki https://github.com/python-zeroconf/python-zeroconf/wiki
Security https://github.com/python-zeroconf/python-zeroconf/security
Insights https://github.com/python-zeroconf/python-zeroconf/pulse
bdracohttps://github.com/bdraco
python-zeroconf:masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
bdraco:supress_bthttps://github.com/bdraco/python-zeroconf/tree/supress_bt
Conversationhttps://github.com/python-zeroconf/python-zeroconf/pull/918
Commits12 (12)https://github.com/python-zeroconf/python-zeroconf/pull/918/commits
Checkshttps://github.com/python-zeroconf/python-zeroconf/pull/918/checks
Files changedhttps://github.com/python-zeroconf/python-zeroconf/pull/918/files
Let connection_lost close the underlying sockethttps://github.com/python-zeroconf/python-zeroconf/pull/918#top
bdracohttps://github.com/bdraco
python-zeroconf:masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
bdraco:supress_bthttps://github.com/bdraco/python-zeroconf/tree/supress_bt
https://github.com/bdraco
bdracohttps://github.com/bdraco
Jul 19, 2021https://github.com/python-zeroconf/python-zeroconf/pull/918#issue-947180792
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/918
#917https://github.com/python-zeroconf/python-zeroconf/issues/917
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/918
https://github.com/bdraco
Suppress log backtrace when shutdown during startuphttps://github.com/python-zeroconf/python-zeroconf/pull/918/commits/c4a17ee39ba31fe828530fc37b09d21c5eaeed92
c4a17eehttps://github.com/python-zeroconf/python-zeroconf/pull/918/commits/c4a17ee39ba31fe828530fc37b09d21c5eaeed92
https://github.com/bdraco
bdracohttps://github.com/bdraco
force-pushedhttps://github.com/python-zeroconf/python-zeroconf/compare/481d7a764f4f24bdb9438454215664259969a954..c4a17ee39ba31fe828530fc37b09d21c5eaeed92
481d7a7https://github.com/python-zeroconf/python-zeroconf/commit/481d7a764f4f24bdb9438454215664259969a954
c4a17eehttps://github.com/python-zeroconf/python-zeroconf/commit/c4a17ee39ba31fe828530fc37b09d21c5eaeed92
Compare https://github.com/python-zeroconf/python-zeroconf/compare/481d7a764f4f24bdb9438454215664259969a954..c4a17ee39ba31fe828530fc37b09d21c5eaeed92
July 19, 2021 01:50https://github.com/python-zeroconf/python-zeroconf/pull/918#event-5035726763
https://github.com/codecov-commenter
codecov-commenterhttps://github.com/codecov-commenter
Jul 19, 2021https://github.com/python-zeroconf/python-zeroconf/pull/918#issuecomment-882169800
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/918
Codecovhttps://codecov.io/gh/jstasiak/python-zeroconf/pull/918?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
#918https://codecov.io/gh/jstasiak/python-zeroconf/pull/918?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
1602977https://github.com/python-zeroconf/python-zeroconf/commit/1602977eec93ae60b98619d490eba2f9697dcee5
masterhttps://codecov.io/gh/jstasiak/python-zeroconf/commit/b6eaf7249f386f573b0876204ccfdfa02ee9ac5b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
b6eaf72https://github.com/python-zeroconf/python-zeroconf/commit/b6eaf7249f386f573b0876204ccfdfa02ee9ac5b
https://codecov.io/gh/jstasiak/python-zeroconf/pull/918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
Impacted Fileshttps://codecov.io/gh/jstasiak/python-zeroconf/pull/918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
zeroconf/_core.pyhttps://codecov.io/gh/jstasiak/python-zeroconf/pull/918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak#diff-emVyb2NvbmYvX2NvcmUucHk=
Continue to review full report at Codecovhttps://codecov.io/gh/jstasiak/python-zeroconf/pull/918?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
Codecovhttps://codecov.io/gh/jstasiak/python-zeroconf/pull/918?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
b6eaf72...1602977https://codecov.io/gh/jstasiak/python-zeroconf/pull/918?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
comment docshttps://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/918
https://github.com/bdraco
bdracohttps://github.com/bdraco
Jul 19, 2021 https://github.com/python-zeroconf/python-zeroconf/pull/918#ref-issue-947110265
Sample code causes Windows OSError #10038 #917 https://github.com/python-zeroconf/python-zeroconf/issues/917
https://github.com/bdraco
Wait for connection_losthttps://github.com/python-zeroconf/python-zeroconf/pull/918/commits/acf9d9330ab13359425a622ec9f8204724c012fb
acf9d93https://github.com/python-zeroconf/python-zeroconf/pull/918/commits/acf9d9330ab13359425a622ec9f8204724c012fb
https://github.com/bdraco
bdracohttps://github.com/bdraco
Jul 19, 2021https://github.com/python-zeroconf/python-zeroconf/pull/918#event-5035890199
bdracohttps://github.com/bdraco
July 18, 2021 17:00https://github.com/python-zeroconf/python-zeroconf/pull/918#commits-pushed-1e56a69
https://github.com/bdraco
Wait for connection_losthttps://github.com/python-zeroconf/python-zeroconf/pull/918/commits/1e56a69efc37c0af1da73c7f7f5f4db80ac5018b
1e56a69https://github.com/python-zeroconf/python-zeroconf/pull/918/commits/1e56a69efc37c0af1da73c7f7f5f4db80ac5018b
https://github.com/bdraco
Wait for connection_losthttps://github.com/python-zeroconf/python-zeroconf/pull/918/commits/5dbb3037f58443b21257c538f13b09360642735c
5dbb303https://github.com/python-zeroconf/python-zeroconf/pull/918/commits/5dbb3037f58443b21257c538f13b09360642735c
https://github.com/bdraco
Wait for connection_losthttps://github.com/python-zeroconf/python-zeroconf/pull/918/commits/91f6633ac223c5809e76c362fcfa38ca945beabc
91f6633https://github.com/python-zeroconf/python-zeroconf/pull/918/commits/91f6633ac223c5809e76c362fcfa38ca945beabc
https://github.com/bdraco
Wait for connection_losthttps://github.com/python-zeroconf/python-zeroconf/pull/918/commits/8029f403022a9e9f02f3d8a2625c8c1bc93f289e
8029f40https://github.com/python-zeroconf/python-zeroconf/pull/918/commits/8029f403022a9e9f02f3d8a2625c8c1bc93f289e
https://github.com/bdraco
bdracohttps://github.com/bdraco
Jul 19, 2021 https://github.com/python-zeroconf/python-zeroconf/pull/918#pullrequestreview-709119715
View reviewed changes https://github.com/python-zeroconf/python-zeroconf/pull/918/files/8029f403022a9e9f02f3d8a2625c8c1bc93f289e
zeroconf/_core.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/918/files/8029f403022a9e9f02f3d8a2625c8c1bc93f289e#diff-750ed0c2ea67041705a919870d16a3bd6d463ac0ab68371f92ab75d4a5257a8d
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/918
bdracohttps://github.com/bdraco
July 18, 2021 17:10https://github.com/python-zeroconf/python-zeroconf/pull/918#commits-pushed-62e1db0
https://github.com/bdraco
Wait for connection_losthttps://github.com/python-zeroconf/python-zeroconf/pull/918/commits/62e1db01b9d39c84188e39aab82a56469ef46cd7
62e1db0https://github.com/python-zeroconf/python-zeroconf/pull/918/commits/62e1db01b9d39c84188e39aab82a56469ef46cd7
https://github.com/bdraco
Wait for connection_losthttps://github.com/python-zeroconf/python-zeroconf/pull/918/commits/e191af4547bca429bdc5450620e452efceed2d9b
e191af4https://github.com/python-zeroconf/python-zeroconf/pull/918/commits/e191af4547bca429bdc5450620e452efceed2d9b
https://github.com/bdraco
let connection lost do ithttps://github.com/python-zeroconf/python-zeroconf/pull/918/commits/4fd471f7e085ce8274fbce5727a3644d80479a18
4fd471fhttps://github.com/python-zeroconf/python-zeroconf/pull/918/commits/4fd471f7e085ce8274fbce5727a3644d80479a18
https://github.com/bdraco
preenhttps://github.com/python-zeroconf/python-zeroconf/pull/918/commits/e3090cf0ebe9f9beb01c77b2ec96dab5d9c64223
e3090cfhttps://github.com/python-zeroconf/python-zeroconf/pull/918/commits/e3090cf0ebe9f9beb01c77b2ec96dab5d9c64223
https://github.com/bdraco
should never throwhttps://github.com/python-zeroconf/python-zeroconf/pull/918/commits/460b865e39be047a9a388f6697c409ad1e8df5dc
460b865https://github.com/python-zeroconf/python-zeroconf/pull/918/commits/460b865e39be047a9a388f6697c409ad1e8df5dc
https://github.com/bdraco
blackhttps://github.com/python-zeroconf/python-zeroconf/pull/918/commits/1602977eec93ae60b98619d490eba2f9697dcee5
1602977https://github.com/python-zeroconf/python-zeroconf/pull/918/commits/1602977eec93ae60b98619d490eba2f9697dcee5
https://github.com/bdraco
bdracohttps://github.com/bdraco
Jul 19, 2021https://github.com/python-zeroconf/python-zeroconf/pull/918#event-5035956228
https://github.com/bdraco
bdracohttps://github.com/bdraco
Jul 19, 2021https://github.com/python-zeroconf/python-zeroconf/pull/918#event-5035956462
https://github.com/bdraco
bdracohttps://github.com/bdraco
Jul 19, 2021https://github.com/python-zeroconf/python-zeroconf/pull/918#issuecomment-882209535
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/918
https://github.com/bdraco
bdracohttps://github.com/bdraco
July 19, 2021 04:07https://github.com/python-zeroconf/python-zeroconf/pull/918#event-5036037991
https://github.com/bdraco
bdracohttps://github.com/bdraco
919b096https://github.com/python-zeroconf/python-zeroconf/commit/919b096d6260a4f9f4306b9b4dddb5b026b49462
Jul 19, 2021https://github.com/python-zeroconf/python-zeroconf/pull/918#event-5036039017
https://github.com/bdraco
bdracohttps://github.com/bdraco
July 19, 2021 04:07https://github.com/python-zeroconf/python-zeroconf/pull/918#event-5036039104
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F918
Sample code causes Windows OSError #10038 https://github.com/python-zeroconf/python-zeroconf/issues/917
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/918
https://github.com/bdraco
https://github.com/codecov-commenter
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.