René's URL Explorer Experiment


Title: Only wake up the query loop when there is a change in the next query time by bdraco · Pull Request #818 · python-zeroconf/python-zeroconf · GitHub

Open Graph Title: Only wake up the query loop when there is a change in the next query time by bdraco · Pull Request #818 · python-zeroconf/python-zeroconf

X Title: Only wake up the query loop when there is a change in the next query time by bdraco · Pull Request #818 · python-zeroconf/python-zeroconf

Description: The ServiceBrowser query loop (async_browser_task) was being awoken on every packet because it was using zeroconf.async_wait which wakes up on every new packet. We only need to awaken the loop when the next time we are going to send a query has changed. fixes #814 fixes #768

Open Graph Description: The ServiceBrowser query loop (async_browser_task) was being awoken on every packet because it was using zeroconf.async_wait which wakes up on every new packet. We only need to awaken the loop whe...

X Description: The ServiceBrowser query loop (async_browser_task) was being awoken on every packet because it was using zeroconf.async_wait which wakes up on every new packet. We only need to awaken the loop whe...

Opengraph URL: https://github.com/python-zeroconf/python-zeroconf/pull/818

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6ac9fba1-6a19-9508-5ae3-6ecc512fcb1c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id88C0:2ADD62:91B331:C2E7AD:6B00B64C
html-safe-nonce452596704e9333df9c20d6acaf3167c3a2c43b1697b8db196b0eb8cd1587efa3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OEMwOjJBREQ2Mjo5MUIzMzE6QzJFN0FEOjZCMDBCNjRDIiwidmlzaXRvcl9pZCI6IjY3Mjg4MjYwNTA2OTM4NzExODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacbe4418601e1d88ccb873cacc3d4db7d01dd241abca6634802f6efa496f50ac61
hovercard-subject-tagpull_request:675824796
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-zeroconf/python-zeroconf/pull/818/files
twitter:imagehttps://avatars.githubusercontent.com/u/663432?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/663432?s=400&v=4
og:image:altThe ServiceBrowser query loop (async_browser_task) was being awoken on every packet because it was using zeroconf.async_wait which wakes up on every new packet. We only need to awaken the loop whe...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None1d07c25977adfc5ff6acb0a962a9bc168c07afbda6fef765f9761c350c2ae4a2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git
octolytics-dimension-user_id120192235
octolytics-dimension-user_loginpython-zeroconf
octolytics-dimension-repository_id21548731
octolytics-dimension-repository_nwopython-zeroconf/python-zeroconf
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21548731
octolytics-dimension-repository_network_root_nwopython-zeroconf/python-zeroconf
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5429cbfc6aca8c7b9a086a3c8f47400346f38cc9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-zeroconf/python-zeroconf/pull/818/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F818%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F818%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/818/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/818/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/818/files
python-zeroconfhttps://github.com/python-zeroconf
python-zeroconfhttps://github.com/python-zeroconf/python-zeroconf
Codehttps://github.com/python-zeroconf/python-zeroconf
Issues50 (50)https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests16 (16)https://github.com/python-zeroconf/python-zeroconf/pulls
Discussionshttps://github.com/python-zeroconf/python-zeroconf/discussions
Actionshttps://github.com/python-zeroconf/python-zeroconf/actions
Projectshttps://github.com/python-zeroconf/python-zeroconf/projects
Wikihttps://github.com/python-zeroconf/python-zeroconf/wiki
Security and quality5 (5)https://github.com/python-zeroconf/python-zeroconf/security
Insightshttps://github.com/python-zeroconf/python-zeroconf/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
bdracohttps://github.com/bdraco
python-zeroconf:masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
bdraco:abtract_query_schedulerhttps://github.com/bdraco/python-zeroconf/tree/abtract_query_scheduler
Conversation 2 https://github.com/python-zeroconf/python-zeroconf/pull/818
Commits 18 https://github.com/python-zeroconf/python-zeroconf/pull/818/commits
Checks 0 https://github.com/python-zeroconf/python-zeroconf/pull/818/checks
Files changed https://github.com/python-zeroconf/python-zeroconf/pull/818/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/818/files
Only wake up the query loop when there is a change in the next query time https://github.com/python-zeroconf/python-zeroconf/pull/818/files#top
Show all changes 18 commits https://github.com/python-zeroconf/python-zeroconf/pull/818/files
a8a809c wip bdraco Jun 22, 2021 https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/a8a809c9dfe05f74dc010026c31b7ea583db275b
9cc7f88 Merge remote-tracking branch 'upstream/master' into abtract_query_sch… bdraco Jun 22, 2021 https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/9cc7f88e8354e9c3bb03b27231aa942ddb69c054
0002f92 Fix default v6_flow_scope argument with tests that mock send bdraco Jun 22, 2021 https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/0002f920c3646dda1cd61920a35ae351839e019f
a742b4f typing bdraco Jun 22, 2021 https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/a742b4fb11de43797e17262b943f0a6be6de2e8e
6bbfb4f Merge remote-tracking branch 'upstream/master' into abtract_query_sch… bdraco Jun 22, 2021 https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/6bbfb4fa7cfee128df12b45375bafd71b9e543c4
0e828e4 Merge branch 'v6_scope_flow_test_fixes' into abtract_query_scheduler bdraco Jun 22, 2021 https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/0e828e4dc57ec5a4c4a7a341fd5ed4091aadfb06
f7270f1 adjust test bdraco Jun 23, 2021 https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/f7270f11ddd9d8085c923bf5525e917cc14daf40
09fc54a Merge remote-tracking branch 'upstream/master' into abtract_query_sch… bdraco Jun 23, 2021 https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/09fc54a5c82040697b96c9e23adc70e0a6317047
60796b7 adjust test bdraco Jun 23, 2021 https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/60796b7cf12e555e1c94684d444426c8ce0a59c4
41f7d4e docs bdraco Jun 23, 2021 https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/41f7d4e16bbed2495af6d82deb828f13b1a3995e
7f7a179 make unit testable bdraco Jun 23, 2021 https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/7f7a179134372276e8ea3003bffca0d087c5d8fa
e0ff45d QueryScheduler tests bdraco Jun 23, 2021 https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/e0ff45d338a24c343bb0965e23009950fbe2d804
3e37509 QueryScheduler tests bdraco Jun 23, 2021 https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/3e37509104b4728ee237b4086aba8d2e29fbe885
41a98be no kwargs bdraco Jun 23, 2021 https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/41a98befc44b695994b326ba520a9360f5b246a4
bd3a7d0 naming bdraco Jun 23, 2021 https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/bd3a7d0e0ce334468e95c8af32e34d2ae6d52a1b
f3784fd typo bdraco Jun 23, 2021 https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/f3784fd036ccdacac63198f4bef12ef7d26ab62a
8ece209 stale doc string bdraco Jun 23, 2021 https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/8ece209bf7272c9b28a93fe30cdff134d9c709c8
7f49c61 Merge remote-tracking branch 'upstream/master' into abtract_query_sch… bdraco Jun 23, 2021 https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/7f49c61b1df3106b32d06fdcae84e4f5c7c19da6
Clear filters https://github.com/python-zeroconf/python-zeroconf/pull/818/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/818/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/818/files
test_browser.py https://github.com/python-zeroconf/python-zeroconf/pull/818/files#diff-1cffc19f1b507a911a493f49e7d5847e516d94e2f7b673b036aa883c411cdb33
browser.py https://github.com/python-zeroconf/python-zeroconf/pull/818/files#diff-00dbbe6b896cdfe22f6fdb7287dd1c1136d4fffd1d113b7f94a625ec89572958
tests/services/test_browser.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/818/files#diff-1cffc19f1b507a911a493f49e7d5847e516d94e2f7b673b036aa883c411cdb33
View file https://github.com/bdraco/python-zeroconf/blob/7f49c61b1df3106b32d06fdcae84e4f5c7c19da6/tests/services/test_browser.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/818/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/818/files#diff-1cffc19f1b507a911a493f49e7d5847e516d94e2f7b673b036aa883c411cdb33
https://github.com/python-zeroconf/python-zeroconf/pull/818/files#diff-1cffc19f1b507a911a493f49e7d5847e516d94e2f7b673b036aa883c411cdb33
https://github.com/python-zeroconf/python-zeroconf/pull/818/files#diff-1cffc19f1b507a911a493f49e7d5847e516d94e2f7b673b036aa883c411cdb33
https://github.com/python-zeroconf/python-zeroconf/pull/818/files#diff-1cffc19f1b507a911a493f49e7d5847e516d94e2f7b673b036aa883c411cdb33
https://github.com/python-zeroconf/python-zeroconf/pull/818/files#diff-1cffc19f1b507a911a493f49e7d5847e516d94e2f7b673b036aa883c411cdb33
https://github.com/python-zeroconf/python-zeroconf/pull/818/files#diff-1cffc19f1b507a911a493f49e7d5847e516d94e2f7b673b036aa883c411cdb33
https://github.com/python-zeroconf/python-zeroconf/pull/818/files#diff-1cffc19f1b507a911a493f49e7d5847e516d94e2f7b673b036aa883c411cdb33
https://github.com/python-zeroconf/python-zeroconf/pull/818/files#diff-1cffc19f1b507a911a493f49e7d5847e516d94e2f7b673b036aa883c411cdb33
zeroconf/_services/browser.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/818/files#diff-00dbbe6b896cdfe22f6fdb7287dd1c1136d4fffd1d113b7f94a625ec89572958
View file https://github.com/bdraco/python-zeroconf/blob/7f49c61b1df3106b32d06fdcae84e4f5c7c19da6/zeroconf/_services/browser.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/818/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/818/files#diff-00dbbe6b896cdfe22f6fdb7287dd1c1136d4fffd1d113b7f94a625ec89572958
https://github.com/python-zeroconf/python-zeroconf/pull/818/files#diff-00dbbe6b896cdfe22f6fdb7287dd1c1136d4fffd1d113b7f94a625ec89572958
https://github.com/python-zeroconf/python-zeroconf/pull/818/files#diff-00dbbe6b896cdfe22f6fdb7287dd1c1136d4fffd1d113b7f94a625ec89572958
https://github.com/python-zeroconf/python-zeroconf/pull/818/files#diff-00dbbe6b896cdfe22f6fdb7287dd1c1136d4fffd1d113b7f94a625ec89572958
https://github.com/python-zeroconf/python-zeroconf/pull/818/files#diff-00dbbe6b896cdfe22f6fdb7287dd1c1136d4fffd1d113b7f94a625ec89572958
https://github.com/python-zeroconf/python-zeroconf/pull/818/files#diff-00dbbe6b896cdfe22f6fdb7287dd1c1136d4fffd1d113b7f94a625ec89572958
https://github.com/python-zeroconf/python-zeroconf/pull/818/files#diff-00dbbe6b896cdfe22f6fdb7287dd1c1136d4fffd1d113b7f94a625ec89572958
https://github.com/python-zeroconf/python-zeroconf/pull/818/files#diff-00dbbe6b896cdfe22f6fdb7287dd1c1136d4fffd1d113b7f94a625ec89572958
https://github.com/python-zeroconf/python-zeroconf/pull/818/files#diff-00dbbe6b896cdfe22f6fdb7287dd1c1136d4fffd1d113b7f94a625ec89572958
https://github.com/python-zeroconf/python-zeroconf/pull/818/files#diff-00dbbe6b896cdfe22f6fdb7287dd1c1136d4fffd1d113b7f94a625ec89572958
https://github.com/python-zeroconf/python-zeroconf/pull/818/files#diff-00dbbe6b896cdfe22f6fdb7287dd1c1136d4fffd1d113b7f94a625ec89572958
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.