René's URL Explorer Experiment


Title: Only wake up the query loop when there is a change in the next query time by bdraco · Pull Request #818 · python-zeroconf/python-zeroconf · GitHub

Open Graph Title: Only wake up the query loop when there is a change in the next query time by bdraco · Pull Request #818 · python-zeroconf/python-zeroconf

X Title: Only wake up the query loop when there is a change in the next query time by bdraco · Pull Request #818 · python-zeroconf/python-zeroconf

Description: A pure python implementation of multicast DNS service discovery - Only wake up the query loop when there is a change in the next query time by bdraco · Pull Request #818 · python-zeroconf/python-zeroconf

Open Graph Description: The ServiceBrowser query loop (async_browser_task) was being awoken on every packet because it was using zeroconf.async_wait which wakes up on every new packet. We only need to awaken the loop whe...

X Description: The ServiceBrowser query loop (async_browser_task) was being awoken on every packet because it was using zeroconf.async_wait which wakes up on every new packet. We only need to awaken the loop whe...

Opengraph URL: https://github.com/python-zeroconf/python-zeroconf/pull/818

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:29b75a2c-c6a1-5cab-eb53-de474d3ffc28
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8C24:2CAE80:C83527:1128558:6B00B2A5
html-safe-nonce9c120e2b2f77d532698ebe894a2f4e9357ec7c237903045d18892c4a082aff93
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzI0OjJDQUU4MDpDODM1Mjc6MTEyODU1ODo2QjAwQjJBNSIsInZpc2l0b3JfaWQiOiIyOTA3MjU2NjIxMzU4OTUzMTI1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd61e971ccf8bf005557f9a81d3ed84350e7f3aec0962fb40c9d0489c7a6fda6c
hovercard-subject-tagpull_request:675824796
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-zeroconf/python-zeroconf/818/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0649759154086026b15b2b06be719abccc7d888cb18e4631f04ff5f8cdacd550/python-zeroconf/python-zeroconf/pull/818
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0649759154086026b15b2b06be719abccc7d888cb18e4631f04ff5f8cdacd550/python-zeroconf/python-zeroconf/pull/818
og:image:altThe ServiceBrowser query loop (async_browser_task) was being awoken on every packet because it was using zeroconf.async_wait which wakes up on every new packet. We only need to awaken the loop whe...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebdraco
hostnamegithub.com
expected-hostnamegithub.com
None1d07c25977adfc5ff6acb0a962a9bc168c07afbda6fef765f9761c350c2ae4a2
turbo-cache-controlno-cache
go-importgithub.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git
octolytics-dimension-user_id120192235
octolytics-dimension-user_loginpython-zeroconf
octolytics-dimension-repository_id21548731
octolytics-dimension-repository_nwopython-zeroconf/python-zeroconf
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21548731
octolytics-dimension-repository_network_root_nwopython-zeroconf/python-zeroconf
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5429cbfc6aca8c7b9a086a3c8f47400346f38cc9
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python-zeroconf/python-zeroconf/pull/818#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F818
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F818
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/818
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/818
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/818
python-zeroconfhttps://github.com/python-zeroconf
python-zeroconfhttps://github.com/python-zeroconf/python-zeroconf
Codehttps://github.com/python-zeroconf/python-zeroconf
Issues50 (50)https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests16 (16)https://github.com/python-zeroconf/python-zeroconf/pulls
Discussionshttps://github.com/python-zeroconf/python-zeroconf/discussions
Actionshttps://github.com/python-zeroconf/python-zeroconf/actions
Projectshttps://github.com/python-zeroconf/python-zeroconf/projects
Wikihttps://github.com/python-zeroconf/python-zeroconf/wiki
Security and quality5 (5)https://github.com/python-zeroconf/python-zeroconf/security
Insightshttps://github.com/python-zeroconf/python-zeroconf/insights
https://github.com/python-zeroconf/python-zeroconf
bdracohttps://github.com/bdraco
python-zeroconf:masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
bdraco:abtract_query_schedulerhttps://github.com/bdraco/python-zeroconf/tree/abtract_query_scheduler
Conversationhttps://github.com/python-zeroconf/python-zeroconf/pull/818
Commits18 (18)https://github.com/python-zeroconf/python-zeroconf/pull/818/commits
Checkshttps://github.com/python-zeroconf/python-zeroconf/pull/818/checks
Files changedhttps://github.com/python-zeroconf/python-zeroconf/pull/818/files
Only wake up the query loop when there is a change in the next query timehttps://github.com/python-zeroconf/python-zeroconf/pull/818#top
bdracohttps://github.com/bdraco
python-zeroconf:masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
bdraco:abtract_query_schedulerhttps://github.com/bdraco/python-zeroconf/tree/abtract_query_scheduler
https://github.com/bdraco
bdracohttps://github.com/bdraco
Jun 22, 2021https://github.com/python-zeroconf/python-zeroconf/pull/818#issue-927711402
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/818
#814https://github.com/python-zeroconf/python-zeroconf/issues/814
#768https://github.com/python-zeroconf/python-zeroconf/issues/768
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/818
bdracohttps://github.com/bdraco
June 22, 2021 13:33https://github.com/python-zeroconf/python-zeroconf/pull/818#commits-pushed-a8a809c
https://github.com/bdraco
wiphttps://github.com/python-zeroconf/python-zeroconf/pull/818/commits/a8a809c9dfe05f74dc010026c31b7ea583db275b
a8a809chttps://github.com/python-zeroconf/python-zeroconf/pull/818/commits/a8a809c9dfe05f74dc010026c31b7ea583db275b
https://github.com/bdraco
Merge remote-tracking branch 'upstream/master' into abtract_query_sch…https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/9cc7f88e8354e9c3bb03b27231aa942ddb69c054
9cc7f88https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/9cc7f88e8354e9c3bb03b27231aa942ddb69c054
https://github.com/bdraco
Fix default v6_flow_scope argument with tests that mock sendhttps://github.com/python-zeroconf/python-zeroconf/pull/818/commits/0002f920c3646dda1cd61920a35ae351839e019f
0002f92https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/0002f920c3646dda1cd61920a35ae351839e019f
https://github.com/bdraco
typinghttps://github.com/python-zeroconf/python-zeroconf/pull/818/commits/a742b4fb11de43797e17262b943f0a6be6de2e8e
a742b4fhttps://github.com/python-zeroconf/python-zeroconf/pull/818/commits/a742b4fb11de43797e17262b943f0a6be6de2e8e
https://github.com/bdraco
Merge remote-tracking branch 'upstream/master' into abtract_query_sch…https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/6bbfb4fa7cfee128df12b45375bafd71b9e543c4
6bbfb4fhttps://github.com/python-zeroconf/python-zeroconf/pull/818/commits/6bbfb4fa7cfee128df12b45375bafd71b9e543c4
https://github.com/bdraco
Merge branch 'v6_scope_flow_test_fixes' into abtract_query_schedulerhttps://github.com/python-zeroconf/python-zeroconf/pull/818/commits/0e828e4dc57ec5a4c4a7a341fd5ed4091aadfb06
0e828e4https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/0e828e4dc57ec5a4c4a7a341fd5ed4091aadfb06
https://github.com/bdraco
adjust testhttps://github.com/python-zeroconf/python-zeroconf/pull/818/commits/f7270f11ddd9d8085c923bf5525e917cc14daf40
f7270f1https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/f7270f11ddd9d8085c923bf5525e917cc14daf40
https://github.com/bdraco
Merge remote-tracking branch 'upstream/master' into abtract_query_sch…https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/09fc54a5c82040697b96c9e23adc70e0a6317047
09fc54ahttps://github.com/python-zeroconf/python-zeroconf/pull/818/commits/09fc54a5c82040697b96c9e23adc70e0a6317047
https://github.com/bdraco
adjust testhttps://github.com/python-zeroconf/python-zeroconf/pull/818/commits/60796b7cf12e555e1c94684d444426c8ce0a59c4
60796b7https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/60796b7cf12e555e1c94684d444426c8ce0a59c4
https://github.com/bdraco
bdracohttps://github.com/bdraco
Jun 23, 2021https://github.com/python-zeroconf/python-zeroconf/pull/818#event-4925853888
https://github.com/bdraco
docshttps://github.com/python-zeroconf/python-zeroconf/pull/818/commits/41f7d4e16bbed2495af6d82deb828f13b1a3995e
41f7d4ehttps://github.com/python-zeroconf/python-zeroconf/pull/818/commits/41f7d4e16bbed2495af6d82deb828f13b1a3995e
https://github.com/codecov-commenter
codecov-commenterhttps://github.com/codecov-commenter
Jun 23, 2021https://github.com/python-zeroconf/python-zeroconf/pull/818#issuecomment-866440508
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/818
Codecovhttps://codecov.io/gh/jstasiak/python-zeroconf/pull/818?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
#818https://codecov.io/gh/jstasiak/python-zeroconf/pull/818?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
7f49c61https://github.com/python-zeroconf/python-zeroconf/commit/7f49c61b1df3106b32d06fdcae84e4f5c7c19da6
masterhttps://codecov.io/gh/jstasiak/python-zeroconf/commit/a7b4f8e070de69db1ed872e2ff7a953ec624394c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
a7b4f8ehttps://github.com/python-zeroconf/python-zeroconf/commit/a7b4f8e070de69db1ed872e2ff7a953ec624394c
https://codecov.io/gh/jstasiak/python-zeroconf/pull/818?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
Impacted Fileshttps://codecov.io/gh/jstasiak/python-zeroconf/pull/818?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
zeroconf/_services/browser.pyhttps://codecov.io/gh/jstasiak/python-zeroconf/pull/818/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak#diff-emVyb2NvbmYvX3NlcnZpY2VzL2Jyb3dzZXIucHk=
Continue to review full report at Codecovhttps://codecov.io/gh/jstasiak/python-zeroconf/pull/818?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
Codecovhttps://codecov.io/gh/jstasiak/python-zeroconf/pull/818?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
a7b4f8e...7f49c61https://codecov.io/gh/jstasiak/python-zeroconf/pull/818?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
comment docshttps://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/818
bdracohttps://github.com/bdraco
June 22, 2021 15:10https://github.com/python-zeroconf/python-zeroconf/pull/818#commits-pushed-7f7a179
https://github.com/bdraco
make unit testablehttps://github.com/python-zeroconf/python-zeroconf/pull/818/commits/7f7a179134372276e8ea3003bffca0d087c5d8fa
7f7a179https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/7f7a179134372276e8ea3003bffca0d087c5d8fa
https://github.com/bdraco
QueryScheduler testshttps://github.com/python-zeroconf/python-zeroconf/pull/818/commits/e0ff45d338a24c343bb0965e23009950fbe2d804
e0ff45dhttps://github.com/python-zeroconf/python-zeroconf/pull/818/commits/e0ff45d338a24c343bb0965e23009950fbe2d804
https://github.com/bdraco
QueryScheduler testshttps://github.com/python-zeroconf/python-zeroconf/pull/818/commits/3e37509104b4728ee237b4086aba8d2e29fbe885
3e37509https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/3e37509104b4728ee237b4086aba8d2e29fbe885
https://github.com/bdraco
no kwargshttps://github.com/python-zeroconf/python-zeroconf/pull/818/commits/41a98befc44b695994b326ba520a9360f5b246a4
41a98behttps://github.com/python-zeroconf/python-zeroconf/pull/818/commits/41a98befc44b695994b326ba520a9360f5b246a4
https://github.com/bdraco
naminghttps://github.com/python-zeroconf/python-zeroconf/pull/818/commits/bd3a7d0e0ce334468e95c8af32e34d2ae6d52a1b
bd3a7d0https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/bd3a7d0e0ce334468e95c8af32e34d2ae6d52a1b
https://github.com/bdraco
bdracohttps://github.com/bdraco
Jun 23, 2021 https://github.com/python-zeroconf/python-zeroconf/pull/818#ref-issue-927698568
Make a helper to wait for ServiceBrowser start a test #815 https://github.com/python-zeroconf/python-zeroconf/issues/815
bdracohttps://github.com/bdraco
June 22, 2021 16:20https://github.com/python-zeroconf/python-zeroconf/pull/818#commits-pushed-f3784fd
https://github.com/bdraco
typohttps://github.com/python-zeroconf/python-zeroconf/pull/818/commits/f3784fd036ccdacac63198f4bef12ef7d26ab62a
f3784fdhttps://github.com/python-zeroconf/python-zeroconf/pull/818/commits/f3784fd036ccdacac63198f4bef12ef7d26ab62a
https://github.com/bdraco
stale doc stringhttps://github.com/python-zeroconf/python-zeroconf/pull/818/commits/8ece209bf7272c9b28a93fe30cdff134d9c709c8
8ece209https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/8ece209bf7272c9b28a93fe30cdff134d9c709c8
https://github.com/bdraco
Merge remote-tracking branch 'upstream/master' into abtract_query_sch…https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/7f49c61b1df3106b32d06fdcae84e4f5c7c19da6
7f49c61https://github.com/python-zeroconf/python-zeroconf/pull/818/commits/7f49c61b1df3106b32d06fdcae84e4f5c7c19da6
https://github.com/bdraco
bdracohttps://github.com/bdraco
Jun 23, 2021https://github.com/python-zeroconf/python-zeroconf/pull/818#issuecomment-866486070
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/818
https://github.com/bdraco
bdracohttps://github.com/bdraco
June 23, 2021 03:06https://github.com/python-zeroconf/python-zeroconf/pull/818#event-4926208210
https://github.com/bdraco
bdracohttps://github.com/bdraco
4062fe2https://github.com/python-zeroconf/python-zeroconf/commit/4062fe21d8baaad36960f8cae0f59ac7083a6b55
Jun 23, 2021https://github.com/python-zeroconf/python-zeroconf/pull/818#event-4926208973
https://github.com/bdraco
bdracohttps://github.com/bdraco
June 23, 2021 03:06https://github.com/python-zeroconf/python-zeroconf/pull/818#event-4926209027
https://github.com/bdraco
bdracohttps://github.com/bdraco
Jun 23, 2021 https://github.com/python-zeroconf/python-zeroconf/pull/818#ref-issue-927815571
Outgoing query scheduling is suboptimal #821 https://github.com/python-zeroconf/python-zeroconf/issues/821
https://github.com/bdraco
bdracohttps://github.com/bdraco
Dec 14, 2023 https://github.com/python-zeroconf/python-zeroconf/pull/818#ref-pullrequest-2042352746
feat: significantly improve efficiency of the ServiceBrowser scheduler #1335 https://github.com/python-zeroconf/python-zeroconf/pull/1335
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F818
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/818
Service browser queries get awoken on every new packet even if it’s not relevant https://github.com/python-zeroconf/python-zeroconf/issues/814
tests/services/test_browser.py::test_integration is still flakey on pypy https://github.com/python-zeroconf/python-zeroconf/issues/768
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/818
https://github.com/bdraco
https://github.com/codecov-commenter
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.