René's URL Explorer Experiment


Title: Fix cache handling of records with different TTLs by bdraco · Pull Request #729 · python-zeroconf/python-zeroconf · GitHub

Open Graph Title: Fix cache handling of records with different TTLs by bdraco · Pull Request #729 · python-zeroconf/python-zeroconf

X Title: Fix cache handling of records with different TTLs by bdraco · Pull Request #729 · python-zeroconf/python-zeroconf

Description: There should only be one unique record in the cache at a time as having multiple unique records will different TTLs in the cache can result in unexpected behavior since some functions returned all matching records and some fetched from the right side of the list to return the newest record. Intead we now store the records in a dict to ensure that the newest record always replaces the same unique record and we never have a source of truth problem determining the TTL of a record from the cache.

Open Graph Description: There should only be one unique record in the cache at a time as having multiple unique records will different TTLs in the cache can result in unexpected behavior since some functions returned all ...

X Description: There should only be one unique record in the cache at a time as having multiple unique records will different TTLs in the cache can result in unexpected behavior since some functions returned all ...

Opengraph URL: https://github.com/python-zeroconf/python-zeroconf/pull/729

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2f617690-d229-e9a4-c79c-e61e7b667115
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDE92:139223:3C84FD:50E697:6B00A1CC
html-safe-nonce98c276c18ebacc6d57c4a0c843e3e4f019784ca1b08a9c5d388c0b4f37b4cc50
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTkyOjEzOTIyMzozQzg0RkQ6NTBFNjk3OjZCMDBBMUNDIiwidmlzaXRvcl9pZCI6IjQ4MjQ1NDA4MDg1ODc3MTk2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc02b990abd4098cbc6f7cedba06c70065df1a6c674771796ac863478a5077074
hovercard-subject-tagpull_request:673756298
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-zeroconf/python-zeroconf/pull/729/files
twitter:imagehttps://avatars.githubusercontent.com/u/663432?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/663432?s=400&v=4
og:image:altThere should only be one unique record in the cache at a time as having multiple unique records will different TTLs in the cache can result in unexpected behavior since some functions returned all ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None52c95ce7e48016ae14399656b4ee812462b6f1fa28c5008c8394da64794c00b8
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git
octolytics-dimension-user_id120192235
octolytics-dimension-user_loginpython-zeroconf
octolytics-dimension-repository_id21548731
octolytics-dimension-repository_nwopython-zeroconf/python-zeroconf
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21548731
octolytics-dimension-repository_network_root_nwopython-zeroconf/python-zeroconf
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1c9ddec8215f9a94e295c8310c3579b9c54ba31a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-zeroconf/python-zeroconf/pull/729/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F729%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F729%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/729/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/729/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/729/files
python-zeroconfhttps://github.com/python-zeroconf
python-zeroconfhttps://github.com/python-zeroconf/python-zeroconf
Codehttps://github.com/python-zeroconf/python-zeroconf
Issues50 (50)https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests16 (16)https://github.com/python-zeroconf/python-zeroconf/pulls
Discussionshttps://github.com/python-zeroconf/python-zeroconf/discussions
Actionshttps://github.com/python-zeroconf/python-zeroconf/actions
Projectshttps://github.com/python-zeroconf/python-zeroconf/projects
Wikihttps://github.com/python-zeroconf/python-zeroconf/wiki
Security and quality5 (5)https://github.com/python-zeroconf/python-zeroconf/security
Insightshttps://github.com/python-zeroconf/python-zeroconf/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
bdracohttps://github.com/bdraco
python-zeroconf:masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
bdraco:fix_cache_conflicthttps://github.com/bdraco/python-zeroconf/tree/fix_cache_conflict
Conversation 1 https://github.com/python-zeroconf/python-zeroconf/pull/729
Commits 1 https://github.com/python-zeroconf/python-zeroconf/pull/729/commits
Checks 0 https://github.com/python-zeroconf/python-zeroconf/pull/729/checks
Files changed https://github.com/python-zeroconf/python-zeroconf/pull/729/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/729/files
Fix cache handling of records with different TTLs https://github.com/python-zeroconf/python-zeroconf/pull/729/files#top
Show all changes 1 commit https://github.com/python-zeroconf/python-zeroconf/pull/729/files
e4be118 Fix cache handling of records with different TTLs bdraco Jun 18, 2021 https://github.com/python-zeroconf/python-zeroconf/pull/729/commits/e4be118ccc231d01b07795c0c4b046195d9dc11e
Clear filters https://github.com/python-zeroconf/python-zeroconf/pull/729/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/729/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/729/files
test_cache.py https://github.com/python-zeroconf/python-zeroconf/pull/729/files#diff-550ab64693d2f5193d9557ebfbb9ccc62884c425f36e719a72cb3bc707091fbe
_cache.py https://github.com/python-zeroconf/python-zeroconf/pull/729/files#diff-34a6f58b753ed4e51be7652961a3f14255a211d65bee94a114043f7fff71623e
tests/test_cache.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/729/files#diff-550ab64693d2f5193d9557ebfbb9ccc62884c425f36e719a72cb3bc707091fbe
View file https://github.com/bdraco/python-zeroconf/blob/e4be118ccc231d01b07795c0c4b046195d9dc11e/tests/test_cache.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/729/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/729/files#diff-550ab64693d2f5193d9557ebfbb9ccc62884c425f36e719a72cb3bc707091fbe
https://github.com/python-zeroconf/python-zeroconf/pull/729/files#diff-550ab64693d2f5193d9557ebfbb9ccc62884c425f36e719a72cb3bc707091fbe
https://github.com/python-zeroconf/python-zeroconf/pull/729/files#diff-550ab64693d2f5193d9557ebfbb9ccc62884c425f36e719a72cb3bc707091fbe
https://github.com/python-zeroconf/python-zeroconf/pull/729/files#diff-550ab64693d2f5193d9557ebfbb9ccc62884c425f36e719a72cb3bc707091fbe
zeroconf/_cache.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/729/files#diff-34a6f58b753ed4e51be7652961a3f14255a211d65bee94a114043f7fff71623e
View file https://github.com/bdraco/python-zeroconf/blob/e4be118ccc231d01b07795c0c4b046195d9dc11e/zeroconf/_cache.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/729/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/729/files#diff-34a6f58b753ed4e51be7652961a3f14255a211d65bee94a114043f7fff71623e
https://github.com/python-zeroconf/python-zeroconf/pull/729/files#diff-34a6f58b753ed4e51be7652961a3f14255a211d65bee94a114043f7fff71623e
https://github.com/python-zeroconf/python-zeroconf/pull/729/files#diff-34a6f58b753ed4e51be7652961a3f14255a211d65bee94a114043f7fff71623e
https://github.com/python-zeroconf/python-zeroconf/pull/729/files#diff-34a6f58b753ed4e51be7652961a3f14255a211d65bee94a114043f7fff71623e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.