René's URL Explorer Experiment


Title: Skip socket creation if add_multicast_member fails (windows) by bdraco · Pull Request #341 · python-zeroconf/python-zeroconf · GitHub

Open Graph Title: Skip socket creation if add_multicast_member fails (windows) by bdraco · Pull Request #341 · python-zeroconf/python-zeroconf

X Title: Skip socket creation if add_multicast_member fails (windows) by bdraco · Pull Request #341 · python-zeroconf/python-zeroconf

Description: #339 with typing fixed Fixes a regression caused by refactoring error in #331

Open Graph Description: #339 with typing fixed Fixes a regression caused by refactoring error in #331

X Description: #339 with typing fixed Fixes a regression caused by refactoring error in #331

Opengraph URL: https://github.com/python-zeroconf/python-zeroconf/pull/341

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ee31c65d-9e11-4ce9-6d4a-59d83248f400
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idABF6:25BF4B:51E6091:6E758C1:697349E5
html-safe-nonce7320b95054cb69e021c45cec951558594e7e1b83128e523c6e4e36f40227701e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkY2OjI1QkY0Qjo1MUU2MDkxOjZFNzU4QzE6Njk3MzQ5RTUiLCJ2aXNpdG9yX2lkIjoiOTAzOTY2ODU2MDcyNzg1MzU0MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd2ba3a484ec28873b631a5d02316294230f6d0ac3ccbfb36b5e240c6ebee50f1
hovercard-subject-tagpull_request:623102049
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-zeroconf/python-zeroconf/341/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e8b51426cfdd58dc1666e5f9bab012bd1d071c494975067b9f43b43ef9f09d3c/python-zeroconf/python-zeroconf/pull/341
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e8b51426cfdd58dc1666e5f9bab012bd1d071c494975067b9f43b43ef9f09d3c/python-zeroconf/python-zeroconf/pull/341
og:image:alt#339 with typing fixed Fixes a regression caused by refactoring error in #331
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebdraco
hostnamegithub.com
expected-hostnamegithub.com
None9c6b49fea3d431063963fbeee3309a15cb4096903286e532f663096b47b63bc6
turbo-cache-controlno-preview
go-importgithub.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git
octolytics-dimension-user_id120192235
octolytics-dimension-user_loginpython-zeroconf
octolytics-dimension-repository_id21548731
octolytics-dimension-repository_nwopython-zeroconf/python-zeroconf
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21548731
octolytics-dimension-repository_network_root_nwopython-zeroconf/python-zeroconf
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release814e1d7d82db0f7eb6982bfa0395502441bb14ad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-zeroconf/python-zeroconf/pull/341#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F341
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F341
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/341
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/341
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/341
python-zeroconf https://github.com/python-zeroconf
python-zeroconfhttps://github.com/python-zeroconf/python-zeroconf
Notifications https://github.com/login?return_to=%2Fpython-zeroconf%2Fpython-zeroconf
Fork 232 https://github.com/login?return_to=%2Fpython-zeroconf%2Fpython-zeroconf
Star 704 https://github.com/login?return_to=%2Fpython-zeroconf%2Fpython-zeroconf
Code https://github.com/python-zeroconf/python-zeroconf
Issues 50 https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests 5 https://github.com/python-zeroconf/python-zeroconf/pulls
Discussions https://github.com/python-zeroconf/python-zeroconf/discussions
Actions https://github.com/python-zeroconf/python-zeroconf/actions
Projects 0 https://github.com/python-zeroconf/python-zeroconf/projects
Wiki https://github.com/python-zeroconf/python-zeroconf/wiki
Security 0 https://github.com/python-zeroconf/python-zeroconf/security
Insights https://github.com/python-zeroconf/python-zeroconf/pulse
Code https://github.com/python-zeroconf/python-zeroconf
Issues https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests https://github.com/python-zeroconf/python-zeroconf/pulls
Discussions https://github.com/python-zeroconf/python-zeroconf/discussions
Actions https://github.com/python-zeroconf/python-zeroconf/actions
Projects https://github.com/python-zeroconf/python-zeroconf/projects
Wiki https://github.com/python-zeroconf/python-zeroconf/wiki
Security https://github.com/python-zeroconf/python-zeroconf/security
Insights https://github.com/python-zeroconf/python-zeroconf/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python-zeroconf/python-zeroconf/pull/341#issue-comment-box
bdracohttps://github.com/bdraco
python-zeroconf:masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
bdraco:issues/337https://github.com/bdraco/python-zeroconf/tree/issues/337
Skip socket creation if add_multicast_member fails (windows) https://github.com/python-zeroconf/python-zeroconf/pull/341#top
bdracohttps://github.com/bdraco
python-zeroconf:masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
bdraco:issues/337https://github.com/bdraco/python-zeroconf/tree/issues/337
Conversation 6 https://github.com/python-zeroconf/python-zeroconf/pull/341
Commits 3 https://github.com/python-zeroconf/python-zeroconf/pull/341/commits
Checks 0 https://github.com/python-zeroconf/python-zeroconf/pull/341/checks
Files changed https://github.com/python-zeroconf/python-zeroconf/pull/341/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/341
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/{{ revealButtonHref }}
https://github.com/bdraco
bdracohttps://github.com/bdraco
Apr 26, 2021https://github.com/python-zeroconf/python-zeroconf/pull/341#issue-867429841
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/341
#339https://github.com/python-zeroconf/python-zeroconf/pull/339
#331https://github.com/python-zeroconf/python-zeroconf/pull/331
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/341
https://github.com/bdraco
bdracohttps://github.com/bdraco
Apr 26, 2021https://github.com/python-zeroconf/python-zeroconf/pull/341#issuecomment-826632013
bdraco#2https://github.com/bdraco/python-zeroconf/pull/2
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/341
https://github.com/bdraco
bdracohttps://github.com/bdraco
Apr 26, 2021 https://github.com/python-zeroconf/python-zeroconf/pull/341#ref-pullrequest-857342020
fix #337 : do not create the socket if add_multicast_member failed #339 https://github.com/python-zeroconf/python-zeroconf/pull/339
https://github.com/bdraco
bdracohttps://github.com/bdraco
Apr 26, 2021https://github.com/python-zeroconf/python-zeroconf/pull/341#event-4643316969
https://github.com/bdraco
bdracohttps://github.com/bdraco
force-pushedhttps://github.com/python-zeroconf/python-zeroconf/compare/6870122e068b54234f63b3d92a4461d81af297f6..57e603c6fcc0ff0cb3965bbe96cf34fb995731da
6870122https://github.com/python-zeroconf/python-zeroconf/commit/6870122e068b54234f63b3d92a4461d81af297f6
57e603chttps://github.com/python-zeroconf/python-zeroconf/commit/57e603c6fcc0ff0cb3965bbe96cf34fb995731da
Compare https://github.com/python-zeroconf/python-zeroconf/compare/6870122e068b54234f63b3d92a4461d81af297f6..57e603c6fcc0ff0cb3965bbe96cf34fb995731da
April 26, 2021 08:40https://github.com/python-zeroconf/python-zeroconf/pull/341#event-4643329313
https://github.com/TTimo
https://github.com/bdraco
Skip socket creation if add_multicast_member fails (windows)https://github.com/python-zeroconf/python-zeroconf/pull/341/commits/fd1c0635560304490704ef7a6677bff4fddbcdfc
fd1c063https://github.com/python-zeroconf/python-zeroconf/pull/341/commits/fd1c0635560304490704ef7a6677bff4fddbcdfc
python-zeroconf#331https://github.com/python-zeroconf/python-zeroconf/pull/331
https://github.com/bdraco
bdracohttps://github.com/bdraco
force-pushedhttps://github.com/python-zeroconf/python-zeroconf/compare/57e603c6fcc0ff0cb3965bbe96cf34fb995731da..fd1c0635560304490704ef7a6677bff4fddbcdfc
57e603chttps://github.com/python-zeroconf/python-zeroconf/commit/57e603c6fcc0ff0cb3965bbe96cf34fb995731da
fd1c063https://github.com/python-zeroconf/python-zeroconf/commit/fd1c0635560304490704ef7a6677bff4fddbcdfc
Compare https://github.com/python-zeroconf/python-zeroconf/compare/57e603c6fcc0ff0cb3965bbe96cf34fb995731da..fd1c0635560304490704ef7a6677bff4fddbcdfc
April 26, 2021 08:46https://github.com/python-zeroconf/python-zeroconf/pull/341#event-4643364904
https://github.com/codecov-commenter
codecov-commenterhttps://github.com/codecov-commenter
Apr 28, 2021https://github.com/python-zeroconf/python-zeroconf/pull/341#issuecomment-828257129
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/341
Codecovhttps://codecov.io/gh/jstasiak/python-zeroconf/pull/341?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
#341https://codecov.io/gh/jstasiak/python-zeroconf/pull/341?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
0c3cea3https://github.com/python-zeroconf/python-zeroconf/commit/0c3cea3ffce33fbe6a79c8d80a9f23d7011ff4a8
masterhttps://codecov.io/gh/jstasiak/python-zeroconf/commit/fe948105cc0923336ffa6d93cbe7d45470612a36?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
fe94810https://github.com/python-zeroconf/python-zeroconf/commit/fe948105cc0923336ffa6d93cbe7d45470612a36
https://codecov.io/gh/jstasiak/python-zeroconf/pull/341?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
Impacted Fileshttps://codecov.io/gh/jstasiak/python-zeroconf/pull/341?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
zeroconf/__init__.pyhttps://codecov.io/gh/jstasiak/python-zeroconf/pull/341/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak#diff-emVyb2NvbmYvX19pbml0X18ucHk=
zeroconf/test.pyhttps://codecov.io/gh/jstasiak/python-zeroconf/pull/341/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak#diff-emVyb2NvbmYvdGVzdC5weQ==
Continue to review full report at Codecovhttps://codecov.io/gh/jstasiak/python-zeroconf/pull/341?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
Codecovhttps://codecov.io/gh/jstasiak/python-zeroconf/pull/341?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
fe94810...0c3cea3https://codecov.io/gh/jstasiak/python-zeroconf/pull/341?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
comment docshttps://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jakub+Stasiak
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/341
https://github.com/bdraco
bdracohttps://github.com/bdraco
Apr 28, 2021https://github.com/python-zeroconf/python-zeroconf/pull/341#issuecomment-828264095
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/341
https://github.com/bdraco
bdracohttps://github.com/bdraco
Apr 28, 2021https://github.com/python-zeroconf/python-zeroconf/pull/341#issuecomment-828273598
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/341
https://github.com/jstasiak
jstasiakhttps://github.com/jstasiak
Apr 28, 2021https://github.com/python-zeroconf/python-zeroconf/pull/341#issuecomment-828603219
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/341
https://github.com/bdraco
bdracohttps://github.com/bdraco
force-pushedhttps://github.com/python-zeroconf/python-zeroconf/compare/41bcca353c947afd52991638b2091badd32de1e1..d54d83890700ffb9b523ce1f2c7270aa14976d69
41bcca3https://github.com/python-zeroconf/python-zeroconf/commit/41bcca353c947afd52991638b2091badd32de1e1
d54d838https://github.com/python-zeroconf/python-zeroconf/commit/d54d83890700ffb9b523ce1f2c7270aa14976d69
Compare https://github.com/python-zeroconf/python-zeroconf/compare/41bcca353c947afd52991638b2091badd32de1e1..d54d83890700ffb9b523ce1f2c7270aa14976d69
April 28, 2021 17:22https://github.com/python-zeroconf/python-zeroconf/pull/341#event-4658254596
https://github.com/bdraco
Ensure known socket errors cause add_multicast_member to return Falsehttps://github.com/python-zeroconf/python-zeroconf/pull/341/commits/cc2405f9091fe5297ecbc54183394b67c0529798
cc2405fhttps://github.com/python-zeroconf/python-zeroconf/pull/341/commits/cc2405f9091fe5297ecbc54183394b67c0529798
https://github.com/bdraco
bdracohttps://github.com/bdraco
force-pushedhttps://github.com/python-zeroconf/python-zeroconf/compare/d54d83890700ffb9b523ce1f2c7270aa14976d69..cc2405f9091fe5297ecbc54183394b67c0529798
d54d838https://github.com/python-zeroconf/python-zeroconf/commit/d54d83890700ffb9b523ce1f2c7270aa14976d69
cc2405fhttps://github.com/python-zeroconf/python-zeroconf/commit/cc2405f9091fe5297ecbc54183394b67c0529798
Compare https://github.com/python-zeroconf/python-zeroconf/compare/d54d83890700ffb9b523ce1f2c7270aa14976d69..cc2405f9091fe5297ecbc54183394b67c0529798
April 28, 2021 17:25https://github.com/python-zeroconf/python-zeroconf/pull/341#event-4658269862
https://github.com/bdraco
Merge branch 'master' into issues/337https://github.com/python-zeroconf/python-zeroconf/pull/341/commits/0c3cea3ffce33fbe6a79c8d80a9f23d7011ff4a8
0c3cea3https://github.com/python-zeroconf/python-zeroconf/pull/341/commits/0c3cea3ffce33fbe6a79c8d80a9f23d7011ff4a8
https://github.com/bdraco
bdracohttps://github.com/bdraco
beccad1https://github.com/python-zeroconf/python-zeroconf/commit/beccad1f0b41730f541b2e90ea2eaa2496de5044
May 3, 2021https://github.com/python-zeroconf/python-zeroconf/pull/341#event-4676421669
https://github.com/bdraco
bdracohttps://github.com/bdraco
May 3, 2021 06:16https://github.com/python-zeroconf/python-zeroconf/pull/341#event-4676421737
https://github.com/bdraco
bdracohttps://github.com/bdraco
May 3, 2021 https://github.com/python-zeroconf/python-zeroconf/pull/341#ref-issue-845599408
Socket Errors on Win 10 with 0.29 #337 https://github.com/python-zeroconf/python-zeroconf/issues/337
https://github.com/jstasiak
jstasiakhttps://github.com/jstasiak
May 5, 2021https://github.com/python-zeroconf/python-zeroconf/pull/341#issuecomment-832993900
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/341
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F341
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/341
https://github.com/bdraco
https://github.com/codecov-commenter
https://github.com/jstasiak
https://github.com/TTimo
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.