René's URL Explorer Experiment


Title: Ensure the name cache is rolled back when the packet reaches maximum size by bdraco · Pull Request #318 · python-zeroconf/python-zeroconf · GitHub

Open Graph Title: Ensure the name cache is rolled back when the packet reaches maximum size by bdraco · Pull Request #318 · python-zeroconf/python-zeroconf

X Title: Ensure the name cache is rolled back when the packet reaches maximum size by bdraco · Pull Request #318 · python-zeroconf/python-zeroconf

Description: Fixes #308 If the packet was too large, it would be rolled back at the end of write_record. We need to remove the names that were added to the name cache (self.names) as well to avoid a case were we would create a pointer to a name that was rolled back. The size of the packet was incorrect at the end after the inserts because insert_short would increase self.size even though it was already accounted before. To resolve this insert_short_at_start was added which does not increase self.size. This did not cause an actual bug, however it sure made debugging this problem far more difficult. Additionally the size now inserted and then replaced when the actual size is known because it made debugging quite difficult since the size did not previously agree with the data.

Open Graph Description: Fixes #308 If the packet was too large, it would be rolled back at the end of write_record. We need to remove the names that were added to the name cache (self.names) as well to avoid a case were w...

X Description: Fixes #308 If the packet was too large, it would be rolled back at the end of write_record. We need to remove the names that were added to the name cache (self.names) as well to avoid a case were w...

Opengraph URL: https://github.com/python-zeroconf/python-zeroconf/pull/318

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9e85c0d6-e0e1-5488-de21-3ed2875d9ae0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC9FA:3AE93F:7039DA:959A7D:6B00AD59
html-safe-nonce7ca45916dad0f24819c9725c91ce3db356a594a914ebd895ba3e5ef15bcb9df3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOUZBOjNBRTkzRjo3MDM5REE6OTU5QTdEOjZCMDBBRDU5IiwidmlzaXRvcl9pZCI6Ijg2MjgwNDA3Njc3MTA5OTc4NDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8733dfe55f02133fb1179b529981c4819aff909575c2c86dc0204d7046300a01
hovercard-subject-tagpull_request:510967492
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-zeroconf/python-zeroconf/pull/318/files
twitter:imagehttps://avatars.githubusercontent.com/u/663432?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/663432?s=400&v=4
og:image:altFixes #308 If the packet was too large, it would be rolled back at the end of write_record. We need to remove the names that were added to the name cache (self.names) as well to avoid a case were w...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonec0dd5f5d6f515a591019ecd66df2c4eab3379c2d3b0777568a90d8c7ae10b79e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git
octolytics-dimension-user_id120192235
octolytics-dimension-user_loginpython-zeroconf
octolytics-dimension-repository_id21548731
octolytics-dimension-repository_nwopython-zeroconf/python-zeroconf
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21548731
octolytics-dimension-repository_network_root_nwopython-zeroconf/python-zeroconf
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release729d8cda69b3d267995675dfbf89ff27ccf61bf6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python-zeroconf/python-zeroconf/pull/318/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F318%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F318%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/318/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/318/files
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/318/files
python-zeroconfhttps://github.com/python-zeroconf
python-zeroconfhttps://github.com/python-zeroconf/python-zeroconf
Codehttps://github.com/python-zeroconf/python-zeroconf
Issues50 (50)https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests16 (16)https://github.com/python-zeroconf/python-zeroconf/pulls
Discussionshttps://github.com/python-zeroconf/python-zeroconf/discussions
Actionshttps://github.com/python-zeroconf/python-zeroconf/actions
Projectshttps://github.com/python-zeroconf/python-zeroconf/projects
Wikihttps://github.com/python-zeroconf/python-zeroconf/wiki
Security and quality5 (5)https://github.com/python-zeroconf/python-zeroconf/security
Insightshttps://github.com/python-zeroconf/python-zeroconf/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython-zeroconf%2Fpython-zeroconf%2Fissues%2Fnew%2Fchoose
jstasiakhttps://github.com/jstasiak
python-zeroconf:masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
bdraco:fix_reset_on_packetshttps://github.com/bdraco/python-zeroconf/tree/fix_reset_on_packets
Conversation 30 https://github.com/python-zeroconf/python-zeroconf/pull/318
Commits 1 https://github.com/python-zeroconf/python-zeroconf/pull/318/commits
Checks 0 https://github.com/python-zeroconf/python-zeroconf/pull/318/checks
Files changed https://github.com/python-zeroconf/python-zeroconf/pull/318/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/318/files
Ensure the name cache is rolled back when the packet reaches maximum size https://github.com/python-zeroconf/python-zeroconf/pull/318/files#top
Show all changes 1 commit https://github.com/python-zeroconf/python-zeroconf/pull/318/files
f20e851 Ensure the name cache is rolled back when the packet reaches maximum … bdraco Dec 29, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/318/commits/f20e85117296ab922ce75fb4a579df14dfd4eb54
Clear filters https://github.com/python-zeroconf/python-zeroconf/pull/318/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/318/files
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/318/files
__init__.py https://github.com/python-zeroconf/python-zeroconf/pull/318/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
test.py https://github.com/python-zeroconf/python-zeroconf/pull/318/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
zeroconf/__init__.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/318/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
View file https://github.com/bdraco/python-zeroconf/blob/f20e85117296ab922ce75fb4a579df14dfd4eb54/zeroconf/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/318/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/318/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
https://github.com/python-zeroconf/python-zeroconf/pull/318/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
https://github.com/python-zeroconf/python-zeroconf/pull/318/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
https://github.com/python-zeroconf/python-zeroconf/pull/318/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
https://github.com/python-zeroconf/python-zeroconf/pull/318/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
https://github.com/python-zeroconf/python-zeroconf/pull/318/files#diff-56c27b404ed775578ac7f53660f47f1d73811e81fb03f7b1186b7dba38c8d11e
zeroconf/test.pyhttps://github.com/python-zeroconf/python-zeroconf/pull/318/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
View file https://github.com/bdraco/python-zeroconf/blob/f20e85117296ab922ce75fb4a579df14dfd4eb54/zeroconf/test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/318/{{ revealButtonHref }}
https://github.com/python-zeroconf/python-zeroconf/pull/318/files#diff-8a2375d7dc40a924b4a5a4738d1e6cdb4516d23371268f2ea70a2e5d33edfcd7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.