René's URL Explorer Experiment


Title: Don't call callbacks whend holding _handlers_lock by emontnemery · Pull Request #258 · python-zeroconf/python-zeroconf · GitHub

Open Graph Title: Don't call callbacks whend holding _handlers_lock by emontnemery · Pull Request #258 · python-zeroconf/python-zeroconf

X Title: Don't call callbacks whend holding _handlers_lock by emontnemery · Pull Request #258 · python-zeroconf/python-zeroconf

Description: A pure python implementation of multicast DNS service discovery - Don't call callbacks whend holding _handlers_lock by emontnemery · Pull Request #258 · python-zeroconf/python-zeroconf

Open Graph Description: Don't hold _handlers_lock when calling the service callbacks. Closes #255 Background: #239 adds the lock _handlers_lock: https://github.com/jstasiak/python-zeroconf/blob/552a030eb592a0c07feaa7a...

X Description: Don't hold _handlers_lock when calling the service callbacks. Closes #255 Background: #239 adds the lock _handlers_lock: https://github.com/jstasiak/python-zeroconf/blob/552a030eb592a0c07fe...

Opengraph URL: https://github.com/python-zeroconf/python-zeroconf/pull/258

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:156f66d4-8724-acc5-fd1a-53e0230c6819
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9158:22D266:43449A:5CE88A:6B009099
html-safe-nonce6aeb47830d94ef10a28cbca502b8a9be25ead38055690e8aa3115e84433a73f4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTU4OjIyRDI2Njo0MzQ0OUE6NUNFODhBOjZCMDA5MDk5IiwidmlzaXRvcl9pZCI6IjI0MjkzNTcxMTM1NzE1NzgwMDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacebd43274eab3258c81be6778d5b28ef5e0a9c58b0bc3fcc7f30ff8c3bb7a0d93
hovercard-subject-tagpull_request:422894589
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-zeroconf/python-zeroconf/258/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6a8ad6b08ab7ecbf2f2c2df06712befab6d82634cdb22578e4e7272e3b9c7320/python-zeroconf/python-zeroconf/pull/258
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6a8ad6b08ab7ecbf2f2c2df06712befab6d82634cdb22578e4e7272e3b9c7320/python-zeroconf/python-zeroconf/pull/258
og:image:altDon't hold _handlers_lock when calling the service callbacks. Closes #255 Background: #239 adds the lock _handlers_lock: https://github.com/jstasiak/python-zeroconf/blob/552a030eb592a0c07feaa7a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameemontnemery
hostnamegithub.com
expected-hostnamegithub.com
Nonec710a5cb5c47be60abfe6e8410436d409906979dbed614ef09f29c60f5535b08
turbo-cache-controlno-cache
go-importgithub.com/python-zeroconf/python-zeroconf git https://github.com/python-zeroconf/python-zeroconf.git
octolytics-dimension-user_id120192235
octolytics-dimension-user_loginpython-zeroconf
octolytics-dimension-repository_id21548731
octolytics-dimension-repository_nwopython-zeroconf/python-zeroconf
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21548731
octolytics-dimension-repository_network_root_nwopython-zeroconf/python-zeroconf
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebe616a2a6ec1c609d6e002896dff5352d5c5f28b
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python-zeroconf/python-zeroconf/pull/258#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F258
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F258
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-zeroconf%2Fpython-zeroconf
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/258
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/258
Reloadhttps://github.com/python-zeroconf/python-zeroconf/pull/258
python-zeroconfhttps://github.com/python-zeroconf
python-zeroconfhttps://github.com/python-zeroconf/python-zeroconf
Codehttps://github.com/python-zeroconf/python-zeroconf
Issues50 (50)https://github.com/python-zeroconf/python-zeroconf/issues
Pull requests16 (16)https://github.com/python-zeroconf/python-zeroconf/pulls
Discussionshttps://github.com/python-zeroconf/python-zeroconf/discussions
Actionshttps://github.com/python-zeroconf/python-zeroconf/actions
Projectshttps://github.com/python-zeroconf/python-zeroconf/projects
Wikihttps://github.com/python-zeroconf/python-zeroconf/wiki
Security and quality5 (5)https://github.com/python-zeroconf/python-zeroconf/security
Insightshttps://github.com/python-zeroconf/python-zeroconf/insights
https://github.com/python-zeroconf/python-zeroconf
jstasiakhttps://github.com/jstasiak
python-zeroconf:masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
emontnemery:fix_starvehttps://github.com/emontnemery/python-zeroconf/tree/fix_starve
Conversationhttps://github.com/python-zeroconf/python-zeroconf/pull/258
Commits1 (1)https://github.com/python-zeroconf/python-zeroconf/pull/258/commits
Checkshttps://github.com/python-zeroconf/python-zeroconf/pull/258/checks
Files changedhttps://github.com/python-zeroconf/python-zeroconf/pull/258/files
Don't call callbacks whend holding _handlers_lockhttps://github.com/python-zeroconf/python-zeroconf/pull/258#top
jstasiakhttps://github.com/jstasiak
python-zeroconf:masterhttps://github.com/python-zeroconf/python-zeroconf/tree/master
emontnemery:fix_starvehttps://github.com/emontnemery/python-zeroconf/tree/fix_starve
https://github.com/emontnemery
emontnemeryhttps://github.com/emontnemery
May 25, 2020https://github.com/python-zeroconf/python-zeroconf/pull/258#issue-624482220
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/258
#255https://github.com/python-zeroconf/python-zeroconf/issues/255
#239https://github.com/python-zeroconf/python-zeroconf/pull/239
https://github.com/jstasiak/python-zeroconf/blob/552a030eb592a0c07feaa7a01ece1464da4b1d0b/zeroconf/__init__.py#L2209https://github.com/jstasiak/python-zeroconf/blob/552a030eb592a0c07feaa7a01ece1464da4b1d0b/zeroconf/__init__.py#L2209
https://github.com/jstasiak/python-zeroconf/blob/552a030eb592a0c07feaa7a01ece1464da4b1d0b/zeroconf/__init__.py#L2484-L2489https://github.com/jstasiak/python-zeroconf/blob/552a030eb592a0c07feaa7a01ece1464da4b1d0b/zeroconf/__init__.py#L2484-L2489
https://github.com/jstasiak/python-zeroconf/blob/552a030eb592a0c07feaa7a01ece1464da4b1d0b/zeroconf/__init__.py#L1541-L1546https://github.com/jstasiak/python-zeroconf/blob/552a030eb592a0c07feaa7a01ece1464da4b1d0b/zeroconf/__init__.py#L1541-L1546
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/258
https://github.com/emontnemery
Don't call callbacks whend holding _handlers_lockhttps://github.com/python-zeroconf/python-zeroconf/pull/258/commits/0b9152bd1c56f617e211f08e25c845506c008588
0b9152bhttps://github.com/python-zeroconf/python-zeroconf/pull/258/commits/0b9152bd1c56f617e211f08e25c845506c008588
https://github.com/coveralls
coverallshttps://github.com/coveralls
May 25, 2020https://github.com/python-zeroconf/python-zeroconf/pull/258#issuecomment-633715139
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/258
https://coveralls.io/builds/31021659
0b9152bhttps://github.com/python-zeroconf/python-zeroconf/commit/0b9152bd1c56f617e211f08e25c845506c008588
445d7f5https://github.com/python-zeroconf/python-zeroconf/commit/445d7f5dbe38947bd0bd1e3a5b8d649c1819c21f
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/258
https://github.com/coveralls
coverallshttps://github.com/coveralls
May 25, 2020https://github.com/python-zeroconf/python-zeroconf/pull/258#issuecomment-633715141
https://coveralls.io/builds/31021659
0b9152bhttps://github.com/python-zeroconf/python-zeroconf/commit/0b9152bd1c56f617e211f08e25c845506c008588
445d7f5https://github.com/python-zeroconf/python-zeroconf/commit/445d7f5dbe38947bd0bd1e3a5b8d649c1819c21f
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/258
https://github.com/jstasiak
jstasiakhttps://github.com/jstasiak
May 25, 2020https://github.com/python-zeroconf/python-zeroconf/pull/258#issuecomment-633720635
@mattsaxonhttps://github.com/mattsaxon
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/258
https://github.com/jstasiak
jstasiakhttps://github.com/jstasiak
May 25, 2020https://github.com/python-zeroconf/python-zeroconf/pull/258#issuecomment-633721195
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/258
https://github.com/emontnemery
emontnemeryhttps://github.com/emontnemery
May 25, 2020https://github.com/python-zeroconf/python-zeroconf/pull/258#issuecomment-633725362
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/258
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/258
https://github.com/gjbadros
gjbadroshttps://github.com/gjbadros
May 25, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/258#ref-pullrequest-617672129
Separately send large mDNS responses to comply with RFC 6762 #248 https://github.com/python-zeroconf/python-zeroconf/pull/248
https://github.com/jstasiak
jstasiakhttps://github.com/jstasiak
May 26, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/258#ref-pullrequest-624793168
Remove deprecated ServiceInfo address parameter/property #260 https://github.com/python-zeroconf/python-zeroconf/pull/260
https://github.com/mattsaxon
mattsaxonhttps://github.com/mattsaxon
May 26, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/258#pullrequestreview-418576229
View reviewed changes https://github.com/python-zeroconf/python-zeroconf/pull/258/files/0b9152bd1c56f617e211f08e25c845506c008588
mattsaxonhttps://github.com/mattsaxon
https://github.com/python-zeroconf/python-zeroconf/pull/258#pullrequestreview-418576229
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/258
https://github.com/emontnemery
emontnemeryhttps://github.com/emontnemery
May 26, 2020https://github.com/python-zeroconf/python-zeroconf/pull/258#issuecomment-634220784
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/258
@mattsaxonhttps://github.com/mattsaxon
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/258
https://github.com/mattsaxon
mattsaxonhttps://github.com/mattsaxon
May 26, 2020https://github.com/python-zeroconf/python-zeroconf/pull/258#issuecomment-634223941
@emontnemeryhttps://github.com/emontnemery
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/258
https://github.com/emontnemery
emontnemeryhttps://github.com/emontnemery
May 26, 2020https://github.com/python-zeroconf/python-zeroconf/pull/258#issuecomment-634231437
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/258
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/258
https://github.com/jstasiak
jstasiakhttps://github.com/jstasiak
May 26, 2020https://github.com/python-zeroconf/python-zeroconf/pull/258#issuecomment-634232392
@hmmbobhttps://github.com/hmmbob
#255 (comment)https://github.com/python-zeroconf/python-zeroconf/issues/255#issuecomment-633706096
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/258
https://github.com/jstasiak
jstasiakhttps://github.com/jstasiak
fe86566https://github.com/python-zeroconf/python-zeroconf/commit/fe865667e4610d57067a8f710f4d818eaa5e14dc
May 26, 2020https://github.com/python-zeroconf/python-zeroconf/pull/258#event-3375364523
https://github.com/jstasiak
jstasiakhttps://github.com/jstasiak
May 26, 2020https://github.com/python-zeroconf/python-zeroconf/pull/258#issuecomment-634277990
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/258
https://github.com/jstasiak
jstasiakhttps://github.com/jstasiak
May 27, 2020https://github.com/python-zeroconf/python-zeroconf/pull/258#issuecomment-634603949
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/258
https://github.com/mattsaxon
mattsaxonhttps://github.com/mattsaxon
May 30, 2020https://github.com/python-zeroconf/python-zeroconf/pull/258#issuecomment-636323951
@emontnemeryhttps://github.com/emontnemery
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/258
https://github.com/bdraco
bdracohttps://github.com/bdraco
Aug 9, 2020 https://github.com/python-zeroconf/python-zeroconf/pull/258#ref-pullrequest-675722538
Reduce the time window that the handlers lock is held #287 https://github.com/python-zeroconf/python-zeroconf/pull/287
https://github.co/hiddenchars
https://github.com/python-zeroconf/python-zeroconf/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-zeroconf%2Fpython-zeroconf%2Fpull%2F258
https://github.com/mattsaxon
mattsaxon https://github.com/mattsaxon
https://github.com/python-zeroconf/python-zeroconf/pull/258/files/0b9152bd1c56f617e211f08e25c845506c008588
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/258
Zeroconf.get_service_info seems broken in 0.26.0 https://github.com/python-zeroconf/python-zeroconf/issues/255
Please reload this pagehttps://github.com/python-zeroconf/python-zeroconf/pull/258
https://github.com/emontnemery
https://github.com/coveralls
https://github.com/jstasiak
https://github.com/mattsaxon
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.